message to use https: instead of http:. This is generally a good idea, and
also silences Google Chrome's phishing warning. Fixes issue #1204.
This commit should have contained only changes to a template file; by
mistake, changes to two django files were also committed here. That
change has been undone in [6725].
- Legacy-Id: 6724
Note: SVN reference [6725] has been migrated to Git commit ca1a04f660aa0473bf8f3aadc7809d462ac4cac0
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
names
- Add a simple textual SubmissionEvent for tracking events in the
lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors
A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.
Also revamp the submit view code:
- Make form code do validation/cleaning only so there's a clear
separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
forms now don't inherit from each other, views don't call each other
but instead reuse common utilities, templates share CSS/utilities
instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases
Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
- Legacy-Id: 6714
true and EMAIL_HOST and EMAIL_PORT is set to localhost:1025 will turn
on debugging which essentially makes it send emails; also added
instructions for starting the debugging SMTP server bundled with
Python
python -m smtpd -n -c DebuggingServer localhost:1025
in a comment near the code
- Legacy-Id: 6713
Improve e-mails from replaced-by updates.
Fix an incorrectly-expanded file tag in the subject.
Fixes#1178.
Use a slightly more natural grammatical construct in the message body.
Fixes#1179.
- Legacy-Id: 6699
Note: SVN reference [6696] has been migrated to Git commit 03896647cc
Fix an incorrectly-expanded file tag in the subject.
Fixes#1178.
Use a slightly more natural grammatical construct in the message body.
Fixes#1179.
- Legacy-Id: 6696
