Commit graph

3654 commits

Author SHA1 Message Date
Lars Eggert 53a2b61bbc
feat: Make the "report a bug" links more visible (#3883)
* feat: Make the "report a bug" links more visible

Also rework the page footer somewhat, while we're here.

* Revert empty change

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:30:21 -05:00
Lars Eggert 955d9ac489
fix: Spacing issues and colorization in conflict review display (#3882)
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-04-26 12:24:33 -05:00
Lars Eggert cd9a2ee229
fix: Color the background of table rows for an AD based on their ballot (#3867)
Instead of just adding a colored bar on the right-hand side.
2022-04-22 11:05:37 -05:00
Robert Sparks f4b0b459cb
feat: add analytics infrastructure (#3862) 2022-04-21 18:06:14 -05:00
Lars Eggert ec13e071ba
fix: Whitespace issue ballot popup (#3860) 2022-04-21 11:55:48 -05:00
Lars Eggert 92e67aca8f
fix: Make the author button work on doc submit (#3850) 2022-04-20 10:52:54 -05:00
Lars Eggert cef7b05981
fix: Don't change text color on hover for badge links (#3845) 2022-04-20 10:50:24 -05:00
Kesara Rathnayake 6b06542fab
fix: fix OIDC authorization bug (#3842) 2022-04-20 10:47:47 -05:00
Lars Eggert f8c06fa5cf
fix: Use unique data-sort attributes (#3836)
* fix: Use unique `data-sort` attributes

So list.js properly sorts columns.

* Address @rjsparks' comments
2022-04-19 10:16:32 -05:00
Lars Eggert ea22b0fd3b
fix: Update the document shepherd template (#3797)
* fix: Update the document shepherd template

Along the lines of https://github.com/ietf-chairs/chairs.ietf.org/pull/5

* Rewrap manually

* Use relative Markdown links to improve readability
2022-04-19 09:32:39 -05:00
Jennifer Richards 43952a8c69
fix: do not prematurely dereference status change RelatedDocuments (#3835)
* test: add tests of the person_link tag

* fix: do not prematurely dereference status change RelatedDocuments

The urlize_related_source_list template tag expects the RelatedDocument
instances, not the source Document.

* test: add test cases for status changes on document_main view
2022-04-19 07:04:38 -05:00
Nicolas Giard 23fdf61ed4
fix: point to github releases in about page (#3827) 2022-04-14 16:21:51 -05:00
Robert Sparks 7c4205d49b
feat: reflect breaking change in internal release description (#3826)
BREAKING CHANGE: the datatracker now uses bootstrap 5 and html 5
see also 6eeae80207
2022-04-14 15:04:09 -05:00
Lars Eggert 81fe7a15cf
fix: add flex-wrap to pagination elements (#3822)
They seem to be one of the only bs5 elements that do not by default wrap, which
causes display issues on narrow screens when there are lots of page elements,
e.g., on http://127.0.0.1:8000/doc/draft-ietf-ipwave-vehicular-networking/

Adding `flex-wrap` (per https://github.com/twbs/bootstrap/issues/23504) makes
this better, but unfortunately doesn't fix it completely, because the layout
still jumps when the window is narrowed by the used. It does fix the issue on
first load and after a reload though.
2022-04-14 15:36:24 -03:00
Jennifer Richards a29965f37d
fix: remove potentially duplicate html entity id (#3818) 2022-04-13 11:42:14 -03:00
Robert Sparks 0944312c20
feat: remove room-view. Fixes #3810. (#3815)
Also changes .editorconfig to not strip trailing whitespace
2022-04-12 17:35:07 -03:00
Lars Eggert d2edc5bda3
fix: Misc template fixes (#3813)
* fix: Remove extra whitespace around parentheses

* fix: Make heading capitalization consistent, colorize a "No"

* fix: Pagination element, spacing, replace text with icon
2022-04-12 12:07:22 -03:00
Lars Eggert 4f1dcd6f41
fix: Don't make a <tbody> for each row (#3808)
Fixes #3805.
2022-04-12 12:04:57 -03:00
Jennifer Richards c14a30392c
fix: clean up agenda personalization links (#3803) 2022-04-12 12:03:13 -03:00
Lars Eggert 09a898e88e
fix: Improve the layout of the photo pages (#3807) 2022-04-12 12:02:16 -03:00
Robert Sparks 0b1388c39f
fix: report seven character prefix of release hash (#3804) 2022-04-11 15:57:25 -03:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Jennifer Richards 2247a368dc
fix: improve RH panel behavior at small viewport sizes (#3801)
* fix: align nav links to top of RH panel
* fix: allow timezone picker to wrap
* fix: improve RH panel behavior at small viewport sizes
  * drop card styling
  * use `btn-group-sm` for compact timezone picker
  * limit overall height of #righthand-panel
  * remove redundant CSS merge artifact
2022-04-08 14:52:55 -03:00
Jennifer Richards eab4705dc1
fix: debug time zone widget and add to agenda RH nav panel (#3792) 2022-04-07 22:57:21 -03:00
Eric Vyncke fd588d61b4
fix: add more explanations in BoF requests (#3706)
* Add more explanations in BoF requests

* Move IAB/IESG information to the template

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-04-07 17:34:53 -05:00
Jennifer Richards 45df4f6dfd
fix: restore current session indicator/link on the agenda page (#3790) 2022-04-07 15:13:43 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Jennifer Richards db254f7a48
fix: tweak review assignment tooltips and control row height (#3788) 2022-04-07 09:48:23 -03:00
Robert Sparks 6867b1b667
fix: put unassigned review assignment contols on one small line (#3780) 2022-04-06 14:05:37 -03:00
Jennifer Richards 7738319c2a
fix: render meeting schedule editor icons using bootstrap-icons (#3777)
Uses template tags to render `ConstraintName` instances as HTML. Fixes #3557.
2022-04-05 18:57:08 -03:00
Jennifer Richards 016ee71855
feat: persist timeslot types made visible in the schedule editor (#3778)
This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
2022-04-05 16:00:59 -03:00
Jennifer Richards 3865c4bc9c
fix: restore function of unassigned review management page (#3774)
* style: reformat manage-review-requests.js as StandardJS style

* refactor: use switch statement instead of if/else-if/else

* style: remove needless line break

* fix: fix jquery selectors to be less fragile and easier to read

* fix: clean up bs5 HTML/CSS for review request buttons
2022-04-01 17:42:12 -03:00
Jennifer Richards 2859c43677
fix: allow import of rev00 minutes and let secretariat edit materials (#3776)
* fix: show "Edit materials" button for all groups for a secretariat user

Fixes ietf-tools#3763

* fix: show "import minutes" button to import initial revision

* test: validate that import session minutes buttons are shown

* test: validate that "Edit materials" links are shown
2022-04-01 12:49:20 -03:00
Robert Sparks cb4a288ab6
fix: separate tables on team review page. Fixes #3679. (#3770) 2022-03-30 18:42:29 -03:00
Robert Sparks 1d8746cd63
fix: add tooltips to calendar icons on group meeting pages. Fixes #3695. (#3767) 2022-03-30 18:37:29 -03:00
Robert Sparks 2e373adcd2
feat: improve release information in footer. (#3738) 2022-03-30 11:53:07 -03:00
Kesara Rathnayake 65439960fe
fix: Use an input field for draft submit status search (#3758) 2022-03-29 12:35:46 -05:00
Jennifer Richards 9590303027
Merge remote-tracking branch 'origin/feat/bs5' into main-merge 2022-03-25 15:18:58 -03:00
Robert Sparks eaf1f01e4d
fix: point wg about pages directly to jabber archives. Fixes #3462 and #3368. (#3750) 2022-03-25 13:48:47 -03:00
Jennifer Richards 4e3330e80f
fix: remove duplicate lines from merge 2022-03-25 12:44:32 -03:00
Jennifer Richards c0c8771370
Merge branch 'main' into main-merge
# Conflicts:
#	.devcontainer/docker-compose.extend.yml
#	.github/workflows/build-test-base.yml
#	.github/workflows/build.yml
#	README.md
#	docker/app.Dockerfile
#	docker/configs/settings_local.py
#	docker/docker-compose.extend.yml
#	docker/scripts/app-init.sh
#	ietf/release/tests.py
#	ietf/release/urls.py
#	ietf/templates/500.html
#	ietf/templates/api/index.html
#	ietf/templates/base.html
#	ietf/templates/base/menu.html
#	ietf/templates/group/group_about_status_edit.html
#	ietf/templates/meeting/agenda_filter.html
#	ietf/templates/release/about.html
#	ietf/utils/tests.py
#	package-lock.json
2022-03-25 11:15:05 -03:00
Robert Sparks 79bcc6448e
feat: redirect to release information at github (#3746)
* chore: remove unused import

* feat: redirect to release information at github.
2022-03-24 16:38:33 -04:00
Nicolas Giard 9a4505dc74
chore: remove svn/trac infrastructure (#3649) (#3739)
* chore: Remove svn/trac related infrastructure

* chore: Remove more svn/trac infrastructure

* fix: remove commented out Trac requirement
2022-03-24 12:24:35 -05:00
Lars Eggert 870fed030f
fix: More fixes for narrow screens (#3662)
* fix: More fixes for narrow screens

Need to keep checking for issues, there are more.

* Make columns more narrow on narrow screens

* More fixes

* More fixes

* Test fixes

* Fix more tests

* Close tbody
2022-03-24 12:40:48 -03:00
Lars Eggert d47692546e
fix: Re-add agenda day navigation targets to right-hand nav (#3723)
Fixes #3698
2022-03-22 07:22:25 -05:00
Jennifer Richards 6ee123d29b
fix: replace invalid bi-chat* icons with valid ones (#3716) 2022-03-21 16:10:56 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Jennifer Richards be10d6bb10
fix: remove overflow-hidden from div#content (#3681)
Allows position="sticky" items to attach to the viewport instead of the #content element.
2022-03-20 14:13:58 -05:00
Tero Kivinen 311bbf8826
fix: Fix the doc_name to have class text-nowrap as we want to keep the entries in one line if possible. (#3683) 2022-03-19 11:56:22 -05:00
Russ Housley d40842e4ce
fix: Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced (#3651)
* Allow AD and Secretariat to update the people to notify about conflict-reviewss until the are announced. Fixes #3639.

* fix: Allow notify list for conflict-review changes in any state
2022-03-16 14:16:55 -05:00
Robert Sparks 9e06efeaba
feat: update the shepherd writeup template (#3650)
* feat: update the shepherd writeup template

Fixes #3580.

* fix: correct the version date
2022-03-16 11:54:00 -05:00
Robert Sparks a60c31e45d
chore: remove svn/trac infrastructure (#3649)
* chore: Remove svn/trac related infrastructure

* chore: Remove more svn/trac infrastructure

* fix: remove commented out Trac requirement
2022-03-16 11:08:47 -05:00
Lars Eggert a68c154df9
fix: Always word-wrap person names in person_link links (#3657)
* fix: Always word-wrap person names in person_link links

Defaulting to "text-nowrap" causes too many issues on narrow screens.

* Remove extra space
2022-03-16 09:34:45 -05:00
Lars Eggert c2cba855d8
fix: Fix a regression in #3625 (#3656)
Tag closed incorrectly.
2022-03-16 09:32:58 -05:00
Lars Eggert 52969aefca
feat: Mobile agenda improvements (#3655)
* fix: Improve agenda page for mobile (narrow) screens

* Remove unrelated change

* Remove FIXME
2022-03-16 09:30:21 -05:00
Lars Eggert c7157c80c5
feat: Linkify external resources on the public profile page (#3647) 2022-03-15 08:50:15 -05:00
Lars Eggert 0bbe216ebd
fix: Add a skipnav link (#3645)
Fixes #3632.
2022-03-15 08:45:17 -05:00
Jennifer Richards 515dbedbc9
feat: bring bs5 branch up to date with changes on main (#3644)
* chore: bring docker dev init script up to date with bs5 branch (#3611)

* ci: only run codeql on schedule

* feat: shorten long agenda filter button labels (#3602)

Sessions with long names lead to poor rendering of the agenda filter buttons
on the 'customize the agenda view' page. This truncates those labels at 3 words.

* docs: Remove stale and incomplete information from the README (#3612)

* docs: Suggest cloning a fork rather than ietf-tools repo (#3614)

* docs: update README

* chore: add issue templates

* chore: update issue templates config

* chore: remove duplicate security issue link

* docs: point feature requests to discussions

* chore: add bug report form

* chore: remove bug report issue template

* chore: fix bug report form

* fix: point the api index page into Github instead of trac/svn

* chore: remove os + version + log fields from bug report form

* fix: point to GitHub for bug reports (#3625)

* fix: point to GitHub for bug reports

* fix: point report bug link to template chooser

* fix: point report bug link to template chooser (2)

Co-authored-by: Nicolas Giard <github@ngpixel.com>

* fix: remove stale explanation of status reports (#3628)

* fix: adjust about page to reflect move to GitHub. Normalize information level on page. (#3629)

* fix: remove anchor tag with empty href (#3630)

* fix: use same github issue URL on 500 error page as elsewhere (#3631)

* chore: update report-a-bug.yml form

* ci: fix __init__.py version quotes

* chore: bring docker-compose to root level (#3642) (#3643)

Authored-by: Nicolas Giard <github@ngpixel.com>

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
2022-03-15 10:29:33 -03:00
Lars Eggert 323d890252
fix: Search for docalias, not document (#3635)
Fixes #3605.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-03-14 11:49:23 -05:00
Lars Eggert 646b7e52ad
fix: Move the navbar last, for text-based browsers (#3636)
Fixes #3632.
2022-03-14 11:38:33 -05:00
Lars Eggert fd8d9762f2
fix: Use fixed lengths for the first three columns of "meta" tables (#3637)
Fixes #3615.
2022-03-14 11:32:28 -05:00
Jennifer Richards e12ea0c64c
fix: use same github issue URL on 500 error page as elsewhere (#3631) 2022-03-11 15:52:38 -06:00
Jennifer Richards ebc2e1a262
fix: remove anchor tag with empty href (#3630) 2022-03-11 15:36:44 -06:00
Robert Sparks 85d4ce748b
fix: adjust about page to reflect move to GitHub. Normalize information level on page. (#3629) 2022-03-11 17:22:44 -04:00
Robert Sparks 9ffb74c4c3
fix: remove stale explanation of status reports (#3628) 2022-03-11 17:02:50 -04:00
Robert Sparks 7b3ec180ab
fix: point to GitHub for bug reports (#3625)
* fix: point to GitHub for bug reports

* fix: point report bug link to template chooser

* fix: point report bug link to template chooser (2)

Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-03-11 13:44:35 -06:00
Robert Sparks ee686837ee
fix: point the api index page into Github instead of trac/svn 2022-03-11 12:59:21 -06:00
Jennifer Richards 3b2e2ea1a9
Merge pull request #3622 from larseggert/unify-buttons
fix: Switch to showing a single "Edit materials" button
2022-03-11 11:48:08 -04:00
Lars Eggert bbf1996909
fix: Use bootstrap-icons icon (#3623)
There was one remaining use of font-awesome; use bootstrap-icons icon now.
2022-03-11 09:14:09 -06:00
Lars Eggert 8319731218
fix: Fix agenda tab wrapping (#3621)
And also fix heading disappearing behind nav tabs. Fixes #3608.
2022-03-11 08:59:11 -06:00
Lars Eggert 876122276f
fix: Remove attempt to do smart linewraps for doc titles. (#3620)
Fixes #3609.
2022-03-11 08:50:50 -06:00
Lars Eggert b1deed3aa2
fix: Switch to showing a single "Edit materials" button
Fixes #3594.
2022-03-11 13:29:35 +02:00
Jennifer Richards bd8638e6df
feat: shorten long agenda filter button labels (#3602)
Sessions with long names lead to poor rendering of the agenda filter buttons
on the 'customize the agenda view' page. This truncates those labels at 3 words.
2022-03-10 13:21:26 -06:00
Jennifer Richards baa3b292b0 fix: clean up formatting of login.html template 2022-03-08 12:13:21 -04:00
Jennifer Richards 3d7b267a64 fix: only add page navigation panel to compatible templates
Only add right-hand page navigation panel to #content elements that have
the ietf-auto-nav class and test that the base template's DOM is compatible
with the panel.
2022-03-08 12:01:24 -04:00
Jennifer Richards 3906bbdc4f Merge remote-tracking branch 'origin/main' into personal/jennifer/7.45.1.dev0.bootstrap-merge
# Conflicts:
#	bootstrap/package.json
#	ietf/templates/meeting/session_buttons_include.html
2022-03-07 16:24:30 -04:00
Robert Sparks 918bb62b26
fix: change onsite tool icon to match the icons displayed at MeetEcho (#3574) 2022-03-07 12:57:40 -06:00
Jennifer Richards dea0b4ed55 fix: fix reference to doc.rfc_number in template 2022-03-04 16:21:11 -04:00
Jennifer Richards d78d0249f1 refactor: improve readability of template logic in document_html.html 2022-03-04 15:42:46 -04:00
Jennifer Richards 0ab0994c9d fix: revert invalid line breaks in templates 2022-03-04 15:32:58 -04:00
Jennifer Richards 686a9150b3 Merge remote-tracking branch 'origin/main' into personal/jennifer/7.45.1.dev0.bootstrap-merge
# Conflicts:
#	ietf/templates/meeting/session_buttons_include.html
2022-03-04 15:14:52 -04:00
Jennifer Richards 077e7e2262 Merged from 7.40.1.dev0
Properly URL-encode and -decode a bunch of query parameters. [from revision 19,981]
 - Legacy-Id: 19986
2022-02-24 17:52:28 +00:00
Jennifer Richards 9d8f4ea207 Fix failing tests
- Legacy-Id: 19982
2022-02-24 16:47:55 +00:00
Lars Eggert 07e0eb84d9 Properly URL-encode and -decode a bunch of query parameters.
- Legacy-Id: 19981
2022-02-24 14:23:46 +00:00
Robert Sparks e3aa43eea5 Merged in [19967] from rjsparks@nostrum.com:
From Kesara Rathnayake: Expire password reset links on use, password change through other mechanics, login, or a short configurable time (initially one hour). Patched in at 7.45.0.p2.
 - Legacy-Id: 19968
Note: SVN reference [19967] has been migrated to Git commit 682392081bddbd1b8653df9135388e6b7c48ee1c
2022-02-23 18:30:27 +00:00
Robert Sparks 358132dbfe Update link to handling ballot positions. Fixes #3208. Commit ready for merge.
- Legacy-Id: 19948
2022-02-18 15:53:19 +00:00
Robert Sparks bc8155f197 Add link to onsite tool to agenda. Fixes #3550. Commit ready for merge.
- Legacy-Id: 19947
2022-02-18 15:12:21 +00:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Robert Sparks f8c7be6df9 Merged in [19917] and [19930] from jennifer@painless-security.com:
Create/delete Meetecho conferences when requesting/canceling interim sessions. Fixes #3507. Fixes #3508.
 - Legacy-Id: 19934
Note: SVN reference [19917] has been migrated to Git commit 81cd64da2bc0122f733df02f7db634665c9b309a

Note: SVN reference [19930] has been migrated to Git commit c64297e495010f3c147726ad61c24ca436c324da
2022-02-14 19:08:10 +00:00
Robert Sparks 11ed1782fb Merged in [19915] from rjsparks@nostrum.com:
Simplify search for link back to group from the review management view.
 - Legacy-Id: 19924
Note: SVN reference [19915] has been migrated to Git commit fa952976ab
2022-02-14 16:40:48 +00:00
Lars Eggert 37cb737987 Check the selenium console log for any issues as part of the test suite,
and fix/suppress errors found by that.
 - Legacy-Id: 19916
2022-02-10 21:20:20 +00:00
Robert Sparks fa952976ab Simplify search for link back to group from the review management view. Commit ready for merge.
- Legacy-Id: 19915
2022-02-09 17:25:43 +00:00
Lars Eggert 1795609816 Some more cosmetic tweaks.
- Legacy-Id: 19914
2022-02-09 14:17:11 +00:00
Lars Eggert 67ebadeadd A bunch more cosmetic fixes.
- Legacy-Id: 19913
2022-02-09 10:11:03 +00:00
Lars Eggert 02b97208b1 Add back noscript warning about disabled js.
- Legacy-Id: 19912
2022-02-09 08:41:31 +00:00
Lars Eggert d7ec9e7f70 Disable various download buttons if there is no agenda yet.
- Legacy-Id: 19911
2022-02-09 08:27:02 +00:00
Lars Eggert 7a86a1cac2 Enable select2 for timezone picker.
- Legacy-Id: 19910
2022-02-09 08:19:36 +00:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds.
- Legacy-Id: 19904
2022-02-01 16:11:34 +00:00