altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 5 Packages Projects Releases Wiki Activity
14172 commits 1 branch 0 tags 2.6 GiB
Commit graph

607 commits

Author SHA1 Message Date
Henrik Levkowetz f41fd1867d Upgraded the required versions of mypy and django-stubs to the latest that support Django 2.2. Fixed some issues found by after the upgrades. 
- Legacy-Id: 18717
 2020-11-22 21:13:36 +00:00
Henrik Levkowetz 088033d843 Added matching indexes to a number of models with ordering by multiple keys. 
- Legacy-Id: 18664
 2020-11-09 19:41:12 +00:00
Henrik Levkowetz b51de66324 Added additional logging of submission steps, for submission timing investigation. Should be reduced once cause of long response times has been found. 
- Legacy-Id: 18655
 2020-11-03 13:24:20 +00:00
Henrik Levkowetz 3c9798c418 Fixed a couple of pyflakes issues. 
- Legacy-Id: 18636
 2020-10-24 18:38:45 +00:00
Henrik Levkowetz 45a808db95 Added more logging for submissions, to get timing information. 
- Legacy-Id: 18635
 2020-10-24 15:20:43 +00:00
Henrik Levkowetz c02752d884 Changed a draft submission revision consistency check to look at Submission objects rather than SubmissionDocEvent objects in order to not fail incorrectly when there are prior cancelled uploads. Related to issue #2909. 
- Legacy-Id: 18586
 2020-10-09 13:21:53 +00:00
Robert Sparks 3baea05e6d Use the id-archive wherever we had been using the id-repository. Fixes #3080. Commit ready for merge. 
- Legacy-Id: 18550
 2020-10-02 14:13:17 +00:00
Henrik Levkowetz 15ea994266 Added an xml_version field to Submission objects, to capture the schema version of submitted XML files (if any). Related to issue #3067. 
- Legacy-Id: 18440
 2020-08-28 14:31:36 +00:00
Henrik Levkowetz 9125104065 Merged in [18324] from rjsparks@nostrum.com: 
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419.
 - Legacy-Id: 18363
Note: SVN reference [18324] has been migrated to Git commit cb58810705
 2020-08-13 11:23:22 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403. 
- Legacy-Id: 18339
 2020-08-06 10:59:52 +00:00
Robert Sparks cb58810705 Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419. Commit ready to merge. 
- Legacy-Id: 18324
 2020-07-30 21:44:02 +00:00
Henrik Levkowetz 1dedffb550 Provide a local environment path for pyang, which is installed with pip and may not be available globally. Fixes issue #3018. 
- Legacy-Id: 18322
 2020-07-30 15:33:24 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge. 
- Legacy-Id: 18298
 2020-07-28 18:54:44 +00:00
Henrik Levkowetz 0a0df995e6 Merged in [18250] from jennifer@painless-security.com: 
Reject or require manual processing for submissions when inconsistent SubmissionDocEvent revs exist. Fixes #2909.
 - Legacy-Id: 18277
Note: SVN reference [18250] has been migrated to Git commit b61bdc289b
 2020-07-26 11:15:49 +00:00
Henrik Levkowetz f0baae3623 Made test parts that depends on yanglint conditional. Added some informational messages about tests skipped due to missing resources. 
- Legacy-Id: 18255
 2020-07-24 13:43:59 +00:00
Jennifer Richards b61bdc289b Reject or require manual processing for submissions when inconsistent SubmissionDocEvent revs exist. Fixes #2909. Commit ready for merge. 
- Legacy-Id: 18250
 2020-07-24 13:24:00 +00:00
Henrik Levkowetz 606cedd796 Merged in the ExtResource work from rjsparks@nostrum.com, based on a feature request and contributions from rsalz@akamai.com. This provides external resource models for Person, Group, and Document models, as a generalisation of the previous related-URL concept. This provides a consistent labelling and classification of URLs and other resources related to a Group, Document, or Person. The GroupURL (and similar) classes will be removed in a later step. Some DocumentURL instances (such as auth48 URLs) remain to convert, as they have come in with other merged-in work while the ExtResource work was in transit. 
- Legacy-Id: 18192
 2020-07-20 01:58:26 +00:00
Robert Sparks 99df95d542 Cleaned up created names. Improved validation during migration. Cleaned up migration output. Cleaned the last of the awp includes from secr views. Removed now unused secr templates. Build extresource urls correctly during submission and when creating group wikis. 
- Legacy-Id: 18158
 2020-07-13 16:03:39 +00:00
Robert Sparks 53f7bc3ce6 migrated forward 
- Legacy-Id: 18144
 2020-07-09 21:07:05 +00:00
Robert Sparks 066ee27505 preparing to merge forward 
- Legacy-Id: 18143
 2020-07-09 20:29:45 +00:00
Henrik Levkowetz 25e644d0e2 Added support for pulling yang modules from yangcatalog.org. 
- Legacy-Id: 18141
 2020-07-08 18:44:56 +00:00
Henrik Levkowetz 9047875296 Removed an unused parameter from submit.tests.do_submission_email(). 
- Legacy-Id: 18082
 2020-06-27 17:17:22 +00:00
Henrik Levkowetz dc7581fef4 Changed NullBoleanField() to BooleanField(null=True), according to the 2.1 upgrade recommendations. 
- Legacy-Id: 18051
 2020-06-24 20:33:57 +00:00
Henrik Levkowetz 186e2ae67b Decorated post_submission() with @transaction.atomic, and did some slight refactoring of code related to post_submission() calls and submission events. This was triggered by a submission left in an intermediate state because of a WSGI timeout (leading to a 504 error). 
- Legacy-Id: 17892
 2020-05-28 15:01:33 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain. 
- Legacy-Id: 17807
 2020-05-16 20:20:05 +00:00
Henrik Levkowetz 3439f3d42c Tweaked a log.assertion() case. 
- Legacy-Id: 17793
 2020-05-14 15:47:41 +00:00
Henrik Levkowetz 111d27486f Added a pyflakes:ignore 
- Legacy-Id: 17771
 2020-05-10 14:25:27 +00:00
Henrik Levkowetz 0daddb5b91 Changed a log.assertion() to provide more information about the unexpected situation. 
- Legacy-Id: 17770
 2020-05-10 14:17:23 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators. 
- Legacy-Id: 17673
 2020-04-21 13:54:31 +00:00
Henrik Levkowetz f2b883d2bb Merged in ^/trunk@17617. 
- Legacy-Id: 17618
 2020-04-14 17:11:51 +00:00
Henrik Levkowetz 5c3c3fff82 Changed the handling of some exceptions during draft submission to give user feedback rather than server 500 responses, in order to deal better with severely malformed drafts. 
- Legacy-Id: 17595
 2020-04-08 13:12:39 +00:00
Henrik Levkowetz 0df0a87a48 Added a workaround for the current libmagic which quite easily can mischaracterise text/plain documents as text/x-Algol68. Fixes issues #2941 and #2956. 
- Legacy-Id: 17594
 2020-04-07 18:33:24 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584. 
- Legacy-Id: 17593
 2020-04-07 16:02:52 +00:00
Henrik Levkowetz 4d345573ae Check if any files matching the submitted draft name and revision already exists on disk in the active drafts or archived drafts directories, and if so reject the submission. Fixes issue #2908 
- Legacy-Id: 17498
 2020-03-21 22:56:57 +00:00
Henrik Levkowetz e99fa4be40 Merged in [17419] from rjsparks@nostrum.com: 
Don't warn about idcutoff when the cutoff is after the meeting starts. Fixes #2907.
 - Legacy-Id: 17422
Note: SVN reference [17419] has been migrated to Git commit edc41a8705
 2020-03-11 21:46:02 +00:00
Robert Sparks edc41a8705 Don't warn about idcutoff when the cutoff is after the meeting starts. Fixes #2907. Commit ready for merge. 
- Legacy-Id: 17419
 2020-03-11 16:15:40 +00:00
Henrik Levkowetz 0f6a886ae0 Corrected the extent of a try/except block, moving more code inside the block. Fixes a submission exception that should just be a document error reported back to the user. 
- Legacy-Id: 17411
 2020-03-09 14:13:37 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports. 
- Legacy-Id: 17385
 2020-03-05 14:41:41 +00:00
Henrik Levkowetz b4d7dd131a Added ability to use the submission API with active secondary email addresses. Fixes issue #2639. 
- Legacy-Id: 17383
 2020-03-04 18:05:56 +00:00
Henrik Levkowetz 095c3a2ccb Fixed an issue where the lookup of recognized country names during draft submission grabbed the unicode name instead of the ascii name for non-ascii country strings in XML submissions. 
- Legacy-Id: 17345
 2020-02-26 17:20:13 +00:00
Henrik Levkowetz a7baacf519 Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting. 
- Legacy-Id: 17337
 2020-02-26 16:59:18 +00:00
Henrik Levkowetz 9439f718d4 Wrapped more code in an exception block, in order not to continue processing after an XML parse exception. Fixes issue #2885. 
- Legacy-Id: 17305
 2020-02-18 20:20:09 +00:00
Henrik Levkowetz e79eb56c01 Changed the xml parser settings for legacy xml draft submissions to remove comments before converting to .txt. Fixes and issue with comments in <artwork> text. 
- Legacy-Id: 17297
 2020-02-16 15:48:45 +00:00
Henrik Levkowetz 65ca6e240c Added some raw_id fields to avoid long page load times 
- Legacy-Id: 17267
 2020-01-30 22:13:29 +00:00
Henrik Levkowetz 096c08aac4 Added a test case for draft submission errors due to periods in document names. 
- Legacy-Id: 17251
 2020-01-18 15:07:51 +00:00
Henrik Levkowetz 060539cf1f Added a suggestion to the error message issued for invalid characters in document names found in draft submission XML files, when the invalid character is a period. In this particular case, the problem most likely is inclusion of the filename extension in the document name. Fixes issue #2874. 
- Legacy-Id: 17250
 2020-01-18 15:06:17 +00:00
Henrik Levkowetz edf28348aa Changed draft submission field validation taking place in clean() to associate the errors with the field in question, rather than raising them as general form errors. 
- Legacy-Id: 17249
 2020-01-18 15:01:35 +00:00
Henrik Levkowetz 76ee1b8cdf Fixed a Py3 issue trying run .decode() on (already decoded) str. 
- Legacy-Id: 17248
 2020-01-18 14:59:08 +00:00
Henrik Levkowetz 3db48727ea Specified explicit UTF-8 decoding of submission checker output 
- Legacy-Id: 17194
 2020-01-07 22:26:00 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com. 
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
 2019-12-20 15:00:55 +00:00
Henrik Levkowetz 202d112e0d Added handling for a decoding exception during submission processing. 
- Legacy-Id: 17151
 2019-12-16 13:32:51 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure 
- Legacy-Id: 17149
 2019-12-13 19:53:45 +00:00
Henrik Levkowetz ac6b664fa5 Added normalization of draft title extracted from submitted XML. 
- Legacy-Id: 17119
 2019-12-02 16:24:51 +00:00
Henrik Levkowetz c486ec8003 Fixed naming of staged xml draft submission files and tweaked the arguments for the xml2rfc parser invocation for xml draft submissions. Added some more logging. 
- Legacy-Id: 17075
 2019-11-21 04:35:31 +00:00
Henrik Levkowetz 98dc8e99f3 Changed the call arguments for submission tool conversion from XML to v3 text to match those of the standalone tool. Fixes an issue where <sourecode> would have line ends stripped when converted by the datatracker. 
- Legacy-Id: 17021
 2019-11-12 18:27:01 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy 
- Legacy-Id: 16968
 2019-11-05 22:41:18 +00:00
Henrik Levkowetz bf299bbfb5 Be more liberal with v3 xml submissions. 
- Legacy-Id: 16956
 2019-11-04 18:13:22 +00:00
Henrik Levkowetz 994e0ba6cc Moved the code that generates .txt and .html draft files from .xml to a place where potential errors can be caught and displayed better. Related to ticket #2814. 
- Legacy-Id: 16862
 2019-10-15 14:33:35 +00:00
Henrik Levkowetz 5b3b9c2791 Reverting the previous commit 
- Legacy-Id: 16857
 2019-10-10 18:32:49 +00:00
Henrik Levkowetz c58f370104 Updated requirements3.txt. Explicitly listing mypy version requirements is counter-productive as it is determined by django-stubs. 
- Legacy-Id: 16856
 2019-10-10 18:31:25 +00:00
Henrik Levkowetz 9d4ca615d3 Merged in [16607] from rcross@amsl.com: 
Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule.  Fixes #2765.
 - Legacy-Id: 16817
Note: SVN reference [16607] has been migrated to Git commit 9a82586e1b
 2019-10-02 20:55:54 +00:00
Henrik Levkowetz 07375b46f8 Added log.unreachable() for the code that creates unknown-email-*' addresses. Addresses issue #2696. 
- Legacy-Id: 16814
 2019-10-02 17:45:44 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run. 
- Legacy-Id: 16772
 2019-09-30 15:42:18 +00:00
Henrik Levkowetz e0479d8d13 Changed the call signature of docevent_from_submission() to take an optional Person object, rather than person name. Added a type hint for the signature. 
- Legacy-Id: 16764
 2019-09-29 20:00:49 +00:00
Henrik Levkowetz a1db2d5aef Tweaked the condition for waiving submission email confirmation slightly. 
- Legacy-Id: 16760
 2019-09-27 06:12:55 +00:00
Henrik Levkowetz 3939c0b88c Changed draft submission to not require an email round-trip when the submitter is logged in. Added corresponding test cases. 
- Legacy-Id: 16749
 2019-09-26 14:43:26 +00:00
Henrik Levkowetz 466bd0675e Added asciiFullname and asciiSurname attributes to the XML submission test template. 
- Legacy-Id: 16748
 2019-09-26 14:41:48 +00:00
Henrik Levkowetz 125ec9b3b7 Added a template interpolation variable for document title to the submission test text template. 
- Legacy-Id: 16747
 2019-09-26 14:40:36 +00:00
Henrik Levkowetz eabf121abe Added code to detect conflicting information for draft name, revision, and title when both XML and text versions of a document are submitted. 
- Legacy-Id: 16746
 2019-09-26 14:38:47 +00:00
Henrik Levkowetz 78889979a1 Changed the draft submission form and views so that an email address is required for each author in order to complete self-service draft submission. It is possible to add these as metadata updates, but this will lead to submission through the secretariat (and the email addresses will still be required). Also updated related templates to make the handling of form section headings more consistent. 
- Legacy-Id: 16745
 2019-09-23 17:26:16 +00:00
Henrik Levkowetz a3f59ee9a2 Added conversion of version 3 XML draft submissions to v3 HTML, in addition to text. Added a link to HTML versions (when present) to the document status page, and renamed the link to the htmlized version to 'htmlized'. Converted the submission XML test-file to version 3. Added test code to check that HTML is generated for version 3 XML submissions. 
- Legacy-Id: 16737
 2019-09-20 14:24:44 +00:00
Henrik Levkowetz 44f42cdb3a Undid the previous commit 
- Legacy-Id: 16735
 2019-09-20 11:30:04 +00:00
Henrik Levkowetz e3e9f676b7 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too. 
- Legacy-Id: 16734
 2019-09-20 11:28:53 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility. 
- Legacy-Id: 16633
 2019-08-08 17:11:14 +00:00
Henrik Levkowetz 22e0d39e4b Fixed an issue where text file charset information would be overwritten on upload of multiple files for a draft. Fixes issue #2768. 
- Legacy-Id: 16626
 2019-08-06 15:41:13 +00:00
Henrik Levkowetz 915d8e3c2a Added LookupError to the exceptions caught during text upload decoding, leading to upload form validation error. 
- Legacy-Id: 16573
 2019-07-22 15:47:40 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch. 
- Legacy-Id: 16468
 2019-07-16 15:36:16 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue. 
- Legacy-Id: 16461
 2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc. 
- Legacy-Id: 16458
 2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods. 
- Legacy-Id: 16455
 2019-07-15 18:01:26 +00:00
Henrik Levkowetz 99a7f9c263 Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type 
- Legacy-Id: 16453
 2019-07-15 17:13:46 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import 
- Legacy-Id: 16448
 2019-07-15 15:46:06 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs. 
- Legacy-Id: 16428
 2019-07-08 10:43:47 +00:00
Henrik Levkowetz 48bab56be9 Removed a print() call 
- Legacy-Id: 16420
 2019-07-07 13:04:20 +00:00
Henrik Levkowetz 1225f8af6b Refactored submission code to be clearer and only do mimetype extraction in one place, made the point where files are saved less obscure, fixed bytes/str issues for file read and write, fixed regex strings, fixed variable name visibility due to scope changes in py3. 
- Legacy-Id: 16375
 2019-07-04 15:49:42 +00:00
Henrik Levkowetz 2e92652eaa Changed a regex to use an r string. Added decoding of command pipe output. 
- Legacy-Id: 16374
 2019-07-04 15:45:18 +00:00
Henrik Levkowetz b54e033474 Fixed an error in the handling of long draft names extracted from xml source. 
- Legacy-Id: 16363
 2019-07-03 19:56:04 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...) 
- Legacy-Id: 16336
 2019-06-29 13:43:31 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__() 
- Legacy-Id: 16330
 2019-06-28 21:07:08 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 13705976e2 Merged in [16287] from rjsparks@nostrum.com: 
Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730.
 - Legacy-Id: 16289
Note: SVN reference [16287] has been migrated to Git commit 9ace7db719
 2019-06-19 14:32:25 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729. 
- Legacy-Id: 16288
 2019-06-19 12:57:52 +00:00
Robert Sparks 9ace7db719 Send mail to a list when a new IETF WG -00 is submitted. Fixes #2730. Commit ready for merge. 
- Legacy-Id: 16287
 2019-06-18 21:24:49 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz a5cf8b6a3b Added a better error message for too long draft names during submission. 
- Legacy-Id: 16281
 2019-06-17 18:25:05 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias. 
- Legacy-Id: 16261
 2019-06-15 12:00:48 +00:00