Commit graph

75 commits

Author SHA1 Message Date
Ole Laursen 6ac0920af0 Move idrfc/ templates to doc/ and subdirectories in doc/, move ported ballot_icon template tag, delete dead code
- Legacy-Id: 6052
2013-08-14 14:10:46 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 795f91a52e Added IAB Chair permission for some IESG agenda links.
- Legacy-Id: 5729
2013-05-14 18:42:08 +00:00
Henrik Levkowetz 313e676823 Added IAB Chair permission for some IESG agenda links.
- Legacy-Id: 5728
2013-05-14 18:40:35 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Joel M. Halpern d83432dd2d Fix Moderator package Conflict review text.
- Legacy-Id: 5535
2013-03-09 23:00:09 +00:00
Joel M. Halpern 41fb290932 Remove the "Set all to not on agenda" button, as it is never used.
- Legacy-Id: 5524
2013-03-09 20:47:13 +00:00
Robert Sparks 1cff6187f5 Put status changes on the agenda, moderator, and package pages
- Legacy-Id: 5331
2013-01-28 20:16:17 +00:00
Ole Laursen ce081cb31d Fix the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
 - Legacy-Id: 5289
2013-01-17 17:10:19 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Ole Laursen bbe51020d4 Move milestones branch out of the way to prepare for merge with trunk
[[Split portion of a mixed commit.]]
 - Legacy-Id: 5185.1
2013-01-15 16:12:31 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz 158f501653 More tweaks and fixes to the IESG scribe template templates.
- Legacy-Id: 5087
2012-12-03 13:16:10 +00:00
Henrik Levkowetz e38f738851 Fixed some s!<br/>!<br>! and s!</li>!<li>! in the scribe template templates, and also where html escaping is and isn't applied.
- Legacy-Id: 5086
2012-12-03 13:07:16 +00:00
Henrik Levkowetz 6599e0874e Merged [4840] from rjsparks@nostrum.com:
Added more information about RFC5742 conflict review documents to the /agenda, moderator, and scribe pages.
Fixes bug #874
 - Legacy-Id: 4863
Note: SVN reference [4840] has been migrated to Git commit 77b5131fe6
2012-09-19 21:04:23 +00:00
Ole Laursen 0ec0fa58f3 Update IESG agenda pages with IANA Review state, consensus and last
call expiration (if applicable)
 - Legacy-Id: 4852
2012-09-17 15:59:35 +00:00
Robert Sparks 77b5131fe6 Added more information about RFC5742 conflict review documents to the /agenda, moderator, and scribe pages.
Fixes bug #874
 - Legacy-Id: 4840
2012-09-11 22:31:45 +00:00
Henrik Levkowetz ed3af82ef4 Fix up scribe template to suite John, undoing a number of fixes from the sprint.
- Legacy-Id: 4838
2012-09-11 16:41:06 +00:00
Henrik Levkowetz 32c7740b55 Reverted a number of changes to the scribe template which made life more difficult for the scribe.
- Legacy-Id: 4820
2012-08-29 00:03:31 +00:00
Robert Sparks e5c3a5adc5 Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)

Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)

Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).

Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text


DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.

Fixes bug 865
 - Legacy-Id: 4772
2012-08-21 04:46:01 +00:00
Robert Sparks 735efac3b0 Add charter documents to iesg/agenda and iesg/agenda/documents
Keep the ordering for drafts the same on iesg/agenda and iesg/agenda/documents
Allow setting the responsible AD for a charter document
Change the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)
 - Legacy-Id: 4769
2012-08-21 03:57:17 +00:00
Robert Sparks 87ebddd0ba Simplified access to current BallotDocevent from a Document.
Added functions to BallotDocEvents to faciliate access to BallotPositionDocEvents, both for all positions, and current AD postions.
Updated the moderator package to use the Documents from _agenda_data.
Added a filter to assist with rendering the moderator package.
Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).
 - Legacy-Id: 4768
2012-08-17 20:45:32 +00:00
Robert Sparks fb2b9c9e6c Removed some duplication between doc/util and doc/models by moving things into doc/models. Fixes bug #857
- Legacy-Id: 4750
2012-08-02 21:36:36 +00:00
Henrik Levkowetz fb9356efed Use the .plain_name Person attribute in the agenda documents form instead of the full .name attribute.
- Legacy-Id: 4740
2012-07-31 22:25:44 +00:00
Richard Barnes 08c1c0cb19 Adjusted the scribe template to make it XHTML compliant and fix what Robert broke
- Legacy-Id: 4724
2012-07-29 01:09:41 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Ole Laursen 7abb438424 Add milestones needing review page for the IESG, replace simple
telechat redirect view with a generic view in urls.py
 - Legacy-Id: 4591
2012-07-04 18:16:34 +00:00
Ole Laursen e5564640eb Get rid of obsolete telechat date management page
- Legacy-Id: 4589
2012-07-04 16:46:20 +00:00
Henrik Levkowetz b51a0c4b3e Remove old non-functional 'management issues' link from IESG agenda section 6 title.
- Legacy-Id: 4562
2012-07-03 10:50:01 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz b1b21e5529 Merged in branch/iola/charter-fixes from olau@iola.dk with a series of fixes to the charter management code.
- Legacy-Id: 4483
2012-06-20 23:01:28 +00:00
Henrik Levkowetz 2b78e1573e Merged in personal/rjs/v4.02_via_rfc containing [4356] which replaces code using the old via-rfc tag with code looking at the document stream (and more), and [4364] which adds document page counts on the future telechats page.
- Legacy-Id: 4482
Note: SVN reference [4356] has been migrated to Git commit 4eabc033c1

Note: SVN reference [4364] has been migrated to Git commit b3c665287d
2012-06-20 22:17:48 +00:00
Ole Laursen a353acd7e6 Fix link to charter .txt file on agenda page
- Legacy-Id: 4469
2012-06-19 14:16:08 +00:00
Henrik Levkowetz 9f3cf38a71 Merged [4364] from rjsparks@nostrum.com:
Expose how many pages each document contains on the docs on future telechats page.
Fixes bug #828
 - Legacy-Id: 4383
Note: SVN reference [4364] has been migrated to Git commit b3c665287d
2012-05-04 11:57:35 +00:00
Robert Sparks b3c665287d Expose how many pages each document contains on the docs on future telechats page.
Fixes bug #828
 - Legacy-Id: 4364
2012-05-03 17:47:12 +00:00
Robert Sparks 4eabc033c1 Replaced the concept of a tag (via-rfc) identifying ise or irtf document (previously the idinternal.via_rfc_editor boolean) with looking at the document's stream.
Removed the stream editing form - that functionality is on the edit info form.
Put the old-ADs back into the list of choices when editing a document's info.

This (re) fixes bug #749
 - Legacy-Id: 4356
2012-05-03 04:26:09 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 9f880a3aab Port all still relevant changes between trunk before migration and charter branch to new trunk (mostly various minor template fixes), except 0.24 version of draft.py tool which has some interfaces changes that requires changes in the submit tool
- Legacy-Id: 4341
2012-04-30 13:36:56 +00:00
Ole Laursen d0dcd60aa8 Fix bug in retrieving charters for agenda, slight template fix
- Legacy-Id: 4202
2012-03-24 12:10:52 +00:00
Ole Laursen b46ebcb553 Sort ADs on last name
- Legacy-Id: 3951
2012-02-22 20:25:40 +00:00
Ole Laursen 5382b31ab2 Fix problem with incomplete proxying in IESG scribe template, found by
John Leslie
 - Legacy-Id: 3925
2012-02-15 13:23:49 +00:00
Ole Laursen 328ecb08c3 Replace old charter branches with new branch based on conversion branch and some preliminary work on generalizing document handling
[[Split portion of a mixed commit.]]
 - Legacy-Id: 3883.1
2012-01-31 17:38:27 +00:00
Ole Laursen fc88964298 Go through the code and replace uses of Person.name with Person.plain_name()
- Legacy-Id: 3849
2012-01-23 20:22:45 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Robert Sparks 6a1caf8738 Marked area directors who are not on the current IESG with square brackets on the discuss summary page.
Fixes bug 666
 - Legacy-Id: 3601
2011-11-12 05:42:03 +00:00