Commit graph

2026 commits

Author SHA1 Message Date
Robert Sparks 37c796ebef
fix: repair ad-dashboard test 2023-11-06 09:39:10 +01:00
Robert Sparks bdeab001e6
chore: sync subseries index test with view changes 2023-11-05 13:56:50 +01:00
Robert Sparks 801b79fbb1
fix: repair is_downref 2023-11-05 13:49:56 +01:00
Robert Sparks 575560a885
fix: don't parameterize search for subseries types. 2023-11-01 16:08:39 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 986e002c1d
chore: repair merge damage 2023-11-01 12:41:15 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Robert Sparks 0afe496aa3
fix: preserve RelatedDocument references to subseries 2023-10-31 15:52:11 -05:00
Lars Eggert 6d87279895
fix: BCPs can normatively cite all other standards levels (#6530)
* fix: BCPs can normatively cite all other standards levels

Fixes #6524

* Revise the logic and add tests

* Fix bug in truth table
2023-10-25 20:43:05 -05:00
Paul Selkirk bdf71caaf1 feat: Update ISE state when entering/exiting IETF conflict review (#6474)
This extends PR #6424 to cover ISE as well as IRTF documents.
2023-10-13 17:50:05 -04:00
Robert Sparks 6e502fa20e
fix: de-docalias merge from main (#6471) 2023-10-13 14:53:43 -03:00
Robert Sparks ab931f0510
chore: merge main into feat/rfc 2023-10-12 15:11:02 -05:00
Paul Selkirk 16f9e0e974
fix: Adjust IRTF charter approval email headers (#5917) (#6460) 2023-10-11 11:09:10 -05:00
Paul Selkirk 72fef7bc69
fix: Don't allow ADs to set docs to -sent states (#6445) 2023-10-10 10:09:04 -05:00
Paul Selkirk f19d1047c4
feat: Update IRTF state when entering/exiting IETF conflict review (#6424)
* feat: Update IRTF state when entering/exiting IETF conflict review (#3469)

* fix: Update IRTF state in approve_conflict_review() as well

* chore: Add "new_state != prev_state" guard
2023-10-09 15:01:35 -05:00
Lars Eggert 7dbfc0208a
feat: Remove document notes from the datatracker (#6387)
* Remove doc.note

* Address comments from @rjsparks

* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Robert Sparks 4b1274c44d
fix: teach search about rfcs and subseries (#6431)
* fix: teach search about rfcs and subseries

* fix: more general manipulation of searches for rfc and subseries

* fix: only tweak subseries search if the thing after the subseries id is digits
2023-10-04 17:12:01 -03:00
Robert Sparks 9a09bf1f7b
fix: make statement published time match statement doc time (#6419)
* fix: make statement published time match statement doc time

* test: improve testing of creating statements
2023-10-02 09:51:33 -05:00
Paul Selkirk c718fedb6c
feat: Allow review rejections to be undone (#6312)
* feat: Allow reviewer to accept a review they're previously rejected

* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.

This largely un-does d105f8b, at the request of at least one team secretary.

* fix: Went a little overboard on the previous commit

one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.

* fix: Actually do the assignment

* fix: If there's an existing assignment, don't create a new one

* style: Restructure conditional for clarity

* test: Add test cases for accepting or assigning a review assignment after rejecting it
2023-09-27 08:57:34 -05:00
Robert Sparks 9e4166393d
fix: cleaner search_result_row diff links for recent drafts replacing other drafts 2023-09-25 15:39:48 -05:00
Robert Sparks 092e572e16
feat: move errata tags 2023-09-22 16:35:54 -05:00
Robert Sparks 8732dcb706
fix: bring tests up current. add subseries names to rfc view. fix html. 2023-09-22 12:40:15 -05:00
Robert Sparks 0390f1868f
feat: subseries 2023-09-21 12:54:17 -05:00
Jennifer Richards f15960d32d
Merge pull request #6328 from rjsparks/dochistory_rfcnumber
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 20:41:43 -03:00
Robert Sparks a39a058a01
fix: populate rfc_number on DocHistory with type_id rfc 2023-09-15 17:33:05 -05:00
Robert Sparks 88e66048da
fix: make Was link go to the right place. Remove unreachable code. 2023-09-15 16:49:21 -05:00
Robert Sparks e0e647fa75
chore: repair merge damage 2023-09-15 13:59:19 -05:00
Robert Sparks 4811374014
chore: reorder migrations (#6325) 2023-09-15 13:10:19 -05:00
Robert Sparks 621528ad03
ci: Merge branch 'main' into feat/rfc 2023-09-15 11:48:44 -05:00
Jennifer Richards b635045aab
Merge pull request #6309 from rjsparks/crawl-fixes
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-15 11:55:27 -03:00
Robert Sparks 4ddf132efb
fix: remove leftover docalias detritus 2023-09-15 09:51:15 -05:00
Robert Sparks 536c1fb6fc
fix: missed docalias artifact removal. Better use of became_rfc. 2023-09-14 16:43:26 -05:00
Robert Sparks 42c4c275d2
fix: move fewer docevents 2023-09-14 12:07:09 -05:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418)
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Robert Sparks 92ea5a6a89
fix: correct cache variable assignment 2023-09-13 15:46:21 -05:00
Robert Sparks a571151b03
fix: allow looking at slide revisions when the slides doc name starts with rfc 2023-09-13 14:17:27 -05:00
Robert Sparks 3a733a36db
fix: memoize became_rfc. Address review comments. 2023-09-13 14:07:40 -05:00
Jennifer Richards 8bc4507def
feat: Give AD the action in ad-f-up doc state (#6272)
* refactor: Add helper class to compare tag changes

* feat: Give AD the action in ad-f-up state

* refactor: Remove unnecessary check

* refactor: Reorganize update_action_holders()

* refactor: Remove unnecessary guard

* test: Update test for new AD handling

* test: Update another test

* test: Test ad-f-up effect on action holders

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-12 09:44:33 -05:00
Robert Sparks bf50f88863
chore: remove debug 2023-09-12 09:37:13 -05:00
Robert Sparks 0c85c4169d
fix: repairs to the timeline graphic 2023-09-12 09:23:01 -05:00
Robert Sparks 5bbea70cb0
fix: repair many revision related issues with the main and htmlized views 2023-09-12 08:55:38 -05:00
Robert Sparks 72d44d56c4
chore: black 2023-09-12 08:52:15 -05:00
Robert Sparks b58ddd7674
fix: move rfc dochistory objects to rfc document objects 2023-09-12 08:51:17 -05:00
Paul Selkirk febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6231)
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088)

* chore: Move PUBLISH_IPR_STATES from settings_local to settings

* fix: Add migration for removed_objfalse in IprEventTypeName

* fix: De-conflict migration

* fix: De-conflict migration

* style: Move PUBLISH_IPR_STATES ahead of not-production block
2023-09-11 13:14:46 -05:00
Robert Sparks 6b6c881353
fix: construct double-submit test correctly (#6168)
* fix: construct double-submit test correctly

* chore: remove unused import
2023-09-08 13:02:18 -05:00
Robert Sparks 7391ea7239
fix: rationalize document_rfc.html and the view driving it 2023-09-07 13:11:33 -05:00
Lars Eggert fb4002dbbd
fix: Don't show deferred I-Ds in AD's missing ballot list (#6162)
* fix: Don't show deferred I-Ds in AD's missing ballot list

Fixes #6152

* Address code review comments
2023-09-05 12:16:33 -05:00
Robert Sparks e0f27b9d52
ci: merge branch 'main' into feat/rfc 2023-09-05 12:02:07 -05:00
Robert Sparks 3c1fc3c0f9
chore: use factory-boy 3.3 (#6269) 2023-09-05 09:54:30 -05:00
Robert Sparks b5bf6789da
chore: remove one shot iab artifact importers (#6258) 2023-08-31 17:14:18 -05:00