Commit graph

135 commits

Author SHA1 Message Date
Henrik Levkowetz 26fcce9c28 Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task.
- Legacy-Id: 12017
2016-09-22 14:23:20 +00:00
Henrik Levkowetz a1efbcad47 Fixed an issue where button badges would be positioned differently on firefox and webkit-based browsers.
- Legacy-Id: 11958
2016-09-09 16:52:36 +00:00
Henrik Levkowetz d0072a580d Tweaked help text for the nomcom member entry form.
- Legacy-Id: 11731
2016-07-20 16:45:41 +00:00
Henrik Levkowetz 5f1f06631c Merged in [11686] from rcross@amsl.com:
A refactor to give secretariat a broader selection of groups to choose from when scheduling non-working group sessions.
 - Legacy-Id: 11694
Note: SVN reference [11686] has been migrated to Git commit b195beb3ad
2016-07-17 11:48:11 +00:00
Henrik Levkowetz b0a0bbbe63 Merged in [11681] from suresh.krishnan@ericsson.com:
Allowed ADs to manage out of area working groups and upload proceedings for them. Fixes issue #1648.
 - Legacy-Id: 11693
Note: SVN reference [11681] has been migrated to Git commit f570ff803d
2016-07-17 11:16:09 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com:
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
2016-01-15 21:59:49 +00:00
Henrik Levkowetz 9bf1ff01f1 Merged in [10621] from lars@netapp.com:
Use js tablesort almost everywhere I thought it would make sense. While I
touched the pages, I also corrected a few minor HTML nits, capitalization
inconsistencies and some other minor things.
Range r10605:r10621
 - Legacy-Id: 10647
Note: SVN reference [10621] has been migrated to Git commit 7d3c2681e2
2016-01-12 16:47:18 +00:00
Robert Sparks 17f7b63603 cleaned some cruft of the unrelated feedback template
- Legacy-Id: 10626
2015-12-23 15:03:14 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once.
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
2015-12-22 21:42:55 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting.
- Legacy-Id: 10620
2015-12-22 04:32:48 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages
- Legacy-Id: 10618
2015-12-21 20:46:56 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField
- Legacy-Id: 10609
2015-12-18 20:38:17 +00:00
Robert Sparks a2af7cfa25 Removed BaseNomcomForm and the notion of custom fieldsets
- Legacy-Id: 10608
2015-12-17 22:31:29 +00:00
Robert Sparks f68d546233 removed move_to_default
- Legacy-Id: 10603
2015-12-16 12:07:32 +00:00
Robert Sparks bf54e2b3f5 Regroup multiselect options to make classifying pending feedback simpler. Make the control larger and resizable. Fixes #1854.
- Legacy-Id: 10593
2015-12-14 23:14:44 +00:00
Robert Sparks 5e0632e8eb Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866.
- Legacy-Id: 10592
2015-12-14 21:05:52 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845.
- Legacy-Id: 10589
2015-12-14 03:26:43 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit)
- Legacy-Id: 10587
2015-12-12 03:49:23 +00:00
Robert Sparks 015242da28 Improve guidance on when, and when not, to delete a Position
- Legacy-Id: 10584
2015-12-11 20:56:52 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768.
- Legacy-Id: 10565
2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850.
- Legacy-Id: 10535
2015-12-02 23:25:42 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template
- Legacy-Id: 10531
2015-12-02 15:45:40 +00:00
Lars Eggert 808196bc0c Update a number of web assets to their latest versions.
Commit ready for merge.
 - Legacy-Id: 10530
2015-12-02 15:05:51 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query
- Legacy-Id: 10526
2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges.
- Legacy-Id: 10525
2015-12-02 03:32:06 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809.
- Legacy-Id: 10524
2015-11-29 21:12:19 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771.
- Legacy-Id: 10522
2015-11-29 04:00:02 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856.
- Legacy-Id: 10521
2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795.
- Legacy-Id: 10505
2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849.
- Legacy-Id: 10501
2015-11-16 21:46:29 +00:00
Robert Sparks bb51fbe059 Preserve linefeeds (using class pasted) when viewing nomcom feedback messages. Commit ready for merge.
- Legacy-Id: 10220
2015-10-16 19:15:44 +00:00
Robert Sparks 71a198c112 Remove spurious parenthesis from the template for viewing nomcom feedback. Commit ready for merge.
- Legacy-Id: 10003
2015-08-10 17:59:04 +00:00
Robert Sparks bcc14cb0d1 Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee. Commit ready for merge.
- Legacy-Id: 10002
2015-08-10 17:57:38 +00:00
Henrik Levkowetz 9cb8f65c8e Updated templates to use the static template tag for static files.
- Legacy-Id: 9945
2015-08-01 14:53:59 +00:00
Henrik Levkowetz 54aac4e12a Updated templates to use the 'static' template tag to dynamically point to the correct static files location.
- Legacy-Id: 9889
2015-07-26 18:15:24 +00:00
Henrik Levkowetz 942352c50b Merged in [9766] from lars@netapp.com:
More HTML fixes.
 - Legacy-Id: 9787
Note: SVN reference [9766] has been migrated to Git commit 77f555bdbdfa653e4b5a0589ead9eda6632f10d7
2015-07-18 12:42:38 +00:00
Henrik Levkowetz 5d8306cfc8 Merged in [9733] from lars@netapp.com:
First round of HTML fixes identified by test-crawl --vnu.
 - Legacy-Id: 9764
Note: SVN reference [9733] has been migrated to Git commit 205df716f8bf4b7dae9e2637f3aa1ba048a158f9
2015-07-18 08:55:30 +00:00
Henrik Levkowetz 0d08fff0ac Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9555
2015-04-24 21:45:04 +00:00
Henrik Levkowetz ec0321e0da Added copyright lines and template origin to the html templates. Fixed a number of instances of html that didn't validate.
- Legacy-Id: 9551
2015-04-24 20:40:01 +00:00
Henrik Levkowetz 789fcb2307 Put back the value attribute for the name/value pair of many input and button elements which lost the value attribute in the conversion, in order to let the backing form code determine which button was pressed.
- Legacy-Id: 9500
2015-04-15 11:31:29 +00:00
Henrik Levkowetz d4bd6c3775 Renamed the base template file from 'ietf.html' to 'base.html'.
- Legacy-Id: 9427
2015-04-08 19:16:48 +00:00
Ole Laursen a589115ff4 Summary: Reindent all HTML files to follow the previous convention (no
tabs) and kill the scripts block in favour of just using a js block with
a script tag (which is easier to understand for context-sensitive
modes such as web-mode in Emacs). Also fix a couple of details, e.g.
missing semicolons in JS snippets.
 - Legacy-Id: 9096
2015-02-17 18:01:04 +00:00
Ole Laursen c72d465438 Summary: Insert anchor-target hack to try to alleviate the problem of
the top menu covering the anchor target, also increase the width at
which content navigation menus disappear
 - Legacy-Id: 9093
2015-02-17 15:17:05 +00:00
Ole Laursen a0ff3cfefb Summary: Move some of the morecss statements to ietf.css, as per
instructions in the README
 - Legacy-Id: 8996
2015-02-05 15:49:34 +00:00
Ole Laursen 9d71ef3179 Summary: Move select2 field handling to a separate .js file, currently
we only include the select2 things on pages with forms that need it
anyway, and this makes it easier to use it in the Secretariat code
 - Legacy-Id: 8986
2015-02-05 13:48:27 +00:00
Ole Laursen e78637b9fc Remove non-facelift static assets, and move the facelift assets one step up
- Legacy-Id: 8971
2015-02-04 17:03:43 +00:00
Ole Laursen b5458c29d3 Summary: Clean up some of the FACELIFT comments
- Legacy-Id: 8959
2015-02-03 16:18:42 +00:00
Ole Laursen 8c5f79ec4b Facelift a couple of pages that has previously escaped because of inheritance from a sub-base page
- Legacy-Id: 8939
2015-01-28 13:02:22 +00:00
Ole Laursen 7462ade959 Summary: Cleanup markup for navtabs a little, use CSS to add margin
instead of empty paragraph
 - Legacy-Id: 8919
2015-01-26 16:32:56 +00:00