altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity
7735 commits 1 branch 0 tags 2.6 GiB
Commit graph

83 commits

Author SHA1 Message Date
Henrik Levkowetz 8a5593e714 When converting submission events to doc events, post them in chronological order. Don't add upload doc events until we're past the possibility of submission cancellation. 
- Legacy-Id: 12097
 2016-10-06 17:03:23 +00:00
Henrik Levkowetz 72cfe4cf68 Removed the creation of duplicate new revision doc events. Corrected the timestamp on approval docevents. Changed where the submission upload docevent is created, to avoid spurious events for cancelled uploads. Adjusted the person associated with some events from submitter to (System). Added tests for the sequence of events associated with a submission. 
- Legacy-Id: 12072
 2016-10-01 21:16:04 +00:00
Henrik Levkowetz 68655b569b Fixed 2 testing bugs. Added tests for handling of submitters without email and drafts with non-ascii names in the author section. 
- Legacy-Id: 12064
 2016-09-30 17:35:35 +00:00
Henrik Levkowetz da2c25182f Code changes to handle draft submission authors without email addresses better. 
- Legacy-Id: 12063
 2016-09-30 10:48:46 +00:00
Henrik Levkowetz 613363cccc Try various ways of handling non-ascii names/emails in draft submissions, in order to get past the early processing to the point where we run idnits and can flag non-ascii content, instead of failing with a server 500 error. 
- Legacy-Id: 12053
 2016-09-27 20:27:05 +00:00
Henrik Levkowetz 254c3db807 Style changes. 
- Legacy-Id: 11944
 2016-09-08 17:37:36 +00:00
Henrik Levkowetz 47d6bbbea3 Renamed the SubmissionEmail event class to SubmissionEmailEvent, and added an admin class for it. 
- Legacy-Id: 11942
 2016-09-08 15:04:53 +00:00
Henrik Levkowetz 7a8c067d83 Changed a state name, and renamed some view functions for easier code reading. Removed extra name= parameters from the submit/ urlpatterns. 
- Legacy-Id: 11917
 2016-09-01 09:14:34 +00:00
Henrik Levkowetz e2fccfb094 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0@11899, which provides better support for manual ID posting. 
- Legacy-Id: 11914
 2016-08-31 22:30:31 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0 
- Legacy-Id: 11899
 2016-08-31 03:00:10 +00:00
Robert Sparks 2009afe7b8 preparing to merge forward to 6.31 
- Legacy-Id: 11875
 2016-08-25 15:21:57 +00:00
Henrik Levkowetz be2a2285bc Added small orange or green yang symbols to draft info- and list-pages, signifying fail or pass for the submission yang validation. 
- Legacy-Id: 10994
 2016-03-28 18:47:53 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check. 
- Legacy-Id: 10894
 2016-03-04 20:08:29 +00:00
Robert Sparks cb778b9660 Exclude concluded bofs from the set of groups for which a person can pre-approve drafts. Restore AD access to preapproval. (Need to consider adding delegate and group secretary access). Fixes #1896. Commit ready for merge 
- Legacy-Id: 10734
 2016-01-26 19:42:57 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward. 
- Legacy-Id: 10157
 2015-10-09 03:16:24 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Henrik Levkowetz cd0a482cb9 Log and re-raise the initial exception, rather than raising one later because submission is undefined. 
- Legacy-Id: 10073
 2015-09-03 15:14:44 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow 
- Legacy-Id: 10040
 2015-08-23 18:15:06 +00:00
Robert Sparks 89f038a1e3 checkpoint 
- Legacy-Id: 10019
 2015-08-17 20:24:16 +00:00
Henrik Levkowetz fe6aa25af5 Improved the handling of failed xml2rfc conversions when no txt document was submitted. 
- Legacy-Id: 9914
 2015-07-29 19:38:00 +00:00
Henrik Levkowetz ea26114076 Merged in [9875] from rjsparks@nostrum.com: 
Improve the form validation for the submission replaces form.
 - Legacy-Id: 9877
Note: SVN reference [9875] has been migrated to Git commit 766270a344
 2015-07-25 15:29:30 +00:00
Robert Sparks 766270a344 Improve the form validation for the submission replaces form. Commit ready for merge. 
- Legacy-Id: 9875
 2015-07-23 14:24:59 +00:00
Henrik Levkowetz da893dad1c Merged in support of xml-source only drafts submissions from personal/henrik/submitxml/. 
- Legacy-Id: 9859
 2015-07-22 21:53:23 +00:00
Henrik Levkowetz d5f36911cf Added support of xml-source only drafts submissions. 
- Legacy-Id: 9858
 2015-07-22 21:35:44 +00:00
Robert Sparks 02a9da52a1 Manually moved the concepts forward. Reworked some presentation. Working enough to bring testers in at Sprint93 
- Legacy-Id: 9717
 2015-07-13 21:09:39 +00:00
Henrik Levkowetz bd6d0775e1 Require posting confirmation for some particular draft name prefixes. 
- Legacy-Id: 8591
 2014-11-08 03:15:20 +00:00
Henrik Levkowetz 9ff2b9ff9a Merged in support for RG pages, from branch/iola/rg-support. 
- Legacy-Id: 7866
 2014-06-09 20:52:14 +00:00
Henrik Levkowetz b5df5c836e Merged in [7587] from rjsparks@nostrum.com: 
Anyone with a role in a group could preapprove drafts. Changed that to an explicit subset of roles. Fixes ticket 998.
 - Legacy-Id: 7609
Note: SVN reference [7587] has been migrated to Git commit 5ba0a274933e61e242ebcbf72b2f37e27d1da60d
 2014-04-13 20:42:26 +00:00
Henrik Levkowetz 45ed4e6da3 Merged [7421] from olau@iola.dk: Fix a crash bug in the redirection logic that occurs when someone 
posts a draft without an access token from the email confirmation step
 - Legacy-Id: 7600
Note: SVN reference [7421] has been migrated to Git commit c0e34dbcad
 2014-04-12 18:32:20 +00:00
Ole Laursen 25625a0241 Add support for RG Chairs for pre-approving draft submissions. Also fixup the preapproval JS so it auto-focuses the draft name text input when you click one of the prefilled names. 
- Legacy-Id: 7542
 2014-03-25 12:14:41 +00:00
Henrik Levkowetz 870be71f79 Made ietf/submit pyflakes-clean. 
- Legacy-Id: 7499
 2014-03-16 08:03:15 +00:00
Ole Laursen c0e34dbcad Fix a crash bug in the redirection logic that occurs when someone 
posts a draft without an access token from the email confirmation step
 - Legacy-Id: 7421
 2014-03-06 11:27:50 +00:00
Ole Laursen 5e7d8c6c08 Fix auth check for editing the metadata of a submission - the path 
without an access token would not allow a Secretariat user but instead
always throw an exception
 - Legacy-Id: 7079
 2014-01-08 17:40:22 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5 
- Legacy-Id: 6968
 2013-12-18 10:13:40 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead 
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
 2013-12-17 10:23:42 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00
Ole Laursen 650d8316eb Make the submit tool use the access token framework with a bit of backwards compatibility glue 
- Legacy-Id: 6717
 2013-11-15 16:09:05 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models: 
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
 2013-11-15 13:30:32 +00:00
Henrik Levkowetz 71d797bcb8 Refines Joel's fix to show clearly who receives draft submission confirmation emails, to show a more detailed warning text when the submitter isn't in the addressee list. Fixes issue #1097. 
- Legacy-Id: 6659
 2013-11-06 15:29:02 +00:00
Ole Laursen 2daff23f02 Remove shim layer from submit code 
- Legacy-Id: 6654
 2013-11-05 16:59:13 +00:00
Joel M. Halpern 72885f4524 Include confirmation addresses in ID-Submission success notice. 
Fixes issue #1097.
 - Legacy-Id: 6638
 2013-11-02 23:29:21 +00:00
Henrik Levkowetz 1dae75ee59 The exception string for submission upload read errors seems to have changed after we switched to wsgi, from "Client read error" to "request data read error". Now looking for just "read error". 
- Legacy-Id: 6264
 2013-09-26 06:29:28 +00:00
Henrik Levkowetz 08f5d1dc08 Preparatory work for adding a 'Replaces' field to the draft submission tool. 
- Legacy-Id: 5719
 2013-05-09 20:08:40 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk. 
- Legacy-Id: 5147
 2012-12-20 20:32:03 +00:00
Ole Laursen c20a5f6bf0 Convert the submit tool to associate RGs and IAB with drafts instead 
of assigning them to individual submission, this is not a complete
overhaul but at least basic support so submission works and doesn't
say WG when it means RG.
 - Legacy-Id: 4910
 2012-10-10 16:15:09 +00:00
Henrik Levkowetz 40081edc27 Don't try to add a ballot's AD email addresses to a new version notification email if there's no ballot. Also did some linguistic fixes, and got rid of a wildcard import. 
- Legacy-Id: 4809
 2012-08-24 08:49:32 +00:00
Ole Laursen ed96cee2e4 Add listing of recently approved drafts to approval page by request 
from Barry Leiba.
 - Legacy-Id: 4420
 2012-05-14 18:21:34 +00:00
Ole Laursen c2b8c653fd Fix bug in submit, had forgotten I had replaced filename with name in 
Preapproval model.
 - Legacy-Id: 4413
 2012-05-10 18:22:03 +00:00
Ole Laursen 188c0846d0 Add approval/pre-approval page for Secretariat and WG Chairs, with 
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
 - Legacy-Id: 4411
 2012-05-10 18:07:59 +00:00
Ole Laursen 8153a1c130 Patch up to pass request object to send mail in the instances where 
it's possible (i.e. when not run in cron) in preparation for better
mail test handling
 - Legacy-Id: 3711
 2011-11-25 18:24:14 +00:00