Commit graph

42 commits

Author SHA1 Message Date
Henrik Levkowetz 7d0fd4cb29 Merged in [11859] from rjsparks@nostrum.com:
Put WG summary information on the rechartering page. Fixes #2000.
 - Legacy-Id: 11881
Note: SVN reference [11859] has been migrated to Git commit b6978debb6
2016-08-26 10:31:03 +00:00
Robert Sparks b6978debb6 Put WG summary information on the rechartering page. Fixes #2000. Commit ready for merge.
- Legacy-Id: 11859
2016-08-24 18:43:15 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Russ Housley 858530c214 Cleaned up the checking permission for a user to manage a group. Also, cleanly handle a set of group parent links did for a loop.
- Legacy-Id: 11082
2016-04-02 21:06:33 +00:00
Robert Sparks b1f229cf9d Create the approval ballot for charters when the charter enters external review (or iesg review if external review is skipped). Fixes #1792. Commit ready for merge.
- Legacy-Id: 10803
2016-02-08 19:59:47 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Robert Sparks f9e35662e5 Fix an initialization problem for the new work message for recharters. Commit ready for merge.
- Legacy-Id: 10218
2015-10-16 16:34:25 +00:00
Ole Laursen 43445307b1 Summary: Be more careful with generating announcements for charters so
they are not saved unless we're in a POST
 - Legacy-Id: 10141
2015-10-07 10:42:31 +00:00
Ole Laursen ec54a59cc6 Summary: Be more careful when generating writeups so that we wait with
saving newly generated writeups until we see a POST (problem found by
the test crawler)
 - Legacy-Id: 10137
2015-10-06 16:20:12 +00:00
Ole Laursen 63d96e0354 Summary: Get rid of submit_initial_charter hack, only create a charter
when a first revision has actually been submitted.
 - Legacy-Id: 10136
2015-10-06 15:14:31 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks e5306eda00 Instrumented issuing ballots. Simplified the ballot-issued email significantly. Deferred adding ballot_saved mail for the automatic yes positions.
- Legacy-Id: 10068
2015-08-28 17:33:49 +00:00
Robert Sparks 150106619b Handle the new-work message
- Legacy-Id: 10066
2015-08-27 21:27:10 +00:00
Robert Sparks 12a03d299b Automatically send the Internal Review message that the secretary currently has to send manually
- Legacy-Id: 10063
2015-08-26 21:31:11 +00:00
Robert Sparks 56ddf4ca2e checkpoint. includes moderate change to how personnel changes are sent out
- Legacy-Id: 10020
2015-08-17 22:11:54 +00:00
Robert Sparks f30f5c39f1 checkpoint
- Legacy-Id: 10017
2015-08-13 21:16:21 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy
- Legacy-Id: 9357
2015-04-02 06:51:34 +00:00
Henrik Levkowetz 2f54511763 Changed all explicitly set HttpResponse content_types to specify charset.
Django sets charset if you don't specify a content_type; if you specify
one you also must add a charset specification (if you want one).  
Fixes issue #1647.
 - Legacy-Id: 9348
2015-03-26 21:35:21 +00:00
Ole Laursen eccd8d27c4 Make new branch from trunk (r9007) and merge facelift-r8876 into it, fixing a few merge conflicts
- Legacy-Id: 9014
2015-02-06 14:08:34 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it
- Legacy-Id: 8940
2015-01-28 13:25:21 +00:00
Ole Laursen d7b4ef6ac4 Summary: Facelift change charter title page
- Legacy-Id: 8932
2015-01-28 09:04:41 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut.
- Legacy-Id: 8896
2015-01-22 17:38:05 +00:00
Robert Sparks 65804be683 This is the second step towards ADs out of GroupInfo into Role.
The use of group.ad has been scrubbed from the code and templates.
  - Those places that set group.ad have been directly manipulate Role objects instead
  - Most places that read group.ad now use a new group.ad_role() that returns a Role object, simplifing some views.

Related to #1555 and #1557.

Commit ready for merge.
 - Legacy-Id: 8854
2015-01-09 18:52:06 +00:00
Robert Sparks 4c9db8f250 This is the first step towards using Role to represent Area directors. It
- Migrates the information captured in GroupInfo.ad to Role objects.
- Renames GroupInfo.ad to GroupInfo._ad (retaining the current column name) to prepare for deletion of that field.
- Provides ad property accessor and setter methods implemented using the group's role_set (so that the existing view code continues to work with minimal changes)
- Improved selection in many querysets that assumed only groups of type 'area' would have area directors.

Related to #1557 and #1555.

Commit ready to merge.
 - Legacy-Id: 8851
2015-01-08 20:22:23 +00:00
Henrik Levkowetz ea341466ca Merged in [8609] from tterriberry@mozilla.com, with minor changes:
Allow changing the title of a charter document.
   Fixes #1334
 - Legacy-Id: 8635
Note: SVN reference [8609] has been migrated to Git commit 63d919eb52
2014-11-11 01:34:04 +00:00
Timothy B. Terriberry 63d919eb52 Allow changing the title of a charter document
Fixes #1334
Commit ready for merge
 - Legacy-Id: 8609
2014-11-09 00:46:28 +00:00
Lars Eggert a4daf2630c Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift
Conflicts:
	ietf/doc/templatetags/ietf_filters.py
	ietf/doc/views_charter.py
	ietf/templates/doc/charter/edit_notify.html
	ietf/templates/doc/charter/edit_telechat_date.html
	ietf/templates/doc/document_ballot_content.html
	ietf/templates/doc/document_history.html
	ietf/templates/doc/edit_notify.html
	ietf/templates/doc/edit_telechat_date.html
	ietf/templates/doc/notify.html
	ietf/templates/group/concluded_groups.html
 - Legacy-Id: 8429
2014-10-14 11:48:57 +00:00
Henrik Levkowetz d4e5f070af Merged in [8293] from rjsparks@nostrum.com:\n XXX: Should what is now captured in the list of STATUSCHANGE_RELATIONS instead be captured in the database in name_docrelationshipname?
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes #1438
 - Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
2014-10-12 17:32:11 +00:00
Henrik Levkowetz ec3e247732 Merged in [8262] and [8263] from rjsparks@nostrum.com:
Changes when returning_item is automatically set to match the
    current IESGs preferences.  Removes several chunks of dead code
    related to editing telechat dates.  Improves returning item tests.

    Refactored multiple edit_telechat functions into one function in
    doc_views.  Added a helper function for determining if ballots have
    changed to isolate the implementation.  Fixed the issue with
    update_agenda setting the returning item bit even when the user
    explicitly said not to.  Added prompting to encourage proper setting
    of the returning item bit to the edit_telechat view.

    Fixes #1209
 - Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1

Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
2014-09-28 19:57:01 +00:00
Henrik Levkowetz 2ff2d79a7e Merged in [8210] from rjsparks@nostrum.com:\n Default the responsible AD for an initial charter or recharter document to the responsible AD for the group. Fixes ticket #1451.
- Legacy-Id: 8316
Note: SVN reference [8210] has been migrated to Git commit 77ddbbe04aedcf7ad7af35032606c1e952228a84
2014-09-16 19:52:24 +00:00
Cong Liu 8ca62eae6d Force mailing to secretary when a charter state changed to internal or external review. Fixes ticket #1444. Commit ready for merge.
- Legacy-Id: 8122
2014-07-19 16:12:21 +00:00
Henrik Levkowetz f00f589e66 Renamed a very specialized function from email_secretariat() to email_iesg_secretary_re_charter().
- Legacy-Id: 7923
2014-06-17 16:31:12 +00:00
Henrik Levkowetz 9ff2b9ff9a Merged in support for RG pages, from branch/iola/rg-support.
- Legacy-Id: 7866
2014-06-09 20:52:14 +00:00
Robert Sparks cb458b1689 Protect against cases where add_state_change_event can return None. Fixes bug # 1383. Commit ready for merge.
- Legacy-Id: 7677
2014-04-30 22:17:01 +00:00
Ole Laursen 01461d1036 Make sure group state is set when approving charters for non-WGs
- Legacy-Id: 7565
2014-04-02 12:24:36 +00:00
Ole Laursen f52e676793 Move chartering groups to /group/chartering/ (with a redirect from the old location), list RGs there too, and amend the previous fix to the chartering process for non-WGs so they have internal and external review states instead of just approved. Also move the code in wginfo/ to group/ as it is no longer just about info for WGs.
- Legacy-Id: 7556
2014-04-01 11:59:08 +00:00
Ole Laursen d3efeb421f Introduce basic charter support for non-WG groups
- Legacy-Id: 7550
2014-03-27 17:06:56 +00:00
Henrik Levkowetz c19268f6a1 A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code.
- Legacy-Id: 7509
2014-03-16 22:15:46 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen 6b2d50db93 Implement missing charter tests as found by the coverage check
- Legacy-Id: 7127
2014-01-14 15:50:03 +00:00
Ole Laursen 7e00fa1424 Move the Secretariat group email utility to wginfo and the rest of the wgcharter stuff to doc/(views|urls|utils)_charter.py alongside the other document types
- Legacy-Id: 7121
2014-01-13 16:08:58 +00:00
Renamed from ietf/wgcharter/views.py (Browse further)