This set of changes focuses on improvements to the nomcom portion of
the datatracker.
These changes:
- Simplify the nomcom form for comments. Make it more obvious who
receives mail when a comment is supplied. Fixes#1849.
- Simplify the nomcom form for nominations. Provide a primary workflow
where nominations choose an existing Person, and a secondary
workflow for nominating new people.
- Allow nominees to add a comment when accepting or declining a
nomination. Fixes#1845.
- Organize the list of nominees on the feedback page. Fixes#1786 and
#1809.
- Simplify the mechanisms used to display feedback message counts.
- Regroup the feedback view to make it easier to see where to spend
review effort. Fixes#1866.
- Capture when nomcom members last reviewed feedback for a given
nominee. Add badges when new feedback is avaliable. Improve the
layout of the feedback index page. Fixes#1850.
- Reorganize the tab navigation on the nomcom private pages. Made it
more obvious when the chair is doing something that only the chair
gets to see. Fixes#1788 and #1795.
- Regroup multiselect options to make classifying pending feedback
simpler. Make the control larger and resizable. Fixes#1495.
- Simplify the chair's views for editing nominee records. Replace the
merge nominee form with a request to the secretariat to merge Person
records. Fixes#1847.
- Added merging nominees to the secretariat's persson merging script.
- Show information for concluded nomcoms. Close feedback and
nomination for concluded nomcoms. Fixes#1856.
- Improve the questionnaire templates, reminding the nominee that
receiving the questionnaire does not imply they have accepted a
nomination. Fixes#1807.
- Remove the description field from Postion. Simplify the Position
list and the Position edit form. Make the nomcom pages more self
documenting. Add a page to help nomcom chiars through setting up a
new nomcom. Fixes#1867 and #1768.
- Remove the type from the template pathname for the requirements
templates. Make the requirements views work for both types plain and
rst. Changed the default type for new nomcom requirement templates
to rst.
- Remove 'incumbent' from the models. Fixes#1771.
- Adjust the models for Nominee and Nomination to better associate
Nominee objects with Person objects.
- Remove BaseNomcomForm and the implementation of custom fieldsets.
- Replace the custom message framework with the django provided
messages framework.
- Improve SearchablePersonField to show the primary email address for
any search result where a name appears more than once.
- Add the use of factory-boy for generating test data. Normalize
management of a test directory for test nomcom public keys.
Significantly improve test coverage of the nomcom related code.
- Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
Better handling of consensus for BCPs and standards track documents. Partial fix for ticket 1560.
- Legacy-Id: 10653
Note: SVN reference [10630] has been migrated to Git commit 884291fd91
These changes:
Simplify the nomcom form for comments. Make it more obvious who receives mail when a comment is supplied. Fixes # 1849.
Simplify the nomcom form for nominations. Provide a primary workflow where nominations choose an existing Person, and a secondary workflow for nominating new people.
Allow nominees to add a comment when accepting or declining a nomination. Fixes#1845.
Organize the list of nominees on the feedback page. Fixes#1786 and #1809.
Simplify the mechanisms used to display feedback message counts.
Regroup the feedback view to make it easier to see where to spend review effort. Fixes#1866.
Capture when nomcom members last reviewed feedback for a given nominee. Add badges when new feedback is avaliable. Improve the layout of the feedback index page. Fixes#1850.
Reorganize the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes#1788 and #1795.
Regroup multiselect options to make classifying pending feedback simpler. Make the control larger and resizable. Fixes#1854.
Simplify the chair's views for editing nominee records. Replace the merge nominee form with a request to the secretariat to merge Person records. Fixes#1847.
Added merging nominees to the secretariat's persson merging script.
Show information for concluded nomcoms. Close feedback and nomination for concluded nomcoms. Fixes#1856.
Improve the questionnaire templates, reminding the nominee that receiving the questionnaire does not imply they have accepted a nomination. Fixes#1807.
Remove the description field from Postion. Simplify the Position list and the Position edit form. Make the nomcom pages more self documenting. Add a page to help nomcom chiars through setting up a new nomcom. Fixes#1867 and #1768.
Remove the type from the template pathname for the requirements templates. Make the requirements views work for both types plain and rst. Changed the default type for new nomcom requirement templates to rst.
Remove 'incumbent' from the models. Fixes#1771.
Adjust the models for Nominee and Nomination to better associate Nominee objects with Person objects.
Remove BaseNomcomForm and the implementation of custom fieldsets.
Replace the custom message framework with the django provided messages framework.
Improve SearchablePersonField to show the primary email address for any search result where a name appears more than once.
Add the use of factory-boy for generating test data. Normalize management of a test directory for test nomcom public keys. Significantly improve test coverage of the nomcom related code.
Commit ready for merge.
- Legacy-Id: 10629
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes#1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
- Legacy-Id: 10625
Reduce confusion around how to send a document from a WG to the IESG through additional, restrictive, validation on the stream state editing form. Fixes bug #1418.
- Legacy-Id: 10445
Note: SVN reference [10431] has been migrated to Git commit 5ee77ca282
Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10420
Note: SVN reference [10418] has been migrated to Git commit cf7d794b09
This fixes Javascript widgets working with DocAliases, such as the
replaces field in draft submission, to work better with Javascript
disabled. It also makes sense from a modelling perspective as the name
really is a unique key for the alias.
The actual transformation requires a series of migrations taking a
couple of minutes to complete. The actual switch to the key is done at
the end.
- Legacy-Id: 10251
Note: SVN reference [10111] has been migrated to Git commit 8bca1b4b33
This fixes Javascript widgets working with DocAliases, such as the
replaces field in draft submission, to work better with Javascript
disabled. It also makes sense from a modelling perspective as the name
really is a unique key for the alias.
The actual transformation requires a series of migrations taking a
couple of minutes to complete. The actual switch to the key is done at
the end.
Branch ready for merge.
- Legacy-Id: 10111
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.
To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.
While revising the existing code to work with this API, a couple of
missing events was discovered:
- In draft expiry, a "Document has expired" event was only generated
in case an IESG process had started on the document - now it's
always generated, as the document changes its state in any case
- Synchronization updates like title and abstract amendmends from the
RFC Editor were silently (except for RFC publication) applied and
not accompanied by a descriptive event - they now are
- do_replace in the Secretariat tools now adds an event
- Proceedings post_process in the Secretariat tools now adds an event
- do_withdraw in the Secretariat tools now adds an event
A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
- Legacy-Id: 10101
tabs) and kill the scripts block in favour of just using a js block with
a script tag (which is easier to understand for context-sensitive
modes such as web-mode in Emacs). Also fix a couple of details, e.g.
missing semicolons in JS snippets.
- Legacy-Id: 9096
enhances a number of pages in the datatracker where forms contain fields
where a person should be chosen, such as for instance when choosing the
shepherd of a document, so that they uniformly display choices which show
both email address and name.
Furthermore, changes have been made so as to make the email address
uniformly act as reference to the person record.
Autocompletion is now consistently provided when looking for the email
address or name of the person to choose.
This solves a number of issues where it has been difficult to choose the
correct Person/Email combination, and where the correct email address to use
for an association has been unavailable previously.
- Legacy-Id: 8472
Note: SVN reference [8471] has been migrated to Git commit d62f2343e8
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes#1438
- Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
Send email when a the telechat date (or returning item bit) changes for a document.
Fixes#1452
- Legacy-Id: 8383
Note: SVN reference [8271] has been migrated to Git commit 80fc0c7caa4feac2966722324e42a53cabe67a6b
Note: SVN reference [8292] has been migrated to Git commit 7c56f8bad35b6ed06f6c6eff7436c178209d4143
Changes when returning_item is automatically set to match the
current IESGs preferences. Removes several chunks of dead code
related to editing telechat dates. Improves returning item tests.
Refactored multiple edit_telechat functions into one function in
doc_views. Added a helper function for determining if ballots have
changed to isolate the implementation. Fixed the issue with
update_agenda setting the returning item bit even when the user
explicitly said not to. Added prompting to encourage proper setting
of the returning item bit to the edit_telechat view.
Fixes#1209
- Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1
Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
