Commit graph

151 commits

Author SHA1 Message Date
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Robert Sparks 8a7c5ac977 All documents show on the AD status page now
- Legacy-Id: 5422
2013-02-04 02:24:14 +00:00
Robert Sparks 589ff698ee Merge forward complete
- Legacy-Id: 5328
2013-01-24 21:28:27 +00:00
Ole Laursen 4b312de464 Introduce a simple cache in doc.get_state so repeated reads don't
cause a DB query
 - Legacy-Id: 5314
2013-01-21 14:01:33 +00:00
Ole Laursen ab6a7f85c0 Get rid of initial "No record" positions when showing old positions,
it's just noise
 - Legacy-Id: 5312
2013-01-21 11:54:56 +00:00
Ole Laursen 188c619635 Display draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
 - Legacy-Id: 5288
2013-01-17 16:02:50 +00:00
Ole Laursen 6e45e5e17b Remove .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
 - Legacy-Id: 5205
2013-01-16 14:15:18 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Ole Laursen 6c91e93886 Allow State.next_states to be blank so the admin doesn't barf
- Legacy-Id: 5023
2012-11-07 14:57:04 +00:00
Ole Laursen 730cd6056e Add DeletedEvent for storing redacted events
- Legacy-Id: 5021
2012-11-07 14:55:39 +00:00
Robert Sparks 2e6caa21b1 Reimplemented clear_ballot to close the existing ballot and create a new one. Changed the all_positions code to only return synthetic no-positions for current ADs when a ballot is actually open
- Legacy-Id: 4909
2012-10-10 15:48:34 +00:00
Henrik Levkowetz 27186d111e Added a docstring note about the convention for when save_*_in_history() shoudl be called.
- Legacy-Id: 4883
2012-09-27 10:03:16 +00:00
Ole Laursen 07490fcb83 Add new IANA states, add consensus event, add a state change event,
add migrations for these that also clean up the RFC Editor states a
little given the recent changes
 - Legacy-Id: 4846
2012-09-17 10:00:56 +00:00
Henrik Levkowetz c245f6a020 Make .ballot_open() available on DocumentInfo instead of on Document, too.
- Legacy-Id: 4807
2012-08-24 08:13:33 +00:00
Henrik Levkowetz 7c78ed81ef Make .active_ballot() available on DocumentInfo instead of on Document, to make charter history snapshots work.
- Legacy-Id: 4803
2012-08-23 10:08:41 +00:00
Henrik Levkowetz c90a26ca50 Merged [4772] from rjsparks@nostrum.com:
Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)

Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)

Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).

Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text


DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.

Fixes bug 865
 - Legacy-Id: 4780
Note: SVN reference [4772] has been migrated to Git commit e5c3a5adc5
2012-08-22 12:34:55 +00:00
Henrik Levkowetz 9bde5b91d6 Added support for conflrev documents based on branch /personal/rcross/v4.32@4722, but tweaked to return only the directory, not the full directory+name+ext path, in order to behave the same way as for other document types.
- Legacy-Id: 4779
2012-08-22 11:26:50 +00:00
Robert Sparks 87ebddd0ba Simplified access to current BallotDocevent from a Document.
Added functions to BallotDocEvents to faciliate access to BallotPositionDocEvents, both for all positions, and current AD postions.
Updated the moderator package to use the Documents from _agenda_data.
Added a filter to assist with rendering the moderator package.
Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).
 - Legacy-Id: 4768
2012-08-17 20:45:32 +00:00
Robert Sparks fb2b9c9e6c Removed some duplication between doc/util and doc/models by moving things into doc/models. Fixes bug #857
- Legacy-Id: 4750
2012-08-02 21:36:36 +00:00
Henrik Levkowetz 6dd8086125 Merged [4724] from rbarnes@bbn.com:
Adjusted the scribe template to make it XHTML compliant and fix what Robert broke
 - Legacy-Id: 4730
Note: SVN reference [4724] has been migrated to Git commit 08c1c0cb19
2012-07-30 21:44:42 +00:00
Richard Barnes 08c1c0cb19 Adjusted the scribe template to make it XHTML compliant and fix what Robert broke
- Legacy-Id: 4724
2012-07-29 01:09:41 +00:00
Adam Roach 80d7ab9eba Adding an "href" method to documents. It doesn't work for documents of type 'liai-att' or 'liaison', but it's a good start.
- Legacy-Id: 4721
2012-07-29 00:42:19 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Henrik Levkowetz a5041a262f Tweak the display of DocEvents.
- Legacy-Id: 4563
2012-07-03 10:58:54 +00:00
Henrik Levkowetz fdb18755a7 Tweak the display of explicitly added documents some more.
- Legacy-Id: 4530
2012-06-27 10:22:01 +00:00
Ole Laursen 8929413a71 Merged in changes from former milestones branch
- Legacy-Id: 4516
2012-06-26 18:09:43 +00:00
Ole Laursen 6c1e87b773 Move milestones branch out of the way to prepare for merge with trunk to get latest charter changes in
[[Split portion of a mixed commit.]]
 - Legacy-Id: 4514.1
2012-06-26 17:47:53 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 7b75d6fd65 Quick fix for extensionless get_absolute_url(). XXX Fixme: needs bigger refactoring.
- Legacy-Id: 4476
2012-06-20 10:27:32 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 2eec257dc8 Add default=None to ballot in BallotPositionDocEvent so it's backwards compatible
- Legacy-Id: 4342
2012-04-30 18:18:47 +00:00
Ole Laursen b9a90f35e1 Clean up and polish charter branch code, fix some subtle bugs with
revision and approved charter lookup.
 - Legacy-Id: 4290
2012-04-19 15:15:43 +00:00
Adam Roach c113bd0588 Migrated HTML agenda to new data model. This has several improvements, as well, such as clearer marking of BOFs.
- Legacy-Id: 4265
2012-04-05 19:30:36 +00:00
Ole Laursen e4a9d8c7aa Finish ballot support for charters (apart from non-generic ballot
deferral), remove a bunch of now obsolete charter code.
 - Legacy-Id: 4255
2012-04-04 18:09:03 +00:00
Ole Laursen a9817e555a Some fixes to generic doc ballot view, fix edit position and send
ballot comment email views, moving them to
/doc/foo-bar/ballot/[id]/position/ and ../emailposition/.
 - Legacy-Id: 4249
2012-04-03 14:53:38 +00:00
Ole Laursen 4fc98cfdd3 Add help_text for StateType.label
- Legacy-Id: 4247
2012-04-02 17:11:25 +00:00
Ole Laursen ed15193bcf Introduce more generic ballot models, start porting doc ballot page to the
new database schema.
 - Legacy-Id: 4240
2012-03-30 17:16:50 +00:00
Ole Laursen df4b36c561 Implement a latest_event for history entries, make canonical name for
charters depend on group acronym and save canonical name in history
entries,
 - Legacy-Id: 4166
2012-03-22 18:19:12 +00:00
Henrik Levkowetz 0dd2563b22 Tweak the admin interface for Documents a bit.
- Legacy-Id: 4153
2012-03-21 14:20:29 +00:00
Ole Laursen c7d9839b1c Fix get_absolute_url to make it point to /doc/ page for charters
- Legacy-Id: 4094
2012-03-15 17:57:12 +00:00
Ole Laursen 65c16409f6 Add labels for std_level abbreviations
- Legacy-Id: 3945
2012-02-22 12:59:44 +00:00
Ole Laursen feb4f93dc6 Import new_revision events for the non-draft document types, this will
allow a more generic document history page; this will be important for
charters, less important for other types, but might as well get it
right from the beginning
 - Legacy-Id: 3940
2012-02-21 16:50:17 +00:00
Ole Laursen 6a128b0250 Merge in patch from Ryan Cross for supporting meeting materials type
in get_absolute_url, currently pointing to the actual item instead of
the corresponding /doc/ page
 - Legacy-Id: 3935
2012-02-17 17:43:50 +00:00
Ole Laursen 6b75ce8e6b Fix problem with URL reversal when models are used in another project
- Legacy-Id: 3892
2012-02-02 14:58:36 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Renamed from redesign/doc/models.py (Browse further)