Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email. Fixes#2891.
- Legacy-Id: 17799
Note: SVN reference [17794] has been migrated to Git commit 96bc71f51f150cec7043aca60d0156d35847019b
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
internal things
* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.
* Turned sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17153
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17128
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy. Also see issues #2721 and #2656.
- Legacy-Id: 17121
Fix#2074, fix#2358 - Add history for assignments, requests and unavailability.
- Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
Moved hard coded defaults for max items to show and days to show to
the settings.py.
- Legacy-Id: 17099
Note: SVN reference [17083] has been migrated to Git commit 90428d6d5f
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed
Fixes issue #2612.
- Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
- Legacy-Id: 17048
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
- Legacy-Id: 17034
Fix#2088 - Sort unassigned review requests by doc name by default.
- Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
Fix#2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
- Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
- Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
- Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
Fix#2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
- Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".
Commit ready for merge.
- Legacy-Id: 16904
This also makes a small text clarification, which was also the initial
reason for the test failure.
Commit ready for merge.
- Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Fix#2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
- Legacy-Id: 16897
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Note: SVN reference [16850] has been migrated to Git commit e145832808
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
Commit ready for merge.
- Legacy-Id: 16895
Fix#2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
- Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.
Commit ready for merge.
- Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
