Commit graph

326 commits

Author SHA1 Message Date
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
2016-09-05 12:33:54 +00:00
Henrik Levkowetz 2c484d5abb Added another migration dependency, to avoid looking for removed tables.
- Legacy-Id: 11880
2016-08-26 10:30:21 +00:00
Henrik Levkowetz 2b226ae7b7 Improved test coverage somewhat by making more of the group tests apply to both the /group/acronym and /wg/acronym (or equivalent) url forms.
- Legacy-Id: 11857
2016-08-24 16:50:54 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run.
- Legacy-Id: 11854
2016-08-24 15:37:25 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 16e28481f6 Add page for emailing open review assignments summary to the review team list
- Legacy-Id: 11846
2016-08-23 14:06:47 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
2016-08-23 12:12:24 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen 507baade01 Add refresh button to manage reviews page, make save detect changes in
the requests and pop the page back up for confirmation if so
 - Legacy-Id: 11827
2016-08-19 16:40:09 +00:00
Ole Laursen 5eba7bf38e Fix a bug
- Legacy-Id: 11807
2016-08-17 16:12:17 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Robert Sparks 4631df61ef improve some test coverage. Commit ready for merge.
- Legacy-Id: 11767
2016-08-09 18:31:05 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge.
- Legacy-Id: 11766
2016-08-09 15:42:40 +00:00
Henrik Levkowetz 34370c6e16 Merged in [11656] from rjsparks@nostrum.com:
Enhanced factories to simplify test writing.
 - Legacy-Id: 11682
Note: SVN reference [11656] has been migrated to Git commit 030ea1c939
2016-07-16 14:15:41 +00:00
Henrik Levkowetz c7cecf66e9 Added a test case for group home.
- Legacy-Id: 11652
2016-07-13 19:20:13 +00:00
Henrik Levkowetz 8ca48aac42 Make group acronym regex patterns consistent.
There were multiple different regex patterns in different urlpattern
declarations, with some of them permitting characters which should not
occur in group acronym.  Changed them to consistently use [-a-z0-9]+ .
 - Legacy-Id: 11651
2016-07-13 19:19:15 +00:00
Henrik Levkowetz 211943148d Make the group factory produce groups with valid acronyms
- Legacy-Id: 11650
2016-07-13 18:48:53 +00:00
Ole Laursen f7eeb1f0f1 Add missing constraint on team in manage review request page
- Legacy-Id: 11636
2016-07-12 16:12:04 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Henrik Levkowetz 8b6d8c9f44 Replaced the hardcoded 'Area Director' approval role with a group-dependent list of approval roles. Fixes issue #1980.
- Legacy-Id: 11575
2016-07-09 16:59:50 +00:00
Henrik Levkowetz 85fb050b2e Brought back, by popular demand, a tab with the link to a group's tools pages (which was removed in release 6.25.0).
- Legacy-Id: 11559
2016-07-08 11:17:58 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
2016-07-07 12:17:55 +00:00
Ole Laursen d54459b28a Add tests of suggested review requests, make suggestions take more
things into account
 - Legacy-Id: 11528
2016-07-06 13:14:11 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Henrik Levkowetz a36cf95572 Refactored the code to skip coverage testing a bit, and added skipping of template and url coverage.
- Legacy-Id: 11472
2016-06-24 15:39:59 +00:00
Henrik Levkowetz 6fa181763b Changed the code test coverage checking to never register coverage counts for tests that are sometimes skipped. Removed now unwanted skip settings from the releasetest settings.
- Legacy-Id: 11453
2016-06-21 20:39:28 +00:00
Henrik Levkowetz 54fc7adb9a Fixed a typo.
- Legacy-Id: 11443
2016-06-21 18:59:44 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Henrik Levkowetz e110419916 Merged in ^/personal/henrik/6.22.1-acctdeps which provides import of addresses subscribed to IETF mailing lists, and additional datatracker account creation requirements. Also a table and form for manual whitelisting of account logins, in order to handle cases which fall outside the default requirements. Fixed some tests.
- Legacy-Id: 11389
2016-06-15 22:10:50 +00:00
Henrik Levkowetz 7c033d3daa Only check state.slug in GroupForm.clean() if state is set.
- Legacy-Id: 11388
2016-06-15 20:02:51 +00:00
Henrik Levkowetz d251692b96 Added a clean() method to the Group creation form which requires a BoF to have a parent group. Fixes issue #1970.
- Legacy-Id: 11387
2016-06-15 19:46:47 +00:00
Henrik Levkowetz 2ba1bde0ba Reverted a bad to group/urls_info.py
- Legacy-Id: 11355
2016-06-14 04:56:50 +00:00
Henrik Levkowetz 9eacdbf2c6 Merged in ^/personal/henrik/6.21.1-biophoto@11313, with work from rjsparks@nostrum.com and henrik@levkowetz.com which provides support for profile biography and photo.
- Legacy-Id: 11314
2016-06-10 19:36:47 +00:00
Henrik Levkowetz 4cb87b5b09 An additional photo test, and a test function rename.
- Legacy-Id: 11313
2016-06-10 18:36:28 +00:00
Henrik Levkowetz ebe45e5312 Added tests for various photo pages.
- Legacy-Id: 11305
2016-06-09 21:59:17 +00:00
Henrik Levkowetz 3e54101e06 Renamed group.views.all_photos() back to chair_photos(). Added differentiated ordering by role to group photo pages. Moved the external links (dependency graph and tools pages) off of the tabs, to the charter page.
- Legacy-Id: 11304
2016-06-09 21:58:35 +00:00
Henrik Levkowetz 7c53eb1843 Renamed group.views.all_photos() back to chair_photos(). Added differentiated ordering by role to group photo pages. Moved the external links (dependency graph and tools pages) off of the tabs, to the charter page.
- Legacy-Id: 11303
2016-06-09 21:58:01 +00:00
Henrik Levkowetz b0cd3a0066 Fixed a problem with accessing a group's workflow customisation page from /group/{{acronym}} instead of /wg/{{acronym}}/.
- Legacy-Id: 11290
2016-06-07 18:13:55 +00:00
Henrik Levkowetz 7edecaee27 Added photo page support for individual groups, and tweaked some names. This provides a photo page for the IAB, but also as a benefit photo pages for other groups.
- Legacy-Id: 11287
2016-06-06 16:33:24 +00:00
Henrik Levkowetz c5e0814e11 Made the photo url and view function names more generic. Shortened a tab name.
- Legacy-Id: 11272
2016-06-05 09:49:24 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257
- Legacy-Id: 11259
2016-06-01 16:37:01 +00:00
Henrik Levkowetz 92214726fd Renamed some files under ietf/group/ which contained views but didn't have 'views' in the name.
- Legacy-Id: 11190
2016-05-13 15:59:10 +00:00