Commit graph

911 commits

Author SHA1 Message Date
Lars Eggert 57f23f5198
chore: feat/dark-mode <- main (#6103)
* chore: Remove unused "rendertest" stuff (#6015)

* fix: restore ability to create status change documents (#5963)

* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment

* fix: Provide human-friendly status in submission status API response (#6011)

Co-authored-by: nectostr <bastinda96@gmail.com>

* fix: Make name/email lookups case-insensitive (#5972) (#6007)

* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains

* fix: Clarify no-action-needed (#5918) (#6020)

When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918

* fix: Fix menu hover issue (#6019)

* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue

* fix: Server error from api_get_session_materials() (#6025)

Fixes #5877

* fix: Clarify Questionnaire label (#4688) (#6017)

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688

* chore: Merge from @martinthomson's rfc-txt-html (#6023)

* fix:no history entry when changing RFC Editor note for doc (#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>

* fix: avoid deprecation warning on view_list() for objs without CommunityList

Fixes #5942

* fix: return 404 for non-existing revisions (#6014)

* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex

* fix: provide date for revisions in bibtex output (#6029)

* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events

* fix: review refactoring issue

fixes #5447

* fix:  Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* feat: IAB statements (#5940)

* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic

* feat: include submitter in email about submitted slides (#6033)

* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change

* chore(dev): update .vscode/settings.json with new taskExplorer settings

* fix: Add editorial stream to proceedings (#6027)

* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings

* fix: Add editorial stream to meeting materials (#6047)

Fixes #6042

* fix: Shows requested reviews for doc fixes (#6022)

* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.

* feat: allow openId to choose an unactive email if there are none active (#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive

* fix: Make review table more responsive (#6053)

* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits

* ci: add --validate-html-harder to tests

* ci: add  --validate-html-harder to build.yml workflow

* fix: Set colspan to actual number of columns (#6069)

* fix: Clean up view_feedback_pending (#6070)

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* docs: Update LICENSE year

* fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)

* fix: Correctly order "last call requested" column in the IESG dashboard (#6079)

* ci: update dev sandbox init script to start memcached

* feat: Reclassify nomcom feedback (#6002)

* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members

* fix: Print decoded key and fully clean up test nomcom (#6094)

* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing

* test: Use correct time zone for test_statement_doc_view (#6064)

* chore(deps): update all npm dependencies for playwright (#6061)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/diff (#6062)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/coverage-action (#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: Hash cache key for default memcached cache (#6089)

* feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075)

* fix(doc): Unify help texts for document states (#6060)

* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* ci: fix sandbox start.sh memcached user

* fix: refactor how settings handles cache definitions (#6099)

* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression

* fix: Cast cache key to str before calling encode (#6100)

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com>
Co-authored-by: nectostr <bastinda96@gmail.com>
Co-authored-by: Rich Salz <rsalz@akamai.com>
Co-authored-by: PriyankaN <priyanka@amsl.com>
Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
Co-authored-by: Ali <alireza83@gmail.com>
Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com>
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Kesara Rathnayake <kesara@fq.nz>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
2023-08-10 09:49:15 -05:00
Lars Eggert 1d22e39a52
fix: Use icons in addition to colors for review-related badges (#6012)
* fix: Use icons in addition to colors for review-related badges

* Remove comment

* Remove debug print
2023-07-23 10:09:16 -07:00
Lars Eggert 97c7dd4d67
fix: Use correct logo in dark mode menubar (#6016)
Also use the "nor" variant elsewhere the logo is small.
2023-07-22 12:56:06 -07:00
Lars Eggert 3a47871f5e
fix: More dark mode fixes (#6001)
* fix: More small dark mode fixes

* "badge rounded-pill bg-" -> "badge rounded-pill text-bg-"

This sets the text color correctly for more readable badges.

* Same for cards

* Fix tests
2023-07-20 13:48:52 -05:00
Robert Sparks a20d1f4d9b
Merge remote-tracking branch 'ietf-tools/main' into feat/dark-mode 2023-07-19 12:18:07 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858)
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
2023-07-18 12:22:28 -05:00
Lars Eggert bd9d3285b5
fix: #timeline -> #doc-timeline (#5985)
Fixes #5923
2023-07-18 09:01:43 -05:00
Paul Selkirk bae204862d
feat: Add bibxml button to document info page (#5921)
* feat: Add bibxml button to document info page (#5908)

* fix: No bibxml for RFCs
2023-07-07 08:23:15 -05:00
Robert Sparks 772b6e8c3c
Merge branch 'main' into feat/dark-mode 2023-06-13 13:37:04 -05:00
Lars Eggert 818f0a9938
fix: Add definition of DOWNREF from RFC3967 (#5789)
Fixes #2788, #5759
2023-06-08 15:14:14 -05:00
Robert Sparks 0864b73aab
fix: use slowpages to cache doc/active (#5781) 2023-06-07 15:35:17 -05:00
Robert Sparks 3fc77633a7
fix: protect htmlize and opengraph templates from fake dochistory objects (#5764) 2023-06-05 20:19:25 -05:00
Lars Eggert e6f47a0474
Fix title 2023-06-02 11:43:54 +03:00
Lars Eggert 27f9e6aadb
Address review comments 2023-06-02 11:43:53 +03:00
Lars Eggert 8caf3a70f8
Fix some badges 2023-06-02 11:43:53 +03:00
Lars Eggert f850061dff
Fix switching in HTMLized view 2023-06-02 11:43:53 +03:00
Lars Eggert e6f351b3c9
Fix more colors 2023-06-02 11:43:53 +03:00
Lars Eggert 54c7951f7b
Fix some colors 2023-06-02 11:43:53 +03:00
Jennifer Richards 1922a6066e
Merge pull request #5700 from ietf-tools/main
chore: main -> django4
2023-05-31 10:59:09 -03:00
Nicolas Giard 0a11892414
chore: use variable for static.ietf.org references (#5692) 2023-05-25 17:23:18 -05:00
Jennifer Richards cdec6cc0aa
Merge pull request #5655 from ietf-tools/main
chore: Merge main into feat/django4
2023-05-18 15:15:42 -03:00
Robert Sparks f9322391dd
fix: change trac.ietf.org links to what they redirect to now (#5651) 2023-05-18 08:31:54 -05:00
Nicolas Giard 12f1cb200a
feat: set fonts for htmlized doc template (#5636) 2023-05-16 14:56:36 -05:00
Jennifer Richards 00f3f01e7e
fix: {% endif %}, not {% end %} 2023-05-12 18:52:35 -03:00
Jennifer Richards 32ed1b7c4a
refactor: Replace deprecated {% ifequal %} with {% if %} 2023-05-12 18:33:15 -03:00
Ian Williams a778377bb8
fix(doc): Replace iconography for position's email status with text label (#5421)
* fix(doc): Use text badges for email status

BI's envelope icons with status icons are difficult to read.
Use text labels instead (keeping the same tooltip).

Fixes #3855.

* test(doc): Fix failing ballot message tests

Some ballot message changes have been modified to correctly identify
what type of document this ballot is for.

Works on #3855

* test(doc): Remove debugging statement

Accidental inclusion of debug statement.

Works on #3855
2023-03-27 13:58:51 +09:00
Jim Fenton d25eca930d
fix(doc): remove revision from shepherd writeup title (#5413)
Fixes #4200
2023-03-25 16:15:34 +09:00
Lars Eggert 8f8a3489ea
fix: Add reviewer name to review assignment summary (#5363)
* fix: Add reviewer name to review assignment summary

Fixes #5360

* Address code review

* Fix test harder
2023-03-20 10:23:45 -05:00
Lars Eggert 57030e4303
fix: Pre-sort WG doc table on date (#5361)
Fixes #5341.

Also remove some js code that was only used on the old agenda
page while I'm here.
2023-03-17 12:07:25 -05:00
Lars Eggert 1d87686a2b
fix: Add missing closing brace in meta tag and updated/obsoleted-by info (#5265)
* fix: Add missing closing brace in meta tag

Fixes #3379

* Also fix "obsoleted by" meta information

* name -> canonical_name
2023-03-03 10:49:15 -06:00
Jennifer Richards 8041cd5c40
fix: Avoid unwanted whitespace when action_holder_badge is empty (#5266) 2023-03-02 15:17:39 -06:00
Lars Eggert cf94b896c8
feat: Add reminder that AD changes for approved documents are unusual (#5231) 2023-02-28 10:21:39 -06:00
Lars Eggert caf80efd84
feat: Prefill the abstract, shepherd and AD info into a ballot writeup (#5218)
* feat: Prefill the abstract, shepherd and AD info into a ballot writeup

* Suggestions from @rjsparks

* Remove instructions to add IANA Expert template.

* Make "notes" fields for various bodies conditioned on the doc stream
2023-02-27 12:19:39 -06:00
Lars Eggert 02f8bf20ef
feat: Add a "report errata button" (#5193)
And also rename "report a bug" to "report a datatracker bug", in the hopes of
reducing GitHub tickets that are not datatracker-related.
2023-02-24 09:13:00 -06:00
Robert Sparks 9ea8523e85
feat: add target to bibxml-ids (#5148) 2023-02-15 11:37:56 -06:00
Lars Eggert 35f1d21302
fix: Fix deferring ballots from the "edit position" view (#5106)
Fixes #4903
2023-02-11 10:11:05 -06:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Lars Eggert 6a6a3db3b9
fix: Don't try to further linkify rfc2html output (#5112)
* fix: Don't try to further linkify rfc2html output

Fixes #5111

* Fix test
2023-02-10 14:33:54 -06:00
Lars Eggert 1afce6669d
fix: Fix HTML validation issues (#5081) 2023-02-06 09:40:38 -06:00
Lars Eggert 7ddc09ef25
fix: Break long words in cards to prevent layout jumps (#5064) 2023-02-01 10:37:20 -06:00
Robert Sparks afac1f8f19
feat: enable editorial stream adoption and balloting (#5011)
* feat: enable editorial stream adoption and balloting

* fix: bring tests into line with refactor

* feat: force intended_std_level to Informational when adopting into a non-ietf stream.

* fix: improve blocking position labels and email content

* fix: simplify pointer to group on doc main page for rswg docs

* fix: recover from merge typos

* fix: correct defer and clear ballot behavior

* fix: improve publication request access logic

* fix: clean up broken editorial state

* fix: adjust test to match migrations
2023-01-31 13:50:51 -06:00
Lars Eggert 61f7984d5c
fix: Handle unset cookies correctly (#5023)
Fixes #5015
2023-01-24 09:02:21 -06:00
Robert Sparks 43c7e92d9d
feat: remove the format element from the bibxml-id source of truth (#5017) 2023-01-23 18:03:19 -06:00
Lars Eggert 570bd141ae
Limit the width of the document selectors to the width of the parent. (#4968)
* Limit the width of the document selectors to the width of the parent.

It's unfortunately not responsive (select2 limitation), but better
than being too long.

* Force "text-overflow: ellipsis" to hide the beginning of a doc name
2023-01-18 10:40:32 -06:00
Lars Eggert e209cae279
Add a datatracker button to the htmlized side pane (#4970)
Fixes #4944
2023-01-18 10:39:43 -06:00
Lars Eggert faf68bc290
fix: Change versions in htmlized sidebar version picker based on shown doc rev (#4977)
Also fix an issue with the revisions list only linking to the latest
version in some cases.

Fixes #4972
2023-01-18 10:38:41 -06:00
Lars Eggert d7a7033a42
fix: Let charter revisions be variable length in the version paginator (#4989)
* fix: Let charter revisions be variable length in the version paginator

Fixes #4988

* Address review comments. Also make major charter revisions bold for readability.
2023-01-18 10:36:21 -06:00
Lars Eggert 1f87ff164f
fix: Add bug report button to htmlized view (#4999)
Fixes #4998
2023-01-18 10:34:18 -06:00
Robert Sparks 0cc907f957
fix: restore display of additional resources (#4956) 2023-01-10 10:19:43 -06:00
Lars Eggert 4b1c10f6ab
feat: Add preference to make citation links go straight to cited docs (#4886)
* feat: Add preference to make citation links go straight to cited documents

* Use localStorage
2022-12-19 13:30:08 -06:00