Commit graph

27 commits

Author SHA1 Message Date
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name.
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code.
- Legacy-Id: 14128
2017-09-17 15:12:18 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Ole Laursen 1970cbab16 Modify importer to take deadline from the document log if at all
possible, also add an extra assignment fallback using deadline =
assignment time + 30 days for early reviews that never had a deadline
(a few left in secdir)
 - Legacy-Id: 12381
2016-11-17 17:16:00 +00:00
Ole Laursen 4826de8c5e Decode timestamps from the previous review tool as being in UTC
- Legacy-Id: 12349
2016-11-14 14:11:36 +00:00
Ole Laursen 010c20801e When importing next reviewer, set it to the reviewer following the one
that the old tool was pointing to, as it was pointing to the
last one having completed a review (despite being named next)
 - Legacy-Id: 12255
2016-11-03 20:13:00 +00:00
Ole Laursen b16a829ec7 Modify review import to read result data for genart from an extra dataset
- Legacy-Id: 12248
2016-11-03 12:49:50 +00:00
Ole Laursen 54bc9ff596 Modify importer to close review requests for done documents as status
"Unknown" instead of auto-closing those where the IESG state is
further in the process on - this seems to leave more requests in
genart open, but hopefully the extra data for genart will fix this
problem shortly.
 - Legacy-Id: 12247
2016-11-02 16:58:03 +00:00
Ole Laursen 67e6423cb4 Modify importer to pick deadline from documents when there's an exact
match, otherwise prefer what's stored with the review request (fixes
a bunch of cases with multiple reviews of the same draft)
 - Legacy-Id: 12246
2016-11-02 12:37:47 +00:00
Ole Laursen 70dfb760cb Don't import reviewer roles for completely unavailable reviewers who were marked as away until after 2020
- Legacy-Id: 12244
2016-11-01 20:57:34 +00:00
Ole Laursen 95bbabf384 Ignore duplicate review requests in importer - genart has had quite a
few of these
 - Legacy-Id: 12171
2016-10-18 13:50:10 +00:00
Ole Laursen d95be38ee7 Implement a reviewer blacklist in the importer and add "alice" in
genart to it
 - Legacy-Id: 12170
2016-10-18 11:51:33 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
2016-10-17 19:37:56 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document
- Legacy-Id: 12147
2016-10-14 09:42:34 +00:00
Ole Laursen 336e2bbc5e In case the review data contains a proper name for a person we already
know, use that - this prevents problems with email addresses being
embedded in review document names.
 - Legacy-Id: 12126
2016-10-13 15:53:14 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Ole Laursen 6c8df95ee6 Close imported review requests that are past IESG approval
automatically as overtaken by events
 - Legacy-Id: 11637
2016-07-12 16:20:42 +00:00
Ole Laursen c3c1911b47 Some fixes for review importer: interpretation of autopolicy and skip
all review requests without a timestamp
 - Legacy-Id: 11629
2016-07-12 14:29:19 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00