Commit graph

849 commits

Author SHA1 Message Date
Henrik Levkowetz d3b4d8c18b Fixed a bug for /meeting/*/agenda.json where multiple entries for a room name could occur, even if only one of them were referenced by sessions.
- Legacy-Id: 13424
2017-05-25 14:13:00 +00:00
Ryan Cross 264f6f36e2 Allow chairs to upload bluesheets for interim meetings. Fixes #2165. Commit ready for merge.
- Legacy-Id: 13412
2017-05-23 19:56:35 +00:00
Henrik Levkowetz a559557284 Added more information about session presentations to the agenda.json output, on request from pusateri@bangj.com.
- Legacy-Id: 13397
2017-05-19 19:55:38 +00:00
Henrik Levkowetz 04e76c9fc9 Added raw_id_fields on DocumentAuthorAdmin to speed up form loading, and added SessionPresentationAdmin to the meeting admin.py
- Legacy-Id: 13395
2017-05-19 14:09:49 +00:00
Henrik Levkowetz a1b48cbc45 Merged in [13337] from rcross@amsl.com:
When editing interim meeting request show duration as HH:MM instead of HH:MM:SS.  Fixes #2226.
 - Legacy-Id: 13362
Note: SVN reference [13337] has been migrated to Git commit 066de1e612
2017-05-15 15:54:46 +00:00
Ryan Cross 066de1e612 When editing interim meeting request show duration as HH:MM instead of HH:MM:SS. Fixes #2226. Commit ready for merge.
- Legacy-Id: 13337
2017-05-12 21:40:20 +00:00
Henrik Levkowetz db40ddc231 Merged in [13324] from rcross@amsl.com:
Disallow multi-day interim meetings with non-consecutive dates.  Fixes #2193.
 - Legacy-Id: 13325
Note: SVN reference [13324] has been migrated to Git commit 75a7beb596
2017-05-11 20:15:49 +00:00
Ryan Cross 75a7beb596 Disallow multi-day interim meetings with non-consecutive dates. Fixes #2193. Commit ready for merge.
- Legacy-Id: 13324
2017-05-11 19:30:26 +00:00
Henrik Levkowetz c0c128d491 Merged in [13308] from rcross@amsl.com:
Add ability for secretariat to skip announcement of regular interim meetings.  Fixes #2210.
 - Legacy-Id: 13321
Note: SVN reference [13308] has been migrated to Git commit 53615b0970
2017-05-11 12:46:44 +00:00
Henrik Levkowetz 73df0baefb Merged in [13303] from rcross@amsl.com:
Fixes #2211.  Session admin edit fails if no resources selected.
 - Legacy-Id: 13319
Note: SVN reference [13303] has been migrated to Git commit 9ba73e70a2
2017-05-11 12:03:19 +00:00
Henrik Levkowetz 3ee897d63b Merged in [13291] from rcross@amsl.com:
Change From address of session request notifications from session_request_developers@ietf.org to session-request@ietf.org.  Fix requester information in session request cancellation email.  Fixes #1621.
 - Legacy-Id: 13314
Note: SVN reference [13291] has been migrated to Git commit 9a9531d9f6
2017-05-11 10:23:20 +00:00
Ryan Cross 53615b0970 Add ability for secretariat to skip announcement of regular interim meetings. Fixes #2210. Commit ready for merge.
- Legacy-Id: 13308
2017-05-10 21:06:15 +00:00
Ryan Cross 9ba73e70a2 Fixes #2211. Session admin edit fails if no resources selected. Commit ready for merge.
- Legacy-Id: 13303
2017-05-10 19:04:11 +00:00
Ryan Cross 9a9531d9f6 Change From address of session request notifications from session_request_developers@ietf.org to session-request@ietf.org. Fix requester information in session request cancellation email. Fixes #1621. Commit ready for merge.
- Legacy-Id: 13291
2017-05-09 21:33:14 +00:00
Henrik Levkowetz a48b785f7e Merged in [13246] from rjsparks@nostrum.com:
Distinguish group that have session requests from those that do not on the materials/editable-groups page. Fixes #2284.
 - Legacy-Id: 13248
Note: SVN reference [13246] has been migrated to Git commit 2e54a5c443
2017-04-19 21:29:32 +00:00
Robert Sparks 2e54a5c443 Distinguish group that have session requests from those that do not on the materials/editable-groups page. Fixes #2284. Commit ready for merge.
- Legacy-Id: 13246
2017-04-19 18:04:48 +00:00
Henrik Levkowetz d3a20a8694 Added filtering of room resources in the session request form based on the 'used' flag of the room resource name. Tweaked admin to show 'used' for ResourceAssociations. Added Flipchart and U-shape-layout resources through a data migration, and added/modified resource icons.
- Legacy-Id: 13225
2017-04-15 19:13:06 +00:00
Henrik Levkowetz 6dc97b232d A migration to match the latest pytz time zone list.
- Legacy-Id: 13201
2017-04-12 18:20:23 +00:00
Henrik Levkowetz 457f0ee4e3 Fixed a bug in the json_agenda data, calculating room midpoints correctly.
- Legacy-Id: 13180
2017-03-31 18:54:08 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz 69c9d25022 Merged in [13125] from rcross@amsl.com:
Add REST API endpoint to notify Datatracker that new recording files are available.
 - Legacy-Id: 13158
Note: SVN reference [13125] has been migrated to Git commit a50b09b152
2017-03-27 21:51:55 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Henrik Levkowetz 28969462ff Merged in [13113] from rcross@amsl.com:
Add Country column to meeting/NN/proceedings/attendees.  Fixes #2228.
 - Legacy-Id: 13148
Note: SVN reference [13113] has been migrated to Git commit 990493f1c4
2017-03-27 16:20:40 +00:00
Ryan Cross a50b09b152 Add REST API endpoint to notify Datatracker that new recording files are available. Commit ready for merge.
- Legacy-Id: 13125
2017-03-25 21:52:11 +00:00
Ryan Cross 990493f1c4 Add Country column to meeting/NN/proceedings/attendees. Fixes #2228. Commit ready for merge.
- Legacy-Id: 13113
2017-03-25 19:20:34 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Ryan Cross eb10f54bd6 Fixes interim meeting edit form returning 500 when duration field is empty. Fixes #2206. Commit ready for merge.
- Legacy-Id: 13022
2017-03-17 18:49:33 +00:00
Ryan Cross 3cd5bea78b Fix issue where editing interim meeting duration does not update underlying timeslot duration. Fixes #2203. Commit ready for merge.
- Legacy-Id: 13021
2017-03-17 18:28:07 +00:00
Henrik Levkowetz 0af1223b3c Merged in [12990] and [12991] from rcross@amsl.com:
Refactor session audio file import.  Add informative email.  Fixes #2164.
 - Legacy-Id: 12998
Note: SVN reference [12990] has been migrated to Git commit 084f8a7495

Note: SVN reference [12991] has been migrated to Git commit 6a5f180fb0
2017-03-12 12:15:37 +00:00
Ryan Cross 6a5f180fb0 Rename and update shared audio file migration. Commit ready for merge
- Legacy-Id: 12991
2017-03-10 23:12:49 +00:00
Ryan Cross 084f8a7495 Refactor session audio file import. Add informative email. Fixes #2164. Commit ready for merge
- Legacy-Id: 12990
2017-03-10 23:04:06 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 387068f67d Updated unreachable markings.
- Legacy-Id: 12967
2017-03-04 05:38:23 +00:00
Henrik Levkowetz f2c1ca1565 Added unreachable markings.
- Legacy-Id: 12966
2017-03-04 05:31:18 +00:00
Henrik Levkowetz 3c6f00869f Dead code removal: meeting models and test_utils.
- Legacy-Id: 12965
2017-03-04 05:19:39 +00:00
Henrik Levkowetz 73a2d86f12 Added an unreachable mark
- Legacy-Id: 12964
2017-03-04 05:19:01 +00:00
Henrik Levkowetz 0745fac189 Undo commit
- Legacy-Id: 12963
2017-03-04 05:17:41 +00:00
Henrik Levkowetz 49ba774ae3 Updated unreachable() marking.
- Legacy-Id: 12962
2017-03-04 05:14:51 +00:00
Henrik Levkowetz ea70381f29 Merged in [12950] from rcross@amsl.com:
Fixes #2219.  Area Group chairs are denied material management access.
 - Legacy-Id: 12951
Note: SVN reference [12950] has been migrated to Git commit c6d1a59aa4
2017-03-02 21:21:07 +00:00
Ryan Cross c6d1a59aa4 Fixes #2219. Area Group chairs are denied material management access. Commit ready for merge.
- Legacy-Id: 12950
2017-03-02 20:14:39 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Henrik Levkowetz 171a7be029 Removed an incorrect Unreachable Code mark.
- Legacy-Id: 12928
2017-02-28 05:08:03 +00:00
Henrik Levkowetz 10cac86165 Preparation for dead code removal: Marked probable dead code with affirm() statements which will signal if we ever reach that point in the code. If no signals seen, the marked functions/methods will be removed after one release cycle.
- Legacy-Id: 12926
2017-02-27 16:45:21 +00:00
Henrik Levkowetz ac9aa326ef Dead code removal: placement.py and related.
- Legacy-Id: 12924
2017-02-27 13:22:04 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz a94c33fd6e Added an alert on the login form, to be shown if a user's password has been cleared. Adjusted url reverse strings to match the changed view function.
- Legacy-Id: 12918
2017-02-25 15:50:47 +00:00
Henrik Levkowetz 350ea9efcf Removed all use of timedeltafield by converting old migrations to reference compatible types.
- Legacy-Id: 12825
2017-02-12 17:10:06 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 30b2abeaf1 New migration for django 1.9 country- and time_zone choices.
- Legacy-Id: 12769
2017-02-01 17:01:50 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Ole Laursen e381dac958 Fix matching pattern in test to be more generic
- Legacy-Id: 12729
2017-01-25 11:29:45 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes.
- Legacy-Id: 12714
2017-01-23 18:35:58 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Henrik Levkowetz 7d25922e9b Enabled correct time sorting and reporting for interim meetings on /group/{{acronym}}/meetings/, and tweaked the date format. Fixes issue #2145.
- Legacy-Id: 12669
2017-01-18 19:24:14 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach.
- Legacy-Id: 12645
2017-01-11 18:42:38 +00:00
Henrik Levkowetz 5286dfdbc8 Made sure that sessionpresentation objects are saved before adding them to a m2m set.
- Legacy-Id: 12636
2017-01-09 21:23:14 +00:00
Henrik Levkowetz 8e9858379b Fixed some pyflakes and form initialization issues with the upgrade to DurationField.
- Legacy-Id: 12599
2016-12-21 17:03:39 +00:00
Henrik Levkowetz 67b2fc1107 Extended the form fields used for duration to accept additional formats, including formats the secretariat are currently using, in order to avoid trouble with the TimedeltaField --> DurationField transition.
- Legacy-Id: 12598
2016-12-21 15:26:32 +00:00
Henrik Levkowetz 3d6b370c59 Upgraded custom TimedeltaFields to use the builtin DurationField from Django 1.8, and adjusted forms and initialization values accordingly.
- Legacy-Id: 12597
2016-12-20 22:56:34 +00:00
Henrik Levkowetz 481a96c935 Changed the handling of skip tests and messages in order to show which tests will be skipped, and why, at the start of a test run.
- Legacy-Id: 12568
2016-12-17 21:49:53 +00:00
Henrik Levkowetz 17a7f59cd6 Deprecation fixes: Use request.GET or request.POST as appropriate, instead of request.REQUEST.
- Legacy-Id: 12533
2016-12-15 13:21:33 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 53f343017e Use models.DurationField from django directly now that it's available, instead of the inlined copy of the 1.8 DurationField code.
- Legacy-Id: 12477
2016-12-07 19:40:18 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz bc683ccc67 Fixed a type issue found by the new django 1.8 query type checks.
- Legacy-Id: 12452
2016-12-05 14:13:00 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz cfd898b767 Updated the proceedings_templates fixture to provide the base proceedings template needed by tests, instead of a copy already instantiated for a specific meeting.
- Legacy-Id: 12445
2016-12-05 12:55:20 +00:00
Henrik Levkowetz 5e48d7ec72 Fixed another year's end related test bug.
- Legacy-Id: 12443
2016-12-04 15:46:27 +00:00
Henrik Levkowetz c06e7af08c Fixed an error in the test_interim_request_series() test.
- Legacy-Id: 12431
2016-12-01 13:20:59 +00:00
Henrik Levkowetz 2a9a7afd0b Added a link to the meetecho session recording (not the youtube conversion) on the IETF agenda page.
- Legacy-Id: 12430
2016-11-30 21:02:33 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz d589718c37 Fixed some pyflakes issues.
- Legacy-Id: 12405
2016-11-28 18:13:43 +00:00
Henrik Levkowetz 1deadeadc0 Added a migration to fix the mext meeting materials names and external links.
- Legacy-Id: 12404
2016-11-28 18:06:38 +00:00
Henrik Levkowetz 05379e2e2d Undid unintended change.
- Legacy-Id: 12399
2016-11-26 20:04:01 +00:00
Henrik Levkowetz a0ed8c7694 Made session minutes available with the same kind of url as session minutes: /meeting//minutes/. (Both of these need to be refined to handle multiple agendas and minutes, for groups having multiple sessions in a meeting.)
- Legacy-Id: 12398
2016-11-25 16:44:31 +00:00
Henrik Levkowetz 09259ae556 Merged in [12393] from rjsparks@nostrum.com:
Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058.  Commit should be patched into production.
 - Legacy-Id: 12395
Note: SVN reference [12393] has been migrated to Git commit 2b0ec6df16
2016-11-23 18:31:10 +00:00
Robert Sparks 2b0ec6df16 Fixed bug where slides from multiple sessions for a group were not all showing. Improved handling of multiple minutes and agendas for groups. Fixes #2058. Commit ready for merge. Commit should be patched into production.
- Legacy-Id: 12393
2016-11-23 17:09:53 +00:00
Henrik Levkowetz 89294a558a Order materials on the agenda session materials popup according to the sessionpresentation order. Fixes issue #2049
- Legacy-Id: 12380
2016-11-17 08:45:49 +00:00
Henrik Levkowetz 216ed80529 Merged in code from rcross@amsl.com to bring back the automatic conversion of slides from powerpoint to pdf.
- Legacy-Id: 12379
2016-11-17 07:30:14 +00:00
Henrik Levkowetz 0a15bf9bb6 Merged in [12326] from housley@vigilsec.com:
Allow WG Chairs to manage the meeting materials when starting from the old WG Chair Dashboard in ietf.secr.proceedings
 - Legacy-Id: 12370
Note: SVN reference [12326] has been migrated to Git commit a37f41823c
2016-11-17 00:26:51 +00:00
Henrik Levkowetz 1a6fc6dc04 Merged in [12353] from rjsparks@nostrum.com:
A second performance improvement for the proceedings pages.
 - Legacy-Id: 12361
Note: SVN reference [12353] has been migrated to Git commit a3cc9df465
2016-11-16 06:54:00 +00:00
Henrik Levkowetz a771e8fad6 Merged in [12352] from rjsparks@nostrum.com:
Add links to session materials pages to the rows on the by-type view of the agenda.
 - Legacy-Id: 12360
Note: SVN reference [12352] has been migrated to Git commit ba60c115fa
2016-11-16 04:22:51 +00:00
Henrik Levkowetz 18518fe566 Merged in [12348] from rjsparks@nostrum.com:
Performance improvements for the proceedings page.
 - Legacy-Id: 12358
Note: SVN reference [12348] has been migrated to Git commit 224999e948
2016-11-16 03:55:59 +00:00
Henrik Levkowetz b254473258 Merged in [12340] from adam@nostrum.com:
Incorporated Robert's \'swim lane\' code to eliminate
slot overlaps that made weekend effectively unusable.
Reworked animation code to use CSS animations for
smoother performance.
Calendar redraw is now completely event driven rather
than refreshed once per second.
Expanded meetings can now be closed with escape key.
Refactored code to make it more idomatic. Eliminated
many globals.
Reformatted to reflect a more consistent coding style.
 - Legacy-Id: 12355
Note: SVN reference [12340] has been migrated to Git commit e4b2905f16
2016-11-16 02:15:43 +00:00
Robert Sparks a3cc9df465 A second performance improvement for the proceedings pages. Commit ready for merge.
- Legacy-Id: 12353
2016-11-15 07:38:21 +00:00
Robert Sparks ba60c115fa Add links to session materials pages to the rows on the by-type view of the agenda. Commit ready for merge.
- Legacy-Id: 12352
2016-11-15 06:58:37 +00:00
Henrik Levkowetz 8fcbf7507e Fixed another duplicate entry issue with materials uploads.
- Legacy-Id: 12350
2016-11-15 01:01:50 +00:00
Robert Sparks 224999e948 Performance improvements for the proceedings page. Commit ready for merge.
- Legacy-Id: 12348
2016-11-14 12:37:04 +00:00
Henrik Levkowetz 7d443357b0 Merged in [12334] from rcross@amsl.com:
Fix parameter validations in meeting.views.ajax_get_utc().  Fixes 2023.  Also fix pyflakes error.
 - Legacy-Id: 12345
Note: SVN reference [12334] has been migrated to Git commit 38a24b57e9
2016-11-14 05:12:34 +00:00
Henrik Levkowetz aa4a46086a Merged in [12330] and [12331] from rcross@amsl.com:
Add the ability for the Secretariat to skip the announcement when scheduling an IRTF interim meeting. Fixes #2015.
 - Legacy-Id: 12344
Note: SVN reference [12330] has been migrated to Git commit d7c1fddb32

Note: SVN reference [12331] has been migrated to Git commit b04d07e5aa
2016-11-14 05:02:10 +00:00
Henrik Levkowetz f9b61202f7 Fixed another case where pre-existing database objects related to meeting materials would cause exceptions when trying to upload updates.
- Legacy-Id: 12343
2016-11-14 04:25:53 +00:00
Henrik Levkowetz 21f3cd62d4 Merged in [12329] from rjsparks@nostrum.com:
Added groups that did not meet to the proceedings.
 - Legacy-Id: 12342
Note: SVN reference [12329] has been migrated to Git commit 467ec82336
2016-11-14 02:53:41 +00:00
Henrik Levkowetz 2af415cf7c Merged in [12318] from rjsparks@nostrum.com:
Change the edit buttons on the materials page to be links. Move where the link appears.
 - Legacy-Id: 12336
Note: SVN reference [12318] has been migrated to Git commit ca0980a8ea
2016-11-12 08:59:32 +00:00
Ryan Cross 38a24b57e9 Fix parameter validations in meeting.views.ajax_get_utc(). Fixes 2023. Also fix pyflakes error. Commit ready for merge
- Legacy-Id: 12334
2016-11-12 07:59:52 +00:00
Ryan Cross d7c1fddb32 Add the ability for the Secretariat to skip the announcement when scheduling an IRTF interim meeting. Fixes #2015. Commit ready for merge.
- Legacy-Id: 12330
2016-11-12 07:11:59 +00:00
Robert Sparks 467ec82336 Added groups that did not meet to the proceedings. Commit ready for merge.
- Legacy-Id: 12329
2016-11-12 07:09:01 +00:00
Russ Housley a37f41823c Allow WG Chairs to manage the meeting materials when starting from the old WG Chair Dashboard in ietf.secr.proceedings
- Legacy-Id: 12326
2016-11-12 05:40:12 +00:00
Robert Sparks 3c04782559 Guard against sessions that have no timeslot (such as for groups that are not officially not meeting at an IETF meeting) in the materials upload views. Commit ready for merge.
- Legacy-Id: 12316
2016-11-11 07:09:41 +00:00
Robert Sparks e3c3b716cd Add a view of past meetings. Commit ready for merge.
- Legacy-Id: 12315
2016-11-11 06:48:26 +00:00
Henrik Levkowetz 71d5eca6e6 If a session agenda for a meeting exists, but is not bound to the session, the Document.objects.create() in upload_session_agenda() will fail. Using get_or_create() instead.
- Legacy-Id: 12270
2016-11-07 12:19:03 +00:00
Henrik Levkowetz 4f2eb07fa7 Updated proceedings_templates fixture.
- Legacy-Id: 12258
2016-11-03 20:47:14 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense.
- Legacy-Id: 12256
2016-11-03 20:13:44 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes.
- Legacy-Id: 12253
2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function.
- Legacy-Id: 12252
2016-11-03 20:08:44 +00:00
Henrik Levkowetz 2b2abdbc29 Merged in [12213] from rcross@amsl.com:
Fix bug where interim announcement form was initialized with lists instead of strings.
 - Legacy-Id: 12228
Note: SVN reference [12213] has been migrated to Git commit ab945b16e5
2016-10-29 10:56:34 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Henrik Levkowetz 534a8d3e12 Reverted last commit as it leads to test failures. Doubtful if these actually can occur in production, but tests will have to be re-written before using the added caching.
- Legacy-Id: 12220
2016-10-26 20:20:37 +00:00
Henrik Levkowetz e1cadcb119 Added caching to avoid calling the meat of each of the Session minutes(), recordings(), bluesheets(), slides(), drafts() methods more than once per session. This removes another 3*#sessions sql queries when the materials are all in place (less when the first invocation reurns nothing).
- Legacy-Id: 12219
2016-10-26 19:17:41 +00:00
Henrik Levkowetz af584c6a1f Removed caching of the materials page (edit buttons are different for different users), and used select_related() and code re-write to reduce the sql query count from ~1900 to ~600, query time from ~2s to ~0.5s. More can be done, but the page response time is more acceptable now.
- Legacy-Id: 12218
2016-10-26 19:06:06 +00:00
Ryan Cross ab945b16e5 Fix bug where interim announcement form was initialized with lists instead of strings. Commit ready for merge
- Legacy-Id: 12213
2016-10-25 20:25:54 +00:00
Henrik Levkowetz 8e2259ebac Added a test for meeting/agenda-utc.
- Legacy-Id: 12195
2016-10-21 14:02:49 +00:00
Henrik Levkowetz a6db502108 Removed some dead code.
- Legacy-Id: 12194
2016-10-21 13:58:36 +00:00
Henrik Levkowetz 31c9defd0e New version of pytz, new choices for the meeting timezone form.
- Legacy-Id: 12154
2016-10-17 18:05:55 +00:00
Henrik Levkowetz 80e52ef0a1 Modified a test in upcoming_ical() to not break if a group does not have a parent.
- Legacy-Id: 12153
2016-10-17 17:33:01 +00:00
Henrik Levkowetz 1a92efb77e Merged in ^/branch/proceedings/6.33.1.dev0@12141 from rcross@amsl.com:
Added meeting proceedings introduction pages: Progress Report and Attendees.  Added a data migration to provide proceedings introduction information for IETF 95 and 96.
 - Legacy-Id: 12150
2016-10-14 15:48:10 +00:00
Ole Laursen e864abdcdb Fix some pyquery compatibility issues
- Legacy-Id: 12145
2016-10-14 09:40:12 +00:00
Ryan Cross 68e11fc823 Add missing proceedings attendee migration. Commit ready for merge.
- Legacy-Id: 12141
2016-10-13 23:32:54 +00:00
Ryan Cross 743ec4d7ff Refactor Proceedings Introduction pages tests and implementation. Commit ready for merge
- Legacy-Id: 12140
2016-10-13 23:31:03 +00:00
Henrik Levkowetz 20c9bc9e62 Reverted one instance of caching, as it seems schedules can change owners.
- Legacy-Id: 12138
2016-10-13 19:51:10 +00:00
Henrik Levkowetz d27fdb976b Fixed a schedule save-as redirect which could not match any URL, leading to a 500 error.
- Legacy-Id: 12134
2016-10-13 18:42:18 +00:00
Henrik Levkowetz de82a244fa Added some caching to methods which are called very often when showing the meeting schedule edit view.
- Legacy-Id: 12133
2016-10-13 18:40:26 +00:00
Henrik Levkowetz 05c26ba4c9 The db api prefers resource URIs ending in slash -- make it so in json_agenda().
- Legacy-Id: 12121
2016-10-12 18:09:18 +00:00
Henrik Levkowetz 23532102f8 Fixed room_name() to not fail when a timeslog has no location. Fixes a server 500 for agenda.json
- Legacy-Id: 12118
2016-10-12 14:17:22 +00:00
Ryan Cross 61945fd11b Fix pyflakes errors. Commit ready for merge
- Legacy-Id: 12112
2016-10-10 22:32:24 +00:00
Ryan Cross c3d4cc1aea Add meeting proceedings introduction pages: Progress Report and Attendees. Commit ready for merge.
- Legacy-Id: 12111
2016-10-10 21:21:02 +00:00
Henrik Levkowetz 269226a486 Merged in [12099] from rjsparks@nostrum.com:
Changes interim announcements and interim cancellation announcements to use mailtriggers. Adds irtf-announce to announcements for IRTF groups. Fixes #2018.
 - Legacy-Id: 12100
Note: SVN reference [12099] has been migrated to Git commit 5b32cc2da7
2016-10-07 15:30:43 +00:00
Robert Sparks 5b32cc2da7 Changes interim announcements and interim cancellation announcements to use mailtriggers. Adds irtf-announce to announcements for IRTF groups. Fixes #2018. Commit ready for merge.
- Legacy-Id: 12099
2016-10-07 15:05:47 +00:00
Henrik Levkowetz 5612a3f463 Merged in [12082] from rcross@amsl.com:
Fix issue where interim meeting request form didn't list research groups when user was a working group chair and a research group chair.
 - Legacy-Id: 12093
Note: SVN reference [12082] has been migrated to Git commit adf28c922f
2016-10-05 18:17:28 +00:00
Ryan Cross adf28c922f Fix issue where interim meeting request form didn't list research groups when user was a working group chair and a research group chair. Commit ready for merge.
- Legacy-Id: 12082
2016-10-04 23:42:18 +00:00
Henrik Levkowetz 87bf9d0ccb Merged in [12038] from rjsparks@nostrum.com:
Change how document names are generated for agendas and slides to allow uploads before meetings are scheduled.
 - Legacy-Id: 12045
Note: SVN reference [12038] has been migrated to Git commit 55febb5432
2016-09-26 19:18:19 +00:00
Henrik Levkowetz e2d9baab2b Tweaked test data to make test data sessions actually fall within their meeting, and to make sure that the test_agenda_current_audio sessions are in the near future.
- Legacy-Id: 12043
2016-09-26 18:46:27 +00:00
Henrik Levkowetz f1b146a1d9 Added a test which specifies a meeting currently under way, in order to make sure that code paths which are used only for current meetings are excercises, this reduces coverage variation due to random meeting dates. Also added a test for the presence of Audio stream, which isn't present on agenda pages of past meetings.
- Legacy-Id: 12041
2016-09-26 17:52:49 +00:00
Henrik Levkowetz eb7c39fcad Made it possible to pass in a meeting instance to make_meeting_test_data(), and added an audio stream UrlResource for test purposes.
- Legacy-Id: 12040
2016-09-26 17:50:38 +00:00
Robert Sparks 55febb5432 Change how document names are generated for agendas and slides to allow uploads before meetings are scheduled. Commit ready for merge.
- Legacy-Id: 12038
2016-09-26 17:34:29 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Henrik Levkowetz 8c34e9d78d Merged in ^/branch/proceedings/6.33.1.dev0 from rjsparks@nostrum.com and rcross@amsl.com. This provides new ietf meeting proceedings pages.
- Legacy-Id: 12028
2016-09-23 17:33:43 +00:00
Robert Sparks c7b82bdf1d Open the new proceedings page for anyone to see. Commit ready for merge.
- Legacy-Id: 12019
2016-09-22 21:09:09 +00:00
Robert Sparks 2042f981bd Changed default for apply_to_all for Slide uploads to False.
Added redirect for non-secretariat users from ietf.secr.proceedings.views.select to ietf.meeting.views.materials.
Added a note to the secr upload_footer pointing to where material upload is now done.
Modified the links on the group meetings page to make it less likely to miss the link to the session materials.
Used class anchor target to clean up landing on the right session of multiple sessions on a group's session details page. Modified the materials page to only add a fragment asking for that anchor for non-ag/wg/rg groups.
Only show the link to the (now) secretariat-only proceedings manipulation page if the user is the secretariat. Relabelled the link to better reflect the page's remaining purpose.
Changed the session_details "Artifacts" panel header to "Agenda, Minutes, and Bluesheets". Added a footer to the "Slides" panel calling out drag-and-drop reordering.
Commit ready for merge.
 - Legacy-Id: 12018
2016-09-22 20:15:57 +00:00
Robert Sparks eab067ff34 Repaired a max string vs max int bug in MeetingFactory. Commit ready for merge.
- Legacy-Id: 12016
2016-09-21 21:56:37 +00:00
Henrik Levkowetz 18b7a2fcdb On request, changed the agenda and minutes links in json_agenda to point at the document text instead of the document API endpoint.
- Legacy-Id: 12011
2016-09-20 20:46:32 +00:00
Henrik Levkowetz c8335f4c59 Set the is_bof flag in json_agenda also when it's false.
- Legacy-Id: 12010
2016-09-20 20:31:39 +00:00
Henrik Levkowetz e553ff80d8 Added an is_bof flag to json_agenda. Also added group state information. Changed the group information to use historic information instead of current.
- Legacy-Id: 12009
2016-09-20 20:28:22 +00:00
Henrik Levkowetz fe0bc55632 Added a link to the minutes api to json_agenda(). Changed the output json to use sorted keys.
- Legacy-Id: 12008
2016-09-20 20:04:27 +00:00
Henrik Levkowetz e917c5a0df Added made group a json object in the json_agenda, and added session.group.type information.
- Legacy-Id: 12005
2016-09-20 18:24:08 +00:00
Robert Sparks efa3228314 Added the ability to remove documents from a session to session_details. Made slide upload code more robust against removing a set of slides from a session and then revising them. Commit ready for merge.
- Legacy-Id: 12004
2016-09-19 22:05:59 +00:00
Robert Sparks 0f6e3f434e Closed off the old paths for materials upload (redirecting some old entry points). Commit ready for merge.
- Legacy-Id: 12000
2016-09-19 19:06:22 +00:00
Robert Sparks c045f7ed73 improve cleanup after slide reorder test. Commit ready for merge.
- Legacy-Id: 11996
2016-09-19 14:17:52 +00:00
Robert Sparks bcac1dfff8 Added slide sorting. Commit ready to merge.
- Legacy-Id: 11995
2016-09-16 20:36:59 +00:00
Robert Sparks 02ee5dc5d7 (somewhat bumpy) merge forward from proceedings/6.31.1.dev0
- Legacy-Id: 11992
2016-09-14 22:09:30 +00:00
Robert Sparks 53f41a6327 Added an order field to SessionPresentation.
Set up removing the order field from Document.
Modified the meeting materials, proceedings, and session details views to use the order field on SessionPresentation.
Added bootstrapped views to upload session materials (agendas, slides, minutes, and bluesheets). 
Integrated upload into the session details view.
Commit ready for merge.
 - Legacy-Id: 11989
2016-09-14 19:11:31 +00:00
Henrik Levkowetz 5a5446ca28 Added object IDs to /meeting/<num>/agenda.json.
- Legacy-Id: 11984
2016-09-13 13:51:01 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz f97204ceee Fixed a number of places where events were given the document time, but the document had not been given a new time yet, after the eventsave refactoring code changes of [11841]. Fixes issue #2004.
- Legacy-Id: 11901
Note: SVN reference [11841] has been migrated to Git commit d868371aff
2016-08-31 10:54:27 +00:00
Henrik Levkowetz eb22690d78 Merged in [11891] from rjsparks@nostrum.com:
Modify agenda.json to properly handle meetings that do not have an agenda yet. Fixes #2003.
 - Legacy-Id: 11896
Note: SVN reference [11891] has been migrated to Git commit 9f409480c0
2016-08-30 18:23:12 +00:00
Henrik Levkowetz 375f2a710d Added page caching for json_agenda(). Changed localization of naive time from database in json_agenda to use settings.PRODUCTION_TIMEZONE.
- Legacy-Id: 11893
2016-08-30 16:32:58 +00:00
Henrik Levkowetz 02e2f591bc Merged in [11888] from rjsparks@nostrum.com:
Added an order field to sessionpresentation to allow ordering slides. Reworked the session details page to break slides and drafts into their own sections.
 - Legacy-Id: 11892
Note: SVN reference [11888] has been migrated to Git commit 89a3afe025
2016-08-30 16:29:51 +00:00
Robert Sparks 9f409480c0 Modify agenda.json to properly handle meetings that do not have an agenda yet. Fixes #2003. Commit ready for merge.
- Legacy-Id: 11891
2016-08-30 14:57:28 +00:00
Robert Sparks 89a3afe025 Added an order field to sessionpresentation to allow ordering slides. Reworked the session details page to break slides and drafts into their own sections. Commit ready for merge.
- Legacy-Id: 11888
2016-08-26 21:06:01 +00:00
Robert Sparks 89c128de63 merge forward from 6.30.1.dev0
- Legacy-Id: 11879
2016-08-25 19:36:08 +00:00
Henrik Levkowetz 7e6ed23f70 Merged in [11858] from rjsparks@nostrum.com:
Merge forward Ryan's IETF Overview pages.
 - Legacy-Id: 11874
Note: SVN reference [11858] has been migrated to Git commit cb3af1a2d9
2016-08-25 13:36:48 +00:00
Robert Sparks cb3af1a2d9 Merge forward Ryan's IETF Overview pages. Commit ready for merge.
- Legacy-Id: 11858
2016-08-24 17:20:54 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz 52c5c0daa0 Merged in [11792] from rcross@amsl.com:
Requests for virtual interim meeting should go directly Scheduled - Waiting for announcement state and an email notification sent to the secretariat.  Fixes issue #1994.
 - Legacy-Id: 11822
Note: SVN reference [11792] has been migrated to Git commit a13b751e1a
2016-08-18 15:03:55 +00:00
Henrik Levkowetz 250af833aa Undid erroneous commit [11820].
- Legacy-Id: 11821
Note: SVN reference [11820] has been migrated to Git commit f497367658
2016-08-18 14:13:06 +00:00
Henrik Levkowetz f497367658 Provide a test materials directory for the bluesheets tests, to avoid dependency on the local directory setup.
- Legacy-Id: 11820
2016-08-18 14:10:28 +00:00
Henrik Levkowetz 328d9de9a6 Provide a test materials directory for the bluesheets tests, to avoid dependency on the local directory setup.
- Legacy-Id: 11818
2016-08-18 12:03:57 +00:00
Henrik Levkowetz 2386fa8884 Merged in [11781] from rcross@amsl.com:
Fix issue with interim meeting series of more than two meetings.  Changed to not send meeting change notifications for meetings not yet announced.
 - Legacy-Id: 11817
Note: SVN reference [11781] has been migrated to Git commit f65335e258
2016-08-18 11:39:06 +00:00
Henrik Levkowetz 72d9017d63 Merged in [11780] from rjsparks@nostrum.com:
Removed bluesheet upload from the secr/ bluesheets generation page. Added navigation to session details from the meeting materials view rows.
 - Legacy-Id: 11815
Note: SVN reference [11780] has been migrated to Git commit 9b295b1b5e346afafdcaf3d00b0b120a1b826e7f
2016-08-17 22:52:11 +00:00
Henrik Levkowetz f1ad6a0e8e Merged in [11779] from rjsparks@nostrum.com:
Robustness improvements for the bluesheet migrations.
 - Legacy-Id: 11814
Note: SVN reference [11779] has been migrated to Git commit 54a774caef8eb00f1d412dba658aaa9a91be3bb8
2016-08-17 21:45:57 +00:00
Henrik Levkowetz 6f05b23837 Merged in [11778] from rjsparks@nostrum.com:
Enabled and refined document_main view for bluesheets.
Improved migration for 95 and 96 bluesheets, adding DocAlias and DocEvent creation.
Added bluesheet upload to the session details view.
Moved a function out of secr/proceedings/views into its own util.py file to allow reusing it in other modules without introducing circular imports.
 - Legacy-Id: 11811
Note: SVN reference [11778] has been migrated to Git commit 0611444b36bc071e8db068a093cc1ad93bb69659
2016-08-17 18:28:02 +00:00
Henrik Levkowetz 3fee46cafb Fixed 2 bugs in the bluesheets migration: Create bluesheets directories if missing, to avoid exceptions when run by developers without the directories in place, and use __in instead of _in in the reverse migration queryset arguments.
- Legacy-Id: 11805
2016-08-17 16:05:51 +00:00
Henrik Levkowetz 4d62fd0a9d Merged in [11770] from rjsparks@nostrum.com:
Merged from rcross: Add Introduction header to proceedings. Add Acknowlegements to the meeting model. Add a view for acknowlegements.
 - Legacy-Id: 11804
Note: SVN reference [11770] has been migrated to Git commit 0b196e5eb5
2016-08-17 15:44:21 +00:00
Ryan Cross a13b751e1a Fixes #1994. Requests for virtual interim meeting should go directly Scheduled - Waiting for announcement state and an email notification sent to the secretariat. Commit ready for merge.
- Legacy-Id: 11792
2016-08-15 21:04:31 +00:00
Ryan Cross f65335e258 Fix issue with interim meeting series of more than two meetings. Changed to not send meeting change notifications for meetings not yet announced. Commit ready for merge.
- Legacy-Id: 11781
2016-08-12 21:32:13 +00:00
Robert Sparks 0b196e5eb5 Merged from rcross: Add Introduction header to proceedings. Add Acknowlegements to the meeting model. Add a view for acknowlegements. Commit ready for merge.
- Legacy-Id: 11770
2016-08-09 19:21:42 +00:00
Ryan Cross 4abb5026d3 Add new files for proceedings acknowledgemetns changes. Commit ready for merge.
- Legacy-Id: 11768
2016-08-09 18:31:38 +00:00
Robert Sparks 4631df61ef improve some test coverage. Commit ready for merge.
- Legacy-Id: 11767
2016-08-09 18:31:05 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge.
- Legacy-Id: 11766
2016-08-09 15:42:40 +00:00
Ryan Cross 485fcd0e53 Add new field meeting.acknowledgements and corresponding page in meeting proceedings. Commit ready for merge.
- Legacy-Id: 11765
2016-08-08 23:26:51 +00:00
Robert Sparks 57afa06fcd Moved the materials start, cutoff, and revision dates into the Meeting object
Add a bit to meeting to note whether proceedings are final. 
Update proceedings view to reflect the status of that bit. 
Add a function that finalizes a meetings proceedings.
Straighten out a migration numbering collision introduced in an earlier merge.
Commit ready for merge.
 - Legacy-Id: 11764
2016-08-08 20:34:37 +00:00
Robert Sparks 162845dcb8 Add a bit to meeting to note whether proceedings are final. Update proceedings view to reflect the status of that bit. Add a function that finalizes a meetings proceedings
- Legacy-Id: 11763
2016-08-08 20:14:04 +00:00
Robert Sparks fbf7d9e685 missed adding a migration
- Legacy-Id: 11761
2016-08-08 17:03:53 +00:00
Robert Sparks 44cd9e0920 Moved the materials start, cutoff, and revision dates into the Meeting object
- Legacy-Id: 11760
2016-08-05 20:44:05 +00:00
Robert Sparks f617e2688f Shift all datetimes for iphone json view to UTC. Commit ready for merge.
- Legacy-Id: 11759
2016-08-05 16:03:53 +00:00
Robert Sparks f2964b9733 Continued iterative-improvements to auto-generated proceedings:
- Migration to create documents and sessionpresentations for ietf95 and 96 bluesheets. Add bluesheets to proceedings.
- Refactor columns for proceedings to group agenda, minutes, and bluesheets into one column.
- Add a column for recordings. Show the recordings for all sessions for a group.
- Refactored all_meeting_ functions on session. Improved (with a hack) how recordings are displayed.
- Add guards against very old meetings. For more modern, past, meetings, add a warning that these are not the official proceedings and provide a link to the official proceedings.

Commit ready for merge.
 - Legacy-Id: 11758
2016-08-04 21:20:06 +00:00
Robert Sparks 56c232ec1d Add guards against very old meetings. For more modern, past, meetings, add a warning that these are not the official proceedings and provide a link to the official proceedings.
- Legacy-Id: 11757
2016-08-04 21:08:56 +00:00
Robert Sparks c68ae7669e Provides a custom json view of meetings optimized for the iphone app. Commit ready for merge.
- Legacy-Id: 11756
2016-08-04 19:51:52 +00:00
Robert Sparks 2ff54a963b refactored all_meeting_ functions on session. Improved (with a hack) how recordings are displayed.
- Legacy-Id: 11755
2016-08-03 18:19:39 +00:00
Robert Sparks a34dc40170 Migration to create documents and sessionpresentations for ietf95 and 96 bluesheets. Add bluesheets to proceedings.
- Legacy-Id: 11747
2016-08-02 20:30:40 +00:00
Robert Sparks 261f97e6c1 Add a column for recordings. Show the recordings for all sessions for a group.
- Legacy-Id: 11746
2016-08-02 15:31:30 +00:00
Henrik Levkowetz 4f3cc26d04 Don't show iaoc leadership sessions on the materials page.
- Legacy-Id: 11720
2016-07-19 17:04:38 +00:00
Henrik Levkowetz e14e1a9963 Merged in [11712] from rjsparks@nostrum.com:
Additional tweaks related to #1984.
 - Legacy-Id: 11718
Note: SVN reference [11712] has been migrated to Git commit 4226ee4980e8ca66d4a4cefacf63d1f0b58b7b40
2016-07-19 16:50:53 +00:00
Henrik Levkowetz 081abec0e8 Merged in [11711] from rjsparks@nostrum.com:
Starting a page for direct rendering of proceedings.
 - Legacy-Id: 11717
Note: SVN reference [11711] has been migrated to Git commit d9b1528f36e092892c9a18602615f7151edf75c3
2016-07-19 11:22:00 +00:00
Henrik Levkowetz 1f535323b6 Merged in [11698] from rcross@amsl.com:
Changed send_interim_announcement_request() to use new mailtrigger interim_approved.
 - Legacy-Id: 11709
Note: SVN reference [11698] has been migrated to Git commit 3da2d4f67b
2016-07-18 11:51:05 +00:00
Henrik Levkowetz f4cbe6c294 Merged in [11690] from housley@vigilsec.com:
When the Secretariat marks a session as cancelled, the HTML agenda
shows a red CANCELLED box, the text shows *** CANCELLED ***, and (as
before) the .ics file includes STATUS:CANCELLED.  Fixes issue #1639.
 - Legacy-Id: 11704
Note: SVN reference [11690] has been migrated to Git commit cbf7daddcc
2016-07-18 10:39:29 +00:00