Commit graph

210 commits

Author SHA1 Message Date
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com:
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge.
- Legacy-Id: 15084
2018-04-25 19:52:44 +00:00
Henrik Levkowetz 28f4c52c20 Added permission for a document shepherd to request publication. Fixes issue #2509.
- Legacy-Id: 15071
2018-04-23 20:41:04 +00:00
Henrik Levkowetz ea7728b501 Changed calls to .related_that*() and .relations_that*() to use tuples rather than lists (a slight optimization).
- Legacy-Id: 15029
2018-04-07 10:47:16 +00:00
Henrik Levkowetz dc90fa3940 Changed user.is_authenticated and .is_anonymous from method calls to attribute access.
- Legacy-Id: 14668
2018-02-22 00:03:30 +00:00
Henrik Levkowetz 07fd714c88 Refined the URL patterns and handling of alternative meeting material file formats, which were broken by an earlier refactoring (v6.57.0). Fixes issue #2436.
- Legacy-Id: 14521
2018-01-14 21:09:28 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz 53eb7c8ae8 Added migrations for document url model changes. Updated the name fixtures. Added ability for individual draft authors to edit document urls.
- Legacy-Id: 14172
2017-09-27 16:37:13 +00:00
Henrik Levkowetz 4174196af0 Fixed a problem with missing extensions for external materials URLs, introduced in earlier doc.href() normalization work.
- Legacy-Id: 14077
2017-08-24 19:18:54 +00:00
Henrik Levkowetz 55003bdf87 Simplified and corrected some code which uses doc.href(), based on the recent updates to href().
- Legacy-Id: 14026
2017-08-03 18:11:46 +00:00
Henrik Levkowetz 22f181cdbe Modified the text shown on Chairs' 'Manage DOcument Adoption in Group' button and corrected the logic for which text to show.
- Legacy-Id: 13725
2017-06-28 17:39:11 +00:00
Henrik Levkowetz 5e6ecfbaf5 Refined the appearance and wording of the 'Manage document's adoption' button.
- Legacy-Id: 13680
2017-06-19 18:09:33 +00:00
Henrik Levkowetz 1178f9f3ba Removed a debug print statement.
- Legacy-Id: 13570
2017-06-09 19:37:41 +00:00
Henrik Levkowetz 317aac9e55 Fixed a place where a missing document author email address could cause a server 500. There may be additional places needing attention, now that we're not inserting dummy addresses.
- Legacy-Id: 13566
2017-06-08 14:44:54 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz b81be04f20 Fixed the DOI information for doc/rfc*/bibtex/ temporarily; for a better fix we need to import the DOI values in ietf/sync/rfceditor.py
- Legacy-Id: 13478
2017-05-31 16:29:07 +00:00
Henrik Levkowetz 3d6fed4b5b Removed the 'Document' tab introduced in 6.48.0
- Legacy-Id: 13228
2017-04-17 11:39:36 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert e14dcdac8f Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time. Commit ready for merge.
 - Legacy-Id: 13109
2017-03-25 18:52:46 +00:00
Henrik Levkowetz eef984202f Better handling of missing documents (such as rfc575)
- Legacy-Id: 13060
2017-03-22 12:07:08 +00:00
Henrik Levkowetz 9082b0abe5 Another tweak to the rev pattern, and exception handling when breaking apart name an rev for documents which don't use the charter rev model.
- Legacy-Id: 13057
2017-03-22 09:50:07 +00:00
Henrik Levkowetz 814e1315b5 Added a new document tab for some documents, showing htmlized drafts and RFCs
using the htmlization code previously developed for tools.ietf.org.  As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.

Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.

Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.

Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.

Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.

Tweaked the code for new author email entries to provide a time if missing
in an updated entry.

Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.

Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
 - Legacy-Id: 13040
2017-03-20 14:08:52 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155.
- Legacy-Id: 12719
2017-01-23 22:54:36 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes.
- Legacy-Id: 12714
2017-01-23 18:35:58 +00:00
Henrik Levkowetz ef1b404fe3 Removed an extraneous request parameter.
- Legacy-Id: 12712
2017-01-23 18:21:15 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Henrik Levkowetz fa60671148 Fixed another instance of '=' being used for comparison in a template.
- Legacy-Id: 12708
2017-01-19 21:21:10 +00:00
Henrik Levkowetz 7c2a161a5f Removed some remaining instances of render using context_instance. Fixed a case of tuple length of list of tuples passed to a template to be the same for all tuples.
- Legacy-Id: 12676
2017-01-19 17:08:27 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge.
- Legacy-Id: 12588
2016-12-19 20:38:51 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Robert Sparks 933134f4cc Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019. Commit ready for merge.
- Legacy-Id: 12104
2016-10-07 17:29:05 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Ole Laursen 24dd268a81 Show on document page if teams are not going to review that version
- Legacy-Id: 11851
2016-08-24 09:08:37 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00