Henrik Levkowetz
55d36e284d
Changed the '%s <%s>'%(name,email) idiom in several places to use email.utils.formataddr() instead, to avoid future problems with names that would need quotes. Added comments in 2 places where this change would not be appropriate.
...
- Legacy-Id: 13536
2017-06-05 22:40:11 +00:00
Henrik Levkowetz
a92c2b4ad5
Updated migration numbering to avoid collisions.
...
- Legacy-Id: 13480
2017-05-31 21:36:08 +00:00
Henrik Levkowetz
76628be3fd
Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
...
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz
4afe0b8830
Added stripping of leading and trailing whitespace from submission data (including email addresses) gleaned from submitted xml. Changed email line parsing to use email.utils.parseaddr() instead of a regex which only would handle unwuoted names (and possibly not utf-8 names) correctly.
...
- Legacy-Id: 13423
2017-05-25 14:10:42 +00:00
Ole Laursen
5b677dc6ba
Merge author stats branch into new branch from trunk
...
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz
14c748df98
Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
...
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Lars Eggert
8a70e9773d
Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
...
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz
814e1315b5
Added a new document tab for some documents, showing htmlized drafts and RFCs
...
using the htmlization code previously developed for tools.ietf.org. As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.
Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.
Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.
Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.
Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.
Tweaked the code for new author email entries to provide a time if missing
in an updated entry.
Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.
Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
- Legacy-Id: 13040
2017-03-20 14:08:52 +00:00
Henrik Levkowetz
bb5096da8a
Added more email validation for draft submission author emails, and blocked some baths that could lead to bad email addresses ('none') being set as document author email addresses.
...
- Legacy-Id: 13010
2017-03-14 14:07:21 +00:00
Henrik Levkowetz
4daf66d11c
Added DocEvent rev= parameter througout the code.
...
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz
5bb5ca727b
Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
...
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Henrik Levkowetz
ffa19c9847
Added a log.affirm() call at the point where we may discover new flawed document author records. Fixed a place where the generation of Person.ascii from Person.name wasn't done well.
...
- Legacy-Id: 12903
2017-02-23 11:57:29 +00:00
Henrik Levkowetz
a5290e143a
Made some changes to the missing-email submission handling. This may have fixed the creation of author records containing 'none' email entries, but as I've not been able to reproduce the issue, this is uncertain. Next is to build an email notification assert statement to help capture information if this happens.
...
- Legacy-Id: 12898
2017-02-22 15:36:28 +00:00
Henrik Levkowetz
27351c4349
Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
...
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz
8930d29a8e
Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
...
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Henrik Levkowetz
cf4a4b02a7
Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080 .
...
- Legacy-Id: 12872
2017-02-18 21:50:18 +00:00
Ole Laursen
9d8874d8b1
Add a suggestion to fix the country name when submitting a draft in
...
case we can't parse it and it's not empty, add page with list of
countries (to be able to refer people to it), add ISO codes as country
aliases - the country alias code is now more intelligent with respect
to case so it's easier to keep these aliases explicitly
- Legacy-Id: 12862
2017-02-16 17:56:23 +00:00
Ole Laursen
b2ff10b0f2
Add support for extracting the country line from the author addresses
...
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
- Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Henrik Levkowetz
f6a1fcdaf8
Added more information about submission errors and a full idnits run to the manual post email sent to the secretariat.
...
- Legacy-Id: 12831
2017-02-13 20:37:47 +00:00
Henrik Levkowetz
aa5e61d958
Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
...
in order to autogenerate dotted path url pattern names. Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.
Changed some imports to prevent import of ietf.urls before django
initialization was complete.
Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.
Started converting old-style middleware classes to new-style middleware
functions (incomplete).
Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.
Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.
Rewrote the filename argument handling in a management command which had
broken with the upgrade.
- Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Ole Laursen
8fdb0047e1
Add migration for converting existing Submission.authors to JSON
...
- Legacy-Id: 12746
2017-01-27 16:12:10 +00:00
Ole Laursen
90051a1575
Add support for displaying and editing author affiliation and country
...
when submitting a draft, replace the Submission.authors line-based
text field with a JSON field
- Legacy-Id: 12745
2017-01-27 16:10:31 +00:00
Ole Laursen
9308948195
Add person, affiliation and country (through django-countries) to
...
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.
Update the Secretariat tools to show affiliation and country.
Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
- Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Henrik Levkowetz
6de7be6953
Specified strip=False for another bunch of CharField form fields with Textarea widgets.
...
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Ole Laursen
76bcab6efc
Show formal languages used on new submissions and make the field
...
editable, also add it to the test with a simple JSON example
- Legacy-Id: 12662
2017-01-17 13:52:16 +00:00
Ole Laursen
1850a26b23
Add words and formal languages to Submission, set them in the submit
...
view, clean up submit view a bit to avoid duplicated attribute setting
code
- Legacy-Id: 12660
2017-01-16 17:37:23 +00:00
Henrik Levkowetz
6eec4c2648
Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach.
...
- Legacy-Id: 12645
2017-01-11 18:42:38 +00:00
Henrik Levkowetz
c2541ec04b
Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files.
...
- Legacy-Id: 12618
2016-12-22 17:21:57 +00:00
Henrik Levkowetz
19ec458668
Added migrations for the model changes done for the Django 1.8 upgrade.
...
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz
14776bae70
Merged django18 work forward to r12447
...
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz
0bb7854591
Merged django18 work forward to 6.39
...
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz
9c9b15bec8
Added guards against picking up non-ascii title and abstract from drafts submitted in xml form.
...
- Legacy-Id: 12429
2016-11-30 15:56:22 +00:00
Henrik Levkowetz
b914f46313
Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
...
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz
7f1c1e43f2
Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission.
...
- Legacy-Id: 12275
2016-11-07 18:21:34 +00:00
Henrik Levkowetz
87e1339924
Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense.
...
- Legacy-Id: 12256
2016-11-03 20:13:44 +00:00
Henrik Levkowetz
ca570ae355
Reverted an inadvertent commit of all changes.
...
- Legacy-Id: 12253
2016-11-03 20:10:09 +00:00
Henrik Levkowetz
276c9c1030
Removed use of the fix_ampersands() function.
...
- Legacy-Id: 12252
2016-11-03 20:08:44 +00:00
Ole Laursen
e864abdcdb
Fix some pyquery compatibility issues
...
- Legacy-Id: 12145
2016-10-14 09:40:12 +00:00
Henrik Levkowetz
e06ac44060
Added a migration to remove most duplicate 'Upload' doc events.
...
- Legacy-Id: 12098
2016-10-06 18:40:04 +00:00
Henrik Levkowetz
8a5593e714
When converting submission events to doc events, post them in chronological order. Don't add upload doc events until we're past the possibility of submission cancellation.
...
- Legacy-Id: 12097
2016-10-06 17:03:23 +00:00
Henrik Levkowetz
88a9c30600
Added a data migration to fix up incorrect submission doc events.
...
- Legacy-Id: 12073
2016-10-02 16:04:26 +00:00
Henrik Levkowetz
72cfe4cf68
Removed the creation of duplicate new revision doc events. Corrected the timestamp on approval docevents. Changed where the submission upload docevent is created, to avoid spurious events for cancelled uploads. Adjusted the person associated with some events from submitter to (System). Added tests for the sequence of events associated with a submission.
...
- Legacy-Id: 12072
2016-10-01 21:16:04 +00:00
Henrik Levkowetz
a9f879cd0e
Tweaked admin models.
...
- Legacy-Id: 12071
2016-10-01 13:36:31 +00:00
Henrik Levkowetz
ff5866367b
Tweaked the nonascii draft test template.
...
- Legacy-Id: 12067
2016-09-30 20:31:24 +00:00
Henrik Levkowetz
68655b569b
Fixed 2 testing bugs. Added tests for handling of submitters without email and drafts with non-ascii names in the author section.
...
- Legacy-Id: 12064
2016-09-30 17:35:35 +00:00
Henrik Levkowetz
da2c25182f
Code changes to handle draft submission authors without email addresses better.
...
- Legacy-Id: 12063
2016-09-30 10:48:46 +00:00
Henrik Levkowetz
613363cccc
Try various ways of handling non-ascii names/emails in draft submissions, in order to get past the early processing to the point where we run idnits and can flag non-ascii content, instead of failing with a server 500 error.
...
- Legacy-Id: 12053
2016-09-27 20:27:05 +00:00
Henrik Levkowetz
0378f4a2f6
Merged in [12014] from rjsparks@nostrum.com:
...
Improves who to copy when sending submission confirmation mail when authors change.
- Legacy-Id: 12044
Note: SVN reference [12014] has been migrated to Git commit 4f01de1b94
2016-09-26 18:47:23 +00:00
Henrik Levkowetz
7f772641d4
Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
...
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Robert Sparks
4f01de1b94
Improves who to copy when sending submission confirmation mail when authors change. Commit ready for merge.
...
- Legacy-Id: 12014
2016-09-21 15:55:17 +00:00