altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
9318 commits 1 branch 0 tags 2.6 GiB
Commit graph

390 commits

Author SHA1 Message Date
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion(). 
- Legacy-Id: 12933
 2017-02-28 20:16:52 +00:00
Henrik Levkowetz ffa19c9847 Added a log.affirm() call at the point where we may discover new flawed document author records. Fixed a place where the generation of Person.ascii from Person.name wasn't done well. 
- Legacy-Id: 12903
 2017-02-23 11:57:29 +00:00
Henrik Levkowetz a5290e143a Made some changes to the missing-email submission handling. This may have fixed the creation of author records containing 'none' email entries, but as I've not been able to reproduce the issue, this is uncertain. Next is to build an email notification assert statement to help capture information if this happens. 
- Legacy-Id: 12898
 2017-02-22 15:36:28 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Ole Laursen 9d8874d8b1 Add a suggestion to fix the country name when submitting a draft in 
case we can't parse it and it's not empty, add page with list of
countries (to be able to refer people to it), add ISO codes as country
aliases - the country alias code is now more intelligent with respect
to case so it's easier to keep these aliases explicitly
 - Legacy-Id: 12862
 2017-02-16 17:56:23 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses 
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
 2017-02-15 18:43:57 +00:00
Henrik Levkowetz f6a1fcdaf8 Added more information about submission errors and a full idnits run to the manual post email sent to the secretariat. 
- Legacy-Id: 12831
 2017-02-13 20:37:47 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Ole Laursen 8fdb0047e1 Add migration for converting existing Submission.authors to JSON 
- Legacy-Id: 12746
 2017-01-27 16:12:10 +00:00
Ole Laursen 90051a1575 Add support for displaying and editing author affiliation and country 
when submitting a draft, replace the Submission.authors line-based
text field with a JSON field
 - Legacy-Id: 12745
 2017-01-27 16:10:31 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to 
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
 2017-01-26 17:10:08 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Ole Laursen 76bcab6efc Show formal languages used on new submissions and make the field 
editable, also add it to the test with a simple JSON example
 - Legacy-Id: 12662
 2017-01-17 13:52:16 +00:00
Ole Laursen 1850a26b23 Add words and formal languages to Submission, set them in the submit 
view, clean up submit view a bit to avoid duplicated attribute setting
code
 - Legacy-Id: 12660
 2017-01-16 17:37:23 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach. 
- Legacy-Id: 12645
 2017-01-11 18:42:38 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade. 
- Legacy-Id: 12478
 2016-12-07 19:41:48 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447 
- Legacy-Id: 12455
 2016-12-05 15:03:40 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39 
- Legacy-Id: 12449
 2016-12-05 14:01:25 +00:00
Henrik Levkowetz 9c9b15bec8 Added guards against picking up non-ascii title and abstract from drafts submitted in xml form. 
- Legacy-Id: 12429
 2016-11-30 15:56:22 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history. 
- Legacy-Id: 12419
 2016-11-29 14:54:19 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission. 
- Legacy-Id: 12275
 2016-11-07 18:21:34 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense. 
- Legacy-Id: 12256
 2016-11-03 20:13:44 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes. 
- Legacy-Id: 12253
 2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function. 
- Legacy-Id: 12252
 2016-11-03 20:08:44 +00:00
Ole Laursen e864abdcdb Fix some pyquery compatibility issues 
- Legacy-Id: 12145
 2016-10-14 09:40:12 +00:00
Henrik Levkowetz e06ac44060 Added a migration to remove most duplicate 'Upload' doc events. 
- Legacy-Id: 12098
 2016-10-06 18:40:04 +00:00
Henrik Levkowetz 8a5593e714 When converting submission events to doc events, post them in chronological order. Don't add upload doc events until we're past the possibility of submission cancellation. 
- Legacy-Id: 12097
 2016-10-06 17:03:23 +00:00
Henrik Levkowetz 88a9c30600 Added a data migration to fix up incorrect submission doc events. 
- Legacy-Id: 12073
 2016-10-02 16:04:26 +00:00
Henrik Levkowetz 72cfe4cf68 Removed the creation of duplicate new revision doc events. Corrected the timestamp on approval docevents. Changed where the submission upload docevent is created, to avoid spurious events for cancelled uploads. Adjusted the person associated with some events from submitter to (System). Added tests for the sequence of events associated with a submission. 
- Legacy-Id: 12072
 2016-10-01 21:16:04 +00:00
Henrik Levkowetz a9f879cd0e Tweaked admin models. 
- Legacy-Id: 12071
 2016-10-01 13:36:31 +00:00
Henrik Levkowetz ff5866367b Tweaked the nonascii draft test template. 
- Legacy-Id: 12067
 2016-09-30 20:31:24 +00:00
Henrik Levkowetz 68655b569b Fixed 2 testing bugs. Added tests for handling of submitters without email and drafts with non-ascii names in the author section. 
- Legacy-Id: 12064
 2016-09-30 17:35:35 +00:00
Henrik Levkowetz da2c25182f Code changes to handle draft submission authors without email addresses better. 
- Legacy-Id: 12063
 2016-09-30 10:48:46 +00:00
Henrik Levkowetz 613363cccc Try various ways of handling non-ascii names/emails in draft submissions, in order to get past the early processing to the point where we run idnits and can flag non-ascii content, instead of failing with a server 500 error. 
- Legacy-Id: 12053
 2016-09-27 20:27:05 +00:00
Henrik Levkowetz 0378f4a2f6 Merged in [12014] from rjsparks@nostrum.com: 
Improves who to copy when sending submission confirmation mail when authors change.
 - Legacy-Id: 12044
Note: SVN reference [12014] has been migrated to Git commit 4f01de1b94
 2016-09-26 18:47:23 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur. 
- Legacy-Id: 12035
 2016-09-25 13:53:22 +00:00
Robert Sparks 4f01de1b94 Improves who to copy when sending submission confirmation mail when authors change. Commit ready for merge. 
- Legacy-Id: 12014
 2016-09-21 15:55:17 +00:00
Henrik Levkowetz 586eec7f2b Made a reverse migration more robust. 
- Legacy-Id: 11974
 2016-09-11 11:59:05 +00:00
Henrik Levkowetz 9cb627f1cc Made some migrations work backwards, too. 
- Legacy-Id: 11964
 2016-09-10 20:06:15 +00:00
Henrik Levkowetz 22b2953b18 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0, which provides secretariat support for managing draft submissions outside of the automated datatracker draft submission tool. In addition to making the secreatiat handling of draft submissions that come in by email or other paths easier, it also improves the datatracker submission and document history for these documents. 
- Legacy-Id: 11959
 2016-09-09 17:00:23 +00:00
Henrik Levkowetz c1ce79f14d Style tweak 
- Legacy-Id: 11945
 2016-09-08 18:30:03 +00:00
Henrik Levkowetz 254c3db807 Style changes. 
- Legacy-Id: 11944
 2016-09-08 17:37:36 +00:00
Henrik Levkowetz 47d6bbbea3 Renamed the SubmissionEmail event class to SubmissionEmailEvent, and added an admin class for it. 
- Legacy-Id: 11942
 2016-09-08 15:04:53 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking). 
- Legacy-Id: 11941
 2016-09-08 14:48:59 +00:00
Henrik Levkowetz a531b7cbc0 Removed BOM 
- Legacy-Id: 11919
 2016-09-02 09:27:44 +00:00
Henrik Levkowetz be6065e6a5 Manual post naming and string tweaks 
- Legacy-Id: 11918
 2016-09-01 12:04:43 +00:00
Henrik Levkowetz 7a8c067d83 Changed a state name, and renamed some view functions for easier code reading. Removed extra name= parameters from the submit/ urlpatterns. 
- Legacy-Id: 11917
 2016-09-01 09:14:34 +00:00
Henrik Levkowetz e2fccfb094 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0@11899, which provides better support for manual ID posting. 
- Legacy-Id: 11914
 2016-08-31 22:30:31 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0 
- Legacy-Id: 11899
 2016-08-31 03:00:10 +00:00
Robert Sparks b988b86b1a Copy group chairs on confirmation email when a new group document revision is submitted that changes the author set. Fixes #1998. Commit ready for merge. 
- Legacy-Id: 11877
 2016-08-25 15:52:51 +00:00
Robert Sparks 2009afe7b8 preparing to merge forward to 6.31 
- Legacy-Id: 11875
 2016-08-25 15:21:57 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Henrik Levkowetz 7f5863d212 Added a FIXME comment about a test which can fail if run across the midnight date shift. 
- Legacy-Id: 11544
 2016-07-07 12:40:41 +00:00
Henrik Levkowetz 5395c85ed7 Changed the acceptable mime type for uploaded xml files to be either text/xml or application/xml. 
- Legacy-Id: 11280
 2016-06-06 07:38:02 +00:00
Henrik Levkowetz 3eaef15fd5 Fixed a bug found by rjsparks@nostrum.com in the submission test text output. 
- Legacy-Id: 11279
 2016-06-06 07:37:05 +00:00
Henrik Levkowetz 72ba673bd8 Removed debug code. 
- Legacy-Id: 11221
 2016-05-22 15:47:05 +00:00
Henrik Levkowetz a32b121efb Changed some instances of error strings from ascii to unicode in order to avoid problems with unicode error messages, such as the file size indications generated by django.template.defaultfilters.filesizeformat(). 
- Legacy-Id: 11220
 2016-05-22 14:40:37 +00:00
Henrik Levkowetz deb2f73047 Merged in ^/branch/iola/community-list-cleanup-r11172@11175. 
- Legacy-Id: 11182
 2016-05-12 19:14:28 +00:00
Henrik Levkowetz aa61123937 Modified a few tests to handle the improved handling of error messages (not conflating them with help text any more). 
- Legacy-Id: 11181
 2016-05-12 13:47:10 +00:00
Ole Laursen 9faae5e915 Merged community list branch with trunk 
- Legacy-Id: 11174
 2016-05-06 17:36:04 +00:00
Henrik Levkowetz 8769cc0207 Fixed bugs in the previous commit (in the tests). 
- Legacy-Id: 11142
 2016-05-03 17:16:17 +00:00
Henrik Levkowetz 304516f4b3 Added test directories for yang model tests. 
- Legacy-Id: 11141
 2016-05-03 16:40:09 +00:00
Henrik Levkowetz d96f0fe964 Added a django management command to populate yang model libraries from RFCs and drafts. 
- Legacy-Id: 11110
 2016-04-08 17:18:54 +00:00
Henrik Levkowetz 97658ee40b Fixed incomplete edit. 
- Legacy-Id: 11027
 2016-03-29 20:45:25 +00:00
Henrik Levkowetz db3a3c3081 Added (belatedly) progress bars to some long-running migrations. 
- Legacy-Id: 11025
 2016-03-29 19:57:24 +00:00
Henrik Levkowetz 6b7faf3926 Added migrations for the submit check display work. 
- Legacy-Id: 10998
 2016-03-28 19:32:49 +00:00
Henrik Levkowetz 4b0b7e0c58 Merged in henrik/6.16.1-pyang-work@10995: 
Added in support for displaying results from selected submission checks as symbols on draft pages and in draft lists.  For now, that means that drafts with yang modules will show either a green or orange yang symbol, depending on the result of the submission yang validation check.
 - Legacy-Id: 10996
 2016-03-28 19:23:10 +00:00
Henrik Levkowetz 3012a8ceb6 Submission check symbols should only be shown when the check returned a result, not otherwise. 
- Legacy-Id: 10995
 2016-03-28 19:08:02 +00:00
Henrik Levkowetz be2a2285bc Added small orange or green yang symbols to draft info- and list-pages, signifying fail or pass for the submission yang validation. 
- Legacy-Id: 10994
 2016-03-28 18:47:53 +00:00
Ole Laursen c061caaf04 Merge in changes from community-list-cleanup 
- Legacy-Id: 10968
 2016-03-23 13:31:24 +00:00
Henrik Levkowetz 7b65e2624f Added another guard against varying pyang output format. 
- Legacy-Id: 10966
 2016-03-22 20:58:08 +00:00
Ole Laursen c7589f9b6a Integrate community lists for groups with the existing group documents 
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.

Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.

Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
 - Legacy-Id: 10963
 2016-03-22 12:48:44 +00:00
Henrik Levkowetz f52e21fb17 Put a guard in the yang validator against trying to read a draft which is absent from the staging area. 
- Legacy-Id: 10958
 2016-03-21 11:42:06 +00:00
Henrik Levkowetz e0d1c0b313 Fixed a possible index error in the yang validator checker plugin. 
- Legacy-Id: 10952
 2016-03-17 13:22:16 +00:00
Henrik Levkowetz 7832427f8f Fixed a typo. 
- Legacy-Id: 10930
 2016-03-15 23:12:46 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources. 
- Legacy-Id: 10929
 2016-03-15 23:12:04 +00:00
Henrik Levkowetz 8c68bc63fa Removed obsolete Submission.idnits_message field. 
- Legacy-Id: 10928
 2016-03-15 23:10:56 +00:00
Henrik Levkowetz 781a552e07 Added an admin model class for SubmissionEvent. 
- Legacy-Id: 10926
 2016-03-15 23:07:04 +00:00
Henrik Levkowetz 62574cd3f8 Fixed a pyflakes issue. 
- Legacy-Id: 10925
 2016-03-15 17:45:22 +00:00
Henrik Levkowetz 78d8e2e44c Removed unused idnits_message field on Submission model. 
- Legacy-Id: 10911
 2016-03-06 17:46:55 +00:00
Henrik Levkowetz 8c07e98052 Removed an unused import 
- Legacy-Id: 10902
 2016-03-05 14:51:07 +00:00
Henrik Levkowetz 7dec6c308d Removed resource file entry left over from refactored code. Adjusted resource class filtering fields 
- Legacy-Id: 10899
 2016-03-05 13:56:11 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0 
- Legacy-Id: 10896
 2016-03-04 21:24:26 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check. 
- Legacy-Id: 10894
 2016-03-04 20:08:29 +00:00
Henrik Levkowetz b00b0c3db9 Moved some production-path checks to the checks module, and fixed up tests which changed some settings without restoring them. 
- Legacy-Id: 10808
 2016-02-09 18:50:37 +00:00
Henrik Levkowetz 33b1cc312e Merged in [10780] from rjsparks@nostrum.com: 
Stop making active unknown-email- objects. Mark existing such objects as inactive. Tweak exception handling in submit/utils to make it obvious that the utilities will not change the person an existing Email record is pointing to.
 - Legacy-Id: 10787
Note: SVN reference [10780] has been migrated to Git commit c8c45e2213
 2016-02-06 19:44:14 +00:00
Robert Sparks c8c45e2213 Stop making active unknown-email- objects. Mark existing such objects as inactive. Tweak exception handling in submit/utils to make it obvious that the utilities will not change the person an existing Email record is pointing to. Commit ready for merge. 
- Legacy-Id: 10780
 2016-02-04 22:50:50 +00:00
Henrik Levkowetz 289d9ebef6 Moved some path checks from SubmissionUploadForm to the ietf/checks.py. 
- Legacy-Id: 10753
 2016-01-28 16:09:44 +00:00
Henrik Levkowetz 8e399de009 Don't fail submission confirmation if the login used is missing an associated person record. 
- Legacy-Id: 10751
 2016-01-27 13:40:23 +00:00
Robert Sparks cb778b9660 Exclude concluded bofs from the set of groups for which a person can pre-approve drafts. Restore AD access to preapproval. (Need to consider adding delegate and group secretary access). Fixes #1896. Commit ready for merge 
- Legacy-Id: 10734
 2016-01-26 19:42:57 +00:00
Ole Laursen 1c3ec64e03 Eliminate odd group_id assignment in submission code, probably left 
over from a previous generation of the code. It causes trouble with a
revamped community rule engine.
 - Legacy-Id: 10730
 2016-01-25 18:26:33 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Henrik Levkowetz 408d51c11f Merged in [10425] from bartosz.balazinski@interdigital.com: 
Provide information about who has suggested document replaced-by information in the notification email.

    This commit fixes bug 1817,
 - Legacy-Id: 10440
Note: SVN reference [10425] has been migrated to Git commit ba39077180
 2015-11-07 21:43:27 +00:00
Bartosz Balazinski ba39077180 This commit fixes bug 1817, commit ready to merge 
- Legacy-Id: 10425
 2015-11-04 23:25:51 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00