If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
result, not the review request page. The doc page will contain the
actual review, so it has all information that is needed. Fixes#2090.
Commit ready for merge.
- Legacy-Id: 13955
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes#2096.
- Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.
The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
- Legacy-Id: 12278
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
- Legacy-Id: 12266
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.
Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
- Legacy-Id: 12080
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
- Legacy-Id: 11843
review requests page.
Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).
Fix various bugs.
- Legacy-Id: 11508
