Commit graph

668 commits

Author SHA1 Message Date
Henrik Levkowetz 43dd7d5e90 Tweaked the management command to send GDPR consent request emails to correctly perform exclusion based on the time of previous consent request emails.
- Legacy-Id: 15504
2018-09-29 20:08:09 +00:00
Henrik Levkowetz 1dd47e18f5 Whitespace changes only.
- Legacy-Id: 15499
2018-09-29 12:46:12 +00:00
Henrik Levkowetz 7ea8a3f431 Tweaked the gdpr reminder command to avoid bounces to RT and copies to gmail.
- Legacy-Id: 15480
2018-09-24 18:37:45 +00:00
Henrik Levkowetz 30f456f83a Changed the default minimum response time used by the delete_data_lacking_consent management command from 14 to 7 days.
- Legacy-Id: 15466
2018-09-18 13:35:27 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively.
- Legacy-Id: 15464
2018-09-16 23:12:43 +00:00
Henrik Levkowetz a389e24fb6 Refined utils.log.log() to flush stdout before logging if we're writing log messages to stderr.
- Legacy-Id: 15463
2018-09-16 14:14:26 +00:00
Henrik Levkowetz b85e1c46d9 Added a delete_data_lacking_consent management command that deletes person records and person information for which we need consent according to GDPR, but have not received it.
- Legacy-Id: 15461
2018-09-16 13:54:32 +00:00
Henrik Levkowetz 3f9dbeada8 Expanded the send_gdpr_consent_request command to add support for deletion dates, email reminder interval, email sending rate limiting, and sending to a list of users.
- Legacy-Id: 15460
2018-09-16 13:52:29 +00:00
Henrik Levkowetz b2bfc7858a Generalized the log.assertion() function a bit to be able to provide more information on assertion failure.
- Legacy-Id: 15426
2018-08-10 15:31:12 +00:00
Henrik Levkowetz e53318084d Added a tiny utility function unwrap() to unwrap wrapped text for matching expected strings in tests.
- Legacy-Id: 15396
2018-07-19 15:53:05 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com:
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
2018-07-10 17:16:47 +00:00
Henrik Levkowetz dbfdb94c34 Merged in [15267] from rcross@amsl.com:
Fix issue with decorator on utils.html.remove_tags().
 - Legacy-Id: 15270
Note: SVN reference [15267] has been migrated to Git commit 0d255f7d0874f01163f292568e76fa9d830a54e2
2018-06-19 21:23:35 +00:00
Henrik Levkowetz 97db5f71b5 Added a management command to send out gdpr consent requests.
- Legacy-Id: 15269
2018-06-19 19:23:46 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Robert Sparks 25e9893a13 Changed how the mail utilities handle lists in their override and extra arguments. Added a test for send_mail_preformatted exercising override and extra. Commit ready for merge.
- Legacy-Id: 15153
2018-05-22 15:38:04 +00:00
Henrik Levkowetz df7df69a59 Updated comment text
- Legacy-Id: 15131
2018-05-05 12:49:39 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz 61a16856ad Updated the admin interface to use the simple-history admin support for Person history.
- Legacy-Id: 15097
2018-05-01 11:07:12 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com:
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Henrik Levkowetz fac57c24a7 Tweaked the wording of coverage_changes output.
- Legacy-Id: 15048
2018-04-17 11:35:36 +00:00
Henrik Levkowetz ab8e73aca5 Included django.utils.html.escape() in the linkify() code, and removed it from various templates, to make sure escape is consistently applied before linkify. Fixes issue #2492.
- Legacy-Id: 15035
2018-04-09 16:36:07 +00:00
Henrik Levkowetz a96c6c4c5b Tweaked the test runner to more consistently force the test coverage tests to be run last.
- Legacy-Id: 15030
2018-04-08 12:42:03 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents().
- Legacy-Id: 14988
2018-04-01 18:51:48 +00:00
Henrik Levkowetz ec6424c9c4 Merged in [14882] from rjsparks@nostrum.com:
Replaced line that had mysteriously been deleted before commit.  Sorry for the noise.
 - Legacy-Id: 14905
Note: SVN reference [14882] has been migrated to Git commit 4a7cdf26d3
2018-03-24 13:39:49 +00:00
Henrik Levkowetz a485c74314 Merged in [14880] from rjsparks@nostrum.com:
Added a Draft test suite.
 - Legacy-Id: 14901
Note: SVN reference [14880] has been migrated to Git commit e09a28cad2
2018-03-22 16:34:10 +00:00
Robert Sparks 4a7cdf26d3 Replaced line that had mysteriously been deleted before commit. Commit ready for merge. Sorry for the noise.
- Legacy-Id: 14882
2018-03-20 21:14:46 +00:00
Robert Sparks e09a28cad2 Failed to add a file in a previous commit. Commit ready for merge.
- Legacy-Id: 14880
2018-03-20 18:21:37 +00:00
Henrik Levkowetz 75deb35e10 Merged in [14851] from housley@vigilsec.com:
Improve parser for references in Internet-Drafts. Fixes #2360
 - Legacy-Id: 14867
Note: SVN reference [14851] has been migrated to Git commit 565b10e00e
2018-03-19 22:37:03 +00:00
Russ Housley 565b10e00e Improve parser for references in Internet-Drafts. Fixes #2360
- Legacy-Id: 14851
2018-03-17 18:25:31 +00:00
Henrik Levkowetz 63c97ad439 Fixed a bug in a RegexValidator error message string interpolation.
- Legacy-Id: 14841
2018-03-17 13:09:58 +00:00
Henrik Levkowetz 9341f96832 Tweaked the document sanitizer to insert a charset meta tag after sanitization.
- Legacy-Id: 14832
2018-03-16 11:13:03 +00:00
Henrik Levkowetz 428c451692 Added a missing tag to the sanitizer whitelist (telling lxml's Cleaner to not clean style with style=False is apparently not always enough). Fixes issue #2470.
- Legacy-Id: 14794
2018-03-14 18:52:11 +00:00
Henrik Levkowetz 02105889b6 Tweaked the mime type validator so it can be called also when there's no required mime types.
- Legacy-Id: 14779
2018-03-13 13:54:04 +00:00
Henrik Levkowetz 2b52919c5e Added sanitize_document() and replaced sanitize_html() with sanitize_fragment() in utils.html
- Legacy-Id: 14776
2018-03-13 13:21:41 +00:00
Henrik Levkowetz f3f77dce48 Changed order of arguments in a test assert for better error legibility.
- Legacy-Id: 14774
2018-03-13 12:38:53 +00:00
Henrik Levkowetz 724f1ceccc Added xmpp as an acceptable protocol in links when sanitizing.
- Legacy-Id: 14766
2018-03-12 13:17:41 +00:00
Henrik Levkowetz 3b7a191feb Removed a debug print statement
- Legacy-Id: 14753
2018-03-09 15:49:25 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz 2fd344f810 Tweaks to handle text types better and make set operation clearer.
- Legacy-Id: 14745
2018-03-07 21:10:47 +00:00
Henrik Levkowetz 802f201d81 Modified the sanitizer and upload handler to strip also the content of some tags, and to produce valid files (if the content is otherwise valid).
- Legacy-Id: 14744
2018-03-07 19:00:24 +00:00
Henrik Levkowetz 5964cdd880 Removed unused data.
- Legacy-Id: 14741
2018-03-07 08:24:43 +00:00
Henrik Levkowetz 2828683cee Replaced html sanitization code that called html5lib directly with calls to bleach, and upgraded the requirements to let us use the latest html5lib and bleach.
- Legacy-Id: 14739
2018-03-06 18:35:34 +00:00
Henrik Levkowetz b92ad2f992 Added sanitization of uploaded html content for session agendas and minutes, and did some refactoring of the upload form classes.
- Legacy-Id: 14738
2018-03-06 15:55:30 +00:00
Henrik Levkowetz 0800304b67 Added TeX escaping utility functions and template filters. Removed
html escaping and added TeX escaping for relevant parts of the bibtext
template.  Fixes issue #2459.
 - Legacy-Id: 14711
2018-02-27 18:15:21 +00:00
Henrik Levkowetz 9ffe1e425a Reverted unintentional commit
- Legacy-Id: 14709
2018-02-27 17:58:25 +00:00
Henrik Levkowetz a5db4d00de Updated PLAN
- Legacy-Id: 14708
2018-02-27 17:55:43 +00:00