Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes#2125.
- Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520. Commit ready for
merge.
- Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes#2218. Commit ready for
merge.
- Legacy-Id: 15382
Note: SVN reference [15347] has been migrated to Git commit dcabfc84f1
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522.
- Legacy-Id: 15378
Note: SVN reference [15344] has been migrated to Git commit 3c478e5c52
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes#2125. Commit ready for merge.
- Legacy-Id: 15354
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
Improvements to tests after converting to factories suggested by studying coverage_changes.
- Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
