Commit graph

93 commits

Author SHA1 Message Date
Henrik Levkowetz 5089651e17 Don't use EmptyQuerySet directly; return Class.objects.none() instead.
- Legacy-Id: 12013
2016-09-21 11:23:57 +00:00
Henrik Levkowetz 22b2953b18 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0, which provides secretariat support for managing draft submissions outside of the automated datatracker draft submission tool. In addition to making the secreatiat handling of draft submissions that come in by email or other paths easier, it also improves the datatracker submission and document history for these documents.
- Legacy-Id: 11959
2016-09-09 17:00:23 +00:00
Henrik Levkowetz 74f7c5782b Added some basic charting support, using highcharts, and charts showing new-revision timelines for document search results.
- Legacy-Id: 11927
2016-09-06 13:19:45 +00:00
Henrik Levkowetz b0906f04af Basic charting of new revision activity for document search results.
- Legacy-Id: 11922
2016-09-06 09:47:22 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz 63f5af7e4d Guard against use of nonexistant attribute.
- Legacy-Id: 11166
2016-05-05 14:09:07 +00:00
Robert Sparks f8a28077f5 Add page counts to doc.json. Fixes #1936. Commit ready for merge.
- Legacy-Id: 11122
2016-04-15 13:53:04 +00:00
Henrik Levkowetz c9cb6a6cee Merged in [11083] from stephen.farrell@cs.tcd.ie, with some tweaks:
Assigned default consensus for IETF stream documents, partly fixing #1403 - IRTF/IAB may want more, this just does IETF stream.
 - Legacy-Id: 11089
Note: SVN reference [11083] has been migrated to Git commit 9ca4e98d46
2016-04-03 17:56:33 +00:00
Stephen Farrell c93a31034b assigned default consensus for IETF stream documents partly fixing #1403 - IRTF/IAB may want more, this just does IETF stream. Commit ready to merge.
- Legacy-Id: 11073
2016-04-02 19:11:54 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com:
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
2016-01-15 21:59:49 +00:00
Henrik Levkowetz bce152b2b9 Rewrote crawl_history() to be easier to read (renaming multiple 'retval' variables and other naming tweaks) and made it return distinct revisions without the added uniqueness filtering round from /personal/lars/6.11.1.dev0@10604.
- Legacy-Id: 10639
2016-01-11 23:33:50 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once.
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
2015-12-22 21:42:55 +00:00
Lars Eggert cf4964059f Fix some issues Henrik found, and implement some of his suggestions:
* Fix ancestor stacking
* Suppress x-axis labels that overlap with others
* Make bars clickable links
 - Legacy-Id: 10590
2015-12-14 13:04:34 +00:00
Lars Eggert d4d09a2f75 Refactor graphical timeline, by making the data available via doc.json. Also
refactor associated js/css/html. Finally, a lot of display tweaks.
 - Legacy-Id: 10550
2015-12-08 14:29:35 +00:00
Lars Eggert 9728186ec4 Make revision history (via crawl_history) available in document templates. This
lays the foundation for graphical timelines.
 - Legacy-Id: 10542
2015-12-03 13:25:51 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks c39ebe4f56 checkpoint
- Legacy-Id: 10018
2015-08-13 22:42:39 +00:00
Robert Sparks 839d0f89ad checkpoint
- Legacy-Id: 10016
2015-08-13 19:41:02 +00:00
Robert Sparks 6c85bc558c checkpoint. Sets initial notify to empty
- Legacy-Id: 10009
2015-08-11 02:27:59 +00:00
Robert Sparks cd5b497acb Changed several email alias references from tools.ietf.org to ietf.org. Fixes #1759. Commit ready for merge.
- Legacy-Id: 9925
2015-07-30 22:13:59 +00:00
Robert Sparks 02a9da52a1 Manually moved the concepts forward. Reworked some presentation. Working enough to bring testers in at Sprint93
- Legacy-Id: 9717
2015-07-13 21:09:39 +00:00
Henrik Levkowetz 8365a36c2f Fixed an issue where the https: schema inadvertently had been included in RFCDIFF_PREFIX, causing duplicate schema specifications in some places. Changed name to RFCDIFF_BASE_URL and cleaned out the duplicate schema specifiers.
- Legacy-Id: 9593
2015-04-30 22:00:49 +00:00
Henrik Levkowetz 91739277f4 Merged in [9541] and [9542] from rjsparks@nostrum.com:
Quit putting the group email list address in the initially generated Notify field.
Updated the tests accordingly.
 - Legacy-Id: 9565
Note: SVN reference [9541] has been migrated to Git commit ecd69a1bcb

Note: SVN reference [9542] has been migrated to Git commit 99e351fe1c
2015-04-26 20:42:03 +00:00
Henrik Levkowetz acc2c59920 Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9556
2015-04-24 21:47:12 +00:00
Robert Sparks ecd69a1bcb Quit putting the group email list address in the initially generated Notify field
- Legacy-Id: 9541
2015-04-22 13:19:29 +00:00
Ole Laursen eccd8d27c4 Make new branch from trunk (r9007) and merge facelift-r8876 into it, fixing a few merge conflicts
- Legacy-Id: 9014
2015-02-06 14:08:34 +00:00
Henrik Levkowetz 58cc1e431f When draft email aliases are generated, the content of the doc.notify field is used to generate the .notify alias, and is also included in the .all alias. If the notify field contains either the .notify alias or the .all alias, this can create a mail loop. Changed the alias generation code to expand (or ignore, for .notify) aliases found in the notify field, and changed the code which fills in the notify field with a default value to insert the author, ad, and shepherd aliases instead of the .all alias.
- Legacy-Id: 8994
2015-02-05 15:38:01 +00:00
Robert Sparks 7e188d2d81 Fix needed-to-pas calculation to use new representation of area directors. Fixes #1587. Commit ready to merge
- Legacy-Id: 8922
2015-01-26 21:10:52 +00:00
Ole Laursen 543ac4ecb7 Summary: Add simple utility for turning rfc1234 doc alias names into RFC1234
- Legacy-Id: 8899
2015-01-23 16:45:26 +00:00
Henrik Levkowetz d4e5f070af Merged in [8293] from rjsparks@nostrum.com:\n XXX: Should what is now captured in the list of STATUSCHANGE_RELATIONS instead be captured in the database in name_docrelationshipname?
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes #1438
 - Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
2014-10-12 17:32:11 +00:00
Henrik Levkowetz 320051213e Merged in [8271] and [8292] from rjsparks@nostrum.com:
Send email when a the telechat date (or returning item bit) changes for a document.
Fixes #1452
 - Legacy-Id: 8383
Note: SVN reference [8271] has been migrated to Git commit 80fc0c7caa4feac2966722324e42a53cabe67a6b

Note: SVN reference [8292] has been migrated to Git commit 7c56f8bad35b6ed06f6c6eff7436c178209d4143
2014-10-12 17:07:45 +00:00
Henrik Levkowetz ec3e247732 Merged in [8262] and [8263] from rjsparks@nostrum.com:
Changes when returning_item is automatically set to match the
    current IESGs preferences.  Removes several chunks of dead code
    related to editing telechat dates.  Improves returning item tests.

    Refactored multiple edit_telechat functions into one function in
    doc_views.  Added a helper function for determining if ballots have
    changed to isolate the implementation.  Fixed the issue with
    update_agenda setting the returning item bit even when the user
    explicitly said not to.  Added prompting to encourage proper setting
    of the returning item bit to the edit_telechat view.

    Fixes #1209
 - Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1

Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
2014-09-28 19:57:01 +00:00
Henrik Levkowetz 8e0200abc9 Merged in [8238] from rjsparks@nostrum.com:\n Look in the right place in the filesystem for the files bits when building reference relations during submit. Fixes bug #1467.
- Legacy-Id: 8362
Note: SVN reference [8238] has been migrated to Git commit c6e22bc429e3c77fd2d5be6d78c20a0c90cbc80b
2014-09-28 18:32:00 +00:00
Timothy B. Terriberry e9c79a9e19 Allow IRTF chair to adopt a draft into any RG.
Fixes #1082.
Commit ready for merge.
 - Legacy-Id: 8143
2014-07-19 21:15:47 +00:00
Henrik Levkowetz 09f654b1f4 Merged in branch/iola/team-support from olau@iola.dk. This generalises and extends the group support for WGs and RGs so that also other groups, such as for instance the Edu Team, can have pages.
- Legacy-Id: 8013
2014-07-02 19:30:07 +00:00
Ole Laursen f9ee750afd Make it possible to adjust the name of new materials upon upload, also fix a couple of warnings from PyFlakes
- Legacy-Id: 7914
2014-06-13 12:30:42 +00:00
Ole Laursen 6e83335f0f Fix a bunch of mistakes found by PyFlakes in the new materials code
- Legacy-Id: 7839
2014-06-03 11:28:27 +00:00
Ole Laursen 2a1f902a67 Rewrite error handling in get_document_content to use a with statement
instead of finally
 - Legacy-Id: 7837
2014-06-03 10:42:33 +00:00
Robert Sparks 18bfe663d5 Corrected Document vs DocHistory mismatch when working with status-change documents. Corrected creation of BallotDocEvent timestamps. Fixes bug #1396. Commit ready for merge
- Legacy-Id: 7705
2014-05-06 20:32:27 +00:00
Henrik Levkowetz c50fccdb7e Merged in [7586] from rjsparks@nostrum.com:
Fixed calculation of needed ballots for status-change documents. Added needed ballots tests for drafts and status-change docs. Fixes bug 1116.
 - Legacy-Id: 7606
Note: SVN reference [7586] has been migrated to Git commit e30ba32c78cf324f5875fcce3f89ff7e27f8453c
2014-04-13 19:36:06 +00:00
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Henrik Levkowetz 8ff8056581 Merged [7383] from jmh@joelhalpern.com: fixes ticket #924
Changes counting logic in ballots to use actual number of ADs.
Causes ballot email to use utility to generate requirements text
 - Legacy-Id: 7404
Note: SVN reference [7383] has been migrated to Git commit 271c48c9c47bf63bee2289fad9224b624c388fba
2014-03-04 18:22:29 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Robert Sparks e309ff92b3 Don't insert references to self.
Move the data filler from a migration to a standalone script
 - Legacy-Id: 6620
2013-11-02 20:59:43 +00:00