Commit graph

12260 commits

Author SHA1 Message Date
Robert Sparks 4b1274c44d
fix: teach search about rfcs and subseries (#6431)
* fix: teach search about rfcs and subseries

* fix: more general manipulation of searches for rfc and subseries

* fix: only tweak subseries search if the thing after the subseries id is digits
2023-10-04 17:12:01 -03:00
Jennifer Richards 82c70a2d5d
Merge pull request #6374 from rjsparks/more_docalias_removal
fix: cleaner search_result_row diff links for recent drafts replacing other drafts
2023-09-26 22:24:17 -03:00
Robert Sparks 4ba62bf149
fix: put rfc history on left 2023-09-26 17:17:04 -05:00
Robert Sparks 1b32fde588
fix: cleaner sync test (#6372) 2023-09-26 17:11:10 -05:00
Robert Sparks 9e4166393d
fix: cleaner search_result_row diff links for recent drafts replacing other drafts 2023-09-25 15:39:48 -05:00
Robert Sparks 092e572e16
feat: move errata tags 2023-09-22 16:35:54 -05:00
Robert Sparks 8732dcb706
fix: bring tests up current. add subseries names to rfc view. fix html. 2023-09-22 12:40:15 -05:00
Robert Sparks 48cb06d20d
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious " 2023-09-21 16:38:41 -05:00
Robert Sparks 0390f1868f
feat: subseries 2023-09-21 12:54:17 -05:00
Jennifer Richards f15960d32d
Merge pull request #6328 from rjsparks/dochistory_rfcnumber
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 20:41:43 -03:00
Jennifer Richards f4629bc750
Merge pull request #6326 from rjsparks/email_expansions
fix: tune mailtrigger recipients and set relevant expansions for rfcs
2023-09-15 20:12:39 -03:00
Robert Sparks a39a058a01
fix: populate rfc_number on DocHistory with type_id rfc 2023-09-15 17:33:05 -05:00
Robert Sparks 88e66048da
fix: make Was link go to the right place. Remove unreachable code. 2023-09-15 16:49:21 -05:00
Robert Sparks bc177b08ea
chore: black 2023-09-15 16:15:47 -05:00
Robert Sparks edadd99044
fix: tune mailtrigger recipients and set relevant expansions for rfcs 2023-09-15 16:02:08 -05:00
Robert Sparks e0e647fa75
chore: repair merge damage 2023-09-15 13:59:19 -05:00
Robert Sparks 4811374014
chore: reorder migrations (#6325) 2023-09-15 13:10:19 -05:00
Robert Sparks 621528ad03
ci: Merge branch 'main' into feat/rfc 2023-09-15 11:48:44 -05:00
Lars Eggert 303ff70e64
fix: Linkify email address lists one-by-one (#6315)
* fix: Linkify email address lists one-by-one

Seems to work around a bug in mozilla/bleach.

Fixes #6307

* Cosmetic change

* Fix test
2023-09-15 10:45:58 -05:00
Jennifer Richards b635045aab
Merge pull request #6309 from rjsparks/crawl-fixes
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-15 11:55:27 -03:00
Robert Sparks 4ddf132efb
fix: remove leftover docalias detritus 2023-09-15 09:51:15 -05:00
Robert Sparks 20f427e013
chore: remove unused view (#6304)
* chore: remove unused view

* chore: deflake

* chore: deflake
2023-09-14 17:10:26 -05:00
Robert Sparks 536c1fb6fc
fix: missed docalias artifact removal. Better use of became_rfc. 2023-09-14 16:43:26 -05:00
Robert Sparks 42c4c275d2
fix: move fewer docevents 2023-09-14 12:07:09 -05:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418)
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Robert Sparks 92ea5a6a89
fix: correct cache variable assignment 2023-09-13 15:46:21 -05:00
Lars Eggert d3d2f0d35f
fix: Enable js functionality on sortable tables (#6301)
Fixes #6263

Also fix the non-js "untrack_document" page while I'm here.
2023-09-13 15:31:01 -05:00
Jennifer Richards 69fd3a059e
fix: Validate string before calling int() (#6268) 2023-09-13 15:29:16 -05:00
Robert Sparks a571151b03
fix: allow looking at slide revisions when the slides doc name starts with rfc 2023-09-13 14:17:27 -05:00
Robert Sparks ececc456ab
fix: repair broken html 2023-09-13 14:10:29 -05:00
Robert Sparks 3a733a36db
fix: memoize became_rfc. Address review comments. 2023-09-13 14:07:40 -05:00
Jennifer Richards 8bc4507def
feat: Give AD the action in ad-f-up doc state (#6272)
* refactor: Add helper class to compare tag changes

* feat: Give AD the action in ad-f-up state

* refactor: Remove unnecessary check

* refactor: Reorganize update_action_holders()

* refactor: Remove unnecessary guard

* test: Update test for new AD handling

* test: Update another test

* test: Test ad-f-up effect on action holders

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-12 09:44:33 -05:00
Robert Sparks bf50f88863
chore: remove debug 2023-09-12 09:37:13 -05:00
Robert Sparks a307e0616c
chore: Merge branch 'feat/rfc' into rfc_htmlized 2023-09-12 09:33:45 -05:00
Robert Sparks 0c85c4169d
fix: repairs to the timeline graphic 2023-09-12 09:23:01 -05:00
Robert Sparks 5bbea70cb0
fix: repair many revision related issues with the main and htmlized views 2023-09-12 08:55:38 -05:00
Robert Sparks be77cc9226
fix: correct missed replumbing of iprdisclosurebase 2023-09-12 08:54:11 -05:00
Robert Sparks 72d44d56c4
chore: black 2023-09-12 08:52:15 -05:00
Robert Sparks b58ddd7674
fix: move rfc dochistory objects to rfc document objects 2023-09-12 08:51:17 -05:00
Jennifer Richards 18a1af22f8
fix: Reject nul characters in ipr search parameters (#6292)
* fix: Reject nul characters in ipr search parameters

Really ought to rework this as a form, but in the meantime
this should prevent 500s. Could probably reduce the number
of places we check the value.

* fix: Guard against absent parameters

* fix: Remove stray junk

* fix: Use correct response code (400, not 405)

* test: Test handling of null chars in IPR search

* refactor: Simplify branch statements

This helps my code validator see that "start" is
always set.
2023-09-12 08:32:16 -05:00
Paul Selkirk febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6231)
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088)

* chore: Move PUBLISH_IPR_STATES from settings_local to settings

* fix: Add migration for removed_objfalse in IprEventTypeName

* fix: De-conflict migration

* fix: De-conflict migration

* style: Move PUBLISH_IPR_STATES ahead of not-production block
2023-09-11 13:14:46 -05:00
Robert Sparks 6b6c881353
fix: construct double-submit test correctly (#6168)
* fix: construct double-submit test correctly

* chore: remove unused import
2023-09-08 13:02:18 -05:00
Robert Sparks 7391ea7239
fix: rationalize document_rfc.html and the view driving it 2023-09-07 13:11:33 -05:00
Robert Sparks 7f074bf37f
fix: avoid redirects in mailarchive links (#6282) 2023-09-07 10:40:20 -05:00
Robert Sparks d0bac8913d
fix: use type instead of state in templates 2023-09-05 18:04:16 -05:00
Paul Selkirk cd56d43736
fix: Allow secretariat to change the state of a dead draft (#6253)
* fix: Allow secretariat to change the state of a dead draft (#6051)

* refactor: Move the secretariat-can-edit-dead-state enablement to the template to limit side-effects.

* style: Correct whitespace to fully revert file

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-05 12:58:56 -05:00
Lars Eggert fb4002dbbd
fix: Don't show deferred I-Ds in AD's missing ballot list (#6162)
* fix: Don't show deferred I-Ds in AD's missing ballot list

Fixes #6152

* Address code review comments
2023-09-05 12:16:33 -05:00
Robert Sparks e0f27b9d52
ci: merge branch 'main' into feat/rfc 2023-09-05 12:02:07 -05:00
Robert Sparks 3c1fc3c0f9
chore: use factory-boy 3.3 (#6269) 2023-09-05 09:54:30 -05:00
Robert Sparks 87f0781ff3
chore: make some old things kept for documentation a little safer (#6260)
* chore: make some old things kept for documentation a little safer

* fix: sh syntax
2023-09-01 14:34:49 -05:00