Commit graph

12112 commits

Author SHA1 Message Date
Robert Sparks d6186af2cc
Merge branch 'main' into feat/rfc 2023-07-20 09:35:58 -05:00
Robert Sparks c8684f727a
Merge branch 'main' into related_no_alias 2023-07-20 09:31:52 -05:00
Robert Sparks 81734443a5
fix: continued repair of code/tests re: RelatedDocument model change 2023-07-20 09:25:14 -05:00
Robert Sparks f52d0ddcf8
test: verify newsubmissiondocevent count by day is correct (#6000) 2023-07-20 08:53:23 -05:00
Jennifer Richards ba356397c0
fix: Specify UTC for TruncDate (#5996) 2023-07-20 08:29:30 -05:00
Robert Sparks 59c0a1f7f9
chore: repair merge damage 2023-07-19 18:09:23 -05:00
Robert Sparks cf3a270cd2
Merge branch 'feat/rfc' into related_no_alias 2023-07-19 17:48:22 -05:00
Lars Eggert d8c0ae5faf
fix: Add numeric localhost addresses to CSRF_TRUSTED_ORIGINS (#5989) 2023-07-19 09:55:22 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858)
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
2023-07-18 12:22:28 -05:00
Paul Selkirk 3f228c788d
feat: Add totals to nominee feedback page (#5977)
* feat: Add totals to nominee feedback page (#4727)

* test: Add a unit test for feedback totals

Also remember to wrap the totals in a <tr> tag.
2023-07-18 09:17:06 -05:00
Lars Eggert bd9d3285b5
fix: #timeline -> #doc-timeline (#5985)
Fixes #5923
2023-07-18 09:01:43 -05:00
Lars Eggert 57843d8538
fix: Import fix from 7a946424c1 (#5984) 2023-07-18 08:58:22 -05:00
Paul Selkirk 0693a4357d
feat: Add "generate email" to action on nominees page (#4893) (#5959)
* feat: Add "generate email" to action on nominees page (#4893)

* fix: Use bare email address for now
2023-07-17 16:00:16 -05:00
Jennifer Richards 9bf0063f11
fix: Preserve Document.time when migrating rfcs (#5954) 2023-07-12 11:02:12 -05:00
Robert Sparks 3fe1fcf122
fix: send the whole txt submission to te DraftParser (#5956) 2023-07-12 08:58:08 -05:00
Jennifer Richards 7d5b1767f5
fix: Fix display of RFCs in search_result_row.html
n.b., dropped the "(was draft...)" suffix for now - need to revive
that or commit to removing it.
2023-07-11 16:35:25 -03:00
Jennifer Richards e42ac40ec4
fix: Use (rfc, published) state for RFC SearchRules 2023-07-11 16:16:05 -03:00
Jennifer Richards 5385760f2a
chore: Migrate SearchRules for the rfc state 2023-07-11 16:14:49 -03:00
Jennifer Richards 71270621b7
chore: Track RFCs if they were tracked as a draft 2023-07-11 11:59:39 -03:00
Robert Sparks 6305555480
chore: address pyflake issues 2023-07-10 14:41:45 -05:00
Robert Sparks b2ebad11d5
fix: repaired rfcdiff api endpoint 2023-07-10 12:56:06 -05:00
Robert Sparks 35ba49f5cc
test: cleanup use of factory 2023-07-08 13:20:17 -05:00
Robert Sparks 63c809a20b
test: adjust secr tests 2023-07-08 12:42:21 -05:00
Robert Sparks 16b1583e33
test: adjust iesg tests 2023-07-08 09:58:45 -05:00
Robert Sparks b8febcb7a3
test: adjusted fuzzy_find_document_rfc test 2023-07-08 09:42:52 -05:00
Robert Sparks 0b9d450a3e
test: adjust status change test to reflect rfc target 2023-07-07 17:55:50 -05:00
Robert Sparks c980649c32
chore: remove unintended commit of temporary skip 2023-07-07 17:49:55 -05:00
Robert Sparks f0a32edec6
chore: note odd placement of code 2023-07-07 17:48:21 -05:00
Robert Sparks d4f5bc6707
fix: make factory name derivation better. Adjust status_change test 2023-07-07 17:48:00 -05:00
Robert Sparks 2c6fe0383c
fix: adjust gating of review requests 2023-07-07 17:31:24 -05:00
Robert Sparks ffb11fd0c1
fix: downref form validation 2023-07-07 17:15:39 -05:00
Robert Sparks 09f0710e77
test: correct use of factories for downref tests 2023-07-07 17:02:16 -05:00
Robert Sparks 632293d369
fix: repaired RelatedDocument is_downref and is_approved_downref methods 2023-07-07 16:14:18 -05:00
Robert Sparks bbef89140e
fix: removed notion of submitting RFCs from find_submission_filenames 2023-07-07 15:41:38 -05:00
Jennifer Richards 8267f4b452
test: Fix typo in names.json (#5939) 2023-07-07 15:10:47 -05:00
Robert Sparks 457b95094a
fix: improvements to submit form validation 2023-07-07 15:08:41 -05:00
Robert Sparks ff058e3c63
test: repair draft_group_link test 2023-07-07 14:03:16 -05:00
Robert Sparks d3f1794fd4
chore: apply black to GenerateDraftAliasesTests 2023-07-07 13:53:37 -05:00
Robert Sparks 78b6f06519
fix: repair generate_draft_aliases 2023-07-07 13:47:50 -05:00
Robert Sparks 11ec3685c4
fix: repaired idnits2_state 2023-07-07 13:10:52 -05:00
Robert Sparks e6a1a17973
fix: typo/logic error in get_base_name 2023-07-07 12:56:23 -05:00
Robert Sparks f30613973c
test: repair pdfized tests 2023-07-07 12:32:48 -05:00
Robert Sparks 06e711288a
test: adjusted RawIdTests 2023-07-07 11:31:11 -05:00
Robert Sparks 8b1fcfdbdd
fix: repair views_search.index_all_drafts 2023-07-07 11:22:44 -05:00
Robert Sparks 6eeffb116f
fix: become agnostic about RFC states until we care 2023-07-07 10:33:29 -05:00
Robert Sparks f7d9e49731
test: pass a correct type 2023-07-07 10:30:57 -05:00
Jennifer Richards 117e07e5ff
Merge pull request #5935 from rjsparks/fixups3
fix: repair various doc view and tests
2023-07-07 11:47:13 -03:00
Robert Sparks 285b11a053
fix: better use of factory 2023-07-07 09:32:29 -05:00
Paul Selkirk bae204862d
feat: Add bibxml button to document info page (#5921)
* feat: Add bibxml button to document info page (#5908)

* fix: No bibxml for RFCs
2023-07-07 08:23:15 -05:00
Robert Sparks a3c87a1945
fix: repaired rfc_feed 2023-07-06 17:43:40 -05:00
Robert Sparks 3486f38421
fix: adjust (useless) assertion in status_change test to reflect that the relevant relation points to an RFC 2023-07-06 17:31:11 -05:00
Robert Sparks 799d3a1a3e
fix: adjusted bibtex view and tests 2023-07-06 17:24:05 -05:00
Robert Sparks 400280e50c
fix: repair test_history_bis_00 2023-07-06 16:05:10 -05:00
Jennifer Richards fc284be6d8
fix: Deal with rfc doc types for references/referenced_by views 2023-07-06 17:44:32 -03:00
Jennifer Richards 9f1b05a518
chore: Move/copy RelatedDocuments to rfcs 2023-07-06 17:44:28 -03:00
Jennifer Richards 563b5a9fe2
chore: Migrate RelatedDocuments for RFCs 2023-07-06 17:44:24 -03:00
Robert Sparks f53a849660
fix: various corrections to rfc main document view and tests (#5931) 2023-07-06 17:24:35 -03:00
Robert Sparks 63a9920685
fix: restored where an rfc came from to the main rfc view (#5930) 2023-07-06 15:11:26 -03:00
Jennifer Richards 8f0b459050
refactor: Replace is_rfc() tests (#5925)
* refactor: Remove is_rfc() - test type_id instead

* fix: Guard against unknown pub_date

This should not ever come up - we have a published_rfc event for
every rfc. Should investigate fixing pub_date() to always return a val.
2023-07-06 12:07:53 -03:00
Jennifer Richards 5d9d87897d
fix: Show rfc documents via document_main view (#5919)
* fix: Fix friendly_state() for drafts in rfc state

* refactor: Change became-rfc to became_rfc for consistency

* refactor: Begin handling RFCs separatly in document_main

WIP

* chore: Hide reviews and conflict reviews for RFCs

* chore: Remove irrelevant fields from rfc doc view

* chore: Remove unused variables

* chore: Remove "Versions" field from document_rfc.html

* chore: Hide "Nits" button for RFC documents
2023-07-05 17:30:20 -03:00
Jennifer Richards 09f347727b
chore: Remove temporary pin on pydantic (#5911)
* chore: Remove temporary pin on pydantic

* test: Guarantee ordering of sessions in test

Should fix an intermittent test failure.
2023-07-05 08:50:50 -05:00
Jennifer Richards 60dc60234d
fix: Better match xml2rfc date parsing (#5914)
* refactor: Split up get_creation_date to ease testing

* test: Add tests of parse_creation_date()

Note change in expected output when date_elt is None:
instead of returning None, this expects today's date.

* fix: Return today instead of None when date is absent

* fix: Handle empty string for day attribute

* test: Check a couple more parse_creation_date cases

* fix: Revert to returning None when date elt is absent

* style: black
2023-07-05 08:23:37 -05:00
Jennifer Richards d87ffb6912
Merge pull request #5912 from ietf-tools/main
chore: Merge main into feat/rfc
2023-07-04 12:09:46 -03:00
Robert Sparks db670dadc5
chore: continued refactor 2023-06-30 17:27:27 -05:00
Jennifer Richards 771296bbe6
feat: Link rfc/draft document history pages (#5894)
* fix: Do not show "rev" column for rfc document history

* style: Reformat document_history() using Black

* refactor: Use "is not None" instead of "!= None"

* refactor: Convert dict() to dict literal

* fix: Migrate group, stream, and ad from draft to rfc Document

* feat: Link rfc/draft history pages
2023-06-28 17:51:31 -03:00
Jennifer Richards bff145f975
fix: Create relationships between draft and rfc Documents (#5890)
* fix: Create RelatedDocument between draft and rfc Documents

* chore: Improve comment

* refactor: Clarify migration
2023-06-28 11:41:08 -03:00
Jennifer Richards 877bc02d77
refactor: Refactor build_file_urls() (#5886) 2023-06-27 11:14:19 -03:00
Robert Sparks e910836ad4
fix: teach build_file_urls about rfc type documents. (#5880) 2023-06-26 21:33:02 -03:00
Jennifer Richards 1db267dd7d
fix: Set has_onsite_tool correctly in no_session() view (#5879)
This will prevent a session that was changed from "notmeet" to
 being scheduled from having its has_onsite_tool flag left as False
2023-06-26 16:10:51 -05:00
Paul Selkirk 98bf7afeab
feat: Display and bulk-edit nomcom position flags (#4681) (#5878)
This adds a table to show the state of all nomcom positions, and lets the
chair set or un-set multiple state flags at the same time.

As a consequence, it moves the email templates to the "Edit position" form.
2023-06-26 16:10:05 -05:00
Robert Sparks 75d199fe31
chore: correct merge errors 2023-06-26 13:14:31 -05:00
Robert Sparks ad0071fd7d
chore: merge feat/rfc 2023-06-26 13:12:15 -05:00
Robert Sparks 69f882d833
chore: tweaks for rebuild_reference_relations 2023-06-26 13:03:59 -05:00
Jennifer Richards 106c67ec95
feat: Migrate docevents onto rfc documents (#5872)
* refactor: Separately migrate DocAliases to rfc Documents

The gap in numbering is intentional, another migration will be along
shortly.

* feat: Migrate docevents onto rfc documents

* chore: Refining DocEvent migration (WIP)

* chore: Move IANA Action state change docevents to rfc docs

* chore: Fix typo

* refactor: Eliminate "created" rfc state

* chore: Leave "ballot set" comments on drafts
2023-06-23 17:16:04 -03:00
Lars Eggert f250a653a2
fix: Remove IESG-related about tabs from non-IETF-stream docs (#5515)
* fix: Remove IESG-related about tabs from non-IETF-stream docs

Fixes #5514

* Fix code review comments

* Address review comments

* Address code review comments
2023-06-22 10:35:59 -05:00
Paul Selkirk 53b5e23612
fix: Be a little clearer when feedback is closed (or not yet open). (#5861) 2023-06-22 08:13:32 -05:00
Jennifer Richards 0144ee991e
fix: Include time zone information in v1 api datetimes (#5851)
* fix: Include time zone information in v1 api datetimes

* fix: Use Z suffix instead of offset in API datetimes
2023-06-21 11:43:19 -05:00
Jennifer Richards f2c2957925
refactor: Represent RFCs as their own DocType (#5835)
* feat: Add RFC DocTypeName, StateType, and States

* refactor: Rename rfc_number() to deprecated_rfc_number()

* feat: Add rfc_number field to DocInfo

* feat: Add DocRelationshipName "became-rfc"

* chore: First-pass migration to create rfc Documents

* chore: create_rfc_documents migration depends on new names

* refactor: Rename variable

* fix: Fix revname / downcase name for "became-rfc" DocRelationshipName

* chore: Remove debugging print statements

* feat: Point rfc aliases at rfc Documents

* test: Refactor RFC factories

* refactor: Rewrite is_rfc() in terms of type_id

* test: Use RfcFactory as base for IndividualRfcFactory

* refactor: Replace calls to deprecated_rfc_number()

* refactor: Remove deprecated_rfc_number() method

* test: Import WgRfcFactory
2023-06-20 15:28:16 -03:00
Lars Eggert a6cc12c14b
fix: Don't (re)sort obsoleted/updated info (#5391)
* fix: Don't (re)sort obsoleted/updated info

Rebased against feat/postgres

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Fix review comments

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-06-20 12:07:45 -05:00
Robert Sparks 8ff14419c2
chore: continued refactoring 2023-06-16 16:59:20 -05:00
Robert Sparks 3c016cc5c8
feat: v3-era aware feed for rfcs (#5828)
* feat: v3-era aware feed for rfcs

* chore: remove obviated comment

* test: improve rfc feed tests
2023-06-16 15:52:42 -05:00
Robert Sparks ac65232115
fix: improve when Message objects are created (#5836)
* fix: improve when Message objects are created

* test: further improve feedback test

* fix: improve and test another form

* test: Restructure test infrastructure
2023-06-16 15:51:31 -05:00
Robert Sparks d6f58b3e67
chore: use more expressive related_name 2023-06-16 15:26:52 -05:00
Robert Sparks f3566c2743
chore: include (nontrivial) migrations 2023-06-16 15:07:51 -05:00
Robert Sparks 769d85a6c4
chore: explore architecture change in RelatedDocument 2023-06-16 14:58:42 -05:00
Robert Sparks 7798ea8d66
Merge remote-tracking branch 'ietf-tools/main' into feat/rfc 2023-06-15 16:07:42 -05:00
Jennifer Richards f04d356834
fix: Do not cache official_timeslotassignment when None (#5830) 2023-06-15 09:27:31 -05:00
Jennifer Richards 6f361f9574
chore: Keep default CSRF_TRUSTED_ORIGINS when in debug mode (#5827) 2023-06-15 09:04:43 -05:00
Lars Eggert 01e2d8b2bf
fix: Don't resort a table if sort query argument is present (#5825)
* fix: Don't resort a table if sort query argument is present

Fixes #5686

* Address code review comments
2023-06-15 08:56:27 -05:00
Lars Eggert fd09e60369
fix: RFC9389 obsoleted RFC8989 (#5822)
Fixes #5820
2023-06-14 12:35:07 -05:00
Lars Eggert 55f481ff74
fix: Also point to IETF web page for liaison relationships (#5823)
Fixes #5780
2023-06-14 12:34:46 -05:00
Lars Eggert a3d9cf3723
fix: Make attendee table sortable (#5824)
Fixes #5606
2023-06-14 12:34:27 -05:00
Jennifer Richards c8dcda0fae
refactor: Do not use canonical_name() for charters (#5818)
* fix: Enforce naming of charter docs in submit()

* style: Reformat submit() with Black

* refactor: Remove redundant check of charter name

* style: Reformat charter_with_milestones_txt with Black

* refactor: Drop canonical_name, use Path in charter_with_milestones_txt

* style: Reformat review_announcement_text() with Black

* style: Reformat action_announcement_text() with Black

* refactor: Change uses of charter.canonical_name() to charter.name

* refactor: Skip docialias when retrieving charter

* refactor: Change canonical_name() to name in utils_charter.py

* refactor: Use Path in read_charter_text()

* refactor: Drop canonical_name, minor refactor of tests_charter.py

* refactor: charter.name instead of canonical_name in milestones.py

* refactor: charter.name instead of canonical_name in tests_info.py

* refactor: Remove unused functions in ietf/secr/utils/groups.py

* refactor: charter.canonical_name -> charter.name in templates

* refactor: Remove charter handling from canonical_name

Temporarily raise an exception for testing

* refactor: Refactor get_charter_text() without canonical_name

* refactor: Remove raise when canonical_name called on a charter

* fix: Add back missing ".txt" extension

* test: Test rejection of invalid charter names
2023-06-14 08:32:21 -05:00
Robert Sparks 518aedb0f0
chore: remove already run single-use management command (#5815) 2023-06-13 15:53:36 -05:00
Robert Sparks a3db61cf69
Merge pull request #5795 from rjsparks/markdowncharters
feat: render charters on about page using markdown
2023-06-13 12:22:51 -05:00
Jennifer Richards f5365b2229
test: Fix test_meetings_misc_session_edit (#5807) 2023-06-12 15:55:46 -05:00
Jennifer Richards 2bf7e8250c
fix: Import DEFAULT_TIMEOUT correctly (#5803) 2023-06-12 13:50:14 -05:00
Jennifer Richards 12f1ac10ad
fix: Fix signature for LenientMemcacheCache.set() (#5800) 2023-06-12 12:48:32 -05:00
Robert Sparks b75b560dea
feat: import IAB minutes from the IAB wordpress site (#5689)
* feat: import IAB minutes from the IAB wordpress site

Work in Progress

* fix: refactor as management commands

* fix: use datetime.timezone.utc for comparisons

* fix: coerce an argument. Command now runs

* chore: extend queryset in a better way

* fix: fetch kesara's repo and move files into place.

* fix: add a DocEvent explaining where the Documents came from

* fix: small optimizations and typo fixes

* fix: performance compromise for very old meetings

* fix: ensure variable is initialized

* fix: avoid operating on null by changing method signature - address review comments

* fix: repair html typo and address pyflake complaint

* chore: run black on a new and changed things
2023-06-09 17:07:31 -05:00
Robert Sparks c3da3088fb
feat: render charters on about page uring markdown 2023-06-09 16:57:41 -05:00