altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
10908 commits 1 branch 0 tags 2.6 GiB
Commit graph

79 commits

Author SHA1 Message Date
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability. 
- Legacy-Id: 16181
 2019-05-02 12:38:41 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz d698eb98df Changed the on-behalf-of name template from 'On behalf of ...' to '... via Datatracker' to make name come first. 
- Legacy-Id: 16009
 2019-03-07 14:42:11 +00:00
Henrik Levkowetz d57088b1f3 Modified one call and one exception point related to on_behalf_of() use for email sending. 
- Legacy-Id: 16008
 2019-03-06 19:13:15 +00:00
Henrik Levkowetz 8a669909bc Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue. 
- Legacy-Id: 16007
 2019-03-06 16:57:00 +00:00
Henrik Levkowetz 5c6ab60f85 Changed a log() call to use unicode string interpolation to handle unicode email address names. 
- Legacy-Id: 15999
 2019-03-05 17:29:43 +00:00
Henrik Levkowetz 46bb4539c5 Added two new functions to replace email From: of users with On-behalf-of addresses, with associated values in settings. Added a catchall stanza in the mail sending pipeline to catch anything not already changed to On-behalf-of addresses. 
- Legacy-Id: 15987
 2019-03-04 20:06:44 +00:00
Henrik Levkowetz e024cca8c4 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 20:32:42 +00:00
Henrik Levkowetz d0b73e9b67 Tweaked the mail sending routines' handling of the copy flag. 
- Legacy-Id: 15586
 2018-10-16 15:05:17 +00:00
Henrik Levkowetz e20e8b7df5 Changed the mail sending routines so it's possible to not copy the debug archive on some messages. 
- Legacy-Id: 15585
 2018-10-16 14:32:10 +00:00
Henrik Levkowetz 0e52b30e5b Added the message-id to log lines for sent messages 
- Legacy-Id: 15582
 2018-10-15 18:46:45 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Robert Sparks 25e9893a13 Changed how the mail utilities handle lists in their override and extra arguments. Added a test for send_mail_preformatted exercising override and extra. Commit ready for merge. 
- Legacy-Id: 15153
 2018-05-22 15:38:04 +00:00
Henrik Levkowetz a18cf20868 Removed code which has been marked as unreachable since February/March 2017 without triggering any usage indications. 
- Legacy-Id: 13667
 2017-06-17 17:54:40 +00:00
Henrik Levkowetz fb93a8c293 Added dates to unreachable() calls, to make it easier to decide when to remove marked code. 
- Legacy-Id: 13538
 2017-06-06 07:27:07 +00:00
Henrik Levkowetz bb5096da8a Added more email validation for draft submission author emails, and blocked some baths that could lead to bad email addresses ('none') being set as document author email addresses. 
- Legacy-Id: 13010
 2017-03-14 14:07:21 +00:00
Henrik Levkowetz 3c6f00869f Dead code removal: meeting models and test_utils. 
- Legacy-Id: 12965
 2017-03-04 05:19:39 +00:00
Henrik Levkowetz 49ba774ae3 Updated unreachable() marking. 
- Legacy-Id: 12962
 2017-03-04 05:14:51 +00:00
Henrik Levkowetz 3a21e03f8d Marked a function as unrachable. Added support in send_mail_message for the Message.msgid field. 
- Legacy-Id: 12954
 2017-03-03 15:43:43 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017. 
- Legacy-Id: 12896
 2017-02-21 19:17:10 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921 
- Legacy-Id: 12129
 2016-10-13 16:38:47 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking). 
- Legacy-Id: 11941
 2016-09-08 14:48:59 +00:00
Henrik Levkowetz 22e2b0ab88 Added a return value used by ietf.middleware.SMTPExceptionMiddleware.process_exception(). 
- Legacy-Id: 11940
 2016-09-08 09:37:22 +00:00
Ole Laursen b790781de9 Add return statements to remaining email sending function so it's 
possibly to get the message back. We need the message and its
Message-ID in the review tracking code, to be able to link to it in
the mail archive.
 - Legacy-Id: 11359
 2016-06-14 09:54:37 +00:00
Robert Sparks 214b81991e Further tweaks to rendering messages from the messaging framework. Commit ready for merge. 
- Legacy-Id: 10809
 2016-02-09 19:56:26 +00:00
Robert Sparks c3e81c179b Some tweaks to handle rendering django messaging framework messages a little better. Commit ready to merge. 
- Legacy-Id: 10804
 2016-02-08 22:09:50 +00:00
Robert Sparks 85cfe0ed8a Show leadership when and where mail was sent at the time it is sent. Commit ready for merge. 
- Legacy-Id: 9608
 2015-05-07 16:29:17 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9028
 2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir). 
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
 2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9026
 2015-02-08 19:16:46 +00:00
Henrik Levkowetz 970059617e Added back a general setting (removed from the Django framework in 1.7) to avoid base64-encoding of UTF-8 email messages. 
- Legacy-Id: 9012
 2015-02-06 12:33:24 +00:00
Robert Sparks 4988d9378c Avoid an issue with python.email breaking To header field values that it has to encode in bad places. Fixes #1589. Commit ready for merge. 
- Legacy-Id: 8961
 2015-02-03 20:18:27 +00:00
Robert Sparks 5ca9581072 Reworked smtp error warning and logging to not use hard-to-read context_managers. Fixes bug #1390. Commit ready to merge. 
- Legacy-Id: 8584
 2014-11-04 19:49:22 +00:00
Henrik Levkowetz 4cc4f5080c Merged in [8254] from rjsparks@nostrum.com:\n Don't send mail to unknown-email-* addresses. Fixes bug #1471. 
- Legacy-Id: 8365
Note: SVN reference [8254] has been migrated to Git commit f7f29a62588eac9b2aaf26cd0401a910fa48403f
 2014-09-28 18:51:21 +00:00
Henrik Levkowetz f00f589e66 Renamed a very specialized function from email_secretariat() to email_iesg_secretary_re_charter(). 
- Legacy-Id: 7923
 2014-06-17 16:31:12 +00:00
Robert Sparks 393422b36b Improves the robustness of the SMTP error handling utilities. Fixes bug #1409. Commit ready for merge. 
- Legacy-Id: 7766
 2014-05-22 01:28:33 +00:00
Robert Sparks bf4f3ad75f Made several changes to better handle non-ascii UTF-8 in email messages. 
Used multipart mime when including the original message in an error message to the secretariat.
Modified the way IANA review email is parsed.
Added non-ascii UTF-8 tests to the IANA review email parser and to the SMTP Exception handling code.

Commit ready for merge.
 - Legacy-Id: 7673
 2014-04-29 18:45:37 +00:00
Henrik Levkowetz 4b6ca22ff7 Merged in [7635] from rjsparks@nostrum.com: 
Replumbed how SMTP Exceptions are handled, which involved refactoring several mail functions
 - Legacy-Id: 7637
Note: SVN reference [7635] has been migrated to Git commit 73b0831b57
 2014-04-24 22:14:57 +00:00
Robert Sparks 73b0831b57 Replumbed how SMTP Exceptions are handled, which involved refactoring several mail functions 
- Legacy-Id: 7635
 2014-04-24 18:29:01 +00:00
Henrik Levkowetz fe5d53fc40 Merged in [7591] from rjsparks@nostrum.com: 
Adds a real (if simple) SMTP server to the test framework and tests handling of exceptions and rejected addresses. Fixes ticket #1314.
 - Legacy-Id: 7613
Note: SVN reference [7591] has been migrated to Git commit 54919f01343995ab154d27dcfaf7a60b15dd5eee
 2014-04-16 19:40:57 +00:00
Henrik Levkowetz af4c6e253c Exclude empty email addresses from the send list. 
- Legacy-Id: 7552
 2014-03-27 22:09:37 +00:00
Henrik Levkowetz 49edc7404e Made ietf/utils pyflakes-clean. 
- Legacy-Id: 7496
 2014-03-16 07:26:03 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules. 
- Legacy-Id: 7495
 2014-03-16 07:09:38 +00:00
Henrik Levkowetz b91524fabc Merged [7368] from rjsparks@nostrum.com: Improves the detail in the messages sent when creating tickets about failed sent email. 
Changes a locally defined exception name to look less like one already defined in smtplib.
This is related to ticket #1208.
 - Legacy-Id: 7382
Note: SVN reference [7368] has been migrated to Git commit 08f13239c9beb6dcb0be978e800b82c4104b61e7
 2014-03-01 18:13:43 +00:00
Henrik Levkowetz 9ea9ba1d66 Merged in [7138] from rjsparks@nostrum.com: 
Reworked SMTP Exception handling, adding sending a ticket to the secretariat when there are errors handing messages off for delivery.
Added SMTP exception handling to send-scheduled-mail.
This is related to ticket #1208
 - Legacy-Id: 7256
Note: SVN reference [7138] has been migrated to Git commit 64727c1c33
 2014-02-17 18:55:37 +00:00
Ole Laursen e98abbf56d Change the port accepted for debug purposes to 2025 instead of 1025 to 
not conflict with the port on the live server
 - Legacy-Id: 6715
 2013-11-15 13:55:10 +00:00
Ole Laursen fd01ddd215 Make the mail code detect USING_DEBUG_EMAIL_SERVER which if set to 
true and EMAIL_HOST and EMAIL_PORT is set to localhost:1025 will turn
on debugging which essentially makes it send emails; also added
instructions for starting the debugging SMTP server bundled with
Python

  python -m smtpd -n -c DebuggingServer localhost:1025

in a comment near the code
 - Legacy-Id: 6713
 2013-11-15 12:57:31 +00:00
Henrik Levkowetz ed020c8b8e Add Auto-Submitted and Precedence header fields to outgoing email messages. 
- Legacy-Id: 6071
 2013-08-17 15:33:56 +00:00