* fix: use DST-friendly tz calculation for TimeSlot end times
Around DST changes, localize(time + duration).astimezone() is not
the same as localize(time).astimezone() + duration. The latter allows
tz-aware times to do their magic and give correct clock times.
* fix: refactor/correct calculation of week-view event start/end times
There were bugs in the timestamp calculations around DST switchover.
This corrects those and tries to clarify and improve documentation in
the relevant code.
* Unicode messages are triggered by both db content and tests
* Make ids unique
* Avoid "No value found" message on page
* Strip HTML from history entries, it's often broken
* Check HTML sources for occurrences of "** No value found for" and fix them
* Fix another occurrence of "** No value found for"
* Fix more occurrences of "** No value found for"
* Fix document revision stripping
* Force breaks of long (garbage) words
* Check URL validity before urlizing them
* Handle some additional corner cases
* Linkify action items
* Don't create profile/email links for System
* Handle headings with HTML elements in them better
* Fix comment
* Fix another occurrence of "** No value found for"
* Better I-D URLization that handles more edge cases. Also, test for them.
* Remove print
* Handle charters better
* Cache for one day
* Update vnu.jar
* Fix py2 -> py3 issue
* Run pyupgrade
* test: Add default-jdk to images
* test: Add option to also validate HTML with vnu.jar
Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.
* fix: Stop the urlizer from urlizing in linkified mailto: text
* More HTML fixes
* More HTML validation fixes
* And more HTML fixes
* Fix floating badge
* Ignore unicode errors
* Only URLize docs that are existing
* Final fixes
* Don't URLize everything during test-crawl
* Feed HTML into vnu using python rather than Java to speed things up
* Allow test-crawl to start vnu on a different port
* Increase retry count to vnu. Restore batch size to 30.
* More HTML validation fixes
* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky
* Undo commit of unmodified file
* Also urlize ftp links
* Fix matching of file name
* More HTML fixes
* Add `is_valid_url` filter
* weekday -> data-weekday
* urlencode URLs
* Add and use vnu_fmt_message. Bump vnu max buffer.
* Simplify doc_exists
* Don't add tab link to mail archive if the URL is invalid
* Run urlize_ietf_docs before linkify
Reduces the possibility of generating incorrect HTML
* Undo superfluous change
* Runner fixes
* Consolidate vnu message filtering into vnu_filter_message
* Correctly handle multiple persons with same name
* Minimze diff
* Fix HTML nits
* Print source snippet in vnu_fmt_message
* Only escape if there is something to escape
* Fix snippet
* Skip crufty old IPR declarations
* Only include modal when needed. Add handles.
* Fix wordwrap+linkification
* Update ietf/doc/templatetags/ietf_filters.py
* Update ietf/doc/templatetags/tests_ietf_filters.py
* Don't right-align second column
* feat: Make the "report a bug" links more visible
Also rework the page footer somewhat, while we're here.
* Revert empty change
Co-authored-by: Nicolas Giard <github@ngpixel.com>
* fix: Correctly linkify all current TLDs
* Pass a list to the build_*_re functions, not a string
* Need to sort TLDs by length to force longer ones to match first
* chore: silence incorrect mypy complaint.
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
* test: add tests of the person_link tag
* fix: do not prematurely dereference status change RelatedDocuments
The urlize_related_source_list template tag expects the RelatedDocument
instances, not the source Document.
* test: add test cases for status changes on document_main view
They seem to be one of the only bs5 elements that do not by default wrap, which
causes display issues on narrow screens when there are lots of page elements,
e.g., on http://127.0.0.1:8000/doc/draft-ietf-ipwave-vehicular-networking/
Adding `flex-wrap` (per https://github.com/twbs/bootstrap/issues/23504) makes
this better, but unfortunately doesn't fix it completely, because the layout
still jumps when the window is narrowed by the used. It does fix the issue on
first load and after a reload though.
Also rewrites scroll_to_element() using javascript. This seems to be less flaky
than the ActionChains implementation. Slight change in behavior - now scrolls
the requested element to the middle of the window instead of barely into view.
The old code would first substitute the "rfx<nnnn>" part, and then again
on the full draft name. This now only ever applies one substitute,
and does longer ones first.
* fix: Remove extra whitespace around parentheses
* fix: Make heading capitalization consistent, colorize a "No"
* fix: Pagination element, spacing, replace text with icon
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
* fix: align nav links to top of RH panel
* fix: allow timezone picker to wrap
* fix: improve RH panel behavior at small viewport sizes
* drop card styling
* use `btn-group-sm` for compact timezone picker
* limit overall height of #righthand-panel
* remove redundant CSS merge artifact
This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
* style: reformat manage-review-requests.js as StandardJS style
* refactor: use switch statement instead of if/else-if/else
* style: remove needless line break
* fix: fix jquery selectors to be less fragile and easier to read
* fix: clean up bs5 HTML/CSS for review request buttons
* fix: show "Edit materials" button for all groups for a secretariat user
Fixes ietf-tools#3763
* fix: show "import minutes" button to import initial revision
* test: validate that import session minutes buttons are shown
* test: validate that "Edit materials" links are shown
* fix: More fixes for narrow screens
Need to keep checking for issues, there are more.
* Make columns more narrow on narrow screens
* More fixes
* More fixes
* Test fixes
* Fix more tests
* Close tbody
* ci: Also check generated HTML with the "vnu" validator
Because HTML Tidy apparently misses a bunch of errors.
* thead -> tbody
* More fixes
* More fixes
* Start checker in test runner
Fixes issue #3545
Conditionally tests if the approver is AnonymousUser, in which case
System is still used
Co-authored-by: Peter Yee <github@houseofyee.com>
* Allow AD and Secretariat to update the people to notify about conflict-reviewss until the are announced. Fixes#3639.
* fix: Allow notify list for conflict-review changes in any state
* chore: bring docker dev init script up to date with bs5 branch (#3611)
* ci: only run codeql on schedule
* feat: shorten long agenda filter button labels (#3602)
Sessions with long names lead to poor rendering of the agenda filter buttons
on the 'customize the agenda view' page. This truncates those labels at 3 words.
* docs: Remove stale and incomplete information from the README (#3612)
* docs: Suggest cloning a fork rather than ietf-tools repo (#3614)
* docs: update README
* chore: add issue templates
* chore: update issue templates config
* chore: remove duplicate security issue link
* docs: point feature requests to discussions
* chore: add bug report form
* chore: remove bug report issue template
* chore: fix bug report form
* fix: point the api index page into Github instead of trac/svn
* chore: remove os + version + log fields from bug report form
* fix: point to GitHub for bug reports (#3625)
* fix: point to GitHub for bug reports
* fix: point report bug link to template chooser
* fix: point report bug link to template chooser (2)
Co-authored-by: Nicolas Giard <github@ngpixel.com>
* fix: remove stale explanation of status reports (#3628)
* fix: adjust about page to reflect move to GitHub. Normalize information level on page. (#3629)
* fix: remove anchor tag with empty href (#3630)
* fix: use same github issue URL on 500 error page as elsewhere (#3631)
* chore: update report-a-bug.yml form
* ci: fix __init__.py version quotes
* chore: bring docker-compose to root level (#3642) (#3643)
Authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
* fix: point to GitHub for bug reports
* fix: point report bug link to template chooser
* fix: point report bug link to template chooser (2)
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Sessions with long names lead to poor rendering of the agenda filter buttons
on the 'customize the agenda view' page. This truncates those labels at 3 words.
Only add right-hand page navigation panel to #content elements that have
the ietf-auto-nav class and test that the base template's DOM is compatible
with the panel.
Make the js a bit less noisy and adjust the tests accordingly.
- Legacy-Id: 19984
Note: SVN reference [19979] has been migrated to Git commit f61ddb4b60
Use correct UTC time when creating Meetecho conferences. Fixes#3565.
- Legacy-Id: 19970
Note: SVN reference [19969] has been migrated to Git commit 82ea659ed4
From Kesara Rathnayake: Expire password reset links on use, password change through other mechanics, login, or a short configurable time (initially one hour). Patched in at 7.45.0.p2.
- Legacy-Id: 19968
Note: SVN reference [19967] has been migrated to Git commit 682392081bddbd1b8653df9135388e6b7c48ee1c
Create/delete Meetecho conferences when requesting/canceling interim sessions. Fixes#3507. Fixes#3508.
- Legacy-Id: 19934
Note: SVN reference [19917] has been migrated to Git commit 81cd64da2bc0122f733df02f7db634665c9b309a
Note: SVN reference [19930] has been migrated to Git commit c64297e495010f3c147726ad61c24ca436c324da
Suppress origin template tag in production mode, show relative path only in other modes.
- Legacy-Id: 19932
Note: SVN reference [19925] has been migrated to Git commit b4d07e11519d77523216bc8817058b0facd2bd41
Fix scoping of session loop variables in sreq edit view. Improve tests that should have caught this.
- Legacy-Id: 19931
Note: SVN reference [19922] has been migrated to Git commit f3eb1aed7591167dea562ad15e3a5990930599de
add search to the doc states admin form.
- Legacy-Id: 19929
Note: SVN reference [19921] has been migrated to Git commit ff05978d24f7a9c607d1dd32212e3e3f377b7e6d
Make working with session purpose easier in the admin.
- Legacy-Id: 19928
Note: SVN reference [19920] has been migrated to Git commit 191d5b134fdab8782280eb9769beec793818975f
Allow secretariat to edit session requests when tool is closed to chairs. Fixes#3547.
- Legacy-Id: 19927
Note: SVN reference [19919] has been migrated to Git commit c8a99dcec4112169a286406aa2c6f5c1b3e3d62c
Simplify search for link back to group from the review management view.
- Legacy-Id: 19924
Note: SVN reference [19915] has been migrated to Git commit fa952976ab
Provide the complete context to the template for mail about approved interim requests. Fixes#3534.
- Legacy-Id: 19923
Note: SVN reference [19907] has been migrated to Git commit 216ebe2b94
