Commit graph

364 commits

Author SHA1 Message Date
Henrik Levkowetz 4049b31026 Added normalization of the email addresses returned by ietf.nomcom.utils.parse_email, in order to not treat feedback from the same person as coming from different sources due to email name+address variations.
- Legacy-Id: 15731
2018-11-06 11:47:11 +00:00
Henrik Levkowetz 5ebeceaa8d Removed a test for the microscopic photos on the nomcom feedback page buttons.
- Legacy-Id: 15616
2018-10-30 11:45:58 +00:00
Henrik Levkowetz fcddc86447 Fixed some incorrect topic audience id slugs, to make the topic availability filtering work correctly.
- Legacy-Id: 15598
2018-10-19 12:53:16 +00:00
Henrik Levkowetz e20e8b7df5 Changed the mail sending routines so it's possible to not copy the debug archive on some messages.
- Legacy-Id: 15585
2018-10-16 14:32:10 +00:00
Henrik Levkowetz 6f9fbea6d3 Updated the nomcom admin pages for Feedback to make it possible to see and sort on the Nominees field.
- Legacy-Id: 15558
2018-10-11 13:40:15 +00:00
Henrik Levkowetz 8c985fe440 Turned the nomcom chair dropdown menu item 'Classify pending feedback' into a tab with a mail count badge.
- Legacy-Id: 15544
2018-10-08 15:11:21 +00:00
Henrik Levkowetz 7ac1556fbf Migration for changed default sort order for nominees.
- Legacy-Id: 15535
2018-10-08 13:03:21 +00:00
Henrik Levkowetz b984422471 Added pagination to the nomcom pending-feedback page, to reduce load time.
- Legacy-Id: 15534
2018-10-08 11:51:21 +00:00
Henrik Levkowetz 8a5e302745 Corrected the nominee ordering change.
- Legacy-Id: 15533
2018-10-08 10:26:00 +00:00
Henrik Levkowetz 64ba033a6c Changed the default sort for nomcom.models.Nominees to be 'person__name'.
- Legacy-Id: 15532
2018-10-08 09:55:10 +00:00
Henrik Levkowetz fc027ae161 Built out test_edit_nomcom_view() to also test adding and removing reminder dates.
- Legacy-Id: 15524
2018-10-06 13:01:08 +00:00
Henrik Levkowetz 2c2effde4f Added a form clean() for the reminder dates of the nomcom edit form, to make something appropriate out of edits that remove reminder dates, rather than clicking 'delete'. This fixes a potential exception, when a blank date cannot be saved, and also does what the user expected (deletes a blanked date).
- Legacy-Id: 15521
2018-10-04 18:03:41 +00:00
Henrik Levkowetz 29ae7809d7 Merged in [15486] from rjsparks@nostrum.com:
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598.
 - Legacy-Id: 15487
Note: SVN reference [15486] has been migrated to Git commit 4d5de5dee6
2018-09-26 21:54:05 +00:00
Robert Sparks 4d5de5dee6 Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598. Commit ready for merge.
- Legacy-Id: 15486
2018-09-26 18:57:30 +00:00
Henrik Levkowetz 4f2f843a55 A string.Template with a unicode template must be given unicode dictionary values if the values contain unicode codepoints. Providing values that are objects with __str__() methods, or utf-8 encoded strings doesn't work. Fixes an issue with nomcom template interpolation for nominees with non-ascii names.
- Legacy-Id: 15481
2018-09-24 21:25:20 +00:00
Henrik Levkowetz 120d78bbbf Changed the sort order of nominees on the private index page to be according to name (instead of email address).
- Legacy-Id: 15479
2018-09-21 19:47:40 +00:00
Henrik Levkowetz 5f512226a5 Added a missing migration and updated nomcom.resources to match model changes.
- Legacy-Id: 15465
2018-09-18 12:53:39 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively.
- Legacy-Id: 15464
2018-09-16 23:12:43 +00:00
Peter E. Yee 047b91862c Fixed 2 trivial spelling errors in NomCom tools. Fixes issue #2569. Commit ready for merge.
- Legacy-Id: 15441
2018-08-17 04:24:51 +00:00
Henrik Levkowetz 35e16ef7d5 Changed User ForeignKeys to not delete objects pointing at a user when the user is deleted, instead setting the ForeignKey field to None.
- Legacy-Id: 15257
2018-06-14 18:53:48 +00:00
Henrik Levkowetz 46bee81bdc Fixed a test email object creation issue.
- Legacy-Id: 15180
2018-05-28 09:48:27 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz fcc22da623 Removed a chunk of code that won't be executed in all test environments from the test coverage measurements
- Legacy-Id: 14550
2018-01-23 17:29:41 +00:00
Henrik Levkowetz f996fe825f Added more test data for the eligibility view, in order to exercise all parts of the view code.
- Legacy-Id: 14541
2018-01-19 15:21:33 +00:00
Henrik Levkowetz 374950ede8 Removed code generating nomcom page urls which doesn't resolve any more. Added a comment about the eligibility view for previous nomcoms.
- Legacy-Id: 14540
2018-01-19 15:06:23 +00:00
Henrik Levkowetz 7921d613d5 Merged in [14533] from rjsparks@nostrum.com:
Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257.
 - Legacy-Id: 14538
Note: SVN reference [14533] has been migrated to Git commit 4ce6b934b8
2018-01-17 22:32:00 +00:00
Robert Sparks 4ce6b934b8 Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257. Commit ready for merge.
- Legacy-Id: 14533
2018-01-17 17:58:58 +00:00
Henrik Levkowetz c3f444eaf1 Merged in [14511] from rjsparks@nostrum.com:
Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303.
 - Legacy-Id: 14513
Note: SVN reference [14511] has been migrated to Git commit 5835e52759
2018-01-11 17:14:21 +00:00
Henrik Levkowetz 16e155356e Merged in [14506] from rjsparks@nostrum.com:
Improved the resilience of the formatted_email nomcom filter. Fixes #1764.
 - Legacy-Id: 14512
Note: SVN reference [14506] has been migrated to Git commit 2dd1f0da29
2018-01-11 16:41:15 +00:00
Robert Sparks 5835e52759 Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303. Commit ready for merge.
- Legacy-Id: 14511
2018-01-11 16:28:19 +00:00
Henrik Levkowetz 78304b4d57 Merged in [14505] from rjsparks@nostrum.com:
Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852.
 - Legacy-Id: 14510
Note: SVN reference [14505] has been migrated to Git commit c8b451094a
2018-01-11 16:07:21 +00:00
Henrik Levkowetz 0bd9dbaab3 Removed some unused imports.
- Legacy-Id: 14509
2018-01-11 15:00:02 +00:00
Henrik Levkowetz 5e0335bbe3 Removed some dead code.
- Legacy-Id: 14508
2018-01-11 13:22:04 +00:00
Robert Sparks 2dd1f0da29 Improved the resilience of the formatted_email nomcom filter. Fixes #1764. Commit ready for merge.
- Legacy-Id: 14506
2018-01-10 22:42:18 +00:00
Robert Sparks c8b451094a Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852. Commit ready for merge.
- Legacy-Id: 14505
2018-01-10 21:54:10 +00:00
Robert Sparks 94f4e9ac58 Simplify the edit nomcom members forms. Fixes #1756. Commit ready for merge.
- Legacy-Id: 14504
2018-01-10 18:26:20 +00:00
Henrik Levkowetz a5e5bb1aab Expanded one of the nomcom tests a bit, and updated a fixture to match the current /nomcom/default/email/feedback_receipt.txt template.
- Legacy-Id: 14223
2017-10-20 14:34:03 +00:00
Henrik Levkowetz ac8e18480e Added tests for correct nomcom email from-address to the nomcom tests, and did some refactoring to improve test failure messages.
- Legacy-Id: 14176
2017-09-28 09:09:51 +00:00
Henrik Levkowetz 166c7531f9 Changed the nomcom code to permit nomcom year interpolation in the nomcom from-address and in nomcom templates. Changed the nomcom from-address setting to 'nomcom-chair-{year}@ietf.org'.
- Legacy-Id: 14175
2017-09-27 21:20:59 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name.
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code.
- Legacy-Id: 14128
2017-09-17 15:12:18 +00:00
Henrik Levkowetz e393b83f6b Merged in [14058] from rjsparks@nostrum.com:
Further refinements to the nominee status table. Related to #2261.
 - Legacy-Id: 14068
Note: SVN reference [14058] has been migrated to Git commit 7cecd9fe38
2017-08-23 17:30:00 +00:00
Henrik Levkowetz 2b2753635f Merged in [14057] from rjsparks@nostrum.com:
Improve the nominee status table to serve as a nomcom dashboard. Fixes #2261.
 - Legacy-Id: 14067
Note: SVN reference [14057] has been migrated to Git commit 2dbb0766fd
2017-08-23 15:06:12 +00:00
Robert Sparks 7cecd9fe38 Further refinements to the nominee status table. Related to #2261. Commit ready for merge.
- Legacy-Id: 14058
2017-08-16 21:59:51 +00:00