Commit graph

3961 commits

Author SHA1 Message Date
Robert Sparks c1627ed011
fix: restore attendee dbtemplate for old meetings pending data correction (#6656)
* fix: restore attendee dbtemplate for old meetings pending data correction

* test: adjust attendees test to match workaround
2023-11-17 10:01:09 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
Ryan Cross 2974e81624
fix: build proceedings attendee list from MeetingRegistration table. … (#6567)
* fix: build proceedings attendee list from MeetingRegistration table. Fixes #6265

* fix: move participants_for_meeting to meeting.utils

* fix: move test_participants_for_meeting to meeting tests
2023-11-07 13:09:19 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586)
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 17:45:07 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570)
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584)
Fixes #6542
2023-11-05 11:04:25 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00
Lars Eggert e7639e94ed
Merge branch 'main' into feat-md-bs 2023-10-24 19:49:17 +02:00
Lars Eggert fd03ab13d7
Small fixes 2023-10-23 17:44:12 -07:00
Martin Thomson 902d657c9f
Icons for sidebar collapse/expand (#6465)
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/).  This is a minimal change, but changes from .

I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/), which is the mirror of the collapsed icon.  I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/).  Both of those seemed less clear than these.

Note that the "shown"/"collapsed" classes on these elements appear to be reversed.  I didn't touch that.
2023-10-23 18:40:24 -05:00
Lars Eggert 0a4fc286cd
fix: More darkmode fixes (#6477)
* fix: More dark mode fixes

This first commit increases contrast of the leftmenu text.

* Fix own ballot position highlight in dark mode

* Fix dark mode axis color in timeline diagrams

* Enable highcharts dark mode

* Fix template

* Properly import our customized bs5 everywhere

* Fix #6499

* Use bs5 color for border-left

* Remove superfluous load
2023-10-23 18:38:35 -05:00
Lars Eggert caa4e837ad
fix: Remove menu item for outdated tutorials list (#6521)
Fixes #6473

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:32:08 -05:00
Lars Eggert f5507daef1
feat: Render markdown agendas with bs5 styles
So that the look is consistent with the rest of the datatracker.
2023-10-23 18:55:31 +03:00
Paul Selkirk a6a39a04dc
feat: Show/edit shepherd for IAB-stream documents (#6498)
* feat: Show/edit shepherd for IAB-stream documents (#4810)

* style: Shepherd for IAB documents is called 'IAB shepherd'
2023-10-23 09:57:23 -05:00
Martin Thomson 6e3c663484
fix: hide sidebar and dark/light toggles from print (#6502)
Fixes #6501.
2023-10-20 08:08:55 -05:00
Robert Sparks c84199630b
Merge pull request #6470 from pselkirk/feat-5440
feat: Send mail when slides are approved
2023-10-16 12:46:13 -05:00
Paul Selkirk f6a2d8c534 refactor: More efficient mail construction/sending 2023-10-13 19:22:06 -04:00
Robert Sparks c036bc6822
Merge pull request #6476 from larseggert/fix-better-nomcom-fb-buttons
fix: Use smaller buttons for NomCom feedback and color the count bubble
2023-10-13 09:03:32 -05:00
Lars Eggert ba66d25372
fix: Use smaller buttons for NomCom feedback and color the count bubble 2023-10-13 16:14:59 +03:00
Lars Eggert e9a8c341e8
fix: Nicer formatting for group milestone tables 2023-10-13 14:07:20 +03:00
Paul Selkirk b04ffe1631 feat: Send mail when slides are approved (#5440) 2023-10-12 13:13:14 -04:00
Lars Eggert fa00abf9de
fix: Add remote instructions and date/time to interim agenda page (#6442)
* fix: Add remote instructions to interim agenda page

Fixes #6433
Fixes #6249

* Also add date and time

* Fix HTML

* Fix CI fail

* Address code review comments

* More suggestions from @rjsparks

* Fix HTML

* Add suffix
2023-10-12 06:29:03 -05:00
Lars Eggert 0f6b403904
fix: Fix "Is Accepting Feedback: yes" action for NomCom (#6467)
Fixes #6466

While I'm here, apply list styling more consistently across NomCom pages.
2023-10-12 06:15:14 -05:00
Paul Selkirk 16f9e0e974
fix: Adjust IRTF charter approval email headers (#5917) (#6460) 2023-10-11 11:09:10 -05:00
David Schinazi 5e0d1bef0f
fix: Remove incorrect line from submission API info web page (#6432)
* Submit can replace

* Empty commit for CI

* revert change to api_submit_info
2023-10-09 12:15:47 -05:00
Lars Eggert 7dbfc0208a
feat: Remove document notes from the datatracker (#6387)
* Remove doc.note

* Address comments from @rjsparks

* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Lars Eggert 0f16012c73
fix: Add html-validate suppression that should have been part of #6356 (#6440) 2023-10-09 11:30:45 -05:00
Robert Sparks d6f5564a82
ci: merge release to main 2023-09-29 14:02:18 -05:00
Robert Sparks c5a955d798
fix: restore interim announce ability (#6410) 2023-09-29 11:33:14 -05:00
Robert Sparks 486a4f5370
Merge pull request #6345 from larseggert/fix-6343
fix: Add link to public pages to private NomCom pages
2023-09-29 10:13:58 -05:00
Paul Selkirk c718fedb6c
feat: Allow review rejections to be undone (#6312)
* feat: Allow reviewer to accept a review they're previously rejected

* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.

This largely un-does d105f8b, at the request of at least one team secretary.

* fix: Went a little overboard on the previous commit

one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.

* fix: Actually do the assignment

* fix: If there's an existing assignment, don't create a new one

* style: Restructure conditional for clarity

* test: Add test cases for accepting or assigning a review assignment after rejecting it
2023-09-27 08:57:34 -05:00
Lars Eggert a8f50f50b0
fix: Only enable city/country entry for in-person interims (#6383)
Was probably broken during the bs5 transition.

Fixes #6346
2023-09-26 12:00:05 -05:00
Lars Eggert 7e18a0fad2
fix: Allow editing of interim meeting subject lines (#6385)
Also change "readonly" to "disabled" to give a visual hint about which
fields are not changeable.

Fixes #6310
2023-09-26 08:10:46 -05:00
Lars Eggert 5db70b2787
fix: State descriptions can have HTML in them, mark them safe (#6384) 2023-09-26 08:09:39 -05:00
Jennifer Richards 8f0a0da5a3
fix: Typo 2023-09-25 12:01:27 -03:00
Lars Eggert a42ef589f3
Unsplit conditionals 2023-09-25 17:41:30 +03:00
Lars Eggert 9efcce227d
Be less clever 2023-09-25 13:42:15 +03:00
Lars Eggert d0de2294a3
Merge remote-tracking branch 'origin/main' into fix-6343 2023-09-25 13:05:31 +03:00
Lars Eggert 910a266126
fix: Prevent duplicate HTML IDs on photo page (#6356)
* fix: Prevent duplicate HTML IDs on photo page

Fixes #6355

* Just don't slugify the ID.

See https://mathiasbynens.be/notes/html5-id-class
2023-09-22 12:50:43 -05:00
Lars Eggert 9391985cbb
fix: Add link to public pages to private NomCom pages
Fixes #6343

Also fix highlighting of the active tab in the nav tab bar while I'm here.
2023-09-21 17:20:38 +03:00
Lars Eggert 303ff70e64
fix: Linkify email address lists one-by-one (#6315)
* fix: Linkify email address lists one-by-one

Seems to work around a bug in mozilla/bleach.

Fixes #6307

* Cosmetic change

* Fix test
2023-09-15 10:45:58 -05:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418)
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Lars Eggert d3d2f0d35f
fix: Enable js functionality on sortable tables (#6301)
Fixes #6263

Also fix the non-js "untrack_document" page while I'm here.
2023-09-13 15:31:01 -05:00
Paul Selkirk febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6231)
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088)

* chore: Move PUBLISH_IPR_STATES from settings_local to settings

* fix: Add migration for removed_objfalse in IprEventTypeName

* fix: De-conflict migration

* fix: De-conflict migration

* style: Move PUBLISH_IPR_STATES ahead of not-production block
2023-09-11 13:14:46 -05:00