Commit graph

109 commits

Author SHA1 Message Date
Ole Laursen 3d1eb07afe Port idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
 - Legacy-Id: 5634
2013-04-10 11:48:07 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Ole Laursen 5a1a2b4f65 Revamp the ballot popup view
- Legacy-Id: 5609
2013-04-04 13:26:08 +00:00
Ole Laursen 4b312de464 Introduce a simple cache in doc.get_state so repeated reads don't
cause a DB query
 - Legacy-Id: 5314
2013-01-21 14:01:33 +00:00
Ole Laursen 06f4ed4cf3 Add a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
 - Legacy-Id: 5313
2013-01-21 12:27:26 +00:00
Ole Laursen ab6a7f85c0 Get rid of initial "No record" positions when showing old positions,
it's just noise
 - Legacy-Id: 5312
2013-01-21 11:54:56 +00:00
Ole Laursen 9bcc4a9f3d Remove ballot.tsv view and comment out the ballot.json view in urls.py
- Legacy-Id: 5299
2013-01-18 13:54:33 +00:00
Ole Laursen 7998371ace Make sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
 - Legacy-Id: 5296
2013-01-18 13:47:31 +00:00
Ole Laursen accf6d4470 Move idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
 - Legacy-Id: 5295
2013-01-18 13:17:00 +00:00
Ole Laursen 1a3aa3b443 Refactor slightly to make views_doc.py independent of other idrfc code
- Legacy-Id: 5294
2013-01-18 10:32:05 +00:00
Ole Laursen ce081cb31d Fix the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
 - Legacy-Id: 5289
2013-01-17 17:10:19 +00:00
Ole Laursen 188c619635 Display draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
 - Legacy-Id: 5288
2013-01-17 16:02:50 +00:00
Ole Laursen 5efcc5fbef Fix revision augmentation so events after RFC publication gets a "RFC"
designation
 - Legacy-Id: 5286
2013-01-17 15:39:57 +00:00
Ole Laursen c0ecb78761 Merge the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
 - Legacy-Id: 5285
2013-01-17 13:28:42 +00:00
Ole Laursen a6a0596be6 Add migration for fixing 1) a dummy RFC entry, 2) three stand-alone
RFCs that didn't get their doc.type set, 3) a big bunch of historic
stand-alone RFCs that have doc.group=None - set these to the
individual submission "none" group for the time being so the view code
doesn't have to deal with a special case.

In some cases this is wrong since there actually was a WG associated
but unfortunately fixing them properly requires detective work
(probably parsing the RFCs) and in at least some cases recreating
historic WGs. In case someone ends up doing this, the documents to
check can still be found with

Document.objects.filter(name__startswith="rfc", group__type="individ")

since there are almost no new RFCs that didn't went through the I-D
process.
 - Legacy-Id: 5284
2013-01-17 13:00:36 +00:00
Ole Laursen aa70cffe73 Rewrite draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
 - Legacy-Id: 5214
2013-01-16 14:57:01 +00:00
Ole Laursen 4624f4a31c Add migration for blanking IESG notes that just consist of "RFC
XXXX", these have been superfluous for some time
 - Legacy-Id: 5207
2013-01-16 14:20:20 +00:00
Ole Laursen e8daf2fbdf Add migration for transforming the .desc on the new_revision events
into something more akin to what is actually shown in the history page
 - Legacy-Id: 5206
2013-01-16 14:17:07 +00:00
Ole Laursen 6e45e5e17b Remove .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
 - Legacy-Id: 5205
2013-01-16 14:15:18 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Ole Laursen 6c91e93886 Allow State.next_states to be blank so the admin doesn't barf
- Legacy-Id: 5023
2012-11-07 14:57:04 +00:00
Ole Laursen 9b73aa30b9 Add migration for DeletedEvent
- Legacy-Id: 5022
2012-11-07 14:55:58 +00:00
Ole Laursen 730cd6056e Add DeletedEvent for storing redacted events
- Legacy-Id: 5021
2012-11-07 14:55:39 +00:00
Ole Laursen a77b2ae0ab Add missing admin entries for StateDocEvent and ConsensusDocEvent
- Legacy-Id: 5006
2012-11-05 13:32:31 +00:00
Henrik Levkowetz 5eeb670b28 Merged [4909] from rjsparks@nostrum.com:
Reimplemented clear_ballot to close the existing ballot and create a new one. Changed the all_positions code to only return synthetic no-positions for current ADs when a ballot is actually open
 - Legacy-Id: 4962
Note: SVN reference [4909] has been migrated to Git commit 2e6caa21b1
2012-10-30 12:07:10 +00:00
Henrik Levkowetz 8493ce7e38 Merged [4885] from rjsparks@nostrum.com:
refactored close_open_ballots, creating a way to close one abllot at a time. rewrote the clear ballot code to close each open ballot and open a new one
 - Legacy-Id: 4960
Note: SVN reference [4885] has been migrated to Git commit b3bdbc9506
2012-10-30 12:06:15 +00:00
Henrik Levkowetz 6e4d27ca5b Added a management command to generate bibxml files for drafts. It's not fully cooked yet, as it needs to differentiate between documents which are currently drafts, and those that have been published as RFCs, but the basics are there.
- Legacy-Id: 4953
2012-10-25 21:18:06 +00:00
Henrik Levkowetz 0efc882252 Merged [4873] from rjsparks@nostrum.com:
Includes the conflict-review document contents in the email sent with the results of the conflict review.
Fixes bug #883
 - Legacy-Id: 4944
Note: SVN reference [4873] has been migrated to Git commit d6579c63e6
2012-10-21 21:02:03 +00:00
Ole Laursen e87b8483e5 Add migration script for setting the group on IAB stream documents to
IAB and IRTF stream documents to the corresponding RG (if it exists),
instead of keeping it as individual submission
 - Legacy-Id: 4911
2012-10-11 15:26:21 +00:00
Robert Sparks 2e6caa21b1 Reimplemented clear_ballot to close the existing ballot and create a new one. Changed the all_positions code to only return synthetic no-positions for current ADs when a ballot is actually open
- Legacy-Id: 4909
2012-10-10 15:48:34 +00:00
Ole Laursen a8671798fd Return None explicitly rather than implicitly
- Legacy-Id: 4886
2012-09-28 14:49:37 +00:00
Robert Sparks b3bdbc9506 refactored close_open_ballots, creating a way to close one abllot at a time. rewrote the clear ballot code to close each open ballot and open a new one
- Legacy-Id: 4885
2012-09-27 21:41:11 +00:00
Henrik Levkowetz 27186d111e Added a docstring note about the convention for when save_*_in_history() shoudl be called.
- Legacy-Id: 4883
2012-09-27 10:03:16 +00:00
Robert Sparks d6579c63e6 Includes the conflict-review document contents in the email sent with the results of the conflict review.
Fixes bug #883
 - Legacy-Id: 4873
2012-09-20 19:35:50 +00:00
Ole Laursen 79a16d913b Add order on IANA Action states
- Legacy-Id: 4871
2012-09-20 14:16:08 +00:00
Ole Laursen 07490fcb83 Add new IANA states, add consensus event, add a state change event,
add migrations for these that also clean up the RFC Editor states a
little given the recent changes
 - Legacy-Id: 4846
2012-09-17 10:00:56 +00:00
Robert Sparks 33e9663b0e Send email to IANA and the IESG when entering IESG evaluation of an RFC5742 conflict review
- Legacy-Id: 4833
2012-09-07 15:39:37 +00:00
Henrik Levkowetz c245f6a020 Make .ballot_open() available on DocumentInfo instead of on Document, too.
- Legacy-Id: 4807
2012-08-24 08:13:33 +00:00
Henrik Levkowetz 7c78ed81ef Make .active_ballot() available on DocumentInfo instead of on Document, to make charter history snapshots work.
- Legacy-Id: 4803
2012-08-23 10:08:41 +00:00
Henrik Levkowetz c90a26ca50 Merged [4772] from rjsparks@nostrum.com:
Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)

Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)

Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).

Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text


DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.

Fixes bug 865
 - Legacy-Id: 4780
Note: SVN reference [4772] has been migrated to Git commit e5c3a5adc5
2012-08-22 12:34:55 +00:00
Henrik Levkowetz 9bde5b91d6 Added support for conflrev documents based on branch /personal/rcross/v4.32@4722, but tweaked to return only the directory, not the full directory+name+ext path, in order to behave the same way as for other document types.
- Legacy-Id: 4779
2012-08-22 11:26:50 +00:00
Robert Sparks 87ebddd0ba Simplified access to current BallotDocevent from a Document.
Added functions to BallotDocEvents to faciliate access to BallotPositionDocEvents, both for all positions, and current AD postions.
Updated the moderator package to use the Documents from _agenda_data.
Added a filter to assist with rendering the moderator package.
Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).
 - Legacy-Id: 4768
2012-08-17 20:45:32 +00:00
Robert Sparks e21e5fefa4 Added a migration to update non-blocking ballot positions that have non-empty discuss text. Fixes bug #856
- Legacy-Id: 4752
2012-08-03 21:33:49 +00:00
Robert Sparks fb2b9c9e6c Removed some duplication between doc/util and doc/models by moving things into doc/models. Fixes bug #857
- Legacy-Id: 4750
2012-08-02 21:36:36 +00:00
Henrik Levkowetz 6dd8086125 Merged [4724] from rbarnes@bbn.com:
Adjusted the scribe template to make it XHTML compliant and fix what Robert broke
 - Legacy-Id: 4730
Note: SVN reference [4724] has been migrated to Git commit 08c1c0cb19
2012-07-30 21:44:42 +00:00
Richard Barnes 08c1c0cb19 Adjusted the scribe template to make it XHTML compliant and fix what Robert broke
- Legacy-Id: 4724
2012-07-29 01:09:41 +00:00
Adam Roach 80d7ab9eba Adding an "href" method to documents. It doesn't work for documents of type 'liai-att' or 'liaison', but it's a good start.
- Legacy-Id: 4721
2012-07-29 00:42:19 +00:00
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00