Commit graph

41 commits

Author SHA1 Message Date
Jennifer Richards 3c13db45fd
fix: validate form in login() (#7435)
* fix: validate form in login()

* refactor: custom LoginView subclass for logins

Preserves old behavior, but avoids some hacks.

* test: reverse with strings, not view refs

* chore: remove unused imports

* fix: restore logout() call
2024-05-24 16:36:58 -05:00
Robert Sparks ae01f6fb92
chore: clean away unused views/tests related to the Allowlisted model (#7027) 2024-02-06 09:39:09 -06:00
Lars Eggert 220be21998
chore: Use codespell to fix typos in code. (#4797)
* chore: Use codespell to fix typos in code.

Second part of replacement of #4651

@rjsparks, I probably need to revert some things here, and I also
still need to add that new migration - how do I do that?

* Revert migrations

* Migrate "Whitelisted" to "Allowlisted"

* TEST_COVERAGE_MASTER_FILE -> TEST_COVERAGE_MAIN_FILE

* Fix permissions

* Add suggestions from @jennifer-richards
2022-12-07 15:10:35 -06:00
Robert Sparks 53f7bc3ce6 migrated forward
- Legacy-Id: 18144
2020-07-09 21:07:05 +00:00
Henrik Levkowetz 7c7c5da39f Changed the 2.1 removed django.contrib.auth.views.logout to LogoutView.
- Legacy-Id: 18052
2020-06-24 20:36:46 +00:00
Robert Sparks b7f45dba05 added ways to see and edit PersonExtResources.
- Legacy-Id: 17869
2020-05-21 20:10:04 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command.
- Legacy-Id: 14426
2017-12-16 18:37:52 +00:00
Henrik Levkowetz 152261a869 Added new infrastructure for personal API keys, to generate, view, and delete them.
- Legacy-Id: 14423
2017-12-14 14:30:59 +00:00
Henrik Levkowetz a94c33fd6e Added an alert on the login form, to be shown if a user's password has been cleared. Adjusted url reverse strings to match the changed view function.
- Legacy-Id: 12918
2017-02-25 15:50:47 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Henrik Levkowetz efc77762be Added the ability for logged-in users to change their login (username) to any of the active email addresses of the account. Fixes ticket #2052.
- Legacy-Id: 12843
2017-02-15 16:59:23 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 7dea44e626 Added a change password page, and linked to it from the account profile page and user menu. Added zxcvbn-based browser-side password strength estimation on the various password setting, re-setting, and changing forms. Added a change password test. Changed ietfauth/urls.py to not use the deprecated string form for views in urlpatterns.
- Legacy-Id: 12798
2017-02-09 17:03:44 +00:00
Henrik Levkowetz db1cc15f1f Undid last commit
- Legacy-Id: 12792
2017-02-08 18:03:29 +00:00
Henrik Levkowetz 15628c698f Tweaked the IPR Details page to show the possible a), b), and c) choices under section 'V' when licensing declaration to be provided later has been chosen.
- Legacy-Id: 12791
2017-02-08 18:02:03 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files.
- Legacy-Id: 12618
2016-12-22 17:21:57 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Henrik Levkowetz fed2a04445 Increased the requirements for account creation, and added a form where the secretariat can add whitelisting to make account creation possible for addresses that don't fulfil the default requirements.
- Legacy-Id: 11374
2016-06-14 21:39:12 +00:00
Henrik Levkowetz 21b2330b6a Removed an newly introduced url() name parameter.
- Legacy-Id: 11184
2016-05-13 09:09:37 +00:00
Henrik Levkowetz deb2f73047 Merged in ^/branch/iola/community-list-cleanup-r11172@11175.
- Legacy-Id: 11182
2016-05-12 19:14:28 +00:00
Henrik Levkowetz 7e61ce84e8 Merged in ^/branch/iola/account-registration-fixes-r11167@11179 from olau@iola.dk, which contains fixes and refactoring for the account registration code, in order to better support the coming community app refactoring.
- Legacy-Id: 11180
2016-05-12 12:59:04 +00:00
Ole Laursen b83e0d2c78 Unify the URL name handling in ietfauth, i.e. just refer directly to
the view behind the URL instead of naming it.
 - Legacy-Id: 11172
2016-05-06 12:58:10 +00:00
Ole Laursen a99aa32c59 Refactor account code to use the built-in Django signing framework
(reusing code previously written for the community lists) instead of
the a custom MD5 scheme, add tests of all views, rewrite custom form
handling code to use plain forms and ensure that the data is properly
validated and errors visible in the UI. Move help texts on the Person
form up to the model.
 - Legacy-Id: 11136
2016-04-27 16:26:04 +00:00
Ole Laursen cdcad43fc0 Simplify community lists further by letting email subscriptions reuse
the existing infrastructure for accounts and emails, instead of a
having a separate confirmation step
 - Legacy-Id: 10951
2016-03-17 12:02:45 +00:00
Henrik Levkowetz e8f2d27de3 Commented out a lot of what I believe to be dead code.
- Legacy-Id: 9418
2015-04-06 07:48:01 +00:00
Henrik Levkowetz 5549088331 With the complications caused by the TransactionMiddleware gone, we can use Django's default login() and logout() views.
- Legacy-Id: 7539
2014-03-23 23:17:15 +00:00
Henrik Levkowetz 475bcbbd30 Working django-auth login and logout views. Password import from htpasswd file still needed.
- Legacy-Id: 7536
2014-03-23 18:27:14 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
2013-12-05 16:24:03 +00:00
Henrik Levkowetz 843493aa23 Fixed a password reset url which didn't work due to a wrong keyword name in the urlpattern.
- Legacy-Id: 4810
2012-08-24 08:50:31 +00:00
Henrik Levkowetz 469bfa11a3 Fix some parameter names in the ietfauth urlconf which had reverted to an old form in a recent merge.
- Legacy-Id: 4741
2012-07-31 22:27:49 +00:00
Henrik Levkowetz 0b1158491f Merged [4705] from adam@nostrum.com:
Adding self-management page for user profile information
 - Legacy-Id: 4714
Note: SVN reference [4705] has been migrated to Git commit 1502efba76
2012-07-29 00:04:08 +00:00
Ole Laursen 13aed82a0e More import path fixes from Henrik
- Legacy-Id: 3877
2012-01-30 19:05:27 +00:00
Ole Laursen b114e5e6cf Add simple view for setting testemailcc cookie when server is in test mode
- Legacy-Id: 3716
2011-11-28 17:19:45 +00:00
Henrik Levkowetz 6c93e2553b Add htpasswd management functionality.
- Legacy-Id: 3386
2011-08-26 18:06:12 +00:00
Henrik Levkowetz 266b7820d0 Merged from log:branch/2.00@2363: Current release branch head to trunk.
- Legacy-Id: 2365
2010-07-21 12:48:05 +00:00
Henrik Levkowetz cd030d3b43 Adding copyright notices to all python files
- Legacy-Id: 716
2007-06-27 21:16:34 +00:00
Henrik Levkowetz 03c18bd33d Fixing a bunch of nits pyflakes were complaining about, in order to get a clean run. There are still at least 2 cases of using undefined values which needs scrutiny.
- Legacy-Id: 235
2007-06-05 16:58:58 +00:00
Bill Fenner cb94159896 Allow login/logout/password change. The initial view once logged
in (unless it's a forced login) will be the (incomplete) "my" view.
Username and logout link are in the upper right corner while logged
in.
 - Legacy-Id: 163
2007-05-24 20:18:11 +00:00