Commit graph

15306 commits

Author SHA1 Message Date
depfu[bot] 3a17abe32a
chore(deps): update all npm dependencies for playwright (#6061)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-08 13:07:17 -05:00
Jennifer Richards d87e504c4d
test: Use correct time zone for test_statement_doc_view (#6064) 2023-08-08 13:05:39 -05:00
Jennifer Richards b574a6e17a
fix: Print decoded key and fully clean up test nomcom (#6094)
* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing
2023-08-08 12:34:27 -05:00
Paul Selkirk 06c9f06d55
feat: Reclassify nomcom feedback (#6002)
* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members
2023-08-08 12:33:17 -05:00
Nicolas Giard b327a27736
ci: update dev sandbox init script to start memcached 2023-08-08 11:44:05 -04:00
Lars Eggert 399b7b9994
fix: Correctly order "last call requested" column in the IESG dashboard (#6079) 2023-08-07 16:53:19 -05:00
Paul Selkirk 638f7ea598
fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065) 2023-08-07 15:14:56 -05:00
Nicolas Giard 59c1db196a
docs: Update LICENSE year 2023-08-02 03:47:17 -04:00
Paul Selkirk 4e4603215d
fix: Clean up view_feedback_pending (#6070)
- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.
2023-08-01 17:46:04 -03:00
Jennifer Richards 22624a3f38
fix: Set colspan to actual number of columns (#6069) 2023-08-01 16:53:45 -03:00
Nicolas Giard ff07286404
ci: add --validate-html-harder to build.yml workflow 2023-07-28 14:19:51 -04:00
Nicolas Giard 416ffb0d6f
ci: add --validate-html-harder to tests 2023-07-27 19:15:48 -04:00
Lars Eggert 04df7973d8
fix: Make review table more responsive (#6053)
* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits
2023-07-27 07:48:51 -07:00
Robert Sparks 593bdb465d
feat: allow openId to choose an unactive email if there are none active (#6041)
* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive
2023-07-25 12:15:39 -07:00
Tero Kivinen b24dd4427b
fix: Shows requested reviews for doc fixes (#6022)
* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.
2023-07-25 07:59:45 -07:00
Kesara Rathnayake e1e15da398
fix: Add editorial stream to meeting materials (#6047)
Fixes #6042
2023-07-25 07:50:49 -07:00
Kesara Rathnayake 101963d3bd
fix: Add editorial stream to proceedings (#6027)
* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings
2023-07-24 10:06:28 -07:00
Nicolas Giard f124af8c2d
chore(dev): update .vscode/settings.json with new taskExplorer settings 2023-07-23 18:45:19 -04:00
Robert Sparks ab0b8e12aa
feat: include submitter in email about submitted slides (#6033)
* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change
2023-07-23 13:56:49 -07:00
Robert Sparks dbe1749438
feat: IAB statements (#5940)
* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic
2023-07-23 11:00:24 -07:00
Tero Kivinen 5a0ea56b38
fix: Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)
* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-07-23 10:02:40 -07:00
Tero Kivinen 14b4f82239
fix: review refactoring issue
fixes #5447
2023-07-23 09:58:01 -07:00
Roman Beltiukov 001719b3b5
fix: provide date for revisions in bibtex output (#6029)
* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events
2023-07-23 09:21:16 -07:00
Roman Beltiukov 4d611706d4
fix: return 404 for non-existing revisions (#6014)
* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex
2023-07-23 09:16:12 -07:00
Ali e61f779816
fix: avoid deprecation warning on view_list() for objs without CommunityList
Fixes #5942
2023-07-23 09:12:13 -07:00
PriyankaN 00c0389c1f
fix:no history entry when changing RFC Editor note for doc (#6021)
* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
2023-07-22 17:33:11 -07:00
Lars Eggert 36a7c5c647
chore: Merge from @martinthomson's rfc-txt-html (#6023) 2023-07-22 16:53:10 -07:00
Rich Salz ebad9489b8
fix: Clarify Questionnaire label (#4688) (#6017)
When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688
2023-07-22 16:40:24 -07:00
Liubov Kurafeeva 3a499cd068
fix: Server error from api_get_session_materials() (#6025)
Fixes #5877
2023-07-22 16:36:35 -07:00
Lars Eggert c717673060
fix: Fix menu hover issue (#6019)
* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue
2023-07-22 15:38:20 -07:00
Rich Salz 8a8821072f
fix: Clarify no-action-needed (#5918) (#6020)
When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918
2023-07-22 15:37:34 -07:00
Rich Salz 9aea2a2e8b
fix: Make name/email lookups case-insensitive (#5972) (#6007)
* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains
2023-07-22 13:16:42 -07:00
Liubov Kurafeeva 91297f18e6
fix: Provide human-friendly status in submission status API response (#6011)
Co-authored-by: nectostr <bastinda96@gmail.com>
2023-07-22 12:43:08 -07:00
Robert Sparks f82988d8b7
fix: restore ability to create status change documents (#5963)
* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment
2023-07-22 12:40:38 -07:00
Lars Eggert 5f8fca68f4
chore: Remove unused "rendertest" stuff (#6015) 2023-07-22 12:36:07 -07:00
Darrel 98634ea27b
chore(dev): fails to build a container in a GitHub Codespace (#6006) 2023-07-22 13:24:41 -04:00
Nicolas Giard a38b6c1bde
docs: update docker/README.md 2023-07-21 18:59:29 -04:00
Lars Eggert 8e439df7c5
fix: HTML-escape person name in tests (#5986)
* fix: Add `mark_safe` to `person_link` to prevent HTML escaping

Fixes part of #5834, namely https://github.com/ietf-tools/datatracker/issues/5834#issuecomment-1627454562

* fix: Fix tests instead of marking name safe
2023-07-21 15:52:19 -07:00
Roman Beltiukov a1a88c5244
docs: update VS Code extensions names (#5997)
[ci skip]
2023-07-20 12:26:54 -05:00
Robert Sparks f52d0ddcf8
test: verify newsubmissiondocevent count by day is correct (#6000) 2023-07-20 08:53:23 -05:00
Robert Sparks 38d5860fc7
chore: pin factory-boy until we address the deprecated post_generation save issue (#5999)
* chore: pin factory-boy until we address the deprecated post_generation save issue

* chore: restore lower bound on factory-boy version
2023-07-20 08:53:11 -05:00
Jennifer Richards ba356397c0
fix: Specify UTC for TruncDate (#5996) 2023-07-20 08:29:30 -05:00
depfu[bot] 9ca3d80baa
chore(deps): update all npm dependencies for dev/diff (#5974)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-07-19 13:46:56 -05:00
Lars Eggert d8c0ae5faf
fix: Add numeric localhost addresses to CSRF_TRUSTED_ORIGINS (#5989) 2023-07-19 09:55:22 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858)
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
2023-07-18 12:22:28 -05:00
Paul Selkirk 3f228c788d
feat: Add totals to nominee feedback page (#5977)
* feat: Add totals to nominee feedback page (#4727)

* test: Add a unit test for feedback totals

Also remember to wrap the totals in a <tr> tag.
2023-07-18 09:17:06 -05:00
Lars Eggert bd9d3285b5
fix: #timeline -> #doc-timeline (#5985)
Fixes #5923
2023-07-18 09:01:43 -05:00
Lars Eggert 57843d8538
fix: Import fix from 7a946424c1 (#5984) 2023-07-18 08:58:22 -05:00
Paul Selkirk 0693a4357d
feat: Add "generate email" to action on nominees page (#4893) (#5959)
* feat: Add "generate email" to action on nominees page (#4893)

* fix: Use bare email address for now
2023-07-17 16:00:16 -05:00
Robert Sparks 83a13a58ba
doc: nudge windows developers towards WSL2 (#5968) 2023-07-14 18:39:03 -05:00