altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity
16478 commits 1 branch 0 tags 2.6 GiB
Commit graph

532 commits

Author SHA1 Message Date
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz e314bb4723 Undid delete of ietf/nomcom/fields; it's currently needed by ietf/nomcom/migrations/0001_initial.py 
- Legacy-Id: 16403
 2019-07-04 22:04:42 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports. 
- Legacy-Id: 16402
 2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit 
- Legacy-Id: 16401
 2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output. 
- Legacy-Id: 16400
 2019-07-04 21:01:39 +00:00
Henrik Levkowetz 1e115539c4 The previous nomcom.fields.EncryptedTextField relied on initial cleartext content having the same type as ciphertext. Under Python3, that's not the case (ciphertext has type bytes). Rewrote the nomcom app and tests to handle capture of comments and encryption to the Feedback.comments ciphertext differently. 
- Legacy-Id: 16350
 2019-07-01 11:59:59 +00:00
Henrik Levkowetz a73e84a84c Removed 
- Legacy-Id: 16347
 2019-07-01 11:46:40 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues. 
- Legacy-Id: 16341
 2019-06-30 20:54:09 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...) 
- Legacy-Id: 16336
 2019-06-29 13:43:31 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__() 
- Legacy-Id: 16330
 2019-06-28 21:07:08 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz f54d6cd23d Merged in [16092] from rcross@amsl.com: 
Remove ability to cancel a break session.  Fixes #2703.
 - Legacy-Id: 16105
Note: SVN reference [16092] has been migrated to Git commit b5850d5c7f
 2019-03-26 15:53:41 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream. 
- Legacy-Id: 15809
 2018-12-11 22:38:05 +00:00
Henrik Levkowetz 5cd155429d Fixed a pyflakes error 
- Legacy-Id: 15750
 2018-11-11 12:05:09 +00:00
Henrik Levkowetz 129a1520d0 Corredted the rendering of non-ascii email names in nomcom templates. 
- Legacy-Id: 15749
 2018-11-10 20:37:27 +00:00
Henrik Levkowetz 4049b31026 Added normalization of the email addresses returned by ietf.nomcom.utils.parse_email, in order to not treat feedback from the same person as coming from different sources due to email name+address variations. 
- Legacy-Id: 15731
 2018-11-06 11:47:11 +00:00
Henrik Levkowetz 5ebeceaa8d Removed a test for the microscopic photos on the nomcom feedback page buttons. 
- Legacy-Id: 15616
 2018-10-30 11:45:58 +00:00
Henrik Levkowetz fcddc86447 Fixed some incorrect topic audience id slugs, to make the topic availability filtering work correctly. 
- Legacy-Id: 15598
 2018-10-19 12:53:16 +00:00
Henrik Levkowetz e20e8b7df5 Changed the mail sending routines so it's possible to not copy the debug archive on some messages. 
- Legacy-Id: 15585
 2018-10-16 14:32:10 +00:00
Henrik Levkowetz 6f9fbea6d3 Updated the nomcom admin pages for Feedback to make it possible to see and sort on the Nominees field. 
- Legacy-Id: 15558
 2018-10-11 13:40:15 +00:00
Henrik Levkowetz 8c985fe440 Turned the nomcom chair dropdown menu item 'Classify pending feedback' into a tab with a mail count badge. 
- Legacy-Id: 15544
 2018-10-08 15:11:21 +00:00
Henrik Levkowetz 7ac1556fbf Migration for changed default sort order for nominees. 
- Legacy-Id: 15535
 2018-10-08 13:03:21 +00:00
Henrik Levkowetz b984422471 Added pagination to the nomcom pending-feedback page, to reduce load time. 
- Legacy-Id: 15534
 2018-10-08 11:51:21 +00:00
Henrik Levkowetz 8a5e302745 Corrected the nominee ordering change. 
- Legacy-Id: 15533
 2018-10-08 10:26:00 +00:00
Henrik Levkowetz 64ba033a6c Changed the default sort for nomcom.models.Nominees to be 'person__name'. 
- Legacy-Id: 15532
 2018-10-08 09:55:10 +00:00
Henrik Levkowetz fc027ae161 Built out test_edit_nomcom_view() to also test adding and removing reminder dates. 
- Legacy-Id: 15524
 2018-10-06 13:01:08 +00:00
Henrik Levkowetz 2c2effde4f Added a form clean() for the reminder dates of the nomcom edit form, to make something appropriate out of edits that remove reminder dates, rather than clicking 'delete'. This fixes a potential exception, when a blank date cannot be saved, and also does what the user expected (deletes a blanked date). 
- Legacy-Id: 15521
 2018-10-04 18:03:41 +00:00
Henrik Levkowetz 29ae7809d7 Merged in [15486] from rjsparks@nostrum.com: 
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598.
 - Legacy-Id: 15487
Note: SVN reference [15486] has been migrated to Git commit 4d5de5dee6
 2018-09-26 21:54:05 +00:00
Robert Sparks 4d5de5dee6 Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598. Commit ready for merge. 
- Legacy-Id: 15486
 2018-09-26 18:57:30 +00:00
Henrik Levkowetz 4f2f843a55 A string.Template with a unicode template must be given unicode dictionary values if the values contain unicode codepoints. Providing values that are objects with __str__() methods, or utf-8 encoded strings doesn't work. Fixes an issue with nomcom template interpolation for nominees with non-ascii names. 
- Legacy-Id: 15481
 2018-09-24 21:25:20 +00:00
Henrik Levkowetz 120d78bbbf Changed the sort order of nominees on the private index page to be according to name (instead of email address). 
- Legacy-Id: 15479
 2018-09-21 19:47:40 +00:00
Henrik Levkowetz 5f512226a5 Added a missing migration and updated nomcom.resources to match model changes. 
- Legacy-Id: 15465
 2018-09-18 12:53:39 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively. 
- Legacy-Id: 15464
 2018-09-16 23:12:43 +00:00
Peter E. Yee 047b91862c Fixed 2 trivial spelling errors in NomCom tools. Fixes issue #2569. Commit ready for merge. 
- Legacy-Id: 15441
 2018-08-17 04:24:51 +00:00
Henrik Levkowetz 35e16ef7d5 Changed User ForeignKeys to not delete objects pointing at a user when the user is deleted, instead setting the ForeignKey field to None. 
- Legacy-Id: 15257
 2018-06-14 18:53:48 +00:00
Henrik Levkowetz 46bee81bdc Fixed a test email object creation issue. 
- Legacy-Id: 15180
 2018-05-28 09:48:27 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin. 
- Legacy-Id: 15172
 2018-05-26 08:32:20 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries. 
- Legacy-Id: 15127
 2018-05-05 12:40:30 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504. 
- Legacy-Id: 15095
 2018-04-27 14:00:33 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues. 
- Legacy-Id: 14664
 2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz fcc22da623 Removed a chunk of code that won't be executed in all test environments from the test coverage measurements 
- Legacy-Id: 14550
 2018-01-23 17:29:41 +00:00
Henrik Levkowetz f996fe825f Added more test data for the eligibility view, in order to exercise all parts of the view code. 
- Legacy-Id: 14541
 2018-01-19 15:21:33 +00:00
Henrik Levkowetz 374950ede8 Removed code generating nomcom page urls which doesn't resolve any more. Added a comment about the eligibility view for previous nomcoms. 
- Legacy-Id: 14540
 2018-01-19 15:06:23 +00:00
Henrik Levkowetz 7921d613d5 Merged in [14533] from rjsparks@nostrum.com: 
Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257.
 - Legacy-Id: 14538
Note: SVN reference [14533] has been migrated to Git commit 4ce6b934b8
 2018-01-17 22:32:00 +00:00
Robert Sparks 4ce6b934b8 Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257. Commit ready for merge. 
- Legacy-Id: 14533
 2018-01-17 17:58:58 +00:00
Henrik Levkowetz c3f444eaf1 Merged in [14511] from rjsparks@nostrum.com: 
Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303.
 - Legacy-Id: 14513
Note: SVN reference [14511] has been migrated to Git commit 5835e52759
 2018-01-11 17:14:21 +00:00
Henrik Levkowetz 16e155356e Merged in [14506] from rjsparks@nostrum.com: 
Improved the resilience of the formatted_email nomcom filter. Fixes #1764.
 - Legacy-Id: 14512
Note: SVN reference [14506] has been migrated to Git commit 2dd1f0da29
 2018-01-11 16:41:15 +00:00
Robert Sparks 5835e52759 Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303. Commit ready for merge. 
- Legacy-Id: 14511
 2018-01-11 16:28:19 +00:00
Henrik Levkowetz 78304b4d57 Merged in [14505] from rjsparks@nostrum.com: 
Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852.
 - Legacy-Id: 14510
Note: SVN reference [14505] has been migrated to Git commit c8b451094a
 2018-01-11 16:07:21 +00:00
Henrik Levkowetz 0bd9dbaab3 Removed some unused imports. 
- Legacy-Id: 14509
 2018-01-11 15:00:02 +00:00
Henrik Levkowetz 5e0335bbe3 Removed some dead code. 
- Legacy-Id: 14508
 2018-01-11 13:22:04 +00:00
Robert Sparks 2dd1f0da29 Improved the resilience of the formatted_email nomcom filter. Fixes #1764. Commit ready for merge. 
- Legacy-Id: 14506
 2018-01-10 22:42:18 +00:00
Robert Sparks c8b451094a Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852. Commit ready for merge. 
- Legacy-Id: 14505
 2018-01-10 21:54:10 +00:00
Robert Sparks 94f4e9ac58 Simplify the edit nomcom members forms. Fixes #1756. Commit ready for merge. 
- Legacy-Id: 14504
 2018-01-10 18:26:20 +00:00
Henrik Levkowetz a5e5bb1aab Expanded one of the nomcom tests a bit, and updated a fixture to match the current /nomcom/default/email/feedback_receipt.txt template. 
- Legacy-Id: 14223
 2017-10-20 14:34:03 +00:00
Henrik Levkowetz ac8e18480e Added tests for correct nomcom email from-address to the nomcom tests, and did some refactoring to improve test failure messages. 
- Legacy-Id: 14176
 2017-09-28 09:09:51 +00:00
Henrik Levkowetz 166c7531f9 Changed the nomcom code to permit nomcom year interpolation in the nomcom from-address and in nomcom templates. Changed the nomcom from-address setting to 'nomcom-chair-{year}@ietf.org'. 
- Legacy-Id: 14175
 2017-09-27 21:20:59 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name. 
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
 2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code. 
- Legacy-Id: 14128
 2017-09-17 15:12:18 +00:00
Henrik Levkowetz e393b83f6b Merged in [14058] from rjsparks@nostrum.com: 
Further refinements to the nominee status table. Related to #2261.
 - Legacy-Id: 14068
Note: SVN reference [14058] has been migrated to Git commit 7cecd9fe38
 2017-08-23 17:30:00 +00:00
Henrik Levkowetz 2b2753635f Merged in [14057] from rjsparks@nostrum.com: 
Improve the nominee status table to serve as a nomcom dashboard. Fixes #2261.
 - Legacy-Id: 14067
Note: SVN reference [14057] has been migrated to Git commit 2dbb0766fd
 2017-08-23 15:06:12 +00:00
Robert Sparks 7cecd9fe38 Further refinements to the nominee status table. Related to #2261. Commit ready for merge. 
- Legacy-Id: 14058
 2017-08-16 21:59:51 +00:00
Robert Sparks 2dbb0766fd Improve the nominee status table to serve as a nomcom dashboard. Fixes #2261. Commit ready for merge. 
- Legacy-Id: 14057
 2017-08-16 20:42:33 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing. 
- Legacy-Id: 14021
 2017-08-01 14:00:29 +00:00
Henrik Levkowetz c4954e13b1 Added more test objects in test_merge_users(), and fixed an issue with merge_users() uncovered by the added testing. 
- Legacy-Id: 13730
 2017-06-29 14:53:00 +00:00
Henrik Levkowetz 3c727106a2 Merged in [13717] from rjsparks@nostrum.com: 
Actually use the topic audience type in the feedback view. Fixes #2320.
 - Legacy-Id: 13728
Note: SVN reference [13717] has been migrated to Git commit 9638cb2e397beab18f3607b324518fd2900215f7
 2017-06-29 12:52:25 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode. 
- Legacy-Id: 13673
 2017-06-18 18:23:18 +00:00
Ryan Cross e9b7c5753e Refactor ietf/bin/merge-person-records to facilitate testing. Add tests. Fixes #2162. Commit ready for merge. 
- Legacy-Id: 13567
 2017-06-08 23:28:43 +00:00
Henrik Levkowetz f2b0881dae Corrected the add_topics migration 
- Legacy-Id: 13525
 2017-06-05 12:27:45 +00:00
Henrik Levkowetz d041edf1b3 Merged in [13501] from rjsparks@nostrum.com: 
Use a simpler widget for the public key file when editing a nomcom to remove confusion between clearing keys and clearing the form control. Fixes #2299.
 - Legacy-Id: 13519
Note: SVN reference [13501] has been migrated to Git commit ca76f5c8f0fbf0832440680381380995b0092ea7
 2017-06-04 19:40:26 +00:00
Henrik Levkowetz 495169de21 Merged in [13474] from rjsparks@nostrum.com: 
Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846.
 - Legacy-Id: 13506
Note: SVN reference [13474] has been migrated to Git commit 4813177086
 2017-06-03 13:50:44 +00:00
Henrik Levkowetz 5b2087f910 Eliminated several variations on word wrapping, keeping only what used to be wrap_text(), but renamed as ietf.utils.text.wordwrap(). This performs better than django.utils.text.wrap() when there are indented text parts. Replaced django's default wordwrap filter with one calling ietf.utils.text.wordwrap in templates. Changed to triggered wrapping in some cases, with the maybewordwrap filter, which triggers on lines longer than 100 characters. This fixes the issue with undesired wrapping of reviews. 
- Legacy-Id: 13505
 2017-06-02 23:13:22 +00:00
Robert Sparks 4813177086 Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846. Commit ready for merge. 
- Legacy-Id: 13474
 2017-05-30 19:54:31 +00:00
Robert Sparks c49abdd557 Allow nomcoms to configure the feedback page to show nominee pictures. Fixes #2252. Commit ready for merge, 
- Legacy-Id: 13413
 2017-05-23 22:18:04 +00:00
Robert Sparks ab6820e938 Correctly calculate statistics on the nomcom private index page. Fixes #2254. Commit ready for merge. 
- Legacy-Id: 13400
 2017-05-22 19:07:52 +00:00
Robert Sparks ac8e5f5402 Make it possible to close nominations without closing feedback. Fixes #2255. Commit ready for merge. 
- Legacy-Id: 13399
 2017-05-22 18:40:05 +00:00
Robert Sparks 1a18130c57 Avoid confusing messages saying a key has not been entered when it has. Fixes #2250. Commit ready for merge. 
- Legacy-Id: 13390
 2017-05-17 21:02:20 +00:00
Robert Sparks 4b0fefeb3e Revert an attempt to improve a nomcom test. Affects #2260. Commit ready for merge. 
- Legacy-Id: 13389
 2017-05-17 16:45:58 +00:00
Robert Sparks ceff54480c Update the feedback count badge when new feedback is provided. Fixes #2260. Commit ready for merge. 
- Legacy-Id: 13388
 2017-05-17 13:55:39 +00:00
Robert Sparks cf382d30bb Don't double-escape when showing feedback. Fixes #2297. Commit ready for merge. 
- Legacy-Id: 13383
 2017-05-16 22:25:52 +00:00
Henrik Levkowetz 3bccc5b3e6 Converted the make/delete_dummy_nomcom scripts to a management command. 
- Legacy-Id: 13236
 2017-04-18 21:14:37 +00:00
Robert Sparks 0088273f5a Adds scripts to create/delete a dummy nomcom to use in development environments. Commit ready for merge. Fixes #2283. 
- Legacy-Id: 13230
 2017-04-18 16:13:14 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method. 
- Legacy-Id: 13157
 2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Henrik Levkowetz dd7b3eb71a Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12833
 2017-02-13 21:37:41 +00:00
Henrik Levkowetz 9b23816a22 Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12832
 2017-02-13 20:58:28 +00:00
Henrik Levkowetz e5f889764c Fixed a problem with stability of test_accept_reject_nomination_edges(), and made some changes to make debugging this easier. 
- Legacy-Id: 12829
 2017-02-13 15:55:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function. 
- Legacy-Id: 12815
 2017-02-10 14:49:16 +00:00
Henrik Levkowetz 2b4f4b0302 Merged django-1.10 work forward to 6.43.0 
- Legacy-Id: 12812
 2017-02-10 11:05:43 +00:00
Henrik Levkowetz deb8ab6dba Changed the nomcom __getattr__ mixin manager so as to not interfere with django 1.10 internals. 
- Legacy-Id: 12811
 2017-02-10 11:02:06 +00:00
Henrik Levkowetz c7ec188d3f Added a migration to capture the ordering option on Nominee. 
- Legacy-Id: 12801
 2017-02-10 10:29:07 +00:00
Henrik Levkowetz 0c784f9976 Added an ordering for Nominee objects. 
- Legacy-Id: 12800
 2017-02-09 21:07:22 +00:00
Henrik Levkowetz 996f78135d Expanded the nominee __unicode__() method to provide unique results by including the nomcom year. 
- Legacy-Id: 12799
 2017-02-09 21:02:43 +00:00
Henrik Levkowetz 1fef6fb1d3 Deprecation fix: removed additional cases of using instance_context in render*() 
- Legacy-Id: 12720
 2017-01-23 22:56:34 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach. 
- Legacy-Id: 12645
 2017-01-11 18:42:38 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns() 
- Legacy-Id: 12623
 2016-12-22 18:14:57 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade. 
- Legacy-Id: 12478
 2016-12-07 19:41:48 +00:00
Henrik Levkowetz 90bf63f01e Fixed the import path for formtools. 
- Legacy-Id: 12263
 2016-11-03 20:54:35 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense. 
- Legacy-Id: 12256
 2016-11-03 20:13:44 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes. 
- Legacy-Id: 12253
 2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function. 
- Legacy-Id: 12252
 2016-11-03 20:08:44 +00:00
Henrik Levkowetz 236fb3e185 Make it possible to merge nominations with inactive email addresses in the Nominee Merge form. 
- Legacy-Id: 12091
 2016-10-05 17:03:31 +00:00
Henrik Levkowetz 851b9b3d2f Fixed a problem with the error message text for the nominee email edit form. 
- Legacy-Id: 12087
 2016-10-05 15:14:33 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur. 
- Legacy-Id: 12035
 2016-09-25 13:53:22 +00:00
Henrik Levkowetz 26fcce9c28 Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task. 
- Legacy-Id: 12017
 2016-09-22 14:23:20 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking). 
- Legacy-Id: 11941
 2016-09-08 14:48:59 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions. 
- Legacy-Id: 11436
 2016-06-21 07:51:02 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257 
- Legacy-Id: 11259
 2016-06-01 16:37:01 +00:00
Henrik Levkowetz 6e6a8baa13 Fixed a typo. 
- Legacy-Id: 10931
 2016-03-15 23:15:44 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources. 
- Legacy-Id: 10929
 2016-03-15 23:12:04 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0 
- Legacy-Id: 10896
 2016-03-04 21:24:26 +00:00
Robert Sparks a9abd3c2cd Tweak factories to not randomly create keys that violate constraints. Commit ready for merge 
- Legacy-Id: 10756
 2016-01-28 20:12:00 +00:00
Henrik Levkowetz e552ff85b7 Tentatively comment out use of tempdir() in nomcom.tests. 
- Legacy-Id: 10704
 2016-01-16 22:30:05 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com: 
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
 2016-01-15 21:59:49 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting. 
- Legacy-Id: 10620
 2015-12-22 04:32:48 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person. 
- Legacy-Id: 10619
 2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages 
- Legacy-Id: 10618
 2015-12-21 20:46:56 +00:00
Robert Sparks 2120b79d6b collapse some duplicated code 
- Legacy-Id: 10617
 2015-12-21 16:50:46 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors. 
- Legacy-Id: 10610
 2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField 
- Legacy-Id: 10609
 2015-12-18 20:38:17 +00:00
Robert Sparks a2af7cfa25 Removed BaseNomcomForm and the notion of custom fieldsets 
- Legacy-Id: 10608
 2015-12-17 22:31:29 +00:00
Robert Sparks ebb6884b70 Beginning to rework Nominee and Nomination 
- Legacy-Id: 10607
 2015-12-17 21:53:39 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96% 
- Legacy-Id: 10606
 2015-12-16 23:12:40 +00:00
Robert Sparks f68d546233 removed move_to_default 
- Legacy-Id: 10603
 2015-12-16 12:07:32 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default 
- Legacy-Id: 10602
 2015-12-16 11:51:32 +00:00
Robert Sparks bf54e2b3f5 Regroup multiselect options to make classifying pending feedback simpler. Make the control larger and resizable. Fixes #1854. 
- Legacy-Id: 10593
 2015-12-14 23:14:44 +00:00
Robert Sparks 5e0632e8eb Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866. 
- Legacy-Id: 10592
 2015-12-14 21:05:52 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845. 
- Legacy-Id: 10589
 2015-12-14 03:26:43 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit) 
- Legacy-Id: 10587
 2015-12-12 03:49:23 +00:00
Robert Sparks d2f1d1ff12 corrected an improper import and removed some flakes 
- Legacy-Id: 10582
 2015-12-11 19:49:33 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix 
- Legacy-Id: 10581
 2015-12-11 17:30:13 +00:00
Robert Sparks 6574618cdf a stab in the dark at initializing the public_key in a test friendly way 
- Legacy-Id: 10575
 2015-12-11 05:06:58 +00:00
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys 
- Legacy-Id: 10574
 2015-12-11 04:01:11 +00:00
Robert Sparks 66e89e7d29 improved creation of FeedbackLastSeen 
- Legacy-Id: 10572
 2015-12-10 23:07:57 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks d65987b935 Improve the questionnaire templates, reminding the nominee that receiving the questionnaire does not imply they have accepted the nomination. Fixes #1807. 
- Legacy-Id: 10534
 2015-12-02 17:01:10 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template 
- Legacy-Id: 10531
 2015-12-02 15:45:40 +00:00
Robert Sparks 2a63f91d31 Simplify pass of counts 
- Legacy-Id: 10527
 2015-12-02 04:44:42 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query 
- Legacy-Id: 10526
 2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges. 
- Legacy-Id: 10525
 2015-12-02 03:32:06 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809. 
- Legacy-Id: 10524
 2015-11-29 21:12:19 +00:00
Robert Sparks 473970a767 Missed an svn add 
- Legacy-Id: 10523
 2015-11-29 04:16:07 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771. 
- Legacy-Id: 10522
 2015-11-29 04:00:02 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795. 
- Legacy-Id: 10505
 2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Henrik Levkowetz 97f7159a48 Migration for the nomcom 'public_key' field change to a settings-agnostic FileStorage. 
- Legacy-Id: 10301
 2015-10-27 15:34:43 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Henrik Levkowetz 4eaadddf9e Changed nomcom.models.Nomcom() to use a FileSystemStorage which doesn't record the file system location in the migration, in order to avoid having model changes detected when switching from one development path to another. 
- Legacy-Id: 10280
 2015-10-24 20:13:18 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead. 
- Legacy-Id: 10228
 2015-10-18 11:49:15 +00:00
Ole Laursen 73a41bb7e6 Summary: Fix problem with three NomCom tests that had a hard-coded id, 
which doesn't necessarily work with the way transactions work in MySQL
 - Legacy-Id: 10190
 2015-10-12 15:03:00 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward. 
- Legacy-Id: 10157
 2015-10-09 03:16:24 +00:00
Henrik Levkowetz e1cc8218e7 Merged in [10115] from rjsparks@nostrum.com: 
Remove an extraneous field from the form that lets the nomcom chair paste in a questionnaire response.
 - Legacy-Id: 10118
Note: SVN reference [10115] has been migrated to Git commit 3ee236d3ee25dffdd3516b0740251705c4db248c
 2015-10-01 20:44:47 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow 
- Legacy-Id: 10040
 2015-08-23 18:15:06 +00:00
Henrik Levkowetz cb75c7d908 Added a migration for the Nomination.share_nominator field. 
- Legacy-Id: 10039
 2015-08-23 09:15:20 +00:00
Henrik Levkowetz f6c78bcecb Merged in [10004] from rjsparks@nostrum.com: 
Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703.
 - Legacy-Id: 10037
Note: SVN reference [10004] has been migrated to Git commit 1517efaba2
 2015-08-22 18:00:16 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing. 
- Legacy-Id: 10035
 2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc 
- Legacy-Id: 10034
 2015-08-20 04:23:40 +00:00
Robert Sparks 65be4190a7 Done with the first pass instrumenting all mail points. There is one spot in the ipr code that's complicated and will require some refactor before instrumenting. There are a few places to add explicit messages (templates and all) to replace the simple use of email_ad. The next pass will be to make sure every spot that sends mail is covered by a test, and that the tests look at the headers sensibly. That will be followed by a moderately heavy refactor of MailToken and the gather_address utilities. Then pages showing the expansions of a token for a given document/group. Long way to go, but this is working well, and I think it will make things much easier later. 
- Legacy-Id: 10030
 2015-08-19 21:53:02 +00:00
Henrik Levkowetz 0449ebcdfa Merged in [10002] from rjsparks@nostrum.com: 
Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee.
 - Legacy-Id: 10023
Note: SVN reference [10002] has been migrated to Git commit bcc14cb0d1
 2015-08-18 15:39:12 +00:00
Robert Sparks 1517efaba2 Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703. Commit ready for merge. 
- Legacy-Id: 10004
 2015-08-10 18:28:08 +00:00
Robert Sparks bcc14cb0d1 Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee. Commit ready for merge. 
- Legacy-Id: 10002
 2015-08-10 17:57:38 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually. 
- Legacy-Id: 9991
 2015-08-09 16:28:55 +00:00
Henrik Levkowetz 8905ac1789 If the author of a nomcom nomination is unknown, use 'Anonymous' and no email address in outgoing messages, instead of ''. 
- Legacy-Id: 9627
 2015-05-13 16:55:53 +00:00
Henrik Levkowetz db255a86ac Don't show the unused 'author' field in the public nomcom feedback form. Fixes issue #1699. 
- Legacy-Id: 9617
 2015-05-11 21:03:25 +00:00
Henrik Levkowetz 869363e0b0 Fixed a problem with nomcom classification forms showing too many fields. 
- Legacy-Id: 9611
 2015-05-11 19:13:52 +00:00
Henrik Levkowetz 4966e17158 Added 5 migrations for changes in model field help-text strings which changed in the facelift. Also fixed the expression of the help text for NomCom.reminder_interval so the text itself doesn't contain quite as much whitespace. 
- Legacy-Id: 9589
 2015-04-30 16:18:25 +00:00
Henrik Levkowetz 85f9eee27b Updated a set of nomcom tests to account for new facelift DOM attributes. 
- Legacy-Id: 9361
 2015-04-02 19:49:11 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy 
- Legacy-Id: 9357
 2015-04-02 06:51:34 +00:00
Joel M. Halpern 8cab64c2fe added some nomcom test cases. Commit ready for merge. 
- Legacy-Id: 9317
 2015-03-21 22:37:43 +00:00
Henrik Levkowetz 6044944b00 Removed a cut-and-paste error. 
- Legacy-Id: 9249
 2015-03-19 17:54:06 +00:00
Henrik Levkowetz ddbb8c18a5 Updated the nomcom tests to use temporary test directories for data, instead of the regular values in settings.py 
- Legacy-Id: 9248
 2015-03-19 17:52:31 +00:00
Henrik Levkowetz 45761e5c7f Changed the nomcom.forms.FullFeedbackFormSet to use modelformsets_factory() instead of direct subclassing, in order to avoid a crash when using the form, caused by a missing instance attribute. 
- Legacy-Id: 9154
 2015-03-06 18:16:33 +00:00
Henrik Levkowetz 9209be4656 Added back a functioning get_fieldsets() method, which was removed instead of corrected in the Django 1.7 upgrade. 
- Legacy-Id: 9084
 2015-02-13 12:03:32 +00:00
Henrik Levkowetz 071dfc6f8e Cleanup after Django 1.7 migration 
- Legacy-Id: 9082
 2015-02-12 16:38:01 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts 
- Legacy-Id: 9072
 2015-02-12 10:43:52 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9028
 2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir). 
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
 2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9026
 2015-02-08 19:16:46 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it 
- Legacy-Id: 8940
 2015-01-28 13:25:21 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut. 
- Legacy-Id: 8896
 2015-01-22 17:38:05 +00:00