altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16478 commits 1 branch 0 tags 2.6 GiB
Commit graph

175 commits

Author SHA1 Message Date
Robert Sparks fd38a9bf96 Add RFC 8989 nomcom eligibility calculations. Commit ready for merge. 
- Legacy-Id: 18975
 2021-05-06 19:42:09 +00:00
Robert Sparks bcc280fe9b tightened edge for group office rule 
- Legacy-Id: 18972
 2021-05-06 13:51:29 +00:00
Robert Sparks 216ec499df Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation. 
- Legacy-Id: 18971
 2021-05-01 19:57:04 +00:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts. 
- Legacy-Id: 18792
 2021-01-12 16:54:20 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768. 
- Legacy-Id: 18770
 2020-12-16 23:53:37 +00:00
Jim Fenton 431a112bf1 Added NomCom membership history page. Fixes issue #3006. Branch ready for merge. 
- Legacy-Id: 18601
 2020-10-12 02:36:16 +00:00
Henrik Levkowetz efcdc4d917 Updated meeting attendance and nomcom eligibility calculations to take the MeetingRegistration.attendance flag into account. 
- Legacy-Id: 17955
 2020-06-09 21:00:07 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain. 
- Legacy-Id: 17807
 2020-05-16 20:20:05 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584. 
- Legacy-Id: 17593
 2020-04-07 16:02:52 +00:00
Henrik Levkowetz dc4c05ec5b Changed the object factory instances of nomcom private key and cert to be byte objects (matching the production settings), and fixed the issue with nomcom key handling under Py3 found by fenton@bluepopcorn.net. Did some renaming in nomcom/tests.py to better match setup/teardown function names to functionality. 
- Legacy-Id: 17536
 2020-03-25 13:36:29 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances. 
- Legacy-Id: 17390
 2020-03-05 20:46:58 +00:00
Henrik Levkowetz fa4adeb374 Fixed a number of bad Message.content_type settings. 
- Legacy-Id: 17339
 2020-02-26 17:05:53 +00:00
Jennifer Richards cd77c76372 Add links to user profiles from nominee list and feedback page. Fixes #2839. Commit ready for merge. 
- Legacy-Id: 17275
 2020-02-05 21:10:47 +00:00
Robert Sparks cca04b6330 Correct construction for a reverse URL in an edge case. Fixes #2815. Commit ready for merge. 
- Legacy-Id: 16907
 2019-10-22 18:24:57 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue. 
- Legacy-Id: 16461
 2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc. 
- Legacy-Id: 16458
 2019-07-15 19:14:04 +00:00
Henrik Levkowetz 1e115539c4 The previous nomcom.fields.EncryptedTextField relied on initial cleartext content having the same type as ciphertext. Under Python3, that's not the case (ciphertext has type bytes). Rewrote the nomcom app and tests to handle capture of comments and encryption to the Feedback.comments ciphertext differently. 
- Legacy-Id: 16350
 2019-07-01 11:59:59 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...) 
- Legacy-Id: 16336
 2019-06-29 13:43:31 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 5ebeceaa8d Removed a test for the microscopic photos on the nomcom feedback page buttons. 
- Legacy-Id: 15616
 2018-10-30 11:45:58 +00:00
Henrik Levkowetz fcddc86447 Fixed some incorrect topic audience id slugs, to make the topic availability filtering work correctly. 
- Legacy-Id: 15598
 2018-10-19 12:53:16 +00:00
Henrik Levkowetz fc027ae161 Built out test_edit_nomcom_view() to also test adding and removing reminder dates. 
- Legacy-Id: 15524
 2018-10-06 13:01:08 +00:00
Robert Sparks 4d5de5dee6 Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598. Commit ready for merge. 
- Legacy-Id: 15486
 2018-09-26 18:57:30 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries. 
- Legacy-Id: 15127
 2018-05-05 12:40:30 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504. 
- Legacy-Id: 15095
 2018-04-27 14:00:33 +00:00
Henrik Levkowetz f996fe825f Added more test data for the eligibility view, in order to exercise all parts of the view code. 
- Legacy-Id: 14541
 2018-01-19 15:21:33 +00:00
Robert Sparks 4ce6b934b8 Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257. Commit ready for merge. 
- Legacy-Id: 14533
 2018-01-17 17:58:58 +00:00
Robert Sparks c8b451094a Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852. Commit ready for merge. 
- Legacy-Id: 14505
 2018-01-10 21:54:10 +00:00
Robert Sparks 94f4e9ac58 Simplify the edit nomcom members forms. Fixes #1756. Commit ready for merge. 
- Legacy-Id: 14504
 2018-01-10 18:26:20 +00:00
Henrik Levkowetz a5e5bb1aab Expanded one of the nomcom tests a bit, and updated a fixture to match the current /nomcom/default/email/feedback_receipt.txt template. 
- Legacy-Id: 14223
 2017-10-20 14:34:03 +00:00
Henrik Levkowetz ac8e18480e Added tests for correct nomcom email from-address to the nomcom tests, and did some refactoring to improve test failure messages. 
- Legacy-Id: 14176
 2017-09-28 09:09:51 +00:00
Henrik Levkowetz 3c727106a2 Merged in [13717] from rjsparks@nostrum.com: 
Actually use the topic audience type in the feedback view. Fixes #2320.
 - Legacy-Id: 13728
Note: SVN reference [13717] has been migrated to Git commit 9638cb2e397beab18f3607b324518fd2900215f7
 2017-06-29 12:52:25 +00:00
Ryan Cross e9b7c5753e Refactor ietf/bin/merge-person-records to facilitate testing. Add tests. Fixes #2162. Commit ready for merge. 
- Legacy-Id: 13567
 2017-06-08 23:28:43 +00:00
Robert Sparks 4813177086 Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846. Commit ready for merge. 
- Legacy-Id: 13474
 2017-05-30 19:54:31 +00:00
Robert Sparks c49abdd557 Allow nomcoms to configure the feedback page to show nominee pictures. Fixes #2252. Commit ready for merge, 
- Legacy-Id: 13413
 2017-05-23 22:18:04 +00:00
Robert Sparks ac8e5f5402 Make it possible to close nominations without closing feedback. Fixes #2255. Commit ready for merge. 
- Legacy-Id: 13399
 2017-05-22 18:40:05 +00:00
Robert Sparks 1a18130c57 Avoid confusing messages saying a key has not been entered when it has. Fixes #2250. Commit ready for merge. 
- Legacy-Id: 13390
 2017-05-17 21:02:20 +00:00
Robert Sparks 4b0fefeb3e Revert an attempt to improve a nomcom test. Affects #2260. Commit ready for merge. 
- Legacy-Id: 13389
 2017-05-17 16:45:58 +00:00
Robert Sparks ceff54480c Update the feedback count badge when new feedback is provided. Fixes #2260. Commit ready for merge. 
- Legacy-Id: 13388
 2017-05-17 13:55:39 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method. 
- Legacy-Id: 13157
 2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Henrik Levkowetz dd7b3eb71a Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12833
 2017-02-13 21:37:41 +00:00
Henrik Levkowetz 9b23816a22 Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12832
 2017-02-13 20:58:28 +00:00
Henrik Levkowetz e5f889764c Fixed a problem with stability of test_accept_reject_nomination_edges(), and made some changes to make debugging this easier. 
- Legacy-Id: 12829
 2017-02-13 15:55:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 26fcce9c28 Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task. 
- Legacy-Id: 12017
 2016-09-22 14:23:20 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions. 
- Legacy-Id: 11436
 2016-06-21 07:51:02 +00:00
Henrik Levkowetz e552ff85b7 Tentatively comment out use of tempdir() in nomcom.tests. 
- Legacy-Id: 10704
 2016-01-16 22:30:05 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting. 
- Legacy-Id: 10620
 2015-12-22 04:32:48 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person. 
- Legacy-Id: 10619
 2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages 
- Legacy-Id: 10618
 2015-12-21 20:46:56 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors. 
- Legacy-Id: 10610
 2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField 
- Legacy-Id: 10609
 2015-12-18 20:38:17 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96% 
- Legacy-Id: 10606
 2015-12-16 23:12:40 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default 
- Legacy-Id: 10602
 2015-12-16 11:51:32 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845. 
- Legacy-Id: 10589
 2015-12-14 03:26:43 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix 
- Legacy-Id: 10581
 2015-12-11 17:30:13 +00:00
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys 
- Legacy-Id: 10574
 2015-12-11 04:01:11 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead. 
- Legacy-Id: 10228
 2015-10-18 11:49:15 +00:00
Ole Laursen 73a41bb7e6 Summary: Fix problem with three NomCom tests that had a hard-coded id, 
which doesn't necessarily work with the way transactions work in MySQL
 - Legacy-Id: 10190
 2015-10-12 15:03:00 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing. 
- Legacy-Id: 10035
 2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc 
- Legacy-Id: 10034
 2015-08-20 04:23:40 +00:00
Henrik Levkowetz 85f9eee27b Updated a set of nomcom tests to account for new facelift DOM attributes. 
- Legacy-Id: 9361
 2015-04-02 19:49:11 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy 
- Legacy-Id: 9357
 2015-04-02 06:51:34 +00:00
Joel M. Halpern 8cab64c2fe added some nomcom test cases. Commit ready for merge. 
- Legacy-Id: 9317
 2015-03-21 22:37:43 +00:00
Henrik Levkowetz ddbb8c18a5 Updated the nomcom tests to use temporary test directories for data, instead of the regular values in settings.py 
- Legacy-Id: 9248
 2015-03-19 17:52:31 +00:00
Ole Laursen a3399b0bcd Summary: Port remaining parts of nomcom to bootstrap, fix some bugs, 
let the private/public feedback pages share the same template, remove
the edit NomCom chair thing - there's no link to it and the
Secretariat can instead use the ordinary group management tool they
have available
 - Legacy-Id: 8721
 2014-12-02 10:43:20 +00:00
Ole Laursen 87870ca954 Fix more test errors - now only two not yet fully ported views remain 
- Legacy-Id: 8571
 2014-11-03 16:39:41 +00:00
Henrik Levkowetz 0d61e270d6 Normalized a couple of NameModels subclasses. 
- Legacy-Id: 8460
 2014-10-23 21:14:41 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk. 
- Legacy-Id: 7579
 2014-04-06 20:04:36 +00:00
Henrik Levkowetz 563f584a9e Made ietf/nomcom pyflakes-clean. Removed some dead code. 
- Legacy-Id: 7476
 2014-03-15 19:26:01 +00:00
Ole Laursen 892c7d43ce Reuse already fetched page instead of refetching it in nomcom test 
- Legacy-Id: 6922
 2013-12-13 16:47:57 +00:00
Ole Laursen b302ffa814 Fix bug in nomcom test, it was sending a formset without the 
corresponding management form values
 - Legacy-Id: 6921
 2013-12-13 16:45:04 +00:00
Ole Laursen aea222edbc Speed up nomcom tests a bit more by also only generating one certificate for the client per run 
- Legacy-Id: 6920
 2013-12-13 16:28:55 +00:00
Ole Laursen 652a5ca17a Rewrite NomCom test data generation slightly based on the rewritten 
base test data, fix problem with form previews
 - Legacy-Id: 6918
 2013-12-13 15:59:52 +00:00
Ole Laursen e32d346bc5 Fix security_hash problem in nomcom tests, it's no longer a separate function 
- Legacy-Id: 6905
 2013-12-13 13:10:52 +00:00
Ole Laursen d0f2859631 Move NomCom announcements view to nomcom/, move message view to 
message/, add tests, add redirects, fix a couple of small bugs in the
announcements view
 - Legacy-Id: 6769
 2013-11-28 17:55:10 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00
Henrik Levkowetz 5f2da7ba9e Merged [6486] from rjsparks@nostrum.com: 
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
 - Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
 2013-10-30 21:17:46 +00:00
Henrik Levkowetz d649fd5e10 Merged [6465] and [6466] from rjsparks@nostrum.com: 
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state.  Changed the send_reminders management command to not take
any arguments and run against all active nomcoms.  Removed bugs from the
send_reminders management command and added tests for it.  Adjusted several
dbtemplate titles and content.

Fixes bug 1157
 - Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a

Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
 2013-10-21 20:12:00 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures. 
- Legacy-Id: 6320
 2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just 
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
 2013-09-29 17:35:59 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run. 
- Legacy-Id: 5948
 2013-08-06 10:09:29 +00:00
Emilio Jiménez ddbfdf4b7b change merge form, accepted vs any state: accepted, pending vs declined: declined 
Fixes #1016
 - Legacy-Id: 5701
 2013-05-07 11:50:13 +00:00
Emilio Jiménez c3ff510ed0 Change questionnaire response view. 
Fixes #1007
 - Legacy-Id: 5689
 2013-05-02 09:42:00 +00:00