in order to autogenerate dotted path url pattern names. Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.
Changed some imports to prevent import of ietf.urls before django
initialization was complete.
Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.
Started converting old-style middleware classes to new-style middleware
functions (incomplete).
Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.
Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.
Rewrote the filename argument handling in a management command which had
broken with the upgrade.
- Legacy-Id: 12818
review types so that teams will only have those review types
listed and suggested that they are configured to have.
Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.
Fix a couple of bugs.
- Legacy-Id: 12095
The IESG Telechat Agenda now shows "(Has RFC Editor Note)" after the I-D
filename if there is an RFC Editor Note associated with the document. This
was added to the html and txt versions of the agenda. It was not added to the
Secretariat view or the Scribe view of the agenda.
For transition, when an AD edits the RFC Editor Note, they need to move the
text from the current writeup into the new field. Returning documents on the
telechat agenda seems to be the biggest opportunity for something to fall
between the cracks. If an event of type "changed_rfc_editor_note' exists, and
the string "RFC Editor Note" appears in the text of the most recent
'changed_ballot_writeup_text' event, then a message is shown that tells the AD
to remove the RFC Editor Note from the writeup.
- Legacy-Id: 10783
Note: SVN reference [10770] has been migrated to Git commit 4b5ac9e09e
Note: SVN reference [10771] has been migrated to Git commit 46589ee421
Note: SVN reference [10772] has been migrated to Git commit c73659e95c
Note: SVN reference [10773] has been migrated to Git commit 2e6633c016
independent of the search form, to enable them to be reused in the
community lists.
Also clean up the related code a bit, use SearchForm to handle other
document types, and fix missing ids in the HTML so that one can click
the "by" labels to hit the corresponding radio button.
- Legacy-Id: 10729
settings.URL_REGEXPS, partly to cleanup the urls.py files, partly to
make sure that all URL patterns agree on what constitutes a name
- Legacy-Id: 10114
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.
To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.
While revising the existing code to work with this API, a couple of
missing events was discovered:
- In draft expiry, a "Document has expired" event was only generated
in case an IESG process had started on the document - now it's
always generated, as the document changes its state in any case
- Synchronization updates like title and abstract amendmends from the
RFC Editor were silently (except for RFC publication) applied and
not accompanied by a descriptive event - they now are
- do_replace in the Secretariat tools now adds an event
- Proceedings post_process in the Secretariat tools now adds an event
- do_withdraw in the Secretariat tools now adds an event
A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
- Legacy-Id: 10101
Django sets charset if you don't specify a content_type; if you specify
one you also must add a charset specification (if you want one).
Fixes issue #1647.
- Legacy-Id: 9348
The use of group.ad has been scrubbed from the code and templates.
- Those places that set group.ad have been directly manipulate Role objects instead
- Most places that read group.ad now use a new group.ad_role() that returns a Role object, simplifing some views.
Related to #1555 and #1557.
Commit ready for merge.
- Legacy-Id: 8854
- Migrates the information captured in GroupInfo.ad to Role objects.
- Renames GroupInfo.ad to GroupInfo._ad (retaining the current column name) to prepare for deletion of that field.
- Provides ad property accessor and setter methods implemented using the group's role_set (so that the existing view code continues to work with minimal changes)
- Improved selection in many querysets that assumed only groups of type 'area' would have area directors.
Related to #1557 and #1555.
Commit ready to merge.
- Legacy-Id: 8851
Made doc.active_defer_event() look for the events that are currently being created. This remains brittle.
Added email notifying the IESG of an undefer analagous to the defer email.
Guarded against deferring an already deferred document or undeferring a document that hasn't been deferred.
Guarded against deferring a document that's not scheduled for a telechat.
Fixes bugs 1417, 1465, 1417
- Legacy-Id: 8366
Note: SVN reference [8255] has been migrated to Git commit 0b49f402b4ec9145cb290b8a968755cc9ebdef92
to be agenda_package.txt and that file already includes the links that
are enabled by the flag - perhaps it predates the user modeling that
allows ADs and Secretariat to see the links
- Legacy-Id: 6398
utilities to agenda.py, fix a couple of things, remove obsolete test
versions of agenda view, add support for viewing future IESG agendas
through /agenda/YYYY-MM-DD/* (useful when testing)
- Legacy-Id: 6395
review decisions. Add migration to split up iesg_approve/disapprove
events of the form "IESG has approved ... and state has been changed
..." into the approve/disapprove event and a synthesized state change
event. Also regularize the descriptions a bit. This simplifies the
code in the new page.
- Legacy-Id: 6340
ballot text for drafts processed by the IESG) - it has not worked
since the switch to the new schema as it's based on the old numeric
primary keys which we no longer have
- Legacy-Id: 6313
just I-Ds, sort by latest first, limit to documents on current and
future telechats (as the description says) to speed it up, add simple
test of the feed
- Legacy-Id: 6312
(-r5465:HEAD from branch/iola/shimfree). Copying relevant
commit messages here:
- Deleted dead code in many places.
- Renamed id-something to draft-something, make the "is
this eligible for expiration" logic clearer
- Added a name for IPR search URL
- Revamped the ballot popup view
- URL reversed the IPR search link instead of hardcoding it
- Cleaned up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.
idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
- Fixed output bug in test crawler and print referrer upon errors so it's
easier to figure out where a link came from
- Added /doc/in-last-call/ to crawler, report original page as referrer in
a redirect chain rather than intermediate URL
- Ported idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
- Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
drafts in IESG process to new schema in /doc/iesg/ and
/doc/iesg/last-call/
- Added redirects for all of /idtracker/*, removed all view code and other
dead code from idtracker/
- Removed the idtracker sitemap indexing drafts - in its current form,
it adds nothing of value to the HTML-based /doc/all/ view, and it's
pretty slow
- Ported idtracker feeds to new schema, move them to doc/, cleaned up
idtracker/ - only templatetags/ietf_filters and proxy code is left
- Legacy-Id: 5836
(-r5194:5465 from branch/iola/shimfree). Copying relevant
commit messages here:
- Removed .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
- Added migration for transforming the .desc on the new_revision events
into something more akin to what is actually shown in the history page
- Added migration for blanking IESG notes that just consist of "RFC
XXXX", these have been superfluous for some time
- Grant stream chairs access to changing the stream on a draft
- Hacked the format_history_text filter to be less weird, using the same
formatting for snippets and full text, also link up legacy ballot set
events
- Moved the decoraters + utilities to new ietfauth/utils.py file
- Added simple helper to Email to identify invalid email addresses (from
legacy author entries)
- Used new new_revision .desc format for when drafts are submitted
- Improved the looks of the button class by adding extra contrast and a
linear gradient. Currently the gradient is only visible in fairly
recent browsers.
- Rewrote draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
- Fixed two bugs in RFC Editor syncing: make sure documents we don't know
beforehand get a "draft" type and make sure individually submitted
drafts get the type="individ" group instead of NULL
- Made the CSS-styled button feel a bit nicer to use by flattening the
active state, also introduce some temporary styles until browsers
catch up with the standard syntax
- Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
RFCs that didn't get their doc.type set, 3) a big bunch of historic
stand-alone RFCs that have doc.group=None - set these to the
individual submission "none" group for the time being so the view code
doesn't have to deal with a special case.
In some cases this is wrong since there actually was a WG associated
but unfortunately fixing them properly requires detective work
(probably parsing the RFCs) and in at least some cases recreating
historic WGs. In case someone ends up doing this, the documents to
check can still be found with
Document.objects.filter(name__startswith="rfc", group__type="individ")
since there are almost no new RFCs that didn't went through the I-D
process.
- Merged the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
- Fixed revision augmentation so events after RFC publication gets a "RFC"
designation
- Fixed a bug with tabs not using provided name but rather doc.name
- Displaying draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
- Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
- Refactored slightly to make views_doc.py independent of other idrfc code
- Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
- Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
- Now /doc/std1/ works, we can actually do a local link in
urlize_ietf_docs rather than linking to the tools.ietf.org server
- Fixed history text formatter: sanitize HTML before adding linebreaks and
non-breaking spaces, this cuts the time to render a history page with
long comments in half
- Added a test crawler that walks through the crawlable part of the site,
reporting errors and slow pages
- Got rid of initial "No record" positions when showing old positions,
it's just noise
- Added a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
- Introduced a simple cache in doc.get_state so repeated reads don't
cause a DB query
- Cleaned up the search code in preparation for removal of the shim-layer;
use a static button and don't send extraneous GET parameters
- Removed dead code in several places
- Legacy-Id: 5830
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
- Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.
idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
- Legacy-Id: 5611
* Added charters, conflict reviews, and status changes to the AD's "My Documents" page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
- Legacy-Id: 5476
added the ability to start a status change when looking at an RFC (populating the start from accordingly)
Made changes and proposed changes show on the RFC pages
- Legacy-Id: 5330
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
- Legacy-Id: 5289
Add stream to conflict-review documents in the agenda.json object for the IESG telechat agenda
- Legacy-Id: 4942
Note: SVN reference [4836] has been migrated to Git commit b612d8c26501730551cd1e4cc6aeff21dc01219b
Keep the ordering for drafts the same on iesg/agenda and iesg/agenda/documents
Allow setting the responsible AD for a charter document
Change the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)
- Legacy-Id: 4769
- Legacy-Id: 4485
Note: SVN reference [4436] has been migrated to Git commit 9cfdb5afd7f77b161c43b9551ec3fc23575aa255
Note: SVN reference [4438] has been migrated to Git commit 961c6b83d293f465df678a943a7621b731a0acbb
- Legacy-Id: 4482
Note: SVN reference [4356] has been migrated to Git commit 4eabc033c1
Note: SVN reference [4364] has been migrated to Git commit b3c665287d
Expose how many pages each document contains on the docs on future telechats page.
Fixes bug #828
- Legacy-Id: 4383
Note: SVN reference [4364] has been migrated to Git commit b3c665287d
Removed the stream editing form - that functionality is on the edit info form.
Put the old-ADs back into the list of choices when editing a document's info.
This (re) fixes bug #749
- Legacy-Id: 4356
