altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity
9930 commits 1 branch 0 tags 2.6 GiB
Commit graph

97 commits

Author SHA1 Message Date
Henrik Levkowetz f996fe825f Added more test data for the eligibility view, in order to exercise all parts of the view code. 
- Legacy-Id: 14541
 2018-01-19 15:21:33 +00:00
Robert Sparks 4ce6b934b8 Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257. Commit ready for merge. 
- Legacy-Id: 14533
 2018-01-17 17:58:58 +00:00
Robert Sparks c8b451094a Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852. Commit ready for merge. 
- Legacy-Id: 14505
 2018-01-10 21:54:10 +00:00
Robert Sparks 94f4e9ac58 Simplify the edit nomcom members forms. Fixes #1756. Commit ready for merge. 
- Legacy-Id: 14504
 2018-01-10 18:26:20 +00:00
Henrik Levkowetz a5e5bb1aab Expanded one of the nomcom tests a bit, and updated a fixture to match the current /nomcom/default/email/feedback_receipt.txt template. 
- Legacy-Id: 14223
 2017-10-20 14:34:03 +00:00
Henrik Levkowetz ac8e18480e Added tests for correct nomcom email from-address to the nomcom tests, and did some refactoring to improve test failure messages. 
- Legacy-Id: 14176
 2017-09-28 09:09:51 +00:00
Henrik Levkowetz 3c727106a2 Merged in [13717] from rjsparks@nostrum.com: 
Actually use the topic audience type in the feedback view. Fixes #2320.
 - Legacy-Id: 13728
Note: SVN reference [13717] has been migrated to Git commit 9638cb2e397beab18f3607b324518fd2900215f7
 2017-06-29 12:52:25 +00:00
Ryan Cross e9b7c5753e Refactor ietf/bin/merge-person-records to facilitate testing. Add tests. Fixes #2162. Commit ready for merge. 
- Legacy-Id: 13567
 2017-06-08 23:28:43 +00:00
Robert Sparks 4813177086 Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846. Commit ready for merge. 
- Legacy-Id: 13474
 2017-05-30 19:54:31 +00:00
Robert Sparks c49abdd557 Allow nomcoms to configure the feedback page to show nominee pictures. Fixes #2252. Commit ready for merge, 
- Legacy-Id: 13413
 2017-05-23 22:18:04 +00:00
Robert Sparks ac8e5f5402 Make it possible to close nominations without closing feedback. Fixes #2255. Commit ready for merge. 
- Legacy-Id: 13399
 2017-05-22 18:40:05 +00:00
Robert Sparks 1a18130c57 Avoid confusing messages saying a key has not been entered when it has. Fixes #2250. Commit ready for merge. 
- Legacy-Id: 13390
 2017-05-17 21:02:20 +00:00
Robert Sparks 4b0fefeb3e Revert an attempt to improve a nomcom test. Affects #2260. Commit ready for merge. 
- Legacy-Id: 13389
 2017-05-17 16:45:58 +00:00
Robert Sparks ceff54480c Update the feedback count badge when new feedback is provided. Fixes #2260. Commit ready for merge. 
- Legacy-Id: 13388
 2017-05-17 13:55:39 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method. 
- Legacy-Id: 13157
 2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Henrik Levkowetz dd7b3eb71a Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12833
 2017-02-13 21:37:41 +00:00
Henrik Levkowetz 9b23816a22 Stabilized a number of nomcom tests by enforcing queryset ordering. 
- Legacy-Id: 12832
 2017-02-13 20:58:28 +00:00
Henrik Levkowetz e5f889764c Fixed a problem with stability of test_accept_reject_nomination_edges(), and made some changes to make debugging this easier. 
- Legacy-Id: 12829
 2017-02-13 15:55:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 26fcce9c28 Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task. 
- Legacy-Id: 12017
 2016-09-22 14:23:20 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions. 
- Legacy-Id: 11436
 2016-06-21 07:51:02 +00:00
Henrik Levkowetz e552ff85b7 Tentatively comment out use of tempdir() in nomcom.tests. 
- Legacy-Id: 10704
 2016-01-16 22:30:05 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting. 
- Legacy-Id: 10620
 2015-12-22 04:32:48 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person. 
- Legacy-Id: 10619
 2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages 
- Legacy-Id: 10618
 2015-12-21 20:46:56 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors. 
- Legacy-Id: 10610
 2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField 
- Legacy-Id: 10609
 2015-12-18 20:38:17 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96% 
- Legacy-Id: 10606
 2015-12-16 23:12:40 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default 
- Legacy-Id: 10602
 2015-12-16 11:51:32 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845. 
- Legacy-Id: 10589
 2015-12-14 03:26:43 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix 
- Legacy-Id: 10581
 2015-12-11 17:30:13 +00:00
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys 
- Legacy-Id: 10574
 2015-12-11 04:01:11 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead. 
- Legacy-Id: 10228
 2015-10-18 11:49:15 +00:00
Ole Laursen 73a41bb7e6 Summary: Fix problem with three NomCom tests that had a hard-coded id, 
which doesn't necessarily work with the way transactions work in MySQL
 - Legacy-Id: 10190
 2015-10-12 15:03:00 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing. 
- Legacy-Id: 10035
 2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc 
- Legacy-Id: 10034
 2015-08-20 04:23:40 +00:00
Henrik Levkowetz 85f9eee27b Updated a set of nomcom tests to account for new facelift DOM attributes. 
- Legacy-Id: 9361
 2015-04-02 19:49:11 +00:00