Commit graph

1005 commits

Author SHA1 Message Date
Robert Sparks bd25bc6034
fix: improve file investigation results (#7376) 2024-05-06 07:45:36 -05:00
Robert Sparks 6b11291216
feat: investigate file authenticity (#7331)
* feat: investigate file authenticity

* fix: use django-provided validation
2024-04-23 11:43:48 -05:00
Jim Fenton 891c0e975d
refactor: Move document state help to /doc (#7206)
* Redirect /help/state/draft/* to /doc/help/state/draft-*

* Adjust document state index to use /doc/help/state for URLs

* Move all state help to /doc. Fixes #3802

* Move state index redirect into urls file.
2024-03-22 15:03:10 -05:00
Robert Sparks 3bfb9303bc
fix: appropriate metadata for editorial stream docs (#7195) 2024-03-15 23:16:09 -05:00
Paul Selkirk 528d697ac0
refactor: Clarify which mail archive is being searched (#7117)
* refactor: Clarify which mail archive is being searched (#6993)

* refactor: Revert views_review.py, get team email directly
2024-03-11 13:13:32 -05:00
Paul Selkirk 08e0c83324
refactor: Remove Google from document history search (#7093)
* refactor: Remove Google from document history search

"Search lists" dropdown menu devolves into a single button
(two buttons for ADs).

* refactor: Remove unused ARO search

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-02-28 09:58:21 -06:00
Paul Selkirk ce1571ee68
fix: Revert "Email authors" link for an RFC to the draft that it came from (#7077)
* fix: Revert "Email authors" link for RFCs to the draft that it came from (#6856)

* refactor: Move mailto_name calculation to the view

* fix: Fully revert document_draft.html
2024-02-28 08:52:38 -06:00
Robert Sparks 8cb7f3dcae
feat: Import IESG artifacts into the datatracker (#6908)
* chore: remove unused setting

* feat: initial import of iesg minutes

* fix: let the meetings view show older iesg meetings

* feat: iesg narrative minutes

* feat: import bof coordination call minutes

* wip: import commands for iesg appeals and statements

* feat: import iesg statements.

* feat: import iesg artifacts

* feat: many fewer n+1 queries for the group meetings view

* fix: restore chain of elifs in views_doc

* fix: use self.stdout.write vs print in mgmt commands

* fix: use replace instead of astimezone when appropriate

* chore: refactor new migrations into one

* fix: transcode some old files into utf8

* fix: repair overzealous replace

* chore: black

* fix: address minro review comments

* fix: actually capture transcoding work

* fix: handle multiple iesg statements on the same day

* fix: better titles

* feat: pill badge replaced statements

* fix: consolodate source repos to one

* feat: liberal markdown for secretariat controlled content

* fix: handle (and clean) html narrative minutes

* feat: scrub harder

* fix: simplify and improve a scrubber

* chore: reorder migrations
2024-02-20 16:35:08 -06:00
Paul Selkirk 3ba39c956a
refactor: Remove BOF chairs from bofreq template, because BOF requesters shouldn't fill it in (#7065) 2024-02-15 09:43:39 -06:00
Robert Sparks d9cc26be96
feat: replace references to User with references to Person (#6024)
* refactor: change references from User to Person (#5821)

* refactor: Change CommunityList reference from User to Person

* refactor: Convert more user references to person

* refactor: Change augment_docs_and_user_with_user_info to person

* refactor: Change Nomination and Feedback references from User to Person

* refactor: Change a few test case function signatures to be more pythonic

* refactor: Harmonize how profile and photo views look up email_or_name

* refactor: Rework community views to operate on Person instead of User (#5859)

* test: Update tests to try all of the person's emails and aliases

* fix: Recode a test case to avoid an exception if there's Unicode in the URL

This only happens using the form-filling and submission feature of
WebTest, which is only used in this one test case, so just it rip out.

* test: Add duplicate-person tests

* fix: If there are multiple matching users, prefer the logged-in one.

* chore: We no longer use WebTest, so don't include it.

* fix: Address review comments

* fix: case-insensitive person name or email matching (#6096)

* chore: Renumber migrations

* fix: Update merged code so tests pass (#6887)

* fix: Use refactored method

* fix: Don't assume user has person

* fix: Use new view param name

* chore: Drop community lists w/o person; cleanup (#6896)

* fix: Don't assume user has person

* fix: user->person in update_community_list_index.py

* feat: Remove CommunityLists without Person

* refactor: Speed up nomcom migrations

---------

Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-01-24 11:00:19 -06:00
Jennifer Richards cb70da9584
fix: Never show AD col on drafts_for_ad.html (#6914)
* fix: Pass ad as Person instead of name

* refactor: Remove redundant AD check

Results being shown are already filtered by AD if the `ad`
variable is not `None`

* refactor: Add show_ad... flag to prepare_document_table

* refactor: Expose show_ad_and_shepherd flag
2024-01-12 16:39:59 -06:00
Jennifer Richards c7ca0b7d8e
Revert "chore: Replace markup_txt with rfc2html (#6632)" (#6909)
This reverts commit e24fb601db.
2024-01-11 13:08:24 -06:00
Robert Sparks 3312913c6f
fix: better archive search links for group documents (#6835) 2024-01-09 15:17:11 -06:00
Lars Eggert e24fb601db
chore: Replace markup_txt with rfc2html (#6632)
* chore: Replace markup_txt with rfc2html

* Suppress HTML issues

* Remove comment

* Suppress harder

* Suppress even more

* Fix test

* Ignore vnu "duplicate ID" errors

* Undo accidental commit

* Fix RFCs

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-01-05 12:29:28 -06:00
Paul Selkirk 02e0d960a4 fix: Correctly display the last pre-RFC rev of a draft 2024-01-04 00:50:08 -05:00
Paul Selkirk 748bcc328f
fix: Wrap weasyprint to catch exceptions (#6728)
* fix: Wrap weasyprint to catch exceptions (#6324)

* test: Restore socket function after test

* test: Use mock instead of monkeying with sockets

* refactor: Log the error

* fix: Don't catch non-Exception interruptions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-27 11:56:38 -06:00
Jennifer Richards 149f82f578
fix: Include refs to pre-RFC drafts as refs to the RFC (#6784)
* fix: clean up shadowed name in document_referenced_by.html

* fix: include refs to rfc's came_from_draft()

* fix: include refs to draft's became_rfc()

* fix: Count indirect refs by RFCs

* refactor: break indirect ref_by counting to its own fn

* fix: only count refs to pre-rfc draft, not post-draft rfc

(and rename a method)

* test: test referenced_by_rfcs methods

The test_referenced_by_rfcs_as_rfc_or_draft() test
fails because there's a bug!

* test: actually, do double-count refs to rfc/draft

Let's do include refs to an rfc and its precursor draft
as separate refs. This almost surely indicates a data
error because it would mean an rfc referenced both an
rfc and the draft that it came from. That should never
be allowed, so at least let some light fall on it if
it happens.

* chore: Add docstring to document_referenced_by view
2023-12-18 09:11:53 -06:00
Robert Sparks 03e161bae9
chore: merge branch 'main' into feat/rfc 2023-12-05 09:12:11 -06:00
Jennifer Richards b281919d4c
feat: Sort RFCs on subseries views; fix page title (#6704)
* feat: Sort RFCs on subseries doc pages

* feat: Sort RFCs on subseries index pages

* fix: Show subseries doc name as page title

* refactor: Use prettystdname filter for consistency
2023-11-29 12:34:18 -06:00
Kesara Rathnayake f442d6c0af
fix: Remove extra spaces in bibtex (#6688) 2023-11-27 08:13:14 -06:00
Robert Sparks 2137dd8491
fix: teach ajax_select2_search_docs about rfcs (#6679) 2023-11-21 15:33:44 -06:00
Robert Sparks b89c44f443
chore: merge main and fix new views 2023-11-16 15:58:22 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Robert Sparks 3fea443f59
fix: use valid ids on subseries index page 2023-11-05 12:35:34 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Robert Sparks 9a2b0cf947
fix: better empty text and prettystdname on subseries index view 2023-11-01 16:21:05 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00
Martin Thomson 902d657c9f
Icons for sidebar collapse/expand (#6465)
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/).  This is a minimal change, but changes from .

I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/), which is the mirror of the collapsed icon.  I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/).  Both of those seemed less clear than these.

Note that the "shown"/"collapsed" classes on these elements appear to be reversed.  I didn't touch that.
2023-10-23 18:40:24 -05:00
Lars Eggert 0a4fc286cd
fix: More darkmode fixes (#6477)
* fix: More dark mode fixes

This first commit increases contrast of the leftmenu text.

* Fix own ballot position highlight in dark mode

* Fix dark mode axis color in timeline diagrams

* Enable highcharts dark mode

* Fix template

* Properly import our customized bs5 everywhere

* Fix #6499

* Use bs5 color for border-left

* Remove superfluous load
2023-10-23 18:38:35 -05:00
Paul Selkirk a6a39a04dc
feat: Show/edit shepherd for IAB-stream documents (#6498)
* feat: Show/edit shepherd for IAB-stream documents (#4810)

* style: Shepherd for IAB documents is called 'IAB shepherd'
2023-10-23 09:57:23 -05:00
Martin Thomson 6e3c663484
fix: hide sidebar and dark/light toggles from print (#6502)
Fixes #6501.
2023-10-20 08:08:55 -05:00
Robert Sparks ab931f0510
chore: merge main into feat/rfc 2023-10-12 15:11:02 -05:00
Lars Eggert fa00abf9de
fix: Add remote instructions and date/time to interim agenda page (#6442)
* fix: Add remote instructions to interim agenda page

Fixes #6433
Fixes #6249

* Also add date and time

* Fix HTML

* Fix CI fail

* Address code review comments

* More suggestions from @rjsparks

* Fix HTML

* Add suffix
2023-10-12 06:29:03 -05:00
Paul Selkirk 16f9e0e974
fix: Adjust IRTF charter approval email headers (#5917) (#6460) 2023-10-11 11:09:10 -05:00
Lars Eggert 7dbfc0208a
feat: Remove document notes from the datatracker (#6387)
* Remove doc.note

* Address comments from @rjsparks

* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Robert Sparks 4b1274c44d
fix: teach search about rfcs and subseries (#6431)
* fix: teach search about rfcs and subseries

* fix: more general manipulation of searches for rfc and subseries

* fix: only tweak subseries search if the thing after the subseries id is digits
2023-10-04 17:12:01 -03:00
Paul Selkirk c718fedb6c
feat: Allow review rejections to be undone (#6312)
* feat: Allow reviewer to accept a review they're previously rejected

* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.

This largely un-does d105f8b, at the request of at least one team secretary.

* fix: Went a little overboard on the previous commit

one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.

* fix: Actually do the assignment

* fix: If there's an existing assignment, don't create a new one

* style: Restructure conditional for clarity

* test: Add test cases for accepting or assigning a review assignment after rejecting it
2023-09-27 08:57:34 -05:00
Jennifer Richards 82c70a2d5d
Merge pull request #6374 from rjsparks/more_docalias_removal
fix: cleaner search_result_row diff links for recent drafts replacing other drafts
2023-09-26 22:24:17 -03:00
Robert Sparks 4ba62bf149
fix: put rfc history on left 2023-09-26 17:17:04 -05:00
Lars Eggert 5db70b2787
fix: State descriptions can have HTML in them, mark them safe (#6384) 2023-09-26 08:09:39 -05:00
Robert Sparks 9e4166393d
fix: cleaner search_result_row diff links for recent drafts replacing other drafts 2023-09-25 15:39:48 -05:00
Robert Sparks 8732dcb706
fix: bring tests up current. add subseries names to rfc view. fix html. 2023-09-22 12:40:15 -05:00
Robert Sparks 48cb06d20d
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious " 2023-09-21 16:38:41 -05:00
Robert Sparks 0390f1868f
feat: subseries 2023-09-21 12:54:17 -05:00