Commit graph

224 commits

Author SHA1 Message Date
Henrik Levkowetz 68655b569b Fixed 2 testing bugs. Added tests for handling of submitters without email and drafts with non-ascii names in the author section.
- Legacy-Id: 12064
2016-09-30 17:35:35 +00:00
Robert Sparks 4f01de1b94 Improves who to copy when sending submission confirmation mail when authors change. Commit ready for merge.
- Legacy-Id: 12014
2016-09-21 15:55:17 +00:00
Henrik Levkowetz c1ce79f14d Style tweak
- Legacy-Id: 11945
2016-09-08 18:30:03 +00:00
Henrik Levkowetz 254c3db807 Style changes.
- Legacy-Id: 11944
2016-09-08 17:37:36 +00:00
Henrik Levkowetz 7a8c067d83 Changed a state name, and renamed some view functions for easier code reading. Removed extra name= parameters from the submit/ urlpatterns.
- Legacy-Id: 11917
2016-09-01 09:14:34 +00:00
Henrik Levkowetz e2fccfb094 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0@11899, which provides better support for manual ID posting.
- Legacy-Id: 11914
2016-08-31 22:30:31 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Robert Sparks b988b86b1a Copy group chairs on confirmation email when a new group document revision is submitted that changes the author set. Fixes #1998. Commit ready for merge.
- Legacy-Id: 11877
2016-08-25 15:52:51 +00:00
Robert Sparks 2009afe7b8 preparing to merge forward to 6.31
- Legacy-Id: 11875
2016-08-25 15:21:57 +00:00
Henrik Levkowetz 7f5863d212 Added a FIXME comment about a test which can fail if run across the midnight date shift.
- Legacy-Id: 11544
2016-07-07 12:40:41 +00:00
Henrik Levkowetz 3eaef15fd5 Fixed a bug found by rjsparks@nostrum.com in the submission test text output.
- Legacy-Id: 11279
2016-06-06 07:37:05 +00:00
Henrik Levkowetz deb2f73047 Merged in ^/branch/iola/community-list-cleanup-r11172@11175.
- Legacy-Id: 11182
2016-05-12 19:14:28 +00:00
Henrik Levkowetz aa61123937 Modified a few tests to handle the improved handling of error messages (not conflating them with help text any more).
- Legacy-Id: 11181
2016-05-12 13:47:10 +00:00
Ole Laursen 9faae5e915 Merged community list branch with trunk
- Legacy-Id: 11174
2016-05-06 17:36:04 +00:00
Henrik Levkowetz 8769cc0207 Fixed bugs in the previous commit (in the tests).
- Legacy-Id: 11142
2016-05-03 17:16:17 +00:00
Henrik Levkowetz 304516f4b3 Added test directories for yang model tests.
- Legacy-Id: 11141
2016-05-03 16:40:09 +00:00
Henrik Levkowetz d96f0fe964 Added a django management command to populate yang model libraries from RFCs and drafts.
- Legacy-Id: 11110
2016-04-08 17:18:54 +00:00
Ole Laursen c061caaf04 Merge in changes from community-list-cleanup
- Legacy-Id: 10968
2016-03-23 13:31:24 +00:00
Ole Laursen c7589f9b6a Integrate community lists for groups with the existing group documents
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.

Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.

Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
 - Legacy-Id: 10963
2016-03-22 12:48:44 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check.
- Legacy-Id: 10894
2016-03-04 20:08:29 +00:00
Henrik Levkowetz b00b0c3db9 Moved some production-path checks to the checks module, and fixed up tests which changed some settings without restoring them.
- Legacy-Id: 10808
2016-02-09 18:50:37 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once.
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
2015-12-22 21:42:55 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Henrik Levkowetz 7accc69144 Updated a couple of tests.
- Legacy-Id: 10273
2015-10-23 17:12:46 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward.
- Legacy-Id: 10157
2015-10-09 03:16:24 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc
- Legacy-Id: 10034
2015-08-20 04:23:40 +00:00
Henrik Levkowetz 6c253ee48b Improved the verification of submitted file extensions and mimetype.
- Legacy-Id: 9986
2015-08-07 12:10:26 +00:00
Henrik Levkowetz ea26114076 Merged in [9875] from rjsparks@nostrum.com:
Improve the form validation for the submission replaces form.
 - Legacy-Id: 9877
Note: SVN reference [9875] has been migrated to Git commit 766270a344
2015-07-25 15:29:30 +00:00
Robert Sparks 766270a344 Improve the form validation for the submission replaces form. Commit ready for merge.
- Legacy-Id: 9875
2015-07-23 14:24:59 +00:00
Henrik Levkowetz a7179d5e03 Merged in [9862] from rjsparks@nostrum.com:
Ignore suggestions that a draft replaces itself.
 - Legacy-Id: 9874
Note: SVN reference [9862] has been migrated to Git commit 6ccd96fb31
2015-07-23 12:42:49 +00:00
Robert Sparks 6ccd96fb31 Ignore suggestions that a draft replaces itself. Commit ready for merge.
- Legacy-Id: 9862
2015-07-23 08:02:26 +00:00
Henrik Levkowetz da893dad1c Merged in support of xml-source only drafts submissions from personal/henrik/submitxml/.
- Legacy-Id: 9859
2015-07-22 21:53:23 +00:00
Henrik Levkowetz d5f36911cf Added support of xml-source only drafts submissions.
- Legacy-Id: 9858
2015-07-22 21:35:44 +00:00
Henrik Levkowetz 953d639ae3 Merged in Ole's submit-time draft replacement information work, as tested and updated by Robert and Adam.
- Legacy-Id: 9829
2015-07-20 14:53:20 +00:00
Ryan Cross 007d7d22b4 Allow Secretariat to submit drafts during blackout period. Fixes #1755. Commit ready for merge.
- Legacy-Id: 9821
2015-07-20 09:56:19 +00:00
Adam Roach 5cb7c82e39 Check that email is sent to chairs of both replaced and replacing document
- Legacy-Id: 9808
2015-07-18 16:07:26 +00:00
Robert Sparks 02a9da52a1 Manually moved the concepts forward. Reworked some presentation. Working enough to bring testers in at Sprint93
- Legacy-Id: 9717
2015-07-13 21:09:39 +00:00
Ole Laursen 87870ca954 Fix more test errors - now only two not yet fully ported views remain
- Legacy-Id: 8571
2014-11-03 16:39:41 +00:00
Henrik Levkowetz 4cc4f5080c Merged in [8254] from rjsparks@nostrum.com:\n Don't send mail to unknown-email-* addresses. Fixes bug #1471.
- Legacy-Id: 8365
Note: SVN reference [8254] has been migrated to Git commit f7f29a62588eac9b2aaf26cd0401a910fa48403f
2014-09-28 18:51:21 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk.
- Legacy-Id: 7579
2014-04-06 20:04:36 +00:00
Henrik Levkowetz 870be71f79 Made ietf/submit pyflakes-clean.
- Legacy-Id: 7499
2014-03-16 08:03:15 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Ole Laursen 09859b9e6a Implement missing submit tests as spotted by the coverage check
- Legacy-Id: 7081
2014-01-08 17:47:39 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ce316c0adb assertEquals -> assertEqual in submit/tests.py (the former is apparently deprecated)
- Legacy-Id: 6719
2013-11-15 16:24:38 +00:00
Ole Laursen 9f1f7790e2 Add bin/expire-submissions script for making sure old submissions are canceled automatically
- Legacy-Id: 6718
2013-11-15 16:22:29 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Ole Laursen c20a5f6bf0 Convert the submit tool to associate RGs and IAB with drafts instead
of assigning them to individual submission, this is not a complete
overhaul but at least basic support so submission works and doesn't
say WG when it means RG.
 - Legacy-Id: 4910
2012-10-10 16:15:09 +00:00
Ole Laursen 513c2bcf4c Handle IANA Review state intelligently upon draft submission, email
IRSG/ISE/IAB on uploads to alternate streams, email RFC Editor in case
a draft under publication has a new upload
 - Legacy-Id: 4855
2012-09-17 16:06:21 +00:00
Henrik Levkowetz a554288faf Tweaked the I-D submission confirmation email some more, to be able to update the test suite to find the confirmation URL in the message.
- Legacy-Id: 4645
2012-07-27 22:48:56 +00:00
Henrik Levkowetz 7474b27348 Merged in branch/iola/approval from olau@iola.dk, which provides a pre-approval page for new WG drafts.
- Legacy-Id: 4486
2012-06-21 00:24:48 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen ed96cee2e4 Add listing of recently approved drafts to approval page by request
from Barry Leiba.
 - Legacy-Id: 4420
2012-05-14 18:21:34 +00:00
Ole Laursen 188c0846d0 Add approval/pre-approval page for Secretariat and WG Chairs, with
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
 - Legacy-Id: 4411
2012-05-10 18:07:59 +00:00
Ole Laursen da3c40de49 Fix test error introduced by ballot refactor (test didn't set up
ballot position properly).
 - Legacy-Id: 4405
2012-05-07 19:21:26 +00:00
Henrik Levkowetz 29b4090bac Add an assertion in the test code to explicitly check that we have an OK idnits result.
- Legacy-Id: 4298
2012-04-22 14:17:27 +00:00
Ole Laursen 480cb04cd6 Save announcements generated by the system as Messages, adding an
extra relation to be able to associate a draft with the message
 - Legacy-Id: 3917
2012-02-08 21:05:28 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen 923239a5dc Clean up old draft files when submitting a new draft
- Legacy-Id: 3811
2012-01-13 16:38:00 +00:00
Ole Laursen f3685e7af1 Turn expiration into an explicit expires attribute on document, set
that on submission of new revision and resurrection
 - Legacy-Id: 3801
2012-01-12 12:03:45 +00:00
Ole Laursen f74890aec4 Adjust to handle the slightly revamped email_address() on person
- Legacy-Id: 3750
2011-12-07 19:26:53 +00:00
Ole Laursen 3ed02196d7 Fix some instances where we use a non-role email for ADs in spite of them acting as ADs
- Legacy-Id: 3741
2011-12-06 14:01:44 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen ea7f45d56e Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3617
2011-11-14 19:40:20 +00:00
Ole Laursen 76dd5aa53b Set the stream when submitting a document
- Legacy-Id: 3512
2011-10-25 14:32:03 +00:00
Ole Laursen 6f10d2f3f7 Port submit to new schema, adding a set of tests and fixing some bugs
- Legacy-Id: 3436
2011-09-21 19:29:50 +00:00
Ole Laursen 5c5d534104 Add person foreign key on Role to link the role and person directly instead of through Email, this will allow us to use non-personal emails on roles
- Legacy-Id: 3418
2011-09-14 14:01:17 +00:00
Ole Laursen 7f5fd62a3d Add simple test for ID submission, needs more extensive checking
- Legacy-Id: 3416
2011-09-05 17:14:47 +00:00