Commit graph

6672 commits

Author SHA1 Message Date
Robert Sparks 32b431cf24 allow ads and secretaries to edit the review request comment. Fixes #2096. (Again). Commit ready for merge.
- Legacy-Id: 12549
2016-12-15 22:54:40 +00:00
Robert Sparks 6fcd8b8a16 Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096. Commit ready for merge.
- Legacy-Id: 12545
2016-12-15 21:52:12 +00:00
Robert Sparks 870fa59d0c Provide defaults on the Request review form. Fixes #2108. Commit ready for merge.
- Legacy-Id: 12543
2016-12-15 20:36:15 +00:00
Robert Sparks df86798cf3 Provide default filters for reviewer settings. Fixes #2093. Commit ready for merge.
- Legacy-Id: 12541
2016-12-15 19:48:37 +00:00
Robert Sparks 68bdff6fd5 Missed adding a migration to svn for r12521. Commit ready to merge. Should only be applied after r12521.
- Legacy-Id: 12540
2016-12-15 19:30:36 +00:00
Robert Sparks 483d9db895 Removes classes obviated in r12520. Commit ready for merge. Should be held for release after r12520 is released?
- Legacy-Id: 12521
2016-12-15 03:57:21 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Robert Sparks 18fdfc0617 Fixes href() for bluesheets. Fixes #2107. Commit ready for merge. Will patch into production
- Legacy-Id: 12518
2016-12-13 21:26:40 +00:00
Henrik Levkowetz f098e2ae94 Set version info and settings back to development mode
- Legacy-Id: 12513
2016-12-13 11:44:03 +00:00
Henrik Levkowetz d6c837a9ce Set version info to release version 6.40.0 before branching.
- Legacy-Id: 12511
2016-12-13 11:43:49 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 7935926a05 Set version info and settings back to development mode
- Legacy-Id: 12498
2016-12-09 12:56:30 +00:00
Henrik Levkowetz 138c17e42c Set version info to release version 6.39.1 before branching.
- Legacy-Id: 12496
2016-12-09 12:56:22 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz 2978798f39 Made serialization work for RegexStringValidator
- Legacy-Id: 12492
2016-12-09 12:40:21 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Henrik Levkowetz e83cee2c8b Merged in [12487] from rjsparks@nostrum.com:
Make it clearer what version was requested and what version was reviewed on a reveiwers overview page. Fixes #2101.
 - Legacy-Id: 12490
Note: SVN reference [12487] has been migrated to Git commit 96390da5a7514cbe0bd70b61a927cb57260c9c44
2016-12-09 00:05:22 +00:00
Henrik Levkowetz 8c7a400683 Merged in [12486] from rjsparks@nostrum.com:
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes #2078 and #2054.
 - Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
2016-12-08 23:44:50 +00:00
Henrik Levkowetz e40afaedf0 Check event type only when an event is available.
- Legacy-Id: 12484
2016-12-08 17:57:59 +00:00
Henrik Levkowetz 83a260c6c0 Merged in [12482] from rjsparks@nostrum.com:
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes #2092 and #2082.
 - Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
2016-12-08 17:55:37 +00:00
Henrik Levkowetz ef301c0f31 Merged in [12479] from olau@iola.dk:
Add missing team constraint in the check for previous reviews by a
reviewer.
 - Legacy-Id: 12481
Note: SVN reference [12479] has been migrated to Git commit 3f98a1a182
2016-12-08 16:43:45 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Ole Laursen 3f98a1a182 Add missing team constraint in the check for previous reviews by a
reviewer. Commit ready for merge.
 - Legacy-Id: 12479
2016-12-08 12:49:56 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 53f343017e Use models.DurationField from django directly now that it's available, instead of the inlined copy of the 1.8 DurationField code.
- Legacy-Id: 12477
2016-12-07 19:40:18 +00:00
Henrik Levkowetz 217b31f109 Made the RegexStringValidator deconstructible so we can generate migrations.
- Legacy-Id: 12476
2016-12-07 19:28:01 +00:00
Henrik Levkowetz 7fbf2e8609 Changed the deprecated model._meta.get_all_field_names() to a supported construct.
- Legacy-Id: 12475
2016-12-07 18:27:57 +00:00
Henrik Levkowetz eb966c7545 Fixed the manage assigned reviews template to handle the case when reviewed rev is blank. Fixes issue #2086.
- Legacy-Id: 12474
2016-12-07 16:02:04 +00:00
Henrik Levkowetz c312967505 Removed unused legacy code
- Legacy-Id: 12473
2016-12-07 12:20:27 +00:00
Henrik Levkowetz 6304bfda69 Fixed template_coverage_collection initialisation. Tweaked a message. Updated coverage numbers.
- Legacy-Id: 12471
2016-12-07 11:33:33 +00:00
Henrik Levkowetz db7e554c5e Changed to using TestCase from ietf.utils, and turned off coverage checking when loading templates in TemplateChecksTestCase.
- Legacy-Id: 12470
2016-12-07 11:31:31 +00:00
Henrik Levkowetz 7d27849ee3 Fixed a typo.
- Legacy-Id: 12469
2016-12-07 11:29:23 +00:00
Henrik Levkowetz b628a0844b Changed to using TestCase from ietf.utils in some places, for consistent test-suite failure output.
- Legacy-Id: 12467
2016-12-07 11:03:32 +00:00
Henrik Levkowetz 7dfbe51913 Don't count the template loading done in TemplateChecksTestCase towards template coverage numbers.
- Legacy-Id: 12464
2016-12-06 15:55:39 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 8f6e51839f Fixed some additional places to use the new settings.TEMPLATES structure.
- Legacy-Id: 12459
2016-12-05 19:04:27 +00:00
Henrik Levkowetz 18f65e09a0 Removed bad select_related names.
- Legacy-Id: 12456
2016-12-05 15:23:27 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz 3b6f30fc9a Fixed a type mismatch (no_review_from_teams_on_doc() is called with both Document and DocHistory instances; this has to be taken into account)
- Legacy-Id: 12453
2016-12-05 14:38:37 +00:00
Henrik Levkowetz bc683ccc67 Fixed a type issue found by the new django 1.8 query type checks.
- Legacy-Id: 12452
2016-12-05 14:13:00 +00:00
Henrik Levkowetz 1d5a7a692a Added a DB consistency check, and 2 new doc.statetype values found by the check for consistency.
- Legacy-Id: 12451
2016-12-05 14:12:19 +00:00
Henrik Levkowetz 8cf6b0010b Added a template string_if_invalid setting to TEMPLATES when DEBUG is True.
- Legacy-Id: 12450
2016-12-05 14:10:35 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz 486e394cbf Added more document information to the personal profile pages at /person/<full name>, after a suggestion from Benoit Claise. Fixes issue #2066.
- Legacy-Id: 12447
2016-12-05 13:00:01 +00:00
Henrik Levkowetz b897519fff Changed the test runner to use the verbosity set on the command line when loading fixtures.
- Legacy-Id: 12446
2016-12-05 12:56:53 +00:00
Henrik Levkowetz cfd898b767 Updated the proceedings_templates fixture to provide the base proceedings template needed by tests, instead of a copy already instantiated for a specific meeting.
- Legacy-Id: 12445
2016-12-05 12:55:20 +00:00
Henrik Levkowetz be272a019a Changed settings to use the new TEMPLATES dictionary instead of the deprecated individual TEMPLATE_* settings.
- Legacy-Id: 12444
2016-12-05 12:53:21 +00:00
Henrik Levkowetz 5e48d7ec72 Fixed another year's end related test bug.
- Legacy-Id: 12443
2016-12-04 15:46:27 +00:00
Henrik Levkowetz e79368f15e Added new display columns to the reviewer settings admin page.
- Legacy-Id: 12442
2016-12-04 13:07:16 +00:00