altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
14255 commits 1 branch 0 tags 2.6 GiB
Commit graph

92 commits

Author SHA1 Message Date
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402) 
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
 2022-09-01 13:07:28 -03:00
Robert Sparks 9c236ea2a2
chore: remove unneeded logging and code marked unreachable that has not been reached. (#4305) 
* chore: remove unneeded logging and code marked unreachable that has not been reached.

* fix: remove noop save override
 2022-08-04 11:25:31 -05:00
Robert Sparks de4f1feed2
fix: send status change eval and lc to IANA. Fixes #3504. (#4244) 2022-07-23 12:36:00 -05:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds. 
- Legacy-Id: 19904
 2022-02-01 16:11:34 +00:00
Jennifer Richards e11583a87f Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146. Commit ready for merge. 
- Legacy-Id: 18829
 2021-02-12 20:31:00 +00:00
Robert Sparks e94f5c15ff Allow ballot text to be edited after the ballot is approved. Fixes #3157. Related to #3119. Commit ready to merge. 
- Legacy-Id: 18791
 2021-01-11 22:59:11 +00:00
Russ Housley 89ec802a5b Automatically move the IESG document state when a ballot is issued, prevent a writeup change or re-issue of ballot if the document is already approved, and warn about issuing ballots before the IETF Last Call is finished. Fixes #3119. 
- Legacy-Id: 18719
 2020-11-23 22:59:41 +00:00
Henrik Levkowetz 9125104065 Merged in [18324] from rjsparks@nostrum.com: 
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419.
 - Legacy-Id: 18363
Note: SVN reference [18324] has been migrated to Git commit cb58810705
 2020-08-13 11:23:22 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403. 
- Legacy-Id: 18339
 2020-08-06 10:59:52 +00:00
Robert Sparks cb58810705 Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419. Commit ready to merge. 
- Legacy-Id: 18324
 2020-07-30 21:44:02 +00:00
Jennifer Richards 6e97a89786 Notify IRSG when an IRSG ballot is created. Fixes #2978. Commit ready for merge. 
- Legacy-Id: 18162
 2020-07-13 16:45:45 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz 32e9692f54 Fixed a py2/py3 issue in sync.rfceditor.post_approved_draft(), and enhanced tests to execute the failing code (with Mock functions) instead of skipping the code. 
- Legacy-Id: 17265
 2020-01-28 22:37:50 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com. 
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
 2019-12-20 15:00:55 +00:00
Peter E. Yee 8313b0adbf Fixes for questions for you. Does not include any changes in docker/ 
- Legacy-Id: 17150
 2019-12-13 23:01:06 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure 
- Legacy-Id: 17149
 2019-12-13 19:53:45 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com: 
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
 2019-04-08 17:02:02 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document 
- Legacy-Id: 16126
 2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge. 
- Legacy-Id: 16110
 2019-03-28 10:07:11 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge. 
- Legacy-Id: 15698
 2018-11-03 08:13:10 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean. 
- Legacy-Id: 15547
 2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this. 
- Legacy-Id: 15526
 2018-10-07 15:08:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not. 
- Legacy-Id: 15515
 2018-10-01 13:31:17 +00:00
Henrik Levkowetz a3c12d937f Removed two instances of log.assertion(); we have enough data on these now. 
- Legacy-Id: 15252
 2018-06-14 12:03:02 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge. 
- Legacy-Id: 15084
 2018-04-25 19:52:44 +00:00
Robert Sparks 7df28d8bac Marked a couple of functions as unreachable. Commit ready for merge. 
- Legacy-Id: 15080
 2018-04-25 15:10:55 +00:00
Henrik Levkowetz 2ed9face25 Modified the IESG position setting API to send email messages about positions set. 
- Legacy-Id: 15049
 2018-04-17 11:38:40 +00:00
Henrik Levkowetz a9fbea113b Changed incorrect use of 404 status code in api to 400. Fixes issue #2498. 
- Legacy-Id: 15044
 2018-04-13 11:11:48 +00:00
Henrik Levkowetz bd205ae29b Merged in [14849] from ben@nostrum.com: 
Give ADs the red Clear Ballot button
 - Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
 2018-03-24 13:31:48 +00:00
Ben Campbell cc96709957 Give ADs the red Clear Ballot button 
- Legacy-Id: 14848
 2018-03-17 16:35:35 +00:00
Henrik Levkowetz a04e187f0f Removed some old debug print statements. 
- Legacy-Id: 14823
 2018-03-14 22:11:06 +00:00
Henrik Levkowetz 3dd66eba65 Fixed an UnboundLocalError (only partial variable initialization) bug. 
- Legacy-Id: 14620
 2018-02-07 06:13:19 +00:00
Henrik Levkowetz e1fa3ba381 Limited the iesg ballot position API to ADs (excluding secretariat). 
- Legacy-Id: 14444
 2017-12-19 14:10:43 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/. 
- Legacy-Id: 14430
 2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing. 
- Legacy-Id: 14429
 2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names. 
- Legacy-Id: 14428
 2017-12-16 18:43:08 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command. 
- Legacy-Id: 14426
 2017-12-16 18:37:52 +00:00
Henrik Levkowetz abb69338e2 Added a warning message for the user if ballot creation failed due to an already open ballot. This is a bad state, and should prevented by stricter checks before changing state, but is better than the current situation until we decide exactly which checks to implement. 
- Legacy-Id: 14382
 2017-11-30 16:10:38 +00:00
Henrik Levkowetz e7f3d7ecb1 Added the last call end date to the first line of the last call announcement event description, on request from worley@ariadne.com. 
- Legacy-Id: 13845
 2017-07-12 15:03:17 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00