Commit graph

69 commits

Author SHA1 Message Date
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402)
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
2022-09-01 13:07:28 -03:00
Lars Eggert 67ebadeadd A bunch more cosmetic fixes.
- Legacy-Id: 19913
2022-02-09 10:11:03 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert f974fd3c04 Fix more things
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Jennifer Richards 81d9234d54 Use temporary directories instead of "real" filesystem for tests. Fixes #3414. Commit ready for merge.
- Legacy-Id: 19555
2021-11-05 19:45:57 +00:00
Robert Sparks 805d1f4a7e Use BOF consistently.
- Legacy-Id: 19212
2021-07-14 17:33:14 +00:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Robert Sparks f7b1ce1fce Remove abandoned charters from any future telechats. Fixes #3003. Commit ready for merge.
- Legacy-Id: 18037
2020-06-22 21:22:54 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab34ecbb58 Merged in [17288] from rjsparks@nostrum.com:
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881.
 - Legacy-Id: 17307
Note: SVN reference [17288] has been migrated to Git commit 4cce1b5e08
2020-02-18 22:04:15 +00:00
Henrik Levkowetz 0a6260cf16 Merged in [17286] from rjsparks@nostrum.com:
Add Reply-To to the default group review text. Fixes #2883.
 - Legacy-Id: 17292
Note: SVN reference [17286] has been migrated to Git commit 7e09dea02c
2020-02-13 00:33:37 +00:00
Robert Sparks 4cce1b5e08 Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881. Commit ready for merge.
- Legacy-Id: 17288
2020-02-11 20:17:42 +00:00
Robert Sparks 7e09dea02c Add Reply-To to the default group review text. Fixes #2883. Commit ready for merge.
- Legacy-Id: 17286
2020-02-11 15:39:20 +00:00
Henrik Levkowetz 5460a5ab84 Merged in [16785] from rjsparks@nostrum.com:
Improve alerts when looking at non-current versions of a charter document. Fixes #2774.
 - Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
2019-10-08 14:24:01 +00:00
Ryan Cross d332bfd91d Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals. Commit ready to merge
- Legacy-Id: 16562
2019-07-20 22:54:14 +00:00
Henrik Levkowetz 57e16bfd57 Fixed a typo.
- Legacy-Id: 16511
2019-07-17 16:14:55 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes.
- Legacy-Id: 15994
2019-03-04 20:54:38 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks 880dafdb24 Use factories for ietf.doc.tests_charter. Commit ready for merge.
- Legacy-Id: 15226
2018-06-07 23:50:27 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching.
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Robert Sparks 8026f86cd3 Cleaner charter factory simplifies test code. Commit ready for merge.
- Legacy-Id: 14899
2018-03-22 14:01:24 +00:00
Robert Sparks f11907b6a0 Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge.
- Legacy-Id: 14896
2018-03-21 21:59:45 +00:00
Robert Sparks 975522af35 Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458. Commit ready for merge.
- Legacy-Id: 14715
2018-02-28 20:54:56 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert afdf154e0a Change "ID Tracker" to "Datatracker" in various places. Fixes some of #2100.
Commit ready for merge.
 - Legacy-Id: 13108
2017-03-25 18:23:38 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Robert Sparks b1f229cf9d Create the approval ballot for charters when the charter enters external review (or iesg review if external review is skipped). Fixes #1792. Commit ready for merge.
- Legacy-Id: 10803
2016-02-08 19:59:47 +00:00
Robert Sparks dc2593ebe5 Tweak the rendering of Area Directors in the charter text used in new-work, internal review, external review, and group action messages to display. Fixes #1889. Commit ready to merge.
- Legacy-Id: 10723
2016-01-22 20:47:45 +00:00
Henrik Levkowetz 139cda9543 Added listing of Area Directors, and TBD indications, that was inadvertently dropped from some chartering related emails during refactoring. Also added testing code to verify the email body content of some chartering emails a bit more thoroughly.
- Legacy-Id: 10683
2016-01-13 18:32:02 +00:00
Lars Eggert bcea97323f Fix the internal review email template and related code to handle IRTF RGs
better. Commit ready for merge.
 - Legacy-Id: 10673
2016-01-13 13:50:16 +00:00
Henrik Levkowetz db7aa73eb4 Merged in [10418] from henrik@levkowetz.com:
Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
 - Legacy-Id: 10420
Note: SVN reference [10418] has been migrated to Git commit cf7d794b09
2015-11-04 08:46:35 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00