Commit graph

31 commits

Author SHA1 Message Date
Jennifer Richards 3157cf65d1
fix: Accept&ignore group_type for some views 2024-02-12 17:38:36 -04:00
Jennifer Richards c8dcda0fae
refactor: Do not use canonical_name() for charters (#5818)
* fix: Enforce naming of charter docs in submit()

* style: Reformat submit() with Black

* refactor: Remove redundant check of charter name

* style: Reformat charter_with_milestones_txt with Black

* refactor: Drop canonical_name, use Path in charter_with_milestones_txt

* style: Reformat review_announcement_text() with Black

* style: Reformat action_announcement_text() with Black

* refactor: Change uses of charter.canonical_name() to charter.name

* refactor: Skip docialias when retrieving charter

* refactor: Change canonical_name() to name in utils_charter.py

* refactor: Use Path in read_charter_text()

* refactor: Drop canonical_name, minor refactor of tests_charter.py

* refactor: charter.name instead of canonical_name in milestones.py

* refactor: charter.name instead of canonical_name in tests_info.py

* refactor: Remove unused functions in ietf/secr/utils/groups.py

* refactor: charter.canonical_name -> charter.name in templates

* refactor: Remove charter handling from canonical_name

Temporarily raise an exception for testing

* refactor: Refactor get_charter_text() without canonical_name

* refactor: Remove raise when canonical_name called on a charter

* fix: Add back missing ".txt" extension

* test: Test rejection of invalid charter names
2023-06-14 08:32:21 -05:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Robert Sparks d637a4bd83 Merged in [19254], [19256], [19258], [19259] from rjsparks@nostrum.com:\n Improvements to group-role authorization:\n Show groupman_authroles in the GroupFeatures admin list.\n Rename ietf.group.utils.can_manage_group_type to can_manage_all_groups_of_type to improve code readability where it is used.\n Changed the signature of can_manage_all_groups_of_type to only take a type_id. Removed the logic that tried to distinguish permissions for teams by parent - that should be modeled as separate type_ids instead.\n Changed implementation of can_manage_all_groups_of_type to use GroupFeatures.groupman_authroles.
- Legacy-Id: 19273
Note: SVN reference [19254] has been migrated to Git commit c01fea3920

Note: SVN reference [19256] has been migrated to Git commit 7ede0942d0

Note: SVN reference [19258] has been migrated to Git commit 359889c1f7

Note: SVN reference [19259] has been migrated to Git commit a29480703f
2021-08-04 20:49:28 +00:00
Robert Sparks 62c364899c Guard a sort that gets a mix of integers and None. Commit ready for merge.
- Legacy-Id: 19224
2021-07-15 16:28:15 +00:00
Jennifer Richards 17d37723f7 Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Jim Fenton 65c7080b1f Interim change to prevent chairs from editing milestone description. Fixes #3036. Commit ready for merge.
- Legacy-Id: 18272
2020-07-25 18:01:31 +00:00
Robert Sparks b4ac9f83f1 Restrict the ability to change whether a group uses milestone dates to the ADs and the secretariat. Fixes #2869. Commit ready for merge.
- Legacy-Id: 17234
2020-01-16 21:19:29 +00:00
Robert Sparks 42e5163b09 Adds support for dateless milestones. Fixes #2799. Commit ready for merge.
- Legacy-Id: 17185
2020-01-06 20:48:53 +00:00
Robert Sparks f71e9995a7 Dateless milestone work. Commit in preparation for merging forward.
- Legacy-Id: 17174
2019-12-24 21:38:26 +00:00
Henrik Levkowetz fac3053d48 Fixed an issue with the milestone edit changes.
- Legacy-Id: 14762
2018-03-09 21:27:58 +00:00
Henrik Levkowetz cb051a7f59 Changed the handling of the milestone edit form to defer deletion if deletion is indicated together with other changes to the same milestone. Instead emit a warning, and ask for deletion without simultaneous changes to the milestone.
- Legacy-Id: 14761
2018-03-09 20:05:09 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com:
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge.
- Legacy-Id: 12722
2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155.
- Legacy-Id: 12719
2017-01-23 22:54:36 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
2016-09-05 12:33:54 +00:00
Russ Housley 858530c214 Cleaned up the checking permission for a user to manage a group. Also, cleanly handle a set of group parent links did for a loop.
- Legacy-Id: 11082
2016-04-02 21:06:33 +00:00
Suresh Krishnan e454031b47 Changes to unapproved milestones (e.g. attaching a draft) will not trigger a mail to the WG. Fixes #1818. Commit ready for merge.
- Legacy-Id: 10346
2015-10-31 08:42:37 +00:00
Ole Laursen cebc979282 Summary: Resolve person/email/document multiselect issue by importing
select2 and switching the widgets over to using that. Port the
milestones editing page to Bootstrap.
 - Legacy-Id: 8713
2014-11-25 16:47:48 +00:00
Ole Laursen 5604914bfc Add AutocompletedDocumentsField to be used for replacements submission
and refactor milestones tool to use this field
 - Legacy-Id: 8381
2014-10-09 17:14:14 +00:00
Ole Laursen 6e83335f0f Fix a bunch of mistakes found by PyFlakes in the new materials code
- Legacy-Id: 7839
2014-06-03 11:28:27 +00:00
Ole Laursen 976d0b9d68 Turn charter page for non-chartering groups into about page, fix a bunch of potentially broken links due to the split between group-type prefixed URLs and /group/ ones
- Legacy-Id: 7805
2014-05-30 15:59:02 +00:00
Ole Laursen 17cf1095c7 Fix cosmetic problem with label_suffix and the delete labels on the milestones page
- Legacy-Id: 7770
2014-05-22 16:10:37 +00:00
Ole Laursen 0bd82434c8 Fix problem with milestones editing claiming that all resolved
milestones have been changed when you click the review changes button
(by removing work-around for bug in previous version of Django)
 - Legacy-Id: 7769
2014-05-22 15:55:15 +00:00
Ole Laursen 9579525ca4 Add simple materials page, tie up some of the loose ends in group generalization work
- Legacy-Id: 7768
2014-05-22 15:53:20 +00:00
Ole Laursen f52e676793 Move chartering groups to /group/chartering/ (with a redirect from the old location), list RGs there too, and amend the previous fix to the chartering process for non-WGs so they have internal and external review states instead of just approved. Also move the code in wginfo/ to group/ as it is no longer just about info for WGs.
- Legacy-Id: 7556
2014-04-01 11:59:08 +00:00
Renamed from ietf/wginfo/milestones.py (Browse further)