The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.
To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.
While revising the existing code to work with this API, a couple of
missing events was discovered:
- In draft expiry, a "Document has expired" event was only generated
in case an IESG process had started on the document - now it's
always generated, as the document changes its state in any case
- Synchronization updates like title and abstract amendmends from the
RFC Editor were silently (except for RFC publication) applied and
not accompanied by a descriptive event - they now are
- do_replace in the Secretariat tools now adds an event
- Proceedings post_process in the Secretariat tools now adds an event
- do_withdraw in the Secretariat tools now adds an event
A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
- Legacy-Id: 10101
- Migrates the information captured in GroupInfo.ad to Role objects.
- Renames GroupInfo.ad to GroupInfo._ad (retaining the current column name) to prepare for deletion of that field.
- Provides ad property accessor and setter methods implemented using the group's role_set (so that the existing view code continues to work with minimal changes)
- Improved selection in many querysets that assumed only groups of type 'area' would have area directors.
Related to #1557 and #1555.
Commit ready to merge.
- Legacy-Id: 8851
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes#1438
- Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
Changes when returning_item is automatically set to match the
current IESGs preferences. Removes several chunks of dead code
related to editing telechat dates. Improves returning item tests.
Refactored multiple edit_telechat functions into one function in
doc_views. Added a helper function for determining if ballots have
changed to isolate the implementation. Fixed the issue with
update_agenda setting the returning item bit even when the user
explicitly said not to. Added prompting to encourage proper setting
of the returning item bit to the edit_telechat view.
Fixes#1209
- Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1
Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
Allow the secretariat and ads to change the title of a status change
document. Fixes bug 1141.
Applied changes to adapt the code from Django 1.2 to 1.6: Provide a
quoted string to {% url %} and use request.user.person instead of
request.user.get_profile().
- Legacy-Id: 7221
Note: SVN reference [6361] has been migrated to Git commit 7c4cf7002f
Send email to the secretariat when a status change document is put directly into the last-call-requested state.
Fixes bug 1139.
- Legacy-Id: 7208
Note: SVN reference [6359] has been migrated to Git commit faabcb8328
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
- Legacy-Id: 7129
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3
This adds states to status-change- documents and has a migration that must be applied.
This fixes bug #1039
- Legacy-Id: 5770
added the ability to start a status change when looking at an RFC (populating the start from accordingly)
Made changes and proposed changes show on the RFC pages
- Legacy-Id: 5330