Commit graph

14989 commits

Author SHA1 Message Date
Jennifer Richards 264ff60cd2
Merge pull request #5601 from jennifer-richards/django4
chore: Upgrade to Django 3.0
2023-05-11 11:04:36 -04:00
Jennifer Richards 477a2decb5
chore: Merge main into feat/django4 2023-05-10 18:28:04 -04:00
Jennifer Richards 0d070597b4
style: Double backslashes in strings
Not sure why, but if I change the DeprecationWarning filter to
"error", I get a SyntaxError from the \[ because it is an invalid
escape sequence. Not sure why that change triggers it, but
"\[" and "\\[" are the same, so this is a no-op.
2023-05-10 19:21:47 -03:00
Jennifer Richards eee145ee67
fix: Explicitly order GroupTypeNames in active_group_types
Relying on Meta.ordering to order querysets involving GROUP BY queries
is deprecated and will be dropped in Django 3.1.
2023-05-10 19:19:39 -03:00
Jennifer Richards 406ba7bf0b
style: Apply Black style to active_group_types() view 2023-05-10 19:18:30 -03:00
Jennifer Richards e6259a5218
chore: Remove filter on staticfiles DeprecationWarning 2023-05-10 18:52:52 -03:00
Jennifer Richards 1015cf83f8
fix: Finish refactoring LiaisonModelForm subclasses without BetterModelForm 2023-05-10 18:47:36 -03:00
Jennifer Richards 4f443cc445
refactor: Explicitly allow name=None for a couple of views 2023-05-10 17:16:20 -03:00
Jennifer Richards 163479bc06
refactor: Replace obsolete staticfiles template lib with static 2023-05-10 17:12:34 -03:00
Jennifer Richards 85d0934ba0
refactor: Refactor LiaisonForm without BetterModelForm 2023-05-10 17:03:31 -03:00
Jennifer Richards a75dbd4f40
chore: Remove accidentally reverted removal of form_utils app 2023-05-10 16:50:42 -03:00
Jennifer Richards 21ac8c067d
chore: Fix cookie-delete patch to work with Django 3.0 2023-05-10 16:50:11 -03:00
Nicolas Giard 2163a01adc
chore: move git safe directory command to top 2023-05-10 15:40:22 -04:00
Nicolas Giard 871afb1b86
chore: add git safe directory to docker init script 2023-05-10 15:20:48 -04:00
Jennifer Richards 57026bbb5f
Revert "chore: Remove django-cookie-delete-with-all-settings.patch"
This reverts commit 2cf2a3dee6.
2023-05-10 15:55:25 -03:00
Jennifer Richards 69eb6340fd
test: Do not misuse django.conf.settings for HTML validation params 2023-05-10 15:41:36 -03:00
Robert Sparks f8113cb862
fix: close open things (#5593)
* fix: close open things

* fix: clean up test created files

* fix: remove one close too many
2023-05-10 11:19:34 -05:00
Jennifer Richards ed571ae50b
chore: Rename DB engine to drop the deprecated "_psycopg2" suffix 2023-05-10 12:40:37 -03:00
Jennifer Richards 9fa54270e6
chore: Remove mysqlclient dependency (#5589) 2023-05-09 15:24:17 -05:00
depfu[bot] c53d7836ed
chore(deps): update all npm dependencies for dev/deploy-to-container (#5587)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-05-09 15:23:33 -05:00
depfu[bot] 5b091a0558
chore(deps): update all Yarn dependencies (#5564)
* chore(deps): update all Yarn dependencies

* chore: fix yarn cache

---------

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: NGPixel <github@ngpixel.com>
2023-05-09 15:23:14 -05:00
Jennifer Richards a0f6cdb661
feat: Process uploaded submissions asynchronously (#5580)
* fix: Use relative URL for submission status link

* refactor: Refactor/rename process_uploaded_submission async task

* feat: Add async task to process but not accept a submission

* feat: Replace upload_submission() with an async implementation (WIP)

* fix: Do not put Submission in "uploaded" state if an error occured

* refactor: Improve text/XML draft processing flow

* feat: Extract authors from text in async processing

* fix: Fix call signatures and abort submission on failed validation

* feat: Validate submission name format

* fix: Correctly validate emails from text submission

* fix: Clean up submission validation

* fix: Better display errors on upload_submission page

* feat: Reload submission status page when awaiting validation

* test: Fix call signatures; remove unused imports

* chore: Add type hint

* test: Update tests to match renamed task

* fix: Fix typo in error message

* test: Fix failing Api- and AsyncSubmissionTests

* Rename process_uploaded_submission to process_and_accept_...
* Remove outdated tests

Does not yet test new behavior.

* refactor: Break up submission_file() helper

* test: Refactor tests to run the async processing (wip)

* test: Drop test of bad PDF submission

The PDF submission field was removed, so no need to test it.

* test: Update more tests

* test: Bring back create_and_post_submission() and fix more tests

* fix: Drop to manual, don't cancel, on revision inconsistency

Fixes remaining failing SubmitTest tests

* style: Restyle upload_submission() with black

* test: Verify that async submission processing is invoked on upload

* test: Bring back old do_submission and fix tests

Properly separating the upload and async processing stages of submission
is a bigger refactoring than will fit right now. This better exercises
the submission pipeline.

* fix: Accept only XML for API submissions

* test: Test submission processing utilities

* feat: Improve status display for "validating" submissions

* chore: Remove obsolete code

* test: Update test to match amended text

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-09 15:21:46 -05:00
Jennifer Richards 31fd43184c
chore: Tweak add-django-http-cookie-value-none.patch for Django 3.0 2023-05-09 15:39:12 -03:00
Jennifer Richards da168395fc
refactor: Replace deprecated smart_text with smart_str 2023-05-09 15:23:33 -03:00
Jennifer Richards 07e26dd52e
refactor: Replace deprecated force_text with force_str 2023-05-09 15:21:50 -03:00
Jennifer Richards dcb211fbb3
Merge remote-tracking branch 'origin/main' into django4 2023-05-09 14:26:47 -03:00
Jennifer Richards 2cf2a3dee6
chore: Remove django-cookie-delete-with-all-settings.patch
Patch no longer applies. Needed until Django 4.2.1, so bring it back
if we deploy something earlier than that to production.
2023-05-09 11:09:41 -03:00
Jennifer Richards 9fde845719
chore: Revert psycopg2 dependency
Try again with Django 3.2
2023-05-09 11:05:43 -03:00
Jennifer Richards 6d4d09542f
fix: Replace obsolete curry() with functools.partialmethod() 2023-05-08 22:55:15 -03:00
Robert Sparks b1c60efbb3
chore: add bibxml-ids dir to container build. (#5590) 2023-05-08 15:17:00 -05:00
Robert Sparks 400a830661
chore: add bibxml-ids dir to container build. (#5590) 2023-05-08 15:16:31 -05:00
Jennifer Richards 9fda268853
fix: Replace available_attrs helper (dropped by Django 3.0) 2023-05-08 15:19:33 -03:00
Jennifer Richards e1b783ead9
chore: Update requirements.txt for Django 3.0 2023-05-08 15:03:10 -03:00
Robert Sparks 2b1f248e36
fix: add a link to the simplified volunteer view (#5583) 2023-05-08 10:29:18 -05:00
Robert Sparks f919184e14
chore: pin django-oidc-provider (#5588) 2023-05-08 09:15:36 -05:00
Robert Sparks 3bbd5149de
feat: Easy extraction of qualified volunteer list for nomcom chair (#5578)
* feat: Easy extraction of qualified volunteer list for nomcom chair

* fix: tune test setup to years where eligibility calculations can return nonempty

* chore: revert unintended change

* feat: default string when no affiliation is provided
2023-05-05 15:33:47 -05:00
NGPixel 3af357467c
Merge remote-tracking branch 'origin/release' into main 2023-05-04 15:18:51 -04:00
Robert Sparks e32b453c09
Merge pull request #5575 from ietf-tools/main
chore: merge main to the release branch for next release
2023-05-04 12:51:04 -05:00
Eliot Lear 8af8a91c20
fix: allow ISE to initiate conflict review (#5570)
* ISE may initiate conflict review

Add ISE to list of those roles who can initiate a conflict review.

* fix: improve conditional for conflict review action. Add tests.

* chore: fix comment typo

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-05-03 14:04:09 -05:00
Jennifer Richards 6986cae1bf
fix: Listen for show.bs.modal on document (#5565)
Avoids losing the listener when DOM is changed dynamically.
2023-05-02 13:50:38 -05:00
Robert Sparks 1359a5998f
Merge pull request #5558 from ietf-tools/depfu/batch_all/devcoverage-action/npm/2023-05-01
chore(deps): update all npm dependencies for dev/coverage-action
2023-05-01 10:14:56 -05:00
Robert Sparks f8b23b377c
Merge pull request #5557 from ietf-tools/depfu/batch_all/playwright/npm/2023-05-01
chore(deps): update all npm dependencies for playwright
2023-05-01 10:14:34 -05:00
depfu[bot] f2d34dddac
chore(deps): update all npm dependencies for dev/coverage-action 2023-05-01 06:18:43 +00:00
depfu[bot] 0bf9462d8a
chore(deps): update all npm dependencies for playwright 2023-05-01 06:18:14 +00:00
Robert Sparks f835b6f7b0
Merge pull request #5540 from jennifer-richards/create-account-no-person
fix: Avoid 500 error creating account when User.person is None
2023-04-27 14:05:03 -05:00
Jennifer Richards 82e5db7bbd
Merge branch 'main' into create-account-no-person 2023-04-27 13:52:20 -04:00
Jennifer Richards db2f7362c5
feat: Include support address in error message 2023-04-27 17:51:19 +00:00
Nicolas Giard bef11af9de
Merge pull request #5543 from ietf-tools/main
ci: new release (hopefully?)
2023-04-26 15:51:42 -04:00
Nicolas Giard 180663e4ed
ci: fix build workflow conditions 2023-04-26 15:48:15 -04:00
Robert Sparks 69bc878f70
Merge pull request #5541 from ietf-tools/main
ci: Next datatracker release
2023-04-26 14:38:02 -05:00