altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
16324 commits 1 branch 0 tags 2.6 GiB
Commit graph

176 commits

Author SHA1 Message Date
Henrik Levkowetz 64ba033a6c Changed the default sort for nomcom.models.Nominees to be 'person__name'. 
- Legacy-Id: 15532
 2018-10-08 09:55:10 +00:00
Henrik Levkowetz 29ae7809d7 Merged in [15486] from rjsparks@nostrum.com: 
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598.
 - Legacy-Id: 15487
Note: SVN reference [15486] has been migrated to Git commit 4d5de5dee6
 2018-09-26 21:54:05 +00:00
Robert Sparks 4d5de5dee6 Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598. Commit ready for merge. 
- Legacy-Id: 15486
 2018-09-26 18:57:30 +00:00
Henrik Levkowetz 120d78bbbf Changed the sort order of nominees on the private index page to be according to name (instead of email address). 
- Legacy-Id: 15479
 2018-09-21 19:47:40 +00:00
Henrik Levkowetz fcc22da623 Removed a chunk of code that won't be executed in all test environments from the test coverage measurements 
- Legacy-Id: 14550
 2018-01-23 17:29:41 +00:00
Henrik Levkowetz 374950ede8 Removed code generating nomcom page urls which doesn't resolve any more. Added a comment about the eligibility view for previous nomcoms. 
- Legacy-Id: 14540
 2018-01-19 15:06:23 +00:00
Robert Sparks 4ce6b934b8 Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257. Commit ready for merge. 
- Legacy-Id: 14533
 2018-01-17 17:58:58 +00:00
Robert Sparks 5835e52759 Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303. Commit ready for merge. 
- Legacy-Id: 14511
 2018-01-11 16:28:19 +00:00
Robert Sparks c8b451094a Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852. Commit ready for merge. 
- Legacy-Id: 14505
 2018-01-10 21:54:10 +00:00
Robert Sparks 94f4e9ac58 Simplify the edit nomcom members forms. Fixes #1756. Commit ready for merge. 
- Legacy-Id: 14504
 2018-01-10 18:26:20 +00:00
Robert Sparks 7cecd9fe38 Further refinements to the nominee status table. Related to #2261. Commit ready for merge. 
- Legacy-Id: 14058
 2017-08-16 21:59:51 +00:00
Robert Sparks 2dbb0766fd Improve the nominee status table to serve as a nomcom dashboard. Fixes #2261. Commit ready for merge. 
- Legacy-Id: 14057
 2017-08-16 20:42:33 +00:00
Henrik Levkowetz 3c727106a2 Merged in [13717] from rjsparks@nostrum.com: 
Actually use the topic audience type in the feedback view. Fixes #2320.
 - Legacy-Id: 13728
Note: SVN reference [13717] has been migrated to Git commit 9638cb2e397beab18f3607b324518fd2900215f7
 2017-06-29 12:52:25 +00:00
Robert Sparks 4813177086 Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846. Commit ready for merge. 
- Legacy-Id: 13474
 2017-05-30 19:54:31 +00:00
Robert Sparks ab6820e938 Correctly calculate statistics on the nomcom private index page. Fixes #2254. Commit ready for merge. 
- Legacy-Id: 13400
 2017-05-22 19:07:52 +00:00
Robert Sparks ac8e5f5402 Make it possible to close nominations without closing feedback. Fixes #2255. Commit ready for merge. 
- Legacy-Id: 13399
 2017-05-22 18:40:05 +00:00
Robert Sparks 1a18130c57 Avoid confusing messages saying a key has not been entered when it has. Fixes #2250. Commit ready for merge. 
- Legacy-Id: 13390
 2017-05-17 21:02:20 +00:00
Robert Sparks ceff54480c Update the feedback count badge when new feedback is provided. Fixes #2260. Commit ready for merge. 
- Legacy-Id: 13388
 2017-05-17 13:55:39 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 1fef6fb1d3 Deprecation fix: removed additional cases of using instance_context in render*() 
- Legacy-Id: 12720
 2017-01-23 22:56:34 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz 26fcce9c28 Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task. 
- Legacy-Id: 12017
 2016-09-22 14:23:20 +00:00
Robert Sparks dc5ae398f2 Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once. 
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847.
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
 - Legacy-Id: 10625
 2015-12-22 21:42:55 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person. 
- Legacy-Id: 10619
 2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages 
- Legacy-Id: 10618
 2015-12-21 20:46:56 +00:00
Robert Sparks 2120b79d6b collapse some duplicated code 
- Legacy-Id: 10617
 2015-12-21 16:50:46 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors. 
- Legacy-Id: 10610
 2015-12-18 23:11:24 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96% 
- Legacy-Id: 10606
 2015-12-16 23:12:40 +00:00
Robert Sparks f68d546233 removed move_to_default 
- Legacy-Id: 10603
 2015-12-16 12:07:32 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default 
- Legacy-Id: 10602
 2015-12-16 11:51:32 +00:00
Robert Sparks 5e0632e8eb Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866. 
- Legacy-Id: 10592
 2015-12-14 21:05:52 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845. 
- Legacy-Id: 10589
 2015-12-14 03:26:43 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template 
- Legacy-Id: 10531
 2015-12-02 15:45:40 +00:00
Robert Sparks 2a63f91d31 Simplify pass of counts 
- Legacy-Id: 10527
 2015-12-02 04:44:42 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query 
- Legacy-Id: 10526
 2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges. 
- Legacy-Id: 10525
 2015-12-02 03:32:06 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795. 
- Legacy-Id: 10505
 2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Robert Sparks 1517efaba2 Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703. Commit ready for merge. 
- Legacy-Id: 10004
 2015-08-10 18:28:08 +00:00
Ole Laursen a3399b0bcd Summary: Port remaining parts of nomcom to bootstrap, fix some bugs, 
let the private/public feedback pages share the same template, remove
the edit NomCom chair thing - there's no link to it and the
Secretariat can instead use the ordinary group management tool they
have available
 - Legacy-Id: 8721
 2014-12-02 10:43:20 +00:00
Ole Laursen 87870ca954 Fix more test errors - now only two not yet fully ported views remain 
- Legacy-Id: 8571
 2014-11-03 16:39:41 +00:00
Ole Laursen 41cb195f52 Rebase /personal/lars/5.6.4-facelift/ on trunk 
- Legacy-Id: 8520
 2014-10-30 14:31:07 +00:00
Henrik Levkowetz 0d61e270d6 Normalized a couple of NameModels subclasses. 
- Legacy-Id: 8460
 2014-10-23 21:14:41 +00:00
Lars Eggert a4daf2630c Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift 
Conflicts:
	ietf/doc/templatetags/ietf_filters.py
	ietf/doc/views_charter.py
	ietf/templates/doc/charter/edit_notify.html
	ietf/templates/doc/charter/edit_telechat_date.html
	ietf/templates/doc/document_ballot_content.html
	ietf/templates/doc/document_history.html
	ietf/templates/doc/edit_notify.html
	ietf/templates/doc/edit_telechat_date.html
	ietf/templates/doc/notify.html
	ietf/templates/group/concluded_groups.html
 - Legacy-Id: 8429
 2014-10-14 11:48:57 +00:00
Henrik Levkowetz 25423f6779 Added some formset attributes which are needed by the current Django (1.6) code. A better way would maybe be to use formset_factory(), but a simple invocation of that gives other problems. Leaving as is for now, to get a patch out so the nomcom chair can get on with things. 
- Legacy-Id: 8370
 2014-09-29 21:16:55 +00:00
Henrik Levkowetz 563f584a9e Made ietf/nomcom pyflakes-clean. Removed some dead code. 
- Legacy-Id: 7476
 2014-03-15 19:26:01 +00:00
Ole Laursen ab382a726f While cleaning up the Javascript includes in the nomcom app, it turns 
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
 - Legacy-Id: 7097
 2014-01-10 14:06:36 +00:00
Ole Laursen fdb6baf4e6 Use collections.OrderedDict instead of the SortedDict bundled with Django 
- Legacy-Id: 7026
 2013-12-20 11:00:07 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead 
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
 2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated) 
- Legacy-Id: 6945
 2013-12-16 16:53:47 +00:00
Ole Laursen 3febf7d216 Fix odd boolean calculation in nomcom view 
- Legacy-Id: 6923
 2013-12-13 16:48:37 +00:00
Ole Laursen 771591f0db Remove use of obsolete generic delete view 
- Legacy-Id: 6891
 2013-12-12 12:06:09 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django 
- Legacy-Id: 6883
 2013-12-11 16:59:19 +00:00
Ole Laursen d0f2859631 Move NomCom announcements view to nomcom/, move message view to 
message/, add tests, add redirects, fix a couple of small bugs in the
announcements view
 - Legacy-Id: 6769
 2013-11-28 17:55:10 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00
Henrik Levkowetz 5f2da7ba9e Merged [6486] from rjsparks@nostrum.com: 
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
 - Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
 2013-10-30 21:17:46 +00:00
Henrik Levkowetz 6928ff2927 Correct sequence typo. 
- Legacy-Id: 6491
 2013-10-26 15:32:04 +00:00
Henrik Levkowetz d649fd5e10 Merged [6465] and [6466] from rjsparks@nostrum.com: 
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state.  Changed the send_reminders management command to not take
any arguments and run against all active nomcoms.  Removed bugs from the
send_reminders management command and added tests for it.  Adjusted several
dbtemplate titles and content.

Fixes bug 1157
 - Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a

Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
 2013-10-21 20:12:00 +00:00
Henrik Levkowetz 6c13e8027b Fixed the language in some UI strings in the nomcom tool. 
- Legacy-Id: 6358
 2013-10-03 20:56:59 +00:00
Henrik Levkowetz d2df8cac78 Fixed the manyfold duplicated position names in the position selection drop-down list in the nomcom private index page. Fixes issue #1137. 
- Legacy-Id: 6327
 2013-10-01 13:42:30 +00:00
Henrik Levkowetz 8d9c1e9177 Changed 'requirement' to 'desired expertise' in user-visible places in the nomcom app. 
- Legacy-Id: 6259
 2013-09-24 17:50:02 +00:00
Henrik Levkowetz 5d9e6c0b6a Fixed the language of the nomination confirmation message. 
- Legacy-Id: 6250
 2013-09-23 19:27:17 +00:00
Henrik Levkowetz 0016c69b61 Added an index page for nomcoms, at /nomcom/, with links to nomcom pages and announcements, where they exist. 
- Legacy-Id: 6245
 2013-09-22 18:59:24 +00:00
Ole Laursen 5924024513 Swap the arguments to group.has_role so they match the arguments to 
the existing has_role
 - Legacy-Id: 6218
 2013-09-20 13:46:47 +00:00
Ole Laursen 0eed4ad9e5 Add has_role(role_name, user) utility to group, used like 
group.has_role("chair", request.user). Remove the NomCom specific
group utilities, apparently they're not actually used.
 - Legacy-Id: 6217
 2013-09-20 11:23:17 +00:00
Henrik Levkowetz 641bcccfba Replaced the ad_hoc nomcom_member_required() decorator with our generic role_required() decorator. Changed access permission for nomcom-chair only pages to also permit nomcom advisor access (this lets the previous nomcom chair explain and assist as needed). Also tweaked some text strings in the email feedback pipe script. 
- Legacy-Id: 6160
 2013-09-16 21:05:25 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run. 
- Legacy-Id: 5948
 2013-08-06 10:09:29 +00:00
Emilio A. Sánchez López 49117c1622 Nominations are processed first and then the rest of feedback. 
Select multiple resizable when selecting a nominee.
Fixed command that gets the feedback from email to retrieve the full address on the from header.
Added a "feedback pending" link in the top bar.
Fixed escaped html tags when displaying comments from feedback.
See #975
 - Legacy-Id: 5781
 2013-06-10 10:42:11 +00:00
Emilio A. Sánchez López c12400641a Redesign the feedback pending template. See #975 
- Legacy-Id: 5774
 2013-06-05 06:32:17 +00:00
Emilio Jiménez 66c4a32c57 Add subject field to feedback model 
New form to fill feedback mail via web.
Fixes #1042 #1043
 - Legacy-Id: 5748
 2013-05-21 12:31:24 +00:00
Emilio Jiménez f998e0d29f Add form to change email of nominees. 
Refactor merge form to avoid merge old duplicate nominees.
See #1013
 - Legacy-Id: 5747
 2013-05-20 18:17:31 +00:00
Emilio A. Sánchez López ee1eec7de8 Refactored the feedback pending list. Now you can classify feedback as any type of feedback. 
The feedback of a type that is not related to a nominee is classified inmediatly.
The feedback of a type that is related to a nominee must be completed with the nominee information.
Created a view to list feedback that is not related to nominees (e.g. offtopic)
Changed the command that retrieves feedback from email to add the subject inside the comment and to set the author using the from field of the email.
Fixes #1036. Fixes #1035
 - Legacy-Id: 5738
 2013-05-15 16:33:01 +00:00
Emilio Jiménez a6fdc52397 Refactor code to send reminders in a unique function 
Refactor reminder command.
Fixes #1040
 - Legacy-Id: 5736
 2013-05-15 09:08:49 +00:00
Emilio Jiménez 3d25fa261e now reminder form sends accept and decline links, and questionnaires. 
See #1040
 - Legacy-Id: 5735
 2013-05-15 07:24:32 +00:00
Emilio Jiménez 7042e8896a now you can see new feedback types 
See #973
 - Legacy-Id: 5726
 2013-05-12 18:46:53 +00:00
Emilio A. Sánchez López a7af017465 Rename member_required decorator to nomcom_member_required 
Rename private_key_required decorator to nomcom_private_key_required
Fixes #1038
 - Legacy-Id: 5716
 2013-05-09 09:19:06 +00:00
Emilio Jiménez 3cbdecd3c3 Show a message if there is or not a private kay in the user session 
See #1033
 - Legacy-Id: 5713
 2013-05-08 16:19:03 +00:00
Emilio Jiménez f3b3a21ccb Show if nomcom has a public key 
Fixes #1033
 - Legacy-Id: 5712
 2013-05-08 12:59:55 +00:00
Emilio Jiménez 868a82a327 Change message when public key does not exists 
Refactor context views
Add new templatetags to check if the nomcom has public key
Fixes #1030
 - Legacy-Id: 5710
 2013-05-08 12:37:12 +00:00
Emilio Jiménez 3d747dbcb7 Delete * of date field in remider dates 
Fixes #1031
 - Legacy-Id: 5709
 2013-05-08 11:00:47 +00:00
Emilio Jiménez c3ff510ed0 Change questionnaire response view. 
Fixes #1007
 - Legacy-Id: 5689
 2013-05-02 09:42:00 +00:00
Emilio Jiménez 9409776be8 change "Questionnaire Response" label 
See #1003
 - Legacy-Id: 5687
 2013-05-02 08:03:24 +00:00
Emilio Jiménez 519d628cde Add command to send reminders 
Add fields date an interval in nomcom models to send reminders
Refactor some managers
Add help_text to pending feedback form
Limit types in pending feedback form
See #969 #975
 - Legacy-Id: 5683
 2013-04-23 08:24:21 +00:00
Emilio A. Sánchez López 6898c51490 Merge position and nominee into one field in the feedback pending forms. 
Style the feedback pending forms. 
See #975
 - Legacy-Id: 5668
 2013-04-19 07:46:23 +00:00
Emilio Jiménez 85ab39f1ab Refactor feedback, now feedback belong many to many nominees 
See #913 #929 #930 #965 #970 #975
 - Legacy-Id: 5598
 2013-03-26 13:35:58 +00:00
Emilio Jiménez da031d0a7b Better not show private key by default 
See #947
 - Legacy-Id: 5597
 2013-03-26 12:05:17 +00:00
Emilio Jiménez 69c704de2d better errors control in feedback form. 
See #970
 - Legacy-Id: 5593
 2013-03-25 18:02:00 +00:00
Emilio Jiménez da52637e9b Not show nominees and nominee positions duplicated 
See #970 #973
 - Legacy-Id: 5589
 2013-03-22 13:22:37 +00:00
Emilio Jiménez bf38ef3c34 Improve to manage pending feedback errors. 
See #975
 - Legacy-Id: 5585
 2013-03-22 09:28:51 +00:00
Emilio Jiménez 7f7b771650 Improve save questionnaire data. 
See #970
 - Legacy-Id: 5583
 2013-03-22 09:03:58 +00:00
Emilio Jiménez 139ab194c9 Add questionnaire skel view 
Add feedback test
Fixed labels in feedback form
See #970
 - Legacy-Id: 5582
 2013-03-21 18:33:02 +00:00
Emilio Jiménez a9c33ed9f1 Add view to edit nomcom 
Merge public key edit view whith nomcom edit view
Add view to delete nomcom
Add hash url to accept o decline nominations
Change new nominee template to include hash urls
See #976 #977
 - Legacy-Id: 5578
 2013-03-19 17:51:09 +00:00
Emilio Jiménez d3731ce77e Fixed queryset of feedback pending. 
See #975
 - Legacy-Id: 5577
 2013-03-18 13:31:45 +00:00
Emilio Jiménez 40fd14da25 * Add skek view to manage feedback generated from email. 
* Now, nominee, type and user fields in feedback model can be null
See #975
 - Legacy-Id: 5576
 2013-03-17 21:34:25 +00:00