Commit graph

1572 commits

Author SHA1 Message Date
Robert Sparks 3baea05e6d Use the id-archive wherever we had been using the id-repository. Fixes #3080. Commit ready for merge.
- Legacy-Id: 18550
2020-10-02 14:13:17 +00:00
Henrik Levkowetz 0eee548999 Fixed a couple of pyflakes issues.
- Legacy-Id: 18516
2020-09-24 10:23:30 +00:00
Henrik Levkowetz e2caecba2f Added a migration to create missing DocAlias instances (and remove some bad ones).
- Legacy-Id: 18511
2020-09-22 15:25:58 +00:00
Henrik Levkowetz 51806b1964 Updated log.assertion() to provide an exception object (under Py3, it seems that logging.Logger instances ignore the traceback if there isn't also an exception object). Added a check for unset draft-iesg state to Document.set_state().
- Legacy-Id: 18503
2020-09-18 14:15:02 +00:00
Henrik Levkowetz 0fa1500f52 Changed the format of email addresses added to the document notifications filed when the document shepherd is set. Fixes issue #3079.
- Legacy-Id: 18494
2020-09-14 13:31:39 +00:00
Henrik Levkowetz 90a6ed0d08 Fixed a bad membership test.
- Legacy-Id: 18480
2020-09-09 15:32:38 +00:00
Henrik Levkowetz e86bf0194b Added an assertion to catch an unexpected document state (no IESG state set). Updated the log.assertion() function to accept a "note" argument, for more informative assertion messages.
- Legacy-Id: 18479
2020-09-09 14:09:43 +00:00
Henrik Levkowetz 1354604581 Fixed a pyflakes nit.
- Legacy-Id: 18470
2020-09-07 14:57:00 +00:00
Henrik Levkowetz 0fa8800644 Rewrote some code in document_main to avoid using the iesg_state.slug attribute when iesg_state might not be set.
- Legacy-Id: 18469
2020-09-07 14:54:29 +00:00
Henrik Levkowetz a6bbb33177 Merged in [18445] from rjsparks@nostrum.com:
Provide a management command to inform github backups.
 - Legacy-Id: 18455
Note: SVN reference [18445] has been migrated to Git commit 30ac9833c5
2020-09-01 12:10:48 +00:00
Henrik Levkowetz 21cd74a809 Added search field and tweaked the list display for the DocAlias admin.
- Legacy-Id: 18451
2020-08-31 15:38:33 +00:00
Henrik Levkowetz 2355f7c0e8 Merged in [18378] from rjsparks@nostrum.com:
Improved the classification of some github related external resources. Tightened validation of new resource values.
 - Legacy-Id: 18449
Note: SVN reference [18378] has been migrated to Git commit 2b70735fd2
2020-08-31 15:21:42 +00:00
Robert Sparks 30ac9833c5 Provide a management command to inform github backups. Commit ready for merge.
- Legacy-Id: 18445
2020-08-28 15:34:25 +00:00
Robert Sparks ba7e1f3c6a changes to improve interfacing with the backup scripts
- Legacy-Id: 18442
2020-08-28 15:28:22 +00:00
Henrik Levkowetz b3128842c9 Renamed the AUTH48 state_alert_badge() filter to auth48_alert_badge(), as the filter is specific, not generic.
- Legacy-Id: 18439
2020-08-28 13:29:15 +00:00
Henrik Levkowetz 5a64d6027c Added exception catching around an urlreverse that might fail. (Enumerating valid group types will also work, but can get out of sync, so this is more DRY).
- Legacy-Id: 18437
2020-08-28 12:57:22 +00:00
Henrik Levkowetz 1b2900007a Fixed an issue in the auth48 state_alert_badge() template filter, which could arise for a document where a get_state() call returns None.
- Legacy-Id: 18436
2020-08-28 12:49:09 +00:00
Henrik Levkowetz c98b6c8ad3 Fixed an issue with the generated tag for versioned bibxml entries under /doc/bibxml3 for drafts that have been published as RFC.
- Legacy-Id: 18418
2020-08-26 15:23:41 +00:00
Henrik Levkowetz 8d2e0a0637 Merged in [18357] from rjsparks@nostrum.com:
Show link to a drafts group page for all group types when the draft has a group. Fixes #3061.
 - Legacy-Id: 18406
Note: SVN reference [18357] has been migrated to Git commit cf42db8804
2020-08-24 10:53:10 +00:00
Robert Sparks f4fd4b1921 Gather actual repos to backup takinging user and organizational owners into account, iterating through owner repos when necessary using the github api.
- Legacy-Id: 18384
2020-08-19 19:07:29 +00:00
Robert Sparks 2b70735fd2 Improved the classification of some github related external resources. Tightened validation of new resource values. Commit ready to merge.
- Legacy-Id: 18378
2020-08-17 23:50:22 +00:00
Henrik Levkowetz 9125104065 Merged in [18324] from rjsparks@nostrum.com:
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419.
 - Legacy-Id: 18363
Note: SVN reference [18324] has been migrated to Git commit cb58810705
2020-08-13 11:23:22 +00:00
Robert Sparks cf42db8804 Show link to a drafts group page for all group types when the draft has a group. Fixes #3061. Commit ready for merge.
- Legacy-Id: 18357
2020-08-12 18:47:29 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Robert Sparks cb58810705 Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419. Commit ready to merge.
- Legacy-Id: 18324
2020-07-30 21:44:02 +00:00
Henrik Levkowetz e4bc508abc Merged in [18298] from rjsparks@nostrum.com:
Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027.
 - Legacy-Id: 18320
Note: SVN reference [18298] has been migrated to Git commit 2b10465aa7
2020-07-30 14:27:17 +00:00
Henrik Levkowetz 9dbdbd5078 Merged in [18296] from rjsparks@nostrum.com:
Show RSOC from the Group menu. Fixes #3024.
 - Legacy-Id: 18308
Note: SVN reference [18296] has been migrated to Git commit 328c92f395
2020-07-29 14:18:29 +00:00
Henrik Levkowetz 57f6fba930 Merged in [18276] from housley@vigilsec.com:
Send email to AD when an IETF Last Call expires that contains downrefs. Fixes #2472
 - Legacy-Id: 18306
Note: SVN reference [18276] has been migrated to Git commit e0ca07e65d
2020-07-29 13:08:10 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge.
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Robert Sparks 44d19f0533 Let MyPy know a decoration is on purpose. Commit ready for merge.
- Legacy-Id: 18297
2020-07-28 16:49:08 +00:00
Robert Sparks 328c92f395 Show RSOC from the Group menu. Fixes #3024. Commit ready for merge.
- Legacy-Id: 18296
2020-07-28 16:10:42 +00:00
Henrik Levkowetz f10255e0e2 Merged in [18270] from valery@smyslov.net:
Added display of verified errata in red, not verified in orange in document lists.

    #2997
 - Legacy-Id: 18280
Note: SVN reference [18270] has been migrated to Git commit 126d32b37f
2020-07-26 14:46:35 +00:00
Russ Housley e0ca07e65d Send email to AD when an IETF Last Call expires that contains downrefs. Fixes #2472
- Legacy-Id: 18276
2020-07-25 21:09:50 +00:00
Valery Smyslov 126d32b37f #2997
- Legacy-Id: 18270
2020-07-25 17:25:31 +00:00
Henrik Levkowetz d16e946ed3 Merged in [18189] from jennifer@painless-security.com:
Make docs in Auth48 state visually distinct. Fixes #2925.
 - Legacy-Id: 18210
Note: SVN reference [18189] has been migrated to Git commit abe97eeb28
2020-07-21 09:28:53 +00:00
Henrik Levkowetz d6d3d82434 Merged in [18198] from rjsparks@nostrum.com:
Return the right reference for interim meeting materials.
 - Legacy-Id: 18200
Note: SVN reference [18198] has been migrated to Git commit 9bcd64455a
2020-07-20 18:09:16 +00:00
Robert Sparks 9bcd64455a Return the right reference for interim meeting materials. Commit ready for merge.
- Legacy-Id: 18198
2020-07-20 17:39:33 +00:00
Henrik Levkowetz 606cedd796 Merged in the ExtResource work from rjsparks@nostrum.com, based on a feature request and contributions from rsalz@akamai.com. This provides external resource models for Person, Group, and Document models, as a generalisation of the previous related-URL concept. This provides a consistent labelling and classification of URLs and other resources related to a Group, Document, or Person. The GroupURL (and similar) classes will be removed in a later step. Some DocumentURL instances (such as auth48 URLs) remain to convert, as they have come in with other merged-in work while the ExtResource work was in transit.
- Legacy-Id: 18192
2020-07-20 01:58:26 +00:00
Jennifer Richards abe97eeb28 Make docs in Auth48 state visually distinct. Fixes #2925. Commit ready for merge.
- Legacy-Id: 18189
2020-07-17 18:14:23 +00:00
Henrik Levkowetz 4bc6a20661 Merged in [18162] from jennifer@painless-security.com:
Notify IRSG when an IRSG ballot is created. Fixes #2978.
 - Legacy-Id: 18177
Note: SVN reference [18162] has been migrated to Git commit 6e97a89786
2020-07-15 14:52:38 +00:00
Henrik Levkowetz 4fa431651c Renumbered some migrations to avoid multiple leaf nodes.
- Legacy-Id: 18169
2020-07-14 17:40:41 +00:00
Henrik Levkowetz 4b1074483a Merged in [18159] from jennifer@painless-security.com:
Notify secretariat when conflict review/status change doc enters an announcement pending state. Fixes #2962.
 - Legacy-Id: 18168
Note: SVN reference [18159] has been migrated to Git commit 24140fac50
2020-07-14 12:25:47 +00:00
Henrik Levkowetz 2d6925f02f Fixed an UnboundLocalError issue.
- Legacy-Id: 18167
2020-07-14 12:06:14 +00:00
Henrik Levkowetz a7b3d9c83b Merged in [18157] from jennifer@painless-security.com:
Store Auth48 URL as DocumentURL and display in RFC-Editor state. Migrates old data when possible. Alternative to 17563. Fixes #2722.
 - Legacy-Id: 18166
Note: SVN reference [18157] has been migrated to Git commit fff927b085
2020-07-14 11:22:11 +00:00
Robert Sparks 6227162e53 Updated mgmt command to find github repos to back up. Improved test coverage of branch changes. Branch ready for merge.
- Legacy-Id: 18163
2020-07-13 17:36:34 +00:00
Jennifer Richards 6e97a89786 Notify IRSG when an IRSG ballot is created. Fixes #2978. Commit ready for merge.
- Legacy-Id: 18162
2020-07-13 16:45:45 +00:00
Jennifer Richards 24140fac50 Notify secretariat when conflict review/status change doc enters an announcement pending state. Fixes #2962. Commit ready for merge.
- Legacy-Id: 18159
2020-07-13 16:11:58 +00:00
Robert Sparks 99df95d542 Cleaned up created names. Improved validation during migration. Cleaned up migration output. Cleaned the last of the awp includes from secr views. Removed now unused secr templates. Build extresource urls correctly during submission and when creating group wikis.
- Legacy-Id: 18158
2020-07-13 16:03:39 +00:00
Jennifer Richards fff927b085 Store Auth48 URL as DocumentURL and display in RFC-Editor state. Migrates old data when possible. Alternative to 17563. Fixes #2722. Commit ready for merge.
- Legacy-Id: 18157
2020-07-13 15:34:01 +00:00
Robert Sparks 53f7bc3ce6 migrated forward
- Legacy-Id: 18144
2020-07-09 21:07:05 +00:00
Robert Sparks 066ee27505 preparing to merge forward
- Legacy-Id: 18143
2020-07-09 20:29:45 +00:00
Robert Sparks c6f55a3306 Fixed some test scaffolding that used non-existent keys (uncovered by recent improvements in sqlite3 integrity checking). Commit ready for merge.
- Legacy-Id: 18130
2020-07-02 20:05:02 +00:00
Henrik Levkowetz 47a2174e80 Django 2.2 does not wrap single queries in transactions, for performance reasons. This caused some template tags that did database lookups to trigger exceptions. Fixed by moving the lookups (which would not normally change between apache reloads) out from the template tag code to module scope. Adding new groups of type ['ag','area','team','dir','program'] will now require a reload to show up in the group menu.
- Legacy-Id: 18086
2020-06-27 17:28:50 +00:00
Henrik Levkowetz dc5ca4eebc Merged in Django 2.1 upgrade changes.
- Legacy-Id: 18060
2020-06-24 20:51:00 +00:00
Henrik Levkowetz dc7581fef4 Changed NullBoleanField() to BooleanField(null=True), according to the 2.1 upgrade recommendations.
- Legacy-Id: 18051
2020-06-24 20:33:57 +00:00
Robert Sparks bf53bf1057 Merged forward. Added some missing parts to the XMPPURLValidator.
- Legacy-Id: 18050
2020-06-24 19:01:45 +00:00
Robert Sparks f7b1ce1fce Remove abandoned charters from any future telechats. Fixes #3003. Commit ready for merge.
- Legacy-Id: 18037
2020-06-22 21:22:54 +00:00
Robert Sparks d87a1d009b Map some new urls. Create a new external resource type
- Legacy-Id: 17873
2020-05-21 21:46:51 +00:00
Robert Sparks 8a0578040e Added better self-descriptive __str__ functions to PersonExtResource, GroupExtResource, and DocExtResource
- Legacy-Id: 17871
2020-05-21 20:59:44 +00:00
Robert Sparks 02e1226a03 Added appropriate Admin classes
- Legacy-Id: 17870
2020-05-21 20:48:03 +00:00
Robert Sparks 785f6243f1 explicit resource names for classes with the word resource in their name
- Legacy-Id: 17857
2020-05-20 18:28:05 +00:00
Robert Sparks 7e57be2bd3 merged forward ^/personal/rjs/explore-extref
- Legacy-Id: 17840
2020-05-19 18:47:47 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz 02804ba163 Fixed a case of too few format string parameters.
- Legacy-Id: 17768
2020-05-10 14:14:50 +00:00
Henrik Levkowetz 81197f044c Tweaked a 404 message to differentiate between two not-found cases.
- Legacy-Id: 17767
2020-05-10 14:13:39 +00:00
Henrik Levkowetz 29ccca849a Added a second link to htmlized draft content (on the datatracker) in addition to the link to the tools hosted htmlized document.
- Legacy-Id: 17760
2020-05-06 18:23:47 +00:00
Henrik Levkowetz 0b51e9a2b3 Removed a debug statement.
- Legacy-Id: 17732
2020-05-04 20:59:44 +00:00
Henrik Levkowetz 35a2a145fa Merged in [17708] from rjsparks@nostrum.com:
Remove 'point raised - writup needed' from the set of substates the IESG can use with a document. Fixes #2968.
 - Legacy-Id: 17731
Note: SVN reference [17708] has been migrated to Git commit fa492c3947
2020-05-04 20:50:17 +00:00
Henrik Levkowetz 3e6a1cfb11 Limited the data for 'New draft revisions over time' on the personal profile page to type='draft'.
- Legacy-Id: 17720
2020-05-01 11:37:32 +00:00
Robert Sparks fa492c3947 Remove "point raised - writup needed" from the set of substates the IESG can use with a document. Fixes #2968. Commit ready for merge.
- Legacy-Id: 17708
2020-04-29 20:32:31 +00:00
Robert Sparks 7587d564d4 Added GroupExtResources to the group about page, and added the ability to edit them.
- Legacy-Id: 17685
2020-04-24 21:47:24 +00:00
Robert Sparks 2de9eb93b5 Added validation to the migrations. Added external resources to the draft display page. Built an editor for DocExternalResources.
- Legacy-Id: 17683
2020-04-24 16:14:43 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Robert Sparks 672f9bce26 Added display-name. Refined migrations.
- Legacy-Id: 17646
2020-04-15 19:54:29 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584.
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz 98fab6c05b Merged in [17562] from jennifer@painless-security.com:
Add tooltips with doc name to 'updates' and 'obsoletes' links. Fixes #2866;
 - Legacy-Id: 17569
Note: SVN reference [17562] has been migrated to Git commit 2d6179c1a5
2020-03-31 13:03:15 +00:00
Jennifer Richards 2d6179c1a5 Add tooltips with doc name to "updates" and "obsoletes" links. Fixes #2866; Commit ready for merge.
- Legacy-Id: 17562
2020-03-30 20:22:05 +00:00
Henrik Levkowetz 37f39163d1 Prevent an exception on missing author.email.person when listing author emails.
- Legacy-Id: 17554
2020-03-27 16:14:29 +00:00
Henrik Levkowetz 50bb971fc3 Merged in [17496] from rjsparks@nostrum.com:
Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to.  Removed unnecessary imports.
 - Legacy-Id: 17522
Note: SVN reference [17496] has been migrated to Git commit db5d11ea32
2020-03-23 22:34:03 +00:00
Henrik Levkowetz c6be826113 Merged in [17495] from rjsparks@nostrum.com:
Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state.
 - Legacy-Id: 17517
Note: SVN reference [17495] has been migrated to Git commit f2b106cf8c
2020-03-23 11:16:19 +00:00
Henrik Levkowetz 970248a3d6 Merged in [17494] from rjsparks@nostrum.com:
Use current email addresses when we have them when listing document authors. Fixes #1902.
 - Legacy-Id: 17516
Note: SVN reference [17494] has been migrated to Git commit 8583a0a098
2020-03-22 23:55:49 +00:00
Robert Sparks c055d37dcb Removed extref app. Refined population migrations.
- Legacy-Id: 17509
2020-03-22 19:27:28 +00:00
Robert Sparks db5d11ea32 Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to. Commit ready for merge.
- Legacy-Id: 17496
2020-03-21 22:11:33 +00:00
Robert Sparks f2b106cf8c Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state. Commit ready for merge.
- Legacy-Id: 17495
2020-03-21 22:07:15 +00:00
Robert Sparks 8583a0a098 Use current email addresses when we have them when listing document authors. Fixes #1902. Commit ready for merge.
- Legacy-Id: 17494
2020-03-21 21:36:58 +00:00
Henrik Levkowetz 87bf4e8d58 Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899.
- Legacy-Id: 17485
2020-03-21 17:34:37 +00:00
Robert Sparks 316dd183d9 first run at external resources
- Legacy-Id: 17470
2020-03-19 23:32:24 +00:00
Henrik Levkowetz 08130f4986 Merged in [17396] from rjsparks@nostrum.com:
Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286.
 - Legacy-Id: 17420
Note: SVN reference [17396] has been migrated to Git commit 79bb245f8a
2020-03-11 19:21:43 +00:00
Henrik Levkowetz ec13af6c43 Added a guard against accessing attributes of None.
- Legacy-Id: 17409
2020-03-08 13:18:58 +00:00
Henrik Levkowetz 638fbc592e Added a data migration to fix up some incorrect external URLs for reviews.
- Legacy-Id: 17402
2020-03-07 14:21:41 +00:00
Robert Sparks 79bb245f8a Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286. Commit ready for merge.
- Legacy-Id: 17396
2020-03-06 16:47:59 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Henrik Levkowetz a14e38a1a1 Replaced most cases of using of urlopen(), instead using the higher-level 'requests' module where it simplifies the code.
- Legacy-Id: 17380
2020-03-03 17:34:42 +00:00
Henrik Levkowetz 94e4dc7c74 Python3 is more ticklish about comparing strings to None than Py2. Fixed an issue with this in generate_sort_key() for document searches.
- Legacy-Id: 17373
2020-03-02 12:47:05 +00:00
Henrik Levkowetz 07747b26c3 Fixed an issue with tests mocking urlopen() responses, and tweaked error messages on bad results in sync/rfceditor.py
- Legacy-Id: 17356
2020-02-27 15:05:27 +00:00
Henrik Levkowetz bea0c59d6e Fixed a string vs list issue for Message from form case.
- Legacy-Id: 17338
2020-02-26 17:01:00 +00:00
Henrik Levkowetz a7baacf519 Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting.
- Legacy-Id: 17337
2020-02-26 16:59:18 +00:00
Henrik Levkowetz ab34ecbb58 Merged in [17288] from rjsparks@nostrum.com:
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881.
 - Legacy-Id: 17307
Note: SVN reference [17288] has been migrated to Git commit 4cce1b5e08
2020-02-18 22:04:15 +00:00