Commit graph

2465 commits

Author SHA1 Message Date
Ole Laursen 822fd6daac Replace get_profile() hack with a test on the user instead, this
also makes the ballot icon more robust against users without profiles
(which shouldn't happen, but apparently we sometimes get one which
results in a crash rather than something more graceful)
 - Legacy-Id: 4480
2012-06-20 12:26:06 +00:00
Ole Laursen 35eb4f013a Give the incoming name to the top renderer so the links are internally
consistent, this is needed because we still have different views for
/doc/rfcXXXX/ and /doc/draft-foo-bar/
 - Legacy-Id: 4479
2012-06-20 11:16:55 +00:00
Ole Laursen 278776f597 Fix regexp fix - [.-_] does not mean "dot or dash or underscore", it
means all characters between dot and underscore
 - Legacy-Id: 4478
2012-06-20 11:13:46 +00:00
Ole Laursen 95c2b07691 Include _ in allowed document name regexp, we currently have 7 drafts
with _ in the database despite it not being valid - they can be found
with:
select name from doc_document where name like '%\_%' and type_id = "draft";
 - Legacy-Id: 4477
2012-06-20 11:00:35 +00:00
Henrik Levkowetz 7b75d6fd65 Quick fix for extensionless get_absolute_url(). XXX Fixme: needs bigger refactoring.
- Legacy-Id: 4476
2012-06-20 10:27:32 +00:00
Ole Laursen 7538eab96f Fix flow of approval of charters/announcement of the WG action based
on feedback from Cindy Morgan, now there's a link on the approval page
to go to the edit page which sends you back upon saving, and the edit
page doesn't provide a button to send the announcement since you
should do that on the approve page (instead it provides a link).
 - Legacy-Id: 4474
2012-06-19 18:48:02 +00:00
Ole Laursen 4cb42fd91c Include current milestones in charter action/review announcements,
fixes issue #835.
 - Legacy-Id: 4473
2012-06-19 17:06:56 +00:00
Ole Laursen bc6bd21b94 Add CC for group mailing list in action/review emails, fixes issue #837.
- Legacy-Id: 4470
2012-06-19 14:32:18 +00:00
Ole Laursen a353acd7e6 Fix link to charter .txt file on agenda page
- Legacy-Id: 4469
2012-06-19 14:16:08 +00:00
Ole Laursen 72f5495ebb Apparently, CHARTER_TXT_URL http://www.ietf.org/charters/ is really
http://www.ietf.org/charter/, fix this in the settings.py file
 - Legacy-Id: 4468
2012-06-19 14:15:04 +00:00
Henrik Levkowetz 77977bf32f Remove print statements.
- Legacy-Id: 4464
2012-06-17 14:07:18 +00:00
Henrik Levkowetz 802ee2905d Quick fix for crash when going to /wg/imapmove/charter/. I'm not happy about the 'charter-ietf-' constant which now appears several places in the code; we need settings which defines the correct name pattern for different document types (or a table or table column, maybe). But this hopefully will make it possible to continue processing proposed WGs ...
- Legacy-Id: 4459
2012-06-14 20:32:35 +00:00
Henrik Levkowetz fde5387f7a Add missing '{{' before 'submission.filename' in draft announcement email templates.
- Legacy-Id: 4458
2012-06-14 20:19:52 +00:00
Henrik Levkowetz b136245597 Apply patch from rjsparks@nostrum.com for bug in determining if a document is on the agenda, leftover from transition to new schema.
- Legacy-Id: 4454
2012-06-11 21:49:54 +00:00
Henrik Levkowetz dd7c492085 Set version info and settings back to development mode
- Legacy-Id: 4451
2012-06-11 18:40:17 +00:00
Henrik Levkowetz d75d099907 Set version info to release version 4.20 before branching.
- Legacy-Id: 4449
2012-06-11 18:40:15 +00:00
Henrik Levkowetz 51a3c373c5 Added a debug utility module on the same level as south,html5lib etc.
- Legacy-Id: 4446
2012-06-11 15:56:51 +00:00
Henrik Levkowetz a4220324e0 Don't try to call get_profile() if it's not available.
- Legacy-Id: 4445
2012-06-10 18:28:28 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen ed96cee2e4 Add listing of recently approved drafts to approval page by request
from Barry Leiba.
 - Legacy-Id: 4420
2012-05-14 18:21:34 +00:00
Ole Laursen 3a7a45f771 Don't state the group count when you're chair of one group only, it
doesn't seem very polite to point that out.
 - Legacy-Id: 4416
2012-05-11 17:48:47 +00:00
Ole Laursen c2b8c653fd Fix bug in submit, had forgotten I had replaced filename with name in
Preapproval model.
 - Legacy-Id: 4413
2012-05-10 18:22:03 +00:00
Ole Laursen 188c0846d0 Add approval/pre-approval page for Secretariat and WG Chairs, with
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
 - Legacy-Id: 4411
2012-05-10 18:07:59 +00:00
Henrik Levkowetz 37172f3c0b Don't include interim meetings in those considered for the default meeting number for the '/meeting/' url.
- Legacy-Id: 4407
2012-05-07 20:39:51 +00:00
Ole Laursen bb30e1d681 Remove accidentally committed debug print.
- Legacy-Id: 4406
2012-05-07 19:21:54 +00:00
Ole Laursen da3c40de49 Fix test error introduced by ballot refactor (test didn't set up
ballot position properly).
 - Legacy-Id: 4405
2012-05-07 19:21:26 +00:00
Ole Laursen 88d083ff72 Turn chartering process around so one submits the charter text before
putting the charter document into the review state and emailing the
Secretariat.
 - Legacy-Id: 4404
2012-05-07 17:18:45 +00:00
Ole Laursen 2e4ceb5a55 Fixup special init charter/recharter pages to make the process more self-explanatory.
- Legacy-Id: 4403
2012-05-07 16:25:04 +00:00
Ole Laursen 79b4c0843b Add confirmation step so that the new charter effort page allows one
to continue from a BoF (with a warning with confirmation being ticked)
and continue from a WG (with another warning and confirmation not
being ticked). Also allow overriding a historically used acronym (one
that's in the GroupHistory) after confirmation.
 - Legacy-Id: 4402
2012-05-07 16:04:45 +00:00
Ole Laursen 2dbed6a439 Don't show request closing WG link if group is proposed.
- Legacy-Id: 4401
2012-05-07 15:57:22 +00:00
Ole Laursen 07382a07a4 Add an entry to the group history when closing a group is being
requested and use that to put a notice on the WG page.
 - Legacy-Id: 4399
2012-05-04 17:46:35 +00:00
Ole Laursen e2aa218b8a Hide mail to Secretariat and initial review time on rechartering, also
fix some phrasing problems.
 - Legacy-Id: 4398
2012-05-04 17:06:24 +00:00
Ole Laursen 4250832349 Fix URL broken by previous commit moving the charter state help page.
- Legacy-Id: 4397
2012-05-04 16:57:00 +00:00
Ole Laursen 4f9bacbe74 Add notify edit functionality, and send email to charter.notify when
the state is changed as is done for drafts.
 - Legacy-Id: 4396
2012-05-04 16:56:12 +00:00
Henrik Levkowetz 1714428150 Tweak the error messages for acronym collisions in the create-wg form.
- Legacy-Id: 4395
2012-05-04 15:01:02 +00:00
Henrik Levkowetz 2bd427ec0f Add quotes around the WG name in the state change text, for better readability.
- Legacy-Id: 4394
2012-05-04 14:59:30 +00:00
Ole Laursen fc01365352 Remove silly acronym-has-changed check in conclude WG view.
- Legacy-Id: 4393
2012-05-04 14:41:16 +00:00
Ole Laursen 06908f3241 Rename label for WG conclude request so it's clear one is only
requesting the conclusion, not actually closing it.
 - Legacy-Id: 4392
2012-05-04 14:28:42 +00:00
Ole Laursen 286b2fc687 Increase size of conclusion request textarea.
- Legacy-Id: 4391
2012-05-04 14:26:25 +00:00
Henrik Levkowetz 3f3ae20eb4 Apply fix to missing nomcom chair in [4384] instead of [4385].
- Legacy-Id: 4389
Note: SVN reference [4385] has been migrated to Git commit c3ad0b53e4
2012-05-04 13:47:15 +00:00
Henrik Levkowetz 2eb0ab5921 Make arguments to url help_charter_states match the definition in ietf/idrfc/urls.py.
- Legacy-Id: 4388
2012-05-04 13:38:12 +00:00
Henrik Levkowetz c7e75522ad Fix bug in picking up blocking text (patch provided by olau@iola.dk).
- Legacy-Id: 4387
2012-05-04 12:57:06 +00:00
Henrik Levkowetz c3ad0b53e4 Catch exception which is raised if a nomcom NN group has been created, but no nomcom chair has been announced and added yet.
- Legacy-Id: 4385
2012-05-04 12:53:51 +00:00
Henrik Levkowetz 9f3cf38a71 Merged [4364] from rjsparks@nostrum.com:
Expose how many pages each document contains on the docs on future telechats page.
Fixes bug #828
 - Legacy-Id: 4383
Note: SVN reference [4364] has been migrated to Git commit b3c665287d
2012-05-04 11:57:35 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Henrik Levkowetz 741b85926b Fix signature of DocEventAdmin method (needs explicit 'self' parameter)
- Legacy-Id: 4381
2012-05-04 11:44:15 +00:00
Ole Laursen 3ec4dffd24 Check and sanitize text file upload (code is factored out in a new
helper so it can be reused elsewhere in the future).
 - Legacy-Id: 4380
2012-05-04 11:37:16 +00:00
Ole Laursen eaf09d9dc5 Move charter state help to /doc/help/state/charter/.
- Legacy-Id: 4379
2012-05-03 19:23:24 +00:00
Ole Laursen 6ebd2c47ca Say "generate" rather than "edit" when there's no text in the boxes
- Legacy-Id: 4378
2012-05-03 19:14:22 +00:00
Ole Laursen 0cb29a7d10 Don't show diff box if there's only 1 entry (and itself).
- Legacy-Id: 4377
2012-05-03 19:11:50 +00:00
Ole Laursen 3b2c0a2169 Say "Charter" rather than "Recharter" on the charter /doc/ page if the group is proposed or a BoF.
- Legacy-Id: 4376
2012-05-03 19:00:40 +00:00
Ole Laursen 5215527de2 Treat BoF as proposed WG.
- Legacy-Id: 4374
2012-05-03 18:50:51 +00:00
Ole Laursen 79e8013455 s/WG/group/ in acronym clash error.
- Legacy-Id: 4373
2012-05-03 18:47:01 +00:00
Ole Laursen 53f86fe75f Add a star to the required fields.
- Legacy-Id: 4372
2012-05-03 18:39:25 +00:00
Ole Laursen 1526857f43 Fix test broken by previous commit.
- Legacy-Id: 4371
2012-05-03 18:34:54 +00:00
Ole Laursen 761946c653 Fix buggy new group acronym check.
- Legacy-Id: 4369
2012-05-03 18:17:33 +00:00
Ole Laursen c8e9362ba0 Amend previous commit to generate writeups on entering internal review instead.
- Legacy-Id: 4368
2012-05-03 18:09:29 +00:00
Ole Laursen c69174a483 Generate action and review text automatically.
- Legacy-Id: 4367
2012-05-03 18:06:03 +00:00
Ole Laursen 5345def221 Make phrasing sligtly more clear.
- Legacy-Id: 4366
2012-05-03 18:05:02 +00:00
Ole Laursen 7573505b09 Make it move obvious what the change state view actually does by
rephrasing the form.
 - Legacy-Id: 4365
2012-05-03 17:49:12 +00:00
Robert Sparks b3c665287d Expose how many pages each document contains on the docs on future telechats page.
Fixes bug #828
 - Legacy-Id: 4364
2012-05-03 17:47:12 +00:00
Ole Laursen 7527788f85 Fix some phrasing bugs.
- Legacy-Id: 4363
2012-05-03 17:33:52 +00:00
Ole Laursen cb634216b5 Fix terminology confusion and say "send ballot" rather than "issue
ballot" to clear up that it is not actually created.
 - Legacy-Id: 4362
2012-05-03 17:02:55 +00:00
Ole Laursen b6a057673a Fix wording of send ballot comment, the actual text was still specific
to drafts.
 - Legacy-Id: 4360
2012-05-03 16:15:20 +00:00
Ole Laursen 1e0cb1f105 Don't show edit button for snapshots.
- Legacy-Id: 4359
2012-05-03 15:40:28 +00:00
Ole Laursen 7c8d018ad4 Fix bug in hiding "external review needed" checkbox.
- Legacy-Id: 4358
2012-05-03 15:33:08 +00:00
Ole Laursen 9717202fed Create charters in state notrev instead of intrev, as a side effect
this fixes a problem with comments not being saved when starting
review on charter.
 - Legacy-Id: 4357
2012-05-03 12:02:08 +00:00
Robert Sparks 4eabc033c1 Replaced the concept of a tag (via-rfc) identifying ise or irtf document (previously the idinternal.via_rfc_editor boolean) with looking at the document's stream.
Removed the stream editing form - that functionality is on the edit info form.
Put the old-ADs back into the list of choices when editing a document's info.

This (re) fixes bug #749
 - Legacy-Id: 4356
2012-05-03 04:26:09 +00:00
Henrik Levkowetz 462aff53ad Merged in fixes to the charter branch (r4345 - r4353) from olau@iola.dk.
- Legacy-Id: 4354
2012-05-02 19:37:46 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 891ac2585d Use revision numbers to identify ballots and put a warning on closed ballots.
- Legacy-Id: 4352
2012-05-02 17:47:40 +00:00
Ole Laursen 79d9eb84a9 Fix bug in event description when copying over the final approved
charter file.
 - Legacy-Id: 4351
2012-05-02 14:52:16 +00:00
Ole Laursen c4298f602a Offer text from latest approved revision in case there's no initial text
for a recharter submit form.
 - Legacy-Id: 4350
2012-05-02 12:18:40 +00:00
Ole Laursen 5fcd0297ed Reverse direction of revisions on charter /doc/ page to match tools.ietf.org/html/draft-*.
- Legacy-Id: 4349
2012-05-02 12:16:25 +00:00
Ole Laursen b869d9f9dc Change max acronym length to 10 instead of 8
- Legacy-Id: 4348
2012-05-02 11:36:41 +00:00
Ole Laursen 85708073f0 Fix "yes" calculation in needed_ballot_position (bug found by Robert Sparks).
- Legacy-Id: 4347
2012-05-02 11:32:42 +00:00
Ole Laursen 1161d0c848 Fix phrasing on status page
- Legacy-Id: 4344
2012-05-01 12:47:53 +00:00
Ole Laursen 7f5a86f5dd Fix problem with running script again when there are existing ballot
events
 - Legacy-Id: 4343
2012-04-30 18:24:28 +00:00
Ole Laursen 2eec257dc8 Add default=None to ballot in BallotPositionDocEvent so it's backwards compatible
- Legacy-Id: 4342
2012-04-30 18:18:47 +00:00
Ole Laursen 9f880a3aab Port all still relevant changes between trunk before migration and charter branch to new trunk (mostly various minor template fixes), except 0.24 version of draft.py tool which has some interfaces changes that requires changes in the submit tool
- Legacy-Id: 4341
2012-04-30 13:36:56 +00:00
Henrik Levkowetz 8972ef7917 Fix from Adam with a tweak from Henrik for empty .ics files
- Legacy-Id: 4337
2012-04-26 21:38:27 +00:00
Henrik Levkowetz 6b86c81319 Set version info and settings back to development mode
- Legacy-Id: 4336
2012-04-26 20:28:12 +00:00
Henrik Levkowetz f065558b38 Set version info to release version 4.02 before branching.
- Legacy-Id: 4334
2012-04-26 20:27:55 +00:00
Henrik Levkowetz fddaf58f41 Merged [4288] from rjsparks@nostrum.com:
Made several changes to correctly use the new (RFC6410)  "Internet Standard" level
in email that gets sent at various stages in the handling of documents.

Fixes bug 821.
 - Legacy-Id: 4332
Note: SVN reference [4288] has been migrated to Git commit 0e2dd258c7
2012-04-26 20:00:48 +00:00
Henrik Levkowetz d383fac853 Merged branch/iola/migration-fixes@4319, containing these changesets from olau@iola.dk:
- [4319]: Only query for regular IETF meetings when calculating cut off dates
     (reported by Ryan Cross).

   - [4311]: Fix bug in liaison form that prevents Secretariat users from posting
     statements on behalf of SDO liaison managers in some cases.


   - [4310]: Fix problem with direct replyto path in liaison form not using role
     emails (reported by Stephanie McCammon).


   - [4307]: Fix missing return in liaison proxy, fixes problem with from email
     on https://datatracker.ietf.org/liaison/1154/ as reported by Stephanie
     McCammon.


   - [4260]: Move note about IANA scraping messages, apparently I managed to
     put it in the wrong place (they're of course scraping draft approvals, not
     the ballot announcements).


   - [4253]: Move last call announcement text to last call event rather than
     stuffing it inside the state change event.


   - [4252]: Declare coding system to work around annoying problem when the
     date produced by SVN is localized.
 - Legacy-Id: 4331
Note: SVN reference [4252] has been migrated to Git commit 5858454c74

Note: SVN reference [4253] has been migrated to Git commit 25cb532348

Note: SVN reference [4260] has been migrated to Git commit 7b2963aaf0

Note: SVN reference [4307] has been migrated to Git commit b418e5d141

Note: SVN reference [4310] has been migrated to Git commit 9b4415fe51

Note: SVN reference [4311] has been migrated to Git commit bbeaa2d022

Note: SVN reference [4319] has been migrated to Git commit 7db44f8e50
2012-04-26 19:34:57 +00:00
Ole Laursen 5cbfbba055 Port change from trunk before migration and use wrap_text rather than
fill to wrap the ballot comments/discusses.
 - Legacy-Id: 4321
2012-04-25 12:30:19 +00:00
Ole Laursen 441ca9fb9e Follow trunk before migration and don't fill the snippets on the
history page
 - Legacy-Id: 4320
2012-04-25 12:06:00 +00:00
Ole Laursen 7db44f8e50 Only query for regular IETF meetings when calculating cut off dates
(reported by Ryan Cross).
 - Legacy-Id: 4319
2012-04-25 11:00:40 +00:00
Ole Laursen d176d2b161 Copy charter text so we have an appriopriately named charter file when
renaming group acronyms.
 - Legacy-Id: 4315
2012-04-24 13:23:56 +00:00
Ole Laursen 6088bb4758 Fix problem with renamed group acronym.
- Legacy-Id: 4314
2012-04-24 12:55:13 +00:00
Ole Laursen ee5bd75ac6 Be more robust in validating group acronyms and display whole form on
creation (reported by Adrian Farrel), too.
 - Legacy-Id: 4313
2012-04-24 12:26:29 +00:00
Ole Laursen bbeaa2d022 Fix bug in liaison form that prevents Secretariat users from posting
statements on behalf of SDO liaison managers in some cases.
 - Legacy-Id: 4311
2012-04-23 20:18:23 +00:00
Ole Laursen 9b4415fe51 Fix problem with direct replyto path in liaison form not using role
emails (reported by Stephanie McCammon).
 - Legacy-Id: 4310
2012-04-23 20:14:04 +00:00
Ole Laursen b418e5d141 Fix missing "return" in liaison proxy, fixes problem with from email
on https://datatracker.ietf.org/liaison/1154/ as reported by Stephanie
McCammon.
 - Legacy-Id: 4307
2012-04-23 17:52:22 +00:00
Henrik Levkowetz 928e190cd1 Set version info and settings back to development mode
- Legacy-Id: 4306
2012-04-22 18:38:33 +00:00
Henrik Levkowetz 1da422bb91 Set version info to release version 4.01 before branching.
- Legacy-Id: 4304
2012-04-22 18:38:15 +00:00
Henrik Levkowetz 6c27541354 Added a FIXME: for the read_agenda_file() function. Some serious refactoring and generalization is needed here.
- Legacy-Id: 4302
2012-04-22 18:09:52 +00:00
Henrik Levkowetz 233aef46d5 Comment out NewIprTestCase as it writes to the production database.
- Legacy-Id: 4301
2012-04-22 16:33:44 +00:00
Henrik Levkowetz 7c46b9b61b Change the wgchairs.ManageWriteupTestCase to not expect the writeup page to be restricted. This adapts the test to the change made in [4218] to make writeups readable by all.
- Legacy-Id: 4300
Note: SVN reference [4218] has been migrated to Git commit 0e3de35834
2012-04-22 15:37:56 +00:00
Henrik Levkowetz dac11633ff Revert a URL schema change made by olau@iola.dk in [4046] for a reason I can't quite see. This change breaks old URLs.
- Legacy-Id: 4299
Note: SVN reference [4046] has been migrated to Git commit d6baa38fe5
2012-04-22 15:15:38 +00:00