altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
8311 commits 1 branch 0 tags 2.6 GiB
Commit graph

285 commits

Author SHA1 Message Date
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys 
- Legacy-Id: 10574
 2015-12-11 04:01:11 +00:00
Robert Sparks 66e89e7d29 improved creation of FeedbackLastSeen 
- Legacy-Id: 10572
 2015-12-10 23:07:57 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks d65987b935 Improve the questionnaire templates, reminding the nominee that receiving the questionnaire does not imply they have accepted the nomination. Fixes #1807. 
- Legacy-Id: 10534
 2015-12-02 17:01:10 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template 
- Legacy-Id: 10531
 2015-12-02 15:45:40 +00:00
Robert Sparks 2a63f91d31 Simplify pass of counts 
- Legacy-Id: 10527
 2015-12-02 04:44:42 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query 
- Legacy-Id: 10526
 2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges. 
- Legacy-Id: 10525
 2015-12-02 03:32:06 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809. 
- Legacy-Id: 10524
 2015-11-29 21:12:19 +00:00
Robert Sparks 473970a767 Missed an svn add 
- Legacy-Id: 10523
 2015-11-29 04:16:07 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771. 
- Legacy-Id: 10522
 2015-11-29 04:00:02 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795. 
- Legacy-Id: 10505
 2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Henrik Levkowetz 97f7159a48 Migration for the nomcom 'public_key' field change to a settings-agnostic FileStorage. 
- Legacy-Id: 10301
 2015-10-27 15:34:43 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems 
- Legacy-Id: 10298
 2015-10-27 10:37:06 +00:00
Henrik Levkowetz 4eaadddf9e Changed nomcom.models.Nomcom() to use a FileSystemStorage which doesn't record the file system location in the migration, in order to avoid having model changes detected when switching from one development path to another. 
- Legacy-Id: 10280
 2015-10-24 20:13:18 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead. 
- Legacy-Id: 10228
 2015-10-18 11:49:15 +00:00
Ole Laursen 73a41bb7e6 Summary: Fix problem with three NomCom tests that had a hard-coded id, 
which doesn't necessarily work with the way transactions work in MySQL
 - Legacy-Id: 10190
 2015-10-12 15:03:00 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward. 
- Legacy-Id: 10157
 2015-10-09 03:16:24 +00:00
Henrik Levkowetz e1cc8218e7 Merged in [10115] from rjsparks@nostrum.com: 
Remove an extraneous field from the form that lets the nomcom chair paste in a questionnaire response.
 - Legacy-Id: 10118
Note: SVN reference [10115] has been migrated to Git commit 3ee236d3ee25dffdd3516b0740251705c4db248c
 2015-10-01 20:44:47 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow 
- Legacy-Id: 10040
 2015-08-23 18:15:06 +00:00
Henrik Levkowetz cb75c7d908 Added a migration for the Nomination.share_nominator field. 
- Legacy-Id: 10039
 2015-08-23 09:15:20 +00:00
Henrik Levkowetz f6c78bcecb Merged in [10004] from rjsparks@nostrum.com: 
Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703.
 - Legacy-Id: 10037
Note: SVN reference [10004] has been migrated to Git commit 1517efaba2
 2015-08-22 18:00:16 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing. 
- Legacy-Id: 10035
 2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc 
- Legacy-Id: 10034
 2015-08-20 04:23:40 +00:00
Robert Sparks 65be4190a7 Done with the first pass instrumenting all mail points. There is one spot in the ipr code that's complicated and will require some refactor before instrumenting. There are a few places to add explicit messages (templates and all) to replace the simple use of email_ad. The next pass will be to make sure every spot that sends mail is covered by a test, and that the tests look at the headers sensibly. That will be followed by a moderately heavy refactor of MailToken and the gather_address utilities. Then pages showing the expansions of a token for a given document/group. Long way to go, but this is working well, and I think it will make things much easier later. 
- Legacy-Id: 10030
 2015-08-19 21:53:02 +00:00
Henrik Levkowetz 0449ebcdfa Merged in [10002] from rjsparks@nostrum.com: 
Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee.
 - Legacy-Id: 10023
Note: SVN reference [10002] has been migrated to Git commit bcc14cb0d1
 2015-08-18 15:39:12 +00:00
Robert Sparks 1517efaba2 Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703. Commit ready for merge. 
- Legacy-Id: 10004
 2015-08-10 18:28:08 +00:00
Robert Sparks bcc14cb0d1 Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee. Commit ready for merge. 
- Legacy-Id: 10002
 2015-08-10 17:57:38 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually. 
- Legacy-Id: 9991
 2015-08-09 16:28:55 +00:00
Henrik Levkowetz 8905ac1789 If the author of a nomcom nomination is unknown, use 'Anonymous' and no email address in outgoing messages, instead of ''. 
- Legacy-Id: 9627
 2015-05-13 16:55:53 +00:00
Henrik Levkowetz db255a86ac Don't show the unused 'author' field in the public nomcom feedback form. Fixes issue #1699. 
- Legacy-Id: 9617
 2015-05-11 21:03:25 +00:00
Henrik Levkowetz 869363e0b0 Fixed a problem with nomcom classification forms showing too many fields. 
- Legacy-Id: 9611
 2015-05-11 19:13:52 +00:00
Henrik Levkowetz 4966e17158 Added 5 migrations for changes in model field help-text strings which changed in the facelift. Also fixed the expression of the help text for NomCom.reminder_interval so the text itself doesn't contain quite as much whitespace. 
- Legacy-Id: 9589
 2015-04-30 16:18:25 +00:00
Henrik Levkowetz 85f9eee27b Updated a set of nomcom tests to account for new facelift DOM attributes. 
- Legacy-Id: 9361
 2015-04-02 19:49:11 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy 
- Legacy-Id: 9357
 2015-04-02 06:51:34 +00:00
Joel M. Halpern 8cab64c2fe added some nomcom test cases. Commit ready for merge. 
- Legacy-Id: 9317
 2015-03-21 22:37:43 +00:00
Henrik Levkowetz 6044944b00 Removed a cut-and-paste error. 
- Legacy-Id: 9249
 2015-03-19 17:54:06 +00:00
Henrik Levkowetz ddbb8c18a5 Updated the nomcom tests to use temporary test directories for data, instead of the regular values in settings.py 
- Legacy-Id: 9248
 2015-03-19 17:52:31 +00:00
Henrik Levkowetz 45761e5c7f Changed the nomcom.forms.FullFeedbackFormSet to use modelformsets_factory() instead of direct subclassing, in order to avoid a crash when using the form, caused by a missing instance attribute. 
- Legacy-Id: 9154
 2015-03-06 18:16:33 +00:00
Henrik Levkowetz 9209be4656 Added back a functioning get_fieldsets() method, which was removed instead of corrected in the Django 1.7 upgrade. 
- Legacy-Id: 9084
 2015-02-13 12:03:32 +00:00
Henrik Levkowetz 071dfc6f8e Cleanup after Django 1.7 migration 
- Legacy-Id: 9082
 2015-02-12 16:38:01 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts 
- Legacy-Id: 9072
 2015-02-12 10:43:52 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9028
 2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir). 
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
 2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x. 
- Legacy-Id: 9026
 2015-02-08 19:16:46 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it 
- Legacy-Id: 8940
 2015-01-28 13:25:21 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut. 
- Legacy-Id: 8896
 2015-01-22 17:38:05 +00:00
Henrik Levkowetz 0db48f3db0 Merged in [8840] from rjsparks@nostrum.com:\n Automatically ensure Alias records exists when Person records are changed, relieving multiple code locations of that responsibility. Fixes bug #1550. 
- Legacy-Id: 8873
Note: SVN reference [8840] has been migrated to Git commit b0b3a31b10bb35eb00d29f27d75d21c3cc4edc4e
 2015-01-20 22:32:01 +00:00
Henrik Levkowetz ee2892ecf4 Bugfix: don't assign FK to Email to an EmailField (which expects just an email string). 
- Legacy-Id: 8831
 2014-12-22 17:57:31 +00:00
Henrik Levkowetz f4ce5e033c Fix django 1.7 incompatibilities: Remove get_fieldsets() methods which don't work any more because of Django's move from using its own SortedDict to python's OrderedDict (which always is available in python 2.7 and later). The get_fieldsets() method on Form wasn't available in early versions of django, but since it's provided now, we don't need own code for this method. 
- Legacy-Id: 8830
 2014-12-22 17:54:32 +00:00
Henrik Levkowetz b5dad67b05 Fix django 1.7 deprecation warnings: get_query_set() --> get_queryset(). 
- Legacy-Id: 8827
 2014-12-22 17:38:49 +00:00
Henrik Levkowetz 25eb00c925 New django-1.7 initial migrations. Circular references exist, requiring explicit --fake migration for doc, dbtemplate and community apps. 
- Legacy-Id: 8823
 2014-12-22 17:07:38 +00:00
Henrik Levkowetz dd15785936 Removing south migrations as part of the django 1.7 changeover to builtin migrations. 
- Legacy-Id: 8820
 2014-12-22 16:44:35 +00:00
Henrik Levkowetz 770b36d575 Added generated (and sometimes manually tweaked) resources.py files. 
- Legacy-Id: 8744
 2014-12-14 20:33:25 +00:00
Ole Laursen a3399b0bcd Summary: Port remaining parts of nomcom to bootstrap, fix some bugs, 
let the private/public feedback pages share the same template, remove
the edit NomCom chair thing - there's no link to it and the
Secretariat can instead use the ordinary group management tool they
have available
 - Legacy-Id: 8721
 2014-12-02 10:43:20 +00:00
Ole Laursen cebc979282 Summary: Resolve person/email/document multiselect issue by importing 
select2 and switching the widgets over to using that. Port the
milestones editing page to Bootstrap.
 - Legacy-Id: 8713
 2014-11-25 16:47:48 +00:00
Ole Laursen 87870ca954 Fix more test errors - now only two not yet fully ported views remain 
- Legacy-Id: 8571
 2014-11-03 16:39:41 +00:00
Ole Laursen 41cb195f52 Rebase /personal/lars/5.6.4-facelift/ on trunk 
- Legacy-Id: 8520
 2014-10-30 14:31:07 +00:00
Henrik Levkowetz 704589b4c7 Merged in branch/iola/people-cleanup @ [8471] from olau@iola.dk, which 
enhances a number of pages in the datatracker where forms contain fields
  where a person should be chosen, such as for instance when choosing the
  shepherd of a document, so that they uniformly display choices which show
  both email address and name.

  Furthermore, changes have been made so as to make the email address
  uniformly act as reference to the person record.  

  Autocompletion is now consistently provided when looking for the email
  address or name of the person to choose.  

  This solves a number of issues where it has been difficult to choose the
  correct Person/Email combination, and where the correct email address to use
  for an association has been unavailable previously.
 - Legacy-Id: 8472
Note: SVN reference [8471] has been migrated to Git commit d62f2343e8
 2014-10-25 21:05:50 +00:00
Henrik Levkowetz 0d61e270d6 Normalized a couple of NameModels subclasses. 
- Legacy-Id: 8460
 2014-10-23 21:14:41 +00:00
Henrik Levkowetz 28b31061b4 Normalized the naming of a couple of NameModel subclasses. 
- Legacy-Id: 8458
 2014-10-23 19:54:24 +00:00
Lars Eggert a4daf2630c Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift 
Conflicts:
	ietf/doc/templatetags/ietf_filters.py
	ietf/doc/views_charter.py
	ietf/templates/doc/charter/edit_notify.html
	ietf/templates/doc/charter/edit_telechat_date.html
	ietf/templates/doc/document_ballot_content.html
	ietf/templates/doc/document_history.html
	ietf/templates/doc/edit_notify.html
	ietf/templates/doc/edit_telechat_date.html
	ietf/templates/doc/notify.html
	ietf/templates/group/concluded_groups.html
 - Legacy-Id: 8429
 2014-10-14 11:48:57 +00:00
Henrik Levkowetz 3f130f393d Merged in [8359] from rcross@amsl.com:\n fix get_or_create_nominee() to create Alias for new Person. 
- Legacy-Id: 8392
Note: SVN reference [8359] has been migrated to Git commit c71d1d1ef6
 2014-10-12 19:23:06 +00:00
Henrik Levkowetz 25423f6779 Added some formset attributes which are needed by the current Django (1.6) code. A better way would maybe be to use formset_factory(), but a simple invocation of that gives other problems. Leaving as is for now, to get a patch out so the nomcom chair can get on with things. 
- Legacy-Id: 8370
 2014-09-29 21:16:55 +00:00
Ryan Cross c71d1d1ef6 fix get_or_create_nominee() to create Alias for new Person. commit ready for merge. 
- Legacy-Id: 8359
 2014-09-26 22:19:22 +00:00
Ole Laursen 065660b66f Replace the gigantic incumbent email drop-down in the NomCom tool with an 
AutocompletedEmailField, also show the name of the incumbents and not
just their email addresses on the list page
 - Legacy-Id: 8281
 2014-08-18 11:52:08 +00:00
Ole Laursen f7ac066059 Integrate Secretariat tools MultiEmailField with the one in 
utils/fields.py, also fix a couple of issues in NomCom tool (spelling
bugs and avoid overwriting base_fields on forms with dynamic data)
 - Legacy-Id: 8276
 2014-08-17 14:39:23 +00:00
Henrik Levkowetz 09f654b1f4 Merged in branch/iola/team-support from olau@iola.dk. This generalises and extends the group support for WGs and RGs so that also other groups, such as for instance the Edu Team, can have pages. 
- Legacy-Id: 8013
 2014-07-02 19:30:07 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk. 
- Legacy-Id: 7579
 2014-04-06 20:04:36 +00:00
Henrik Levkowetz 563f584a9e Made ietf/nomcom pyflakes-clean. Removed some dead code. 
- Legacy-Id: 7476
 2014-03-15 19:26:01 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean. 
- Legacy-Id: 7462
 2014-03-15 16:09:47 +00:00
Ole Laursen ab382a726f While cleaning up the Javascript includes in the nomcom app, it turns 
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
 - Legacy-Id: 7097
 2014-01-10 14:06:36 +00:00
Ole Laursen f685e45ca5 Add select_related to PositionNomineeField in nomcom app to save a 
bunch of database queries
 - Legacy-Id: 7095
 2014-01-10 13:13:03 +00:00
Ole Laursen fdb6baf4e6 Use collections.OrderedDict instead of the SortedDict bundled with Django 
- Legacy-Id: 7026
 2013-12-20 11:00:07 +00:00
Ole Laursen 1dc860236f Delete ADMIN_MEDIA_PREFIX which is now gone in Django, add a pattern to the static serving so a debug/test server serves the admin static files 
- Legacy-Id: 6975
 2013-12-18 11:45:36 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead 
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
 2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated) 
- Legacy-Id: 6945
 2013-12-16 16:53:47 +00:00
Ole Laursen 3febf7d216 Fix odd boolean calculation in nomcom view 
- Legacy-Id: 6923
 2013-12-13 16:48:37 +00:00
Ole Laursen 892c7d43ce Reuse already fetched page instead of refetching it in nomcom test 
- Legacy-Id: 6922
 2013-12-13 16:47:57 +00:00
Ole Laursen b302ffa814 Fix bug in nomcom test, it was sending a formset without the 
corresponding management form values
 - Legacy-Id: 6921
 2013-12-13 16:45:04 +00:00
Ole Laursen aea222edbc Speed up nomcom tests a bit more by also only generating one certificate for the client per run 
- Legacy-Id: 6920
 2013-12-13 16:28:55 +00:00
Ole Laursen 466928edc2 Only generate the test NomCom certificate once instead to speed up the 
Nomcom tests a bit
 - Legacy-Id: 6919
 2013-12-13 16:10:49 +00:00
Ole Laursen 652a5ca17a Rewrite NomCom test data generation slightly based on the rewritten 
base test data, fix problem with form previews
 - Legacy-Id: 6918
 2013-12-13 15:59:52 +00:00
Ole Laursen 81e5ced4ee Remove "nominee" from FeedbackForm.Meta.fields, it doesn't exist in Feedback 
- Legacy-Id: 6916
 2013-12-13 15:48:13 +00:00
Ole Laursen a2c13b70d1 Make sure all BooleanFields have an explicit default value (with 
Django < 1.6 it used to be False implicitly)
 - Legacy-Id: 6908
 2013-12-13 13:30:07 +00:00
Ole Laursen e32d346bc5 Fix security_hash problem in nomcom tests, it's no longer a separate function 
- Legacy-Id: 6905
 2013-12-13 13:10:52 +00:00
Ole Laursen 771591f0db Remove use of obsolete generic delete view 
- Legacy-Id: 6891
 2013-12-12 12:06:09 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django 
- Legacy-Id: 6883
 2013-12-11 16:59:19 +00:00
Ole Laursen 2c930d0f97 Get rid of remaining use of email_re, use validate_email instead 
- Legacy-Id: 6882
 2013-12-11 16:47:47 +00:00
Ole Laursen 883853f09c Fix bug, TemplateView takes template_name, not template as parameter 
- Legacy-Id: 6880
 2013-12-11 16:43:34 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django 
- Legacy-Id: 6878
 2013-12-11 16:36:09 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate 
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
 2013-12-05 16:24:03 +00:00
Ole Laursen d0f2859631 Move NomCom announcements view to nomcom/, move message view to 
message/, add tests, add redirects, fix a couple of small bugs in the
announcements view
 - Legacy-Id: 6769
 2013-11-28 17:55:10 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch 
- Legacy-Id: 6764
 2013-11-27 12:55:50 +00:00