Commit graph

609 commits

Author SHA1 Message Date
Robert Sparks 18b8a795ad Show diff controls for a bis -00 document. Fixes #2846. Commit ready for merge.
- Legacy-Id: 17147
2019-12-12 17:17:51 +00:00
Henrik Levkowetz 2bc5606986 Merged in [17070] from sasha@dashcare.nl:
Fix #2061 - Improve 'complete review' workflow for secretaries.
When a secretary completes a review, 'link to a review message'
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where 'link to review message' is used, by reviewers or
secretaries, now attempt to fill in the 'reviewed version' if found
in the email subject.
 - Legacy-Id: 17105
Note: SVN reference [17070] has been migrated to Git commit dc9546211f
2019-11-26 20:22:56 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl:
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Sasha Romijn dc9546211f Fix #2061 - Improve "complete review" workflow for secretaries.
When a secretary completes a review, "link to a review message"
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.

All cases where "link to review message" is used, by reviewers or
secretaries, now attempt to fill in the "reviewed version" if found
in the email subject.

Commit ready for merge.
 - Legacy-Id: 17070
2019-11-20 14:25:05 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz 96bbc96ee1 Merged in [16966] from rjsparks@nostrum.com:
Use the recently released shepherd writeup templates. Fixes #2820. ,
 - Legacy-Id: 16991
Note: SVN reference [16966] has been migrated to Git commit fa00beab0e
2019-11-11 16:35:08 +00:00
Henrik Levkowetz 20eb9d8ac1 Merged in [16939] from sasha@dashcare.nl:
Fix #2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.

For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
 - Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
2019-11-11 14:22:54 +00:00
Robert Sparks fa00beab0e Use the recently released shepherd writeup templates. Fixes #2820. Commit ready for merge,
- Legacy-Id: 16966
2019-11-05 21:11:10 +00:00
Henrik Levkowetz c233f07b5d Added a management command to generate draft bibxml files, and also a trial version of datatracker draft bibxml pages.
- Legacy-Id: 16962
2019-11-05 18:10:29 +00:00
Sasha Romijn 6e55f26dbd Fix #2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.

For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.

Commit ready for merge.
 - Legacy-Id: 16939
2019-10-29 16:27:56 +00:00
Henrik Levkowetz c606461b22 Merged in [16924] from sasha@dashcare.nl:
Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
  appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
  through an intermediate page to select for which team they are
  submitting their review.
- The form is similar (and using the same code) as the usual review
  completion, with a few extra fields for the review type and reviewer,
  which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
  automatically created. The assignment is then immediately closed in
  the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
 - Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
2019-10-26 21:16:53 +00:00
Henrik Levkowetz 00fb8d4b43 Merged in [16923] from sasha@dashcare.nl:
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
 - Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
2019-10-26 20:26:21 +00:00
Sasha Romijn 871a4b653b Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button "Submit unsolicited review" will now
  appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
  through an intermediate page to select for which team they are
  submitting their review.
- The form is similar (and using the same code) as the usual review
  completion, with a few extra fields for the review type and reviewer,
  which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
  automatically created. The assignment is then immediately closed in
  the usual way.
- Other workflows are unchanged.

The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.

Commit ready for merge.
 - Legacy-Id: 16924
2019-10-24 12:37:59 +00:00
Sasha Romijn 93797b3fc1 Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
Commit ready for merge.
 - Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Henrik Levkowetz 3e9bad1c8b Merged in [16883] from sasha@dashcare.nl:
Fix #2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
 - Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
2019-10-22 20:59:13 +00:00
Henrik Levkowetz 6688d37bb4 Merged in [16875] from rjsparks@nostrum.com:
Adds docs with blocking positions to the ADs my-documents page. Fixes #2800.
 - Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
2019-10-22 17:43:54 +00:00
Sasha Romijn 3c2b01b3ff Fix #2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.

Commit ready for merge.
 - Legacy-Id: 16883
2019-10-21 14:15:08 +00:00
Henrik Levkowetz 496eb50253 Merged in [16824] from rjsparks@nostrum.com:
Use last-call@ietf.org.
 - Legacy-Id: 16882
Note: SVN reference [16824] has been migrated to Git commit 039d62370dd27764a54c62c7d70959d43f36e880
2019-10-21 14:08:11 +00:00
Henrik Levkowetz 5460a5ab84 Merged in [16785] from rjsparks@nostrum.com:
Improve alerts when looking at non-current versions of a charter document. Fixes #2774.
 - Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
2019-10-08 14:24:01 +00:00
Henrik Levkowetz 8c71252fee Merged in [16688] from sasha@dashcare.nl:
Fix #2478 - When completing review, show which addresses it is posted to.
 - Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
2019-10-01 15:02:03 +00:00
Henrik Levkowetz 3336f4a11b Merged in [16656] from rjsparks@nostrum.com:
Add IANA expert review tracking.
 - Legacy-Id: 16716
Note: SVN reference [16656] has been migrated to Git commit e45a32e49f
2019-09-08 14:34:29 +00:00
Henrik Levkowetz 46fbcfbc01 Merged in [16631] from rjsparks@nostrum.com:
Converted tabs to spaces. Whitespace changes only.
 - Legacy-Id: 16700
Note: SVN reference [16631] has been migrated to Git commit 19a9ce9a95
2019-09-03 19:42:01 +00:00
Henrik Levkowetz f26020631e Merged in [16614] from peter@akayla.com:
Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions.  Fixes issue #2697.
 - Legacy-Id: 16693
Note: SVN reference [16614] has been migrated to Git commit 390ff04722
2019-09-03 12:28:45 +00:00
Sasha Romijn 68ea11a916 Fix #2478 - When completing review, show which addresses it is posted to.
Commit ready for merge.
 - Legacy-Id: 16688
2019-09-02 15:52:26 +00:00
Henrik Levkowetz 7ad34ba69e The logic for displaying 'Email requested to be sent for earlier discuss' on IESG positions was wrong; it would count later discusses and discusses from other ADs as an 'earlier discuss'. Moved any_email_sent() from ballot to position, and refined the criteria.
- Legacy-Id: 16675
2019-08-28 20:56:34 +00:00
Robert Sparks e45a32e49f Add IANA expert review tracking. Commit ready for merge.
- Legacy-Id: 16656
2019-08-15 20:36:07 +00:00
Robert Sparks 19a9ce9a95 Converted tabs to spaces. Whitespace changes only. Commit ready for merge.
- Legacy-Id: 16631
2019-08-07 20:27:57 +00:00
Peter E. Yee 390ff04722 Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions. Fixes issue #2697. Commit ready for merge.
- Legacy-Id: 16614
2019-08-04 23:55:15 +00:00
Henrik Levkowetz baa639ba01 Merged in [16569] from rjsparks@nostrum.com:
Add quotes around document name in the mailarchive search link on a document's main page. Fixes #2659.
 - Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
2019-07-31 22:04:16 +00:00
Henrik Levkowetz a1e7dc9acc Changed a function name.
- Legacy-Id: 16386
2019-07-04 16:10:21 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz b5ad7dbf49 Updated references of RFC 5226 to RFC 8126, which obsoletes it. Fixes issue #2726.
- Legacy-Id: 16235
2019-06-07 12:30:21 +00:00
Henrik Levkowetz 9099c1e1c1 Tweaked the review assignment presentation in review/request_info.html.
- Legacy-Id: 16204
2019-05-08 13:20:23 +00:00
Henrik Levkowetz 1b5cdfe2f5 Added review assignment information to the review-document view. Addresses issue #2717.
- Legacy-Id: 16203
2019-05-07 21:53:38 +00:00
Henrik Levkowetz 40f4ca4ae7 Modified a template to handle old reviews with incomplete information appropriately, instead of leading to 500 errors.
- Legacy-Id: 16186
2019-05-03 22:00:43 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz c0f41f71b4 Added back a file lost by mistake.
- Legacy-Id: 16159
2019-04-25 13:15:00 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com:
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
2019-04-08 17:02:02 +00:00
Henrik Levkowetz 5aad3a652d Merged in [16110] from rjsparks@nostrum.com:
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672.
 - Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
2019-04-03 19:30:10 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16126
2019-04-01 19:46:14 +00:00
Henrik Levkowetz 23d28bc0c3 Merged in [16095] from peter@akayla.com:
Fixed bad calls to rfcdiff for -00 drafts and replaced drafts.  Fixes issue #2697.
 - Legacy-Id: 16117
Note: SVN reference [16095] has been migrated to Git commit cfdbae1f3c
2019-03-28 12:04:54 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge.
- Legacy-Id: 16110
2019-03-28 10:07:11 +00:00
Peter E. Yee cfdbae1f3c Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697. Commit ready for merge.
- Legacy-Id: 16095
2019-03-23 18:17:51 +00:00
Jean Mahoney 37a7203849 added instructions for entering the draft name. Fixes #1375. Commit ready to merge.
- Legacy-Id: 16089
2019-03-23 16:10:46 +00:00
Robert Sparks 1e7238b71b Templates missing from last commit
- Legacy-Id: 16040
2019-03-18 21:16:22 +00:00
Robert Sparks f57fb6b8a6 Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response.
- Legacy-Id: 16039
2019-03-18 21:15:20 +00:00
Robert Sparks da3174ab68 Improved several views.
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00