Commit graph

48 commits

Author SHA1 Message Date
Jennifer Richards 17d37723f7 Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Jennifer Richards 233bff8196 Improve handling of submissions for closed working groups. Fixes #3058. Commit ready for merge.
- Legacy-Id: 18798
2021-01-18 14:55:25 +00:00
Henrik Levkowetz 93e07f8650 Changed deprecated 'load staticfiles' to recommended 'load static'
- Legacy-Id: 18080
2020-06-27 13:51:19 +00:00
Henrik Levkowetz 78889979a1 Changed the draft submission form and views so that an email address is required for each author in order to complete self-service draft submission. It is possible to add these as metadata updates, but this will lead to submission through the secretariat (and the email addresses will still be required). Also updated related templates to make the handling of form section headings more consistent.
- Legacy-Id: 16745
2019-09-23 17:26:16 +00:00
Henrik Levkowetz 2c72d33b84 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
- Legacy-Id: 16736
2019-09-20 11:31:09 +00:00
Henrik Levkowetz 44f42cdb3a Undid the previous commit
- Legacy-Id: 16735
2019-09-20 11:30:04 +00:00
Henrik Levkowetz e3e9f676b7 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
- Legacy-Id: 16734
2019-09-20 11:28:53 +00:00
Henrik Levkowetz 92590b70bf Updated contact address and text for submission problems to streamline secretariat handling.
- Legacy-Id: 16639
2019-08-09 21:58:40 +00:00
Adam Roach 8a8f358ae8 Commit ready for merge: excessive author warning
- Legacy-Id: 14575
2018-01-26 20:58:37 +00:00
Henrik Levkowetz 207ea51723 Added a test case for invalid yang in a draft submission.
- Legacy-Id: 13633
2017-06-15 19:22:36 +00:00
Henrik Levkowetz d98054c103 Added a new yang checker, 'yanglint', to the existing Yang checker class, in
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13630
2017-06-15 16:09:28 +00:00
Ole Laursen d5e98c9644 Add mail to link to Secretariat on country page in case people are
missing a country or alias, adjust wording a bit on status page.
 - Legacy-Id: 12866
2017-02-17 10:21:34 +00:00
Ole Laursen 9d8874d8b1 Add a suggestion to fix the country name when submitting a draft in
case we can't parse it and it's not empty, add page with list of
countries (to be able to refer people to it), add ISO codes as country
aliases - the country alias code is now more intelligent with respect
to case so it's easier to keep these aliases explicitly
 - Legacy-Id: 12862
2017-02-16 17:56:23 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Ole Laursen 90051a1575 Add support for displaying and editing author affiliation and country
when submitting a draft, replace the Submission.authors line-based
text field with a JSON field
 - Legacy-Id: 12745
2017-01-27 16:10:31 +00:00
Ole Laursen 0479600ed0 Simple wording fix
- Legacy-Id: 12663
2017-01-17 13:53:13 +00:00
Ole Laursen 76bcab6efc Show formal languages used on new submissions and make the field
editable, also add it to the test with a simple JSON example
 - Legacy-Id: 12662
2017-01-17 13:52:16 +00:00
Ole Laursen f4555c4269 Fix another spacing bug on the submit page
- Legacy-Id: 12661
2017-01-17 13:50:41 +00:00
Ole Laursen b3d75af1af Fix a spacing bug in the submission HTML
- Legacy-Id: 12659
2017-01-16 17:34:46 +00:00
Henrik Levkowetz b3740bcfca Removed instances of 'load future' from templates that don't need it any more.
- Legacy-Id: 12530
2016-12-15 13:14:16 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Henrik Levkowetz 47d6bbbea3 Renamed the SubmissionEmail event class to SubmissionEmailEvent, and added an admin class for it.
- Legacy-Id: 11942
2016-09-08 15:04:53 +00:00
Henrik Levkowetz 7a8c067d83 Changed a state name, and renamed some view functions for easier code reading. Removed extra name= parameters from the submit/ urlpatterns.
- Legacy-Id: 11917
2016-09-01 09:14:34 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Henrik Levkowetz 7d7bcbef04 In the internet-draft submission status page, point at the datatracker page for the document, rather than the repository copy of the document.
- Legacy-Id: 11511
2016-07-01 20:51:44 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check.
- Legacy-Id: 10894
2016-03-04 20:08:29 +00:00
Henrik Levkowetz 11411d2c30 Merged in an update from trunk@9942.
- Legacy-Id: 9961
2015-08-03 14:12:38 +00:00
Henrik Levkowetz 9cb8f65c8e Updated templates to use the static template tag for static files.
- Legacy-Id: 9945
2015-08-01 14:53:59 +00:00
Henrik Levkowetz fb79c8a22c Updated the meta-data error message to say 'errors ... below' instead of 'errors ... above', to match the relative placement of text and error indications.
- Legacy-Id: 9921
2015-07-30 18:22:28 +00:00
Henrik Levkowetz 54aac4e12a Updated templates to use the 'static' template tag to dynamically point to the correct static files location.
- Legacy-Id: 9889
2015-07-26 18:15:24 +00:00
Henrik Levkowetz 953d639ae3 Merged in Ole's submit-time draft replacement information work, as tested and updated by Robert and Adam.
- Legacy-Id: 9829
2015-07-20 14:53:20 +00:00
Henrik Levkowetz 942352c50b Merged in [9766] from lars@netapp.com:
More HTML fixes.
 - Legacy-Id: 9787
Note: SVN reference [9766] has been migrated to Git commit 77f555bdbdfa653e4b5a0589ead9eda6632f10d7
2015-07-18 12:42:38 +00:00
Robert Sparks 02a9da52a1 Manually moved the concepts forward. Reworked some presentation. Working enough to bring testers in at Sprint93
- Legacy-Id: 9717
2015-07-13 21:09:39 +00:00
Henrik Levkowetz 0d08fff0ac Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9555
2015-04-24 21:45:04 +00:00
Henrik Levkowetz ec0321e0da Added copyright lines and template origin to the html templates. Fixed a number of instances of html that didn't validate.
- Legacy-Id: 9551
2015-04-24 20:40:01 +00:00
Ole Laursen a589115ff4 Summary: Reindent all HTML files to follow the previous convention (no
tabs) and kill the scripts block in favour of just using a js block with
a script tag (which is easier to understand for context-sensitive
modes such as web-mode in Emacs). Also fix a couple of details, e.g.
missing semicolons in JS snippets.
 - Legacy-Id: 9096
2015-02-17 18:01:04 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts
- Legacy-Id: 9072
2015-02-12 10:43:52 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9028
2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir).
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
2015-02-08 20:03:16 +00:00
Henrik Levkowetz 971a631ea3 Fix django 1.7 deprecation warnings: quote arguments to the 'cycle' template tag.
- Legacy-Id: 8826
2014-12-22 17:36:09 +00:00
Ole Laursen 87870ca954 Fix more test errors - now only two not yet fully ported views remain
- Legacy-Id: 8571
2014-11-03 16:39:41 +00:00
Lars Eggert a4daf2630c Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift
Conflicts:
	ietf/doc/templatetags/ietf_filters.py
	ietf/doc/views_charter.py
	ietf/templates/doc/charter/edit_notify.html
	ietf/templates/doc/charter/edit_telechat_date.html
	ietf/templates/doc/document_ballot_content.html
	ietf/templates/doc/document_history.html
	ietf/templates/doc/edit_notify.html
	ietf/templates/doc/edit_telechat_date.html
	ietf/templates/doc/notify.html
	ietf/templates/group/concluded_groups.html
 - Legacy-Id: 8429
2014-10-14 11:48:57 +00:00
Henrik Levkowetz 1c6c3835e8 Typo fixes.
- Legacy-Id: 7254
2014-02-17 12:42:43 +00:00
Ole Laursen 5200a8170b Commit patch from r7172 to make the check for whether a draft
submitter is also one of the authors of the draft more robust on
djangoport branch too so it doesn't get lost in the noise
 - Legacy-Id: 7173
2014-01-28 11:23:52 +00:00
Ole Laursen 42ade6273c Turn on CSRF protection - all forms must from now on have a {% csrf_token %}
- Legacy-Id: 6963
2013-12-17 12:50:24 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00