Commit graph

104 commits

Author SHA1 Message Date
Ole Laursen 019ca2ae03 Merge changes from attic/shimfree into new branch to complete rebasing shimfree on trunk
- Legacy-Id: 6215
2013-09-20 09:48:58 +00:00
Ole Laursen 3562c5ef06 Rewrite slightly to avoid using wgchairs.accounts.get_person_for_user
- Legacy-Id: 6194
2013-09-19 11:02:24 +00:00
Ole Laursen f4761ba7c1 Get rid of unused wgchairs references
- Legacy-Id: 6193
2013-09-19 11:01:32 +00:00
Henrik Levkowetz 19b7bc1d60 Fixed an issue when trying to edit a document state when there's no prior state, and removed the link to edit the document state when there's no set state.
- Legacy-Id: 6132
2013-09-10 15:46:46 +00:00
Henrik Levkowetz 9dc13aa8f2 Merged in personal/rjs/r6117-pubreq:
- Made Publication Request (for documents from IETF working groups) an
  explicit action rather than a side-effect.

- Simplified the working group state edit form.

- Added hints to the WG state edit form to use the document's main page to
  request publication.

- If a document is moved into IESG processing directly by the secretariat or
  an AD (old processing path), set working group state accordingly.
 - Legacy-Id: 6120
2013-09-09 19:29:56 +00:00
Robert Sparks 63139ab860 Made Publication Request (for documents from IETF working groups) an explicit action rather than a side-effect.
Simplified the working group state edit form.
Added hints to the WG state edit form to use the document's main page to request publication.
If a document is moved into IESG processing directly by the secretariat or an AD (old processing path), set working group state accordingly.
 - Legacy-Id: 6119
2013-09-09 18:25:44 +00:00
Henrik Levkowetz 17eb95c180 Tweaked code to correct access to document metadata and actions, adding RGs to the groups and group secretaries to the roles which are given access.
- Legacy-Id: 5939
2013-08-01 14:37:50 +00:00
Suresh Krishnan 60bab5fe50 When working group chairs added an annotation to a document, the date on the history entry was wrong. It has now been fixed.
- Legacy-Id: 5899
2013-07-27 12:51:10 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 45cd8788d1 Added the secretariat to the recipient list for publication request emails generated by the datatracker. Fixes issue #964.
- Legacy-Id: 5698
2013-05-06 16:34:37 +00:00
Henrik Levkowetz becd10a81d Merged [5570] from rjsparks@nostrum.com:
Moves the interface to edit shepherds and sheperd writeups out of the 
wgtracker interface and into the doc views (via idrfc).
Added a little to the simple authorization code (can_edit_) in idrfc.
Added a way to reset the writeup to the current templates (leaving 
extension points to take templates for non-ietf stream documents).
Fixes bug #967.

Implementation notes:
Currently reused EmailsField -- in the long 
run a better approach will be to build a similar PersonField.

This also fixes tickets #834 and #691 (which were effectively duplicates 
of #967)
 - Legacy-Id: 5631
Note: SVN reference [5570] has been migrated to Git commit 3bc9e9a7add65bf135d669381cb5d93c5a2e3e19
2013-04-07 20:40:15 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Ole Laursen aa70cffe73 Rewrite draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
 - Legacy-Id: 5214
2013-01-16 14:57:01 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz e896ead272 Merged [5001] from jmh@joelhalpern.com:
Make comments optional on WG adoption and WG state changes.
 - Legacy-Id: 5016
Note: SVN reference [5001] has been migrated to Git commit 1057dbf631c22669cf35d0d52769945b9836f516
2012-11-07 13:04:05 +00:00
Ole Laursen 6062e16c2d Email IANA and RFC Editor when a draft is pulled from the queue at the
Datatracker, add page for editing IANA states, add more info to the
/doc/draft-XXXXX/doc.json dump for the RFC Editor, add page for
editing consensus, add page for requesting publication at the RFC
Editor for alternate streams (this will email the RFC Editor and set
the draft in the appropriate state), make it possible for alternate
streams to change the intended RFC status of a draft in the stream,
refactor how IANA copies are handled slightly so it's less code, put
drafts automatically in IANA Review "Need Review" state upon last
call, fix a bug in ballot issuing, remove a bit of dead code
 - Legacy-Id: 4857
2012-09-17 16:15:45 +00:00
Suresh Krishnan fd3a74fa1f When the state changes from whatever to Publication Requested, the regular state change mail will go out.
The regular state change mail will be sent to the authors and the wg chairs (this is the current behavior).

Now, in addition to this regular state change mail, another mail will be sent with the title "Publication has been requested for draft <draft-name>" and this mail will be sent to the AD responsible for the WG. I considered sending the mail to both the ADs but decided not to bother the other AD :-).
 - Legacy-Id: 4704
2012-07-28 21:17:00 +00:00
Ole Laursen 7b8928fe01 Make milestones visible in draft search results, and add notices to
the draft state edit form for WG chairs, as reminders for the WG
chairs to keep the milestones updated
 - Legacy-Id: 4559
2012-07-01 08:55:36 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Robert Sparks 4eabc033c1 Replaced the concept of a tag (via-rfc) identifying ise or irtf document (previously the idinternal.via_rfc_editor boolean) with looking at the document's stream.
Removed the stream editing form - that functionality is on the edit info form.
Put the old-ADs back into the list of choices when editing a document's info.

This (re) fixes bug #749
 - Legacy-Id: 4356
2012-05-03 04:26:09 +00:00
Suresh Krishnan 19dbc6c9bb Making doc writeup available as read-only text to regular users who are not shepherd/AD/Secretariat etc.
Adding a link for viewing a writeup to the main datatracker page.
 - Legacy-Id: 4213
2012-03-24 15:03:11 +00:00
Ole Laursen 5fab1e071d Be more careful in generating links to draft actions, fixes problem
with RFCs without an associated group and also makes the code somewhat
more readable (although the template tag detour need to go away at
some point, perhaps after the generic charter refactor)
 - Legacy-Id: 4071
2012-03-08 13:01:20 +00:00
Henrik Levkowetz 00111065ea Guard against trying to use .is_authenticated() on a plain string. The error condition can occur when an exception has been triggered before the auth middleware has run. Related to #767 and #768.
- Legacy-Id: 4054
2012-03-07 10:00:31 +00:00
Ole Laursen dbf5e6ab84 Remove a bunch of old admin files, fix a couple of issues with the new ones, add admin for meeting
- Legacy-Id: 3995
2012-02-28 17:29:52 +00:00
Ole Laursen 1fc978e9fe Fix so that Secretariat can also adopt documents when other people can
- Legacy-Id: 3873
2012-01-30 17:20:12 +00:00
Ole Laursen a2f29f8139 Fix redirect on adoption
- Legacy-Id: 3869
2012-01-26 21:30:06 +00:00
Ole Laursen 65e5298630 Be more careful in handling Document.stream now that it can be null
- Legacy-Id: 3865
2012-01-26 13:28:02 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen 8d6bcc8ff5 Fix adoption test to unset the stream, fix bugs with non-stream drafts
- Legacy-Id: 3852
2012-01-24 13:11:03 +00:00
Ole Laursen fc88964298 Go through the code and replace uses of Person.name with Person.plain_name()
- Legacy-Id: 3849
2012-01-23 20:22:45 +00:00
Ole Laursen 9d77c09f10 Independent submissions are IETF track drafts with group set to Individual
- Legacy-Id: 3844
2012-01-20 18:39:44 +00:00
Ole Laursen 85b036e456 Only output stream tags in get_annotation_tags_for_draft
- Legacy-Id: 3824
2012-01-19 12:05:34 +00:00
Ole Laursen 31aef86164 Merge charter branch with the UI hooks disabled for the time being
- Legacy-Id: 3800
2012-01-11 15:04:13 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen 8153a1c130 Patch up to pass request object to send mail in the instances where
it's possible (i.e. when not run in cron) in preparation for better
mail test handling
 - Legacy-Id: 3711
2011-11-25 18:24:14 +00:00
Ole Laursen 13cec30f07 Fix bug in StreamedId proxy
- Legacy-Id: 3708
2011-11-25 13:29:07 +00:00
Ole Laursen a8e219e16a Rename DocStreamName to StreamName, they're not really doc-specific
- Legacy-Id: 3707
2011-11-25 12:25:35 +00:00
Ole Laursen 9a8b9ea857 Fix merge bug
- Legacy-Id: 3693
2011-11-24 10:41:34 +00:00
Ole Laursen d4b296c5cf Fix bug, make sure user is authenticated before trying to see if he's
got any roles
 - Legacy-Id: 3690
2011-11-23 17:58:06 +00:00
Ole Laursen 367d6b2116 Port recently merged stream delegate management in ietfworkflows to new schema
- Legacy-Id: 3687
2011-11-22 21:15:49 +00:00
Ole Laursen 2b4f6f3751 Import is_secretariat directly from liaisons
- Legacy-Id: 3685
2011-11-22 20:51:27 +00:00
Ole Laursen fb083da243 Fix bug in is_authorized_in_draft_streamREDESIGN
- Legacy-Id: 3682
2011-11-22 18:18:09 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Henrik Levkowetz e8b787312d Merged [3600] from adam@nostrum.com:
Fixing bug in is_authorized_in_draft_stream: would never return true for WG chairs
 - Legacy-Id: 3624
Note: SVN reference [3600] has been migrated to Git commit 5b9b56c5fd
2011-11-16 04:23:03 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen ea7f45d56e Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3617
2011-11-14 19:40:20 +00:00